92517 2012-07-27 10:47:25 -0700 [WK2] Fix build warning in WebEventConversion.cpp 2012-07-27 12:03:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim cdumez webkit.review.bot oldest_to_newest 680799 0 gyuyoung.kim 2012-07-27 10:47:25 -0700 It looks there is comparison build warning in WebEventConversion.cpp as below, WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent(const WebKit::WebTouchEvent&)’: /home/gyuyoung/webkit/WebKit/Source/WebKit2/Shared/WebEventConversion.cpp:322:57: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] 680810 1 154989 gyuyoung.kim 2012-07-27 10:56:59 -0700 Created attachment 154989 Patch 680819 2 154989 cdumez 2012-07-27 11:02:37 -0700 Comment on attachment 154989 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154989&action=review > Source/WebKit2/ChangeLog:3 > + [Wk2] Fix build warning in WebEventConversion.cpp ? > Source/WebKit2/Shared/WebEventConversion.cpp:322 > + for (unsigned i = 0; i < webEvent.touchPoints().size(); ++i) You should use size_t since this is the type returned by WTK::Vector::size() 680823 3 154989 cdumez 2012-07-27 11:04:35 -0700 Comment on attachment 154989 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154989&action=review >> Source/WebKit2/ChangeLog:3 >> + [Wk2] Fix build warning > > in WebEventConversion.cpp ? Also maybe "[WK2]" 680830 4 154990 gyuyoung.kim 2012-07-27 11:11:09 -0700 Created attachment 154990 Patch 680836 5 154991 gyuyoung.kim 2012-07-27 11:12:56 -0700 Created attachment 154991 Patch 680840 6 gyuyoung.kim 2012-07-27 11:13:34 -0700 Patch is modified. 680845 7 154991 cdumez 2012-07-27 11:16:18 -0700 Comment on attachment 154991 Patch LGTM. Thanks. 680910 8 154991 webkit.review.bot 2012-07-27 12:03:26 -0700 Comment on attachment 154991 Patch Clearing flags on attachment: 154991 Committed r123903: <http://trac.webkit.org/changeset/123903> 680911 9 webkit.review.bot 2012-07-27 12:03:31 -0700 All reviewed patches have been landed. Closing bug. 154989 2012-07-27 10:56:59 -0700 2012-07-27 11:11:03 -0700 Patch bug-92517-20120728025647.patch text/plain 1467 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjE5MDE0MzU3NGI5OTFk NzMzZTViN2U2NjViOTMxOGU4NjRkMGFkNS4uZGU5OTdmODYzMmU0MzQxOWFhOWQ5YTA1ZmE4YzQ5 ZWI4MzI0NzdlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTI3ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1drMl0gRml4 IGJ1aWxkIHdhcm5pbmcgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05MjUxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZXJlIGlzIGJ1aWxkIHdhcm5pbmcgcmVsYXRlZCB0byBjb21wYXJpc29uIGJldHdl ZW4gc2lnbmVkIGFuZCB1bnNpZ25lZCBpbnRlZ2VyIGV4cHJlc3Npb25zLgorCisgICAgICAgICog U2hhcmVkL1dlYkV2ZW50Q29udmVyc2lvbi5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYktpdDJQ bGF0Zm9ybVRvdWNoRXZlbnQ6OldlYktpdDJQbGF0Zm9ybVRvdWNoRXZlbnQpOgorCiAyMDEyLTA3 LTI3ICBZb3VuZ1RhZWNrIFNvbmcgIDx5b3VuZ3RhZWNrLnNvbmdAc2Ftc3VuZy5jb20+CiAKICAg ICAgICAgW1dLMl1bRUZMXSBBZGQgYW4gQUNDRUxFUkFURURfQ09NUE9TSVRJTkcgaW1wbGVtZW50 YXRpb24gZm9yIEVmbCBXZWJLaXQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv V2ViRXZlbnRDb252ZXJzaW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJFdmVudENv bnZlcnNpb24uY3BwCmluZGV4IDhiNjFlMjdiMjg5ZGFlZDFiMzU3N2ZmZTU3NzIxMzBkMzA3MzEx NDEuLmI2NTc5NDhjY2M4NzAzMzk4N2FlMTQxZjkwOTExMDE5NWYxMzFhZmEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJFdmVudENvbnZlcnNpb24uY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9XZWJFdmVudENvbnZlcnNpb24uY3BwCkBAIC0zMTksNyArMzE5LDcg QEAgcHVibGljOgogICAgICAgICBtX3RpbWVzdGFtcCA9IHdlYkV2ZW50LnRpbWVzdGFtcCgpOwog CiAgICAgICAgIC8vIFBsYXRmb3JtVG91Y2hFdmVudAotICAgICAgICBmb3IgKGludCBpID0gMDsg aSA8IHdlYkV2ZW50LnRvdWNoUG9pbnRzKCkuc2l6ZSgpOyArK2kpCisgICAgICAgIGZvciAodW5z aWduZWQgaSA9IDA7IGkgPCB3ZWJFdmVudC50b3VjaFBvaW50cygpLnNpemUoKTsgKytpKQogICAg ICAgICAgICAgbV90b3VjaFBvaW50cy5hcHBlbmQoV2ViS2l0MlBsYXRmb3JtVG91Y2hQb2ludCh3 ZWJFdmVudC50b3VjaFBvaW50cygpLmF0KGkpKSk7CiAgICAgfQogfTsK 154990 2012-07-27 11:11:09 -0700 2012-07-27 11:12:50 -0700 Patch bug-92517-20120728031056.patch text/plain 1490 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjE5MDE0MzU3NGI5OTFk NzMzZTViN2U2NjViOTMxOGU4NjRkMGFkNS4uNWYyNjMwNzI3Njg5YzA2ZDlhYjUzYzA1YzYxM2I4 MjZiMDBhNWYzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTI3ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dLMl0gRml4 IGJ1aWxkIHdhcm5pbmcgaW4gV2ViRXZlbnRDb252ZXJzaW4uY3BwIAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI1MTcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBidWlsZCB3YXJuaW5nIHJl bGF0ZWQgdG8gY29tcGFyaXNvbiBiZXR3ZWVuIHNpZ25lZCBhbmQgdW5zaWduZWQgaW50ZWdlciBl eHByZXNzaW9ucy4KKworICAgICAgICAqIFNoYXJlZC9XZWJFdmVudENvbnZlcnNpb24uY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJLaXQyUGxhdGZvcm1Ub3VjaEV2ZW50OjpXZWJLaXQyUGxhdGZv cm1Ub3VjaEV2ZW50KToKKwogMjAxMi0wNy0yNyAgWW91bmdUYWVjayBTb25nICA8eW91bmd0YWVj ay5zb25nQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtXSzJdW0VGTF0gQWRkIGFuIEFDQ0VMRVJB VEVEX0NPTVBPU0lUSU5HIGltcGxlbWVudGF0aW9uIGZvciBFZmwgV2ViS2l0MgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkV2ZW50Q29udmVyc2lvbi5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvV2ViRXZlbnRDb252ZXJzaW9uLmNwcAppbmRleCA4YjYxZTI3YjI4OWRh ZWQxYjM1NzdmZmU1NzcyMTMwZDMwNzMxMTQxLi4wZmFkNjgzZTYwNTZkMzcxMDQxMmQ5Y2IyZWRk YTlkODE0YTgyMDE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViRXZlbnRD b252ZXJzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViRXZlbnRDb252ZXJz aW9uLmNwcApAQCAtMzE5LDcgKzMxOSw3IEBAIHB1YmxpYzoKICAgICAgICAgbV90aW1lc3RhbXAg PSB3ZWJFdmVudC50aW1lc3RhbXAoKTsKIAogICAgICAgICAvLyBQbGF0Zm9ybVRvdWNoRXZlbnQK LSAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCB3ZWJFdmVudC50b3VjaFBvaW50cygpLnNpemUo KTsgKytpKQorICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHdlYkV2ZW50LnRvdWNoUG9p bnRzKCkuc2l6ZSgpOyArK2kpCiAgICAgICAgICAgICBtX3RvdWNoUG9pbnRzLmFwcGVuZChXZWJL aXQyUGxhdGZvcm1Ub3VjaFBvaW50KHdlYkV2ZW50LnRvdWNoUG9pbnRzKCkuYXQoaSkpKTsKICAg ICB9CiB9Owo= 154991 2012-07-27 11:12:56 -0700 2012-07-27 12:03:26 -0700 Patch bug-92517-20120728031243.patch text/plain 1492 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjE5MDE0MzU3NGI5OTFk NzMzZTViN2U2NjViOTMxOGU4NjRkMGFkNS4uNWNhMmMwNjlkZTg3ZWRiMjg5M2FlZWFkM2RlY2U0 MDg3YjU3ZGE5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTI3ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dLMl0gRml4 IGJ1aWxkIHdhcm5pbmcgaW4gV2ViRXZlbnRDb252ZXJzaW9uLmNwcAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI1MTcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBhIGJ1aWxkIHdhcm5pbmcg cmVsYXRlZCB0byBjb21wYXJpc29uIGJldHdlZW4gc2lnbmVkIGFuZCB1bnNpZ25lZCBpbnRlZ2Vy IGV4cHJlc3Npb25zLgorCisgICAgICAgICogU2hhcmVkL1dlYkV2ZW50Q29udmVyc2lvbi5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYktpdDJQbGF0Zm9ybVRvdWNoRXZlbnQ6OldlYktpdDJQbGF0 Zm9ybVRvdWNoRXZlbnQpOgorCiAyMDEyLTA3LTI3ICBZb3VuZ1RhZWNrIFNvbmcgIDx5b3VuZ3Rh ZWNrLnNvbmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW1dLMl1bRUZMXSBBZGQgYW4gQUNDRUxF UkFURURfQ09NUE9TSVRJTkcgaW1wbGVtZW50YXRpb24gZm9yIEVmbCBXZWJLaXQyCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViRXZlbnRDb252ZXJzaW9uLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9XZWJFdmVudENvbnZlcnNpb24uY3BwCmluZGV4IDhiNjFlMjdiMjg5 ZGFlZDFiMzU3N2ZmZTU3NzIxMzBkMzA3MzExNDEuLjBmYWQ2ODNlNjA1NmQzNzEwNDEyZDljYjJl ZGRhOWQ4MTRhODIwMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJFdmVu dENvbnZlcnNpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJFdmVudENvbnZl cnNpb24uY3BwCkBAIC0zMTksNyArMzE5LDcgQEAgcHVibGljOgogICAgICAgICBtX3RpbWVzdGFt cCA9IHdlYkV2ZW50LnRpbWVzdGFtcCgpOwogCiAgICAgICAgIC8vIFBsYXRmb3JtVG91Y2hFdmVu dAotICAgICAgICBmb3IgKGludCBpID0gMDsgaSA8IHdlYkV2ZW50LnRvdWNoUG9pbnRzKCkuc2l6 ZSgpOyArK2kpCisgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgd2ViRXZlbnQudG91Y2hQ b2ludHMoKS5zaXplKCk7ICsraSkKICAgICAgICAgICAgIG1fdG91Y2hQb2ludHMuYXBwZW5kKFdl YktpdDJQbGF0Zm9ybVRvdWNoUG9pbnQod2ViRXZlbnQudG91Y2hQb2ludHMoKS5hdChpKSkpOwog ICAgIH0KIH07Cg==