92507 2012-07-27 07:52:07 -0700 [EFL] Regression(r123858): Default navigation policy decision was switched to "reject" 2012-07-27 10:34:50 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 92466 1 cdumez cdumez gyuyoung.kim haraken hausmann kenneth lucas.de.marchi naginenis rakuco ryuan.choi tmpsantos tonikitoo webkit.review.bot oldest_to_newest 680650 0 cdumez 2012-07-27 07:52:07 -0700 http://trac.webkit.org/changeset/123858 changed the return values of a few functions, one of them being ewk_view_navigation_policy_decision(). The function used to return true (request is accepted) when the client does not handle the decision, now it returns false (request is rejected). 680651 1 154952 cdumez 2012-07-27 07:55:00 -0700 Created attachment 154952 Patch 680668 2 tmpsantos 2012-07-27 08:19:03 -0700 LGTM. For the records: first regression caught on the bots by the API unit tests. 680671 3 cdumez 2012-07-27 08:20:38 -0700 (In reply to comment #2) > LGTM. For the records: first regression caught on the bots by the API unit tests. Yay! :) 680703 4 154952 haraken 2012-07-27 08:44:21 -0700 Comment on attachment 154952 Patch OK 680786 5 154952 webkit.review.bot 2012-07-27 10:34:44 -0700 Comment on attachment 154952 Patch Clearing flags on attachment: 154952 Committed r123883: <http://trac.webkit.org/changeset/123883> 680787 6 webkit.review.bot 2012-07-27 10:34:50 -0700 All reviewed patches have been landed. Closing bug. 154952 2012-07-27 07:55:00 -0700 2012-07-27 10:34:43 -0700 Patch 92507_policy_accept.patch text/plain 2411 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAyODJhMDgyLi43Y2U5YjNhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDctMjcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhl LmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBSZWdyZXNzaW9uKHIxMjM4NTgpOiBE ZWZhdWx0IG5hdmlnYXRpb24gcG9saWN5IGRlY2lzaW9uIHdhcyBzd2l0Y2hlZCB0byAicmVqZWN0 IgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI1MDcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciBy OTI0NjYsIHRoZSBkZWZhdWx0IG5hdmlnYXRpb24gcG9saWN5IGlzIHRvIHJlamVjdCB0aGUgcmVx dWVzdCBpZiB0aGUKKyAgICAgICAgY2xpZW50IGRvZXMgbm90IG1ha2UgYSBkZWNpc2lvbiBleHBs aWNpdGx5LiBUaGUgZGVmYXVsdCBwb2xpY3kgc2hvdWxkIGJlCisgICAgICAgIHRvIGFjY2VwdC4g VGhpcyBicm9rZSBld2tfdmlldyB1bml0IHRlc3RzLgorCisgICAgICAgICogZXdrL2V3a192aWV3 LmNwcDoKKyAgICAgICAgKGV3a192aWV3X25hdmlnYXRpb25fcG9saWN5X2RlY2lzaW9uKToKKwog MjAxMi0wNy0yNyAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAg ICAgICAgIFtFRkxdIEZpeCB3cm9uZyByZXR1cm4gdmFsdWUgaW4gRVdLX1ZJRVdfWFhYIG1hY3Jv LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggNzBiOGE5NS4uNTMwOTE4MSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC00MDE4LDE1ICs0MDE4LDE3IEBAIHZvaWQg ZXdrX3ZpZXdfdHJhbnNpdGlvbl90b19jb21taXRlZF9mb3JfbmV3cGFnZShFdmFzX09iamVjdCog ZXdrVmlldykKIAogLyoqCiAgKiBAaW50ZXJuYWwKLSAqIFJlcG9ydHMgYSByZXF1ZXNldCB3aWxs IGJlIGxvYWRlZC4gSXQncyBjbGllbnQgcmVzcG9uc2liaWxpdHkgdG8gZGVjaWRlIGlmCi0gKiBy ZXF1ZXN0IHdvdWxkIGJlIHVzZWQuIElmIEByZXR1cm4gaXMgdHJ1ZSwgbG9hZGVyIHdpbGwgdHJ5 IHRvIGxvYWQuIEVsc2UsCi0gKiBMb2FkZXIgaWdub3JlIGFjdGlvbiBvZiByZXF1ZXN0LgorICog UmVwb3J0cyB0aGF0IGEgbmF2aWdhdGlvbiBwb2xpY3kgZGVjaXNpb24gc2hvdWxkIGJlIHRha2Vu LiBJZiBAcmV0dXJuCisgKiBpcyB0cnVlLCB0aGUgbmF2aWdhdGlvbiByZXF1ZXN0IHdpbGwgYmUg YWNjZXB0ZWQsIG90aGVyd2lzZSBpdCB3aWxsIGJlCisgKiBpZ25vcmVkLgogICoKICAqIEBwYXJh bSBld2tWaWV3IFZpZXcgdG8gbG9hZAogICogQHBhcmFtIHJlcXVlc3QgUmVxdWVzdCB3aGljaCBj b250YWluIHVybCB0byBuYXZpZ2F0ZQogICogQHBhcmFtIG5hdmlnYXRpb25UeXBlIG5hdmlnYXRp b24gdHlwZQogICoKLSAqIEByZXR1cm4gdHJ1ZSBvbiBzdWNjZXNzIG9yIGZhbHNlIG90aGVyd2lz ZQorICogQHJldHVybiB0cnVlIGlmIHRoZSBjbGllbnQgYWNjZXB0ZWQgdGhlIG5hdmlnYXRpb24g cmVxdWVzdCwgZmFsc2Ugb3RoZXJ3aXNlLiBJZiB0aGUKKyAqIGNsaWVudCBkaWQgbm90IG1ha2Ug YSBkZWNpc2lvbiwgd2UgcmV0dXJuIHRydWUgYnkgZGVmYXVsdCBzaW5jZSB0aGUgZGVmYXVsdCBw b2xpY3kKKyAqIGlzIHRvIGFjY2VwdC4KICAqLwogYm9vbCBld2tfdmlld19uYXZpZ2F0aW9uX3Bv bGljeV9kZWNpc2lvbihFdmFzX09iamVjdCogZXdrVmlldywgRXdrX0ZyYW1lX1Jlc291cmNlX1Jl cXVlc3QqIHJlcXVlc3QsIEV3a19OYXZpZ2F0aW9uX1R5cGUgbmF2aWdhdGlvblR5cGUpCiB7CkBA IC00MDM0LDcgKzQwMzYsNyBAQCBib29sIGV3a192aWV3X25hdmlnYXRpb25fcG9saWN5X2RlY2lz aW9uKEV2YXNfT2JqZWN0KiBld2tWaWV3LCBFd2tfRnJhbWVfUmVzb3VyYwogICAgIEVJTkFfU0FG RVRZX09OX05VTExfUkVUVVJOX1ZBTChzbWFydERhdGEtPmFwaSwgZmFsc2UpOwogCiAgICAgaWYg KCFzbWFydERhdGEtPmFwaS0+bmF2aWdhdGlvbl9wb2xpY3lfZGVjaXNpb24pCi0gICAgICAgIHJl dHVybiBmYWxzZTsKKyAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICByZXR1cm4gc21hcnREYXRh LT5hcGktPm5hdmlnYXRpb25fcG9saWN5X2RlY2lzaW9uKHNtYXJ0RGF0YSwgcmVxdWVzdCwgbmF2 aWdhdGlvblR5cGUpOwogfQo=