92502 2012-07-27 06:39:18 -0700 Fix removing invalid values from color input suggestions 2012-07-29 22:49:50 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keishi keishi dglazkov mifenton tkent webkit.review.bot oldest_to_newest 680551 0 keishi 2012-07-27 06:39:18 -0700 Removing invalid values from color input suggestions is broken. 680557 1 154931 keishi 2012-07-27 06:41:44 -0700 Created attachment 154931 Patch 680573 2 154931 tkent 2012-07-27 06:49:23 -0700 Comment on attachment 154931 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154931&action=review > Source/WebCore/html/ColorInputType.cpp:229 > - if (!element()->isValidValue(option->value())) > + if (!isValidColorString(option->value())) I think we should fix HTMLInputElement::isValidValue() in this case. isValidValue() exists for this purpose. 680585 3 keishi 2012-07-27 07:01:37 -0700 I shouldn't be returning true for typeMismatch etc., so do I need to add a method to InputType and check that in HTMLInputElement::isValidValue()? 680619 4 154943 keishi 2012-07-27 07:28:59 -0700 Created attachment 154943 Patch 680626 5 154943 buildbot 2012-07-27 07:35:32 -0700 Comment on attachment 154943 Patch Attachment 154943 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13367530 680697 6 154943 webkit.review.bot 2012-07-27 08:41:12 -0700 Comment on attachment 154943 Patch Attachment 154943 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13372493 680751 7 154943 webkit-ews 2012-07-27 09:56:12 -0700 Comment on attachment 154943 Patch Attachment 154943 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13371564 680766 8 154943 webkit-ews 2012-07-27 10:14:49 -0700 Comment on attachment 154943 Patch Attachment 154943 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13371566 680797 9 154943 gyuyoung.kim 2012-07-27 10:47:04 -0700 Comment on attachment 154943 Patch Attachment 154943 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13376570 680857 10 154943 darin 2012-07-27 11:26:26 -0700 Comment on attachment 154943 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154943&action=review > Source/WebCore/html/InputType.h:310 > + virtual bool isUsefulValue(const String& value) const; What does “useful value” mean in this context? How is “useful” different from “valid”? I find this terminology unclear. 681606 11 154943 eric 2012-07-29 15:22:15 -0700 Comment on attachment 154943 Patch The EWS bots are unhappy. 681634 12 154943 tkent 2012-07-29 18:34:14 -0700 Comment on attachment 154943 Patch What you need to do is just to implement ColorInputType::typeMismatchFor(const String&). As you know, <input type=color> never cause typeMismatch validation failure because of the aggressive value sanitization. However implementing typeMismatch() is helpful for HTMLInputElement::isValidValue() because isValidValue() doesn't sanitize the specified string. NumberInputType does the same thing. If you feel implementing typeMismatchFor() is hacky, you had better update HTMLInputElement::isValidValue() so that it handles value sanitization correctly. 681672 13 155204 keishi 2012-07-29 21:20:26 -0700 Created attachment 155204 Patch 681673 14 keishi 2012-07-29 21:21:52 -0700 (In reply to comment #12) > (From update of attachment 154943 [details]) > What you need to do is just to implement ColorInputType::typeMismatchFor(const String&). > > As you know, <input type=color> never cause typeMismatch validation failure because of the aggressive value sanitization. However implementing typeMismatch() is helpful for HTMLInputElement::isValidValue() because isValidValue() doesn't sanitize the specified string. NumberInputType does the same thing. > > If you feel implementing typeMismatchFor() is hacky, you had better update HTMLInputElement::isValidValue() so that it handles value sanitization correctly. Ok, I implemented typeMismatchFor() 681677 15 155204 tkent 2012-07-29 21:30:19 -0700 Comment on attachment 155204 Patch ok 681695 16 155204 webkit.review.bot 2012-07-29 22:49:46 -0700 Comment on attachment 155204 Patch Clearing flags on attachment: 155204 Committed r123997: <http://trac.webkit.org/changeset/123997> 681696 17 webkit.review.bot 2012-07-29 22:49:50 -0700 All reviewed patches have been landed. Closing bug. 154931 2012-07-27 06:41:44 -0700 2012-07-27 07:28:55 -0700 Patch bug-92502-20120727224132.patch text/plain 1666 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDZmZmUyNjdlYjQ5NDMy MTEyMTVhMjk4MGVlZTY3YmYwYTNkNTA1YS4uMjQ5NDk0NjU5YTI4YzExOTkyNmY2ZjM2NTFlZWZm MzM0MzQ3ZTBmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTI4ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIEZpeCByZW1vdmluZyBp bnZhbGlkIHZhbHVlcyBmcm9tIGNvbG9yIGlucHV0IHN1Z2dlc3Rpb25zCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjUwMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEludmFsaWQgdmFsdWVzIHdlcmVuJ3Qg YmVpbmcgcmVtb3ZlZCBmcm9tIHRoZSBsaXN0IG9mIHN1Z2dlc3Rpb25zIHRoYXQgQ29sb3JJbnB1 dFR5cGU6OnN1Z2dlc3Rpb25zKCkgcmV0dXJucy4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRl c3RzIHRvIGJlIGFkZGVkIGluIEJ1ZyA5MjA3NS4KKworICAgICAgICAqIGh0bWwvQ29sb3JJbnB1 dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29sb3JJbnB1dFR5cGU6OnN1Z2dlc3Rpb25z KToKKwogMjAxMi0wNy0yNyAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXBsYWNlIENvbG9yQ2hvb3NlckNsaWVudDo6ZWxlbWVudFJlY3RSZWxhdGl2ZVRv V2luZG93IHdpdGggZWxlbWVudFJlY3RSZWxhdGl2ZVRvUm9vdFZpZXcKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9Db2xvcklucHV0VHlwZS5jcHAKaW5kZXggODg2YTJhZDBkMTFlOWNkNWNhMGYyOThjNGM4OTE4 M2RhZWU3N2MyNi4uMjE4OTMxOGFhNjJmZjg2N2E4NzZjY2FiMGU2MDNkZDIxNzYyYzY5MyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9Db2xvcklucHV0VHlwZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9Db2xvcklucHV0VHlwZS5jcHAKQEAgLTIyNiw3ICsyMjYsNyBAQCBW ZWN0b3I8Q29sb3I+IENvbG9ySW5wdXRUeXBlOjpzdWdnZXN0aW9ucygpIGNvbnN0CiAgICAgaWYg KGRhdGFMaXN0KSB7CiAgICAgICAgIFJlZlB0cjxIVE1MQ29sbGVjdGlvbj4gb3B0aW9ucyA9IGRh dGFMaXN0LT5vcHRpb25zKCk7CiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IEhUTUxPcHRp b25FbGVtZW50KiBvcHRpb24gPSBzdGF0aWNfY2FzdDxIVE1MT3B0aW9uRWxlbWVudCo+KG9wdGlv bnMtPml0ZW0oaSkpOyBpKyspIHsKLSAgICAgICAgICAgIGlmICghZWxlbWVudCgpLT5pc1ZhbGlk VmFsdWUob3B0aW9uLT52YWx1ZSgpKSkKKyAgICAgICAgICAgIGlmICghaXNWYWxpZENvbG9yU3Ry aW5nKG9wdGlvbi0+dmFsdWUoKSkpCiAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAg ICAgICBDb2xvciBjb2xvcihvcHRpb24tPnZhbHVlKCkpOwogICAgICAgICAgICAgaWYgKCFjb2xv ci5pc1ZhbGlkKCkpCg== 154943 2012-07-27 07:28:59 -0700 2012-07-29 21:20:21 -0700 Patch bug-92502-20120727232847.patch text/plain 4932 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDZmZmUyNjdlYjQ5NDMy MTEyMTVhMjk4MGVlZTY3YmYwYTNkNTA1YS4uZjBmNGU0NzMzODJhY2E0Yzg3YTI5YzM4MmMxYWJi YzZmZDQ2ZTA5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDQzIEBACiAyMDEyLTA3LTI3ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCisgICAgICAgIEZpeCByZW1vdmluZyBp bnZhbGlkIHZhbHVlcyBmcm9tIGNvbG9yIGlucHV0IHN1Z2dlc3Rpb25zCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjUwMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGl0aW9uYWwgaW5mb3JtYXRpb24g b2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCByYXRpb25hbGUuIFBsZWFzZSBhZGQgcGVy LWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxvdyAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9Db2xvcklucHV0VHlwZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjppc1VzZWZ1bFZhbHVlKTogUmV0dXJucyBmYWxzZSBpZiBzZXR0aW5nIHRo ZSB2YWx1ZSB3b3VsZCBqdXN0IHNldCB0aGUgZmFsbGJhY2sgdmFsdWUuCisgICAgICAgIChXZWJD b3JlKToKKyAgICAgICAgKiBodG1sL0NvbG9ySW5wdXRUeXBlLmg6CisgICAgICAgIChDb2xvcklu cHV0VHlwZSk6CisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OmlzVmFsaWRWYWx1ZSk6IFJldHVybnMgZmFsc2Ug Zm9yIG5vdCB1c2VmdWwgdmFsdWVzLgorICAgICAgICAqIGh0bWwvSW5wdXRUeXBlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OklucHV0VHlwZTo6aXNVc2VmdWxWYWx1ZSk6IFJldHVybnMgZmFsc2Ug aWYgc2V0dGluZyB0aGUgdmFsdWUgd291bGQgYmUgbm8gaGVscCB0byB0aGUgdXNlci4KKyAgICAg ICAgKFdlYkNvcmUpOgorICAgICAgICAqIGh0bWwvSW5wdXRUeXBlLmg6CisgICAgICAgIChJbnB1 dFR5cGUpOgorCisyMDEyLTA3LTI4ICBLZWlzaGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3Jn PgorCisgICAgICAgIEZpeCByZW1vdmluZyBpbnZhbGlkIHZhbHVlcyBmcm9tIGNvbG9yIGlucHV0 IHN1Z2dlc3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05MjUwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEludmFsaWQgdmFsdWVzIHdlcmVuJ3QgYmVpbmcgcmVtb3ZlZCBmcm9tIHRoZSBsaXN0IG9m IHN1Z2dlc3Rpb25zIHRoYXQgQ29sb3JJbnB1dFR5cGU6OnN1Z2dlc3Rpb25zKCkgcmV0dXJucy4K KworICAgICAgICBObyBuZXcgdGVzdHMuIFRlc3RzIHRvIGJlIGFkZGVkIGluIEJ1ZyA5MjA3NS4K KworICAgICAgICAqIGh0bWwvQ29sb3JJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q29sb3JJbnB1dFR5cGU6OnN1Z2dlc3Rpb25zKToKKworMjAxMi0wNy0yNyAgS2Vpc2hpIEhhdHRv cmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KKwogICAgICAgICBSZXBsYWNlIENvbG9yQ2hvb3NlckNs aWVudDo6ZWxlbWVudFJlY3RSZWxhdGl2ZVRvV2luZG93IHdpdGggZWxlbWVudFJlY3RSZWxhdGl2 ZVRvUm9vdFZpZXcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkyNDg4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5 cGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9Db2xvcklucHV0VHlwZS5jcHAKaW5kZXggODg2 YTJhZDBkMTFlOWNkNWNhMGYyOThjNGM4OTE4M2RhZWU3N2MyNi4uYWZmMTNjZjU5MDVkYmIwNTBi ZjQ5NTdiN2JmMzM4Y2Q3OWI3MzIzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9D b2xvcklucHV0VHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9Db2xvcklucHV0VHlw ZS5jcHAKQEAgLTEwNiw2ICsxMDYsMTEgQEAgU3RyaW5nIENvbG9ySW5wdXRUeXBlOjpzYW5pdGl6 ZVZhbHVlKGNvbnN0IFN0cmluZyYgcHJvcG9zZWRWYWx1ZSkgY29uc3QKICAgICByZXR1cm4gcHJv cG9zZWRWYWx1ZS5sb3dlcigpOwogfQogCitib29sIGlzVXNlZnVsVmFsdWUoY29uc3QgU3RyaW5n JiB2YWx1ZSkgY29uc3QKK3sKKyAgICByZXR1cm4gaXNWYWxpZENvbG9yU3RyaW5nKHZhbHVlKTsK K30KKwogQ29sb3IgQ29sb3JJbnB1dFR5cGU6OnZhbHVlQXNDb2xvcigpIGNvbnN0CiB7CiAgICAg cmV0dXJuIENvbG9yKGVsZW1lbnQoKS0+dmFsdWUoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0NvbG9ySW5wdXRUeXBlLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9ySW5w dXRUeXBlLmgKaW5kZXggMTY3OGJkY2U2YjM2NGI4ZGMxZWRmM2I0MTljNDJmZmI0Nzg4MjhkOC4u YmIxYzAzNTM4ZjQ2NTljNTc4NGJiNDBlZTE3ZGY5ZTlhZjdiOTZiOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9Db2xvcklucHV0VHlwZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvQ29sb3JJbnB1dFR5cGUuaApAQCAtNjMsNiArNjMsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1 YWwgdm9pZCBoYW5kbGVET01BY3RpdmF0ZUV2ZW50KEV2ZW50KikgT1ZFUlJJREU7CiAgICAgdmly dHVhbCB2b2lkIGRldGFjaCgpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRSZXNw ZWN0TGlzdEF0dHJpYnV0ZSgpIE9WRVJSSURFOworICAgIHZpcnR1YWwgYm9vbCBpc1VzZWZ1bFZh bHVlKGNvbnN0IFN0cmluZyYgdmFsdWUpIGNvbnN0IE9WRVJSSURFOwogCiAgICAgQ29sb3IgdmFs dWVBc0NvbG9yKCkgY29uc3Q7CiAgICAgdm9pZCBlbmRDb2xvckNob29zZXIoKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IDU5YzYyMDVhODAxYTRmYmMxZWRh YjIzMTVkMjQ3MjBjNTA1YWFhMjEuLmM3MTJmODMyZTNkMDJiYzZmY2E4N2EyZjdhYTYwZGI3ZDhi MDVlN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAtMjI2 LDcgKzIyNiw4IEBAIGJvb2wgSFRNTElucHV0RWxlbWVudDo6aXNWYWxpZFZhbHVlKGNvbnN0IFN0 cmluZyYgdmFsdWUpIGNvbnN0CiAgICAgICAgICYmICFtX2lucHV0VHlwZS0+cmFuZ2VPdmVyZmxv dyh2YWx1ZSkKICAgICAgICAgJiYgIXRvb0xvbmcodmFsdWUsIElnbm9yZURpcnR5RmxhZykKICAg ICAgICAgJiYgIW1faW5wdXRUeXBlLT5wYXR0ZXJuTWlzbWF0Y2godmFsdWUpCi0gICAgICAgICYm ICFtX2lucHV0VHlwZS0+dmFsdWVNaXNzaW5nKHZhbHVlKTsKKyAgICAgICAgJiYgIW1faW5wdXRU eXBlLT52YWx1ZU1pc3NpbmcodmFsdWUpCisgICAgICAgICYmIG1faW5wdXRUeXBlLT5pc1VzZWZ1 bFZhbHVlKHZhbHVlKTsKIH0KIAogYm9vbCBIVE1MSW5wdXRFbGVtZW50Ojp0b29Mb25nKCkgY29u c3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmNwcAppbmRleCAwOWE4OTViNTAyODljNWFhMWUyMjlm N2Y0ZDU4MzI1NzZlMTk4NGQyLi4zNTAyZDU0MDdlZTY2MTc1NTFhNGFiOWRiZmU0YTUwYjg4MTM3 YTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuY3BwCkBAIC05MjUsNiArOTI1LDExIEBAIHVu c2lnbmVkIElucHV0VHlwZTo6d2lkdGgoKSBjb25zdAogICAgIHJldHVybiAwOwogfQogCitib29s IElucHV0VHlwZTo6aXNVc2VmdWxWYWx1ZShjb25zdCBTdHJpbmcmIHZhbHVlKSBjb25zdAorewor ICAgIHJldHVybiB0cnVlOworfQorCiB2b2lkIElucHV0VHlwZTo6YXBwbHlTdGVwKGludCBjb3Vu dCwgQW55U3RlcEhhbmRsaW5nIGFueVN0ZXBIYW5kbGluZywgVGV4dEZpZWxkRXZlbnRCZWhhdmlv ciBldmVudEJlaGF2aW9yLCBFeGNlcHRpb25Db2RlJiBlYykKIHsKICAgICBTdGVwUmFuZ2Ugc3Rl cFJhbmdlKGNyZWF0ZVN0ZXBSYW5nZShhbnlTdGVwSGFuZGxpbmcpKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0 VHlwZS5oCmluZGV4IDAyNDViYTg4ODBiM2YwNzFjNjE1OWJiYmRhOGFmMzViMmViMDBkYzYuLmJh MWZjZmU4NzczNTA0N2Y1ODNiNmRmZDQ5MzhhOGNmZjc0MzBmNWMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1 dFR5cGUuaApAQCAtMzA3LDYgKzMwNyw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHVuc2lnbmVk IGhlaWdodCgpIGNvbnN0OwogICAgIHZpcnR1YWwgdW5zaWduZWQgd2lkdGgoKSBjb25zdDsKIAor ICAgIHZpcnR1YWwgYm9vbCBpc1VzZWZ1bFZhbHVlKGNvbnN0IFN0cmluZyYgdmFsdWUpIGNvbnN0 OworCiBwcm90ZWN0ZWQ6CiAgICAgSW5wdXRUeXBlKEhUTUxJbnB1dEVsZW1lbnQqIGVsZW1lbnQp IDogbV9lbGVtZW50KGVsZW1lbnQpIHsgfQogICAgIEhUTUxJbnB1dEVsZW1lbnQqIGVsZW1lbnQo KSBjb25zdCB7IHJldHVybiBtX2VsZW1lbnQ7IH0K 155204 2012-07-29 21:20:26 -0700 2012-07-29 22:49:45 -0700 Patch bug-92502-20120730132010.patch text/plain 2299 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzOTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDg0MzQ1MTQ4MjZjYzk4 N2ZmZDIzNTY3NjY0OTgwMDA2NGMzMjc3My4uYjlmOTE5ZDkxOGE4ZGI1ZWUxYjFmYWNjMmQ0MGFl ZWY0YmFlZTVlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA3LTI5ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIEZpeCByZW1vdmluZyBp bnZhbGlkIHZhbHVlcyBmcm9tIGNvbG9yIGlucHV0IHN1Z2dlc3Rpb25zCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjUwMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgQ29sb3JJbnB1dFR5cGU6OnR5 cGVNaXNtYXRjaEZvcigpIHJldHVybiBmYWxzZSBmb3IgaW52YWxpZCBjb2xvcgorICAgICAgICB2 YWx1ZXMgc28gdGhhdCB0aGV5IGRvbid0IGFwcGVhciBpbiB0aGUgbGlzdCBvZiBzdWdnZXN0aW9u cyB0aGF0CisgICAgICAgIENvbG9ySW5wdXRUeXBlOjpzdWdnZXN0aW9ucygpIHJldHVybnMuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLiBUZXN0cyB0byBiZSBhZGRlZCBpbiBCdWcgOTIwNzUuCisK KyAgICAgICAgKiBodG1sL0NvbG9ySW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNv bG9ySW5wdXRUeXBlOjp0eXBlTWlzbWF0Y2hGb3IpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAg ICAgICogaHRtbC9Db2xvcklucHV0VHlwZS5oOgorICAgICAgICAoQ29sb3JJbnB1dFR5cGUpOgor CiAyMDEyLTA3LTI5ICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKICAg ICAgICAgUmVtb3ZlIHVudXNlZCBtZXRob2QgSFRNTENvbnN0cnVjdGlvblNpdGVUYXNrOjp0YWtl KEhUTUxDb25zdHJ1Y3Rpb25TaXRlVGFzayYpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0NvbG9ySW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5 cGUuY3BwCmluZGV4IDg4NmEyYWQwZDExZTljZDVjYTBmMjk4YzRjODkxODNkYWVlNzdjMjYuLjNl NzVjNmU2NWFjMDFlZWEyYTAzYjA5NTMzZDE2MzAyODFmNDE5YzkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvQ29sb3JJbnB1dFR5cGUuY3BwCkBAIC0xNjYsNiArMTY2LDExIEBAIGJvb2wgQ29sb3JJbnB1 dFR5cGU6OnNob3VsZFJlc3BlY3RMaXN0QXR0cmlidXRlKCkKICAgICByZXR1cm4gSW5wdXRUeXBl Ojp0aGVtZVN1cHBvcnRzRGF0YUxpc3RVSSh0aGlzKTsKIH0KIAorYm9vbCBDb2xvcklucHV0VHlw ZTo6dHlwZU1pc21hdGNoRm9yKGNvbnN0IFN0cmluZyYgdmFsdWUpIGNvbnN0Cit7CisgICAgcmV0 dXJuIGlzVmFsaWRDb2xvclN0cmluZyh2YWx1ZSk7Cit9CisKIHZvaWQgQ29sb3JJbnB1dFR5cGU6 OmRpZENob29zZUNvbG9yKGNvbnN0IENvbG9yJiBjb2xvcikKIHsKICAgICBpZiAoZWxlbWVudCgp LT5kaXNhYmxlZCgpIHx8IGVsZW1lbnQoKS0+cmVhZE9ubHkoKSB8fCBjb2xvciA9PSB2YWx1ZUFz Q29sb3IoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUu aCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuaAppbmRleCAxNjc4YmRjZTZi MzY0YjhkYzFlZGYzYjQxOWM0MmZmYjQ3ODgyOGQ4Li4xZjA4MTMzZmVkYTM1OTg4MDU2MTZjZTVm NjZlZjdhNzU1NGZjNDAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9ySW5w dXRUeXBlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9Db2xvcklucHV0VHlwZS5oCkBAIC02 Myw2ICs2Myw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGhhbmRsZURPTUFjdGl2YXRl RXZlbnQoRXZlbnQqKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgZGV0YWNoKCkgT1ZFUlJJ REU7CiAgICAgdmlydHVhbCBib29sIHNob3VsZFJlc3BlY3RMaXN0QXR0cmlidXRlKCkgT1ZFUlJJ REU7CisgICAgdmlydHVhbCBib29sIHR5cGVNaXNtYXRjaEZvcihjb25zdCBTdHJpbmcmKSBjb25z dCBPVkVSUklERTsKIAogICAgIENvbG9yIHZhbHVlQXNDb2xvcigpIGNvbnN0OwogICAgIHZvaWQg ZW5kQ29sb3JDaG9vc2VyKCk7Cg==