<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>92500</bug_id>
          
          <creation_ts>2012-07-27 06:11:30 -0700</creation_ts>
          <short_desc>Activate committer bit granted back in April so that I can garden</short_desc>
          <delta_ts>2012-07-27 14:09:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tom Hudson">tomhudson</reporter>
          <assigned_to name="Tom Hudson">tomhudson</assigned_to>
          <cc>abarth</cc>
    
    <cc>ap</cc>
    
    <cc>dpranke</cc>
    
    <cc>ojan</cc>
    
    <cc>peter</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>680517</commentid>
    <comment_count>0</comment_count>
    <who name="Tom Hudson">tomhudson</who>
    <bug_when>2012-07-27 06:11:30 -0700</bug_when>
    <thetext>Activate committer bit granted back in April so that I can garden</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680519</commentid>
    <comment_count>1</comment_count>
      <attachid>154922</attachid>
    <who name="Tom Hudson">tomhudson</who>
    <bug_when>2012-07-27 06:12:21 -0700</bug_when>
    <thetext>Created attachment 154922
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680524</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-27 06:14:58 -0700</bug_when>
    <thetext>Attachment 154922 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Tools/ChangeLog&apos;, u&apos;Tools/Scripts/webkitpy...&quot; exit_code: 1
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680529</commentid>
    <comment_count>3</comment_count>
      <attachid>154922</attachid>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-07-27 06:19:48 -0700</bug_when>
    <thetext>Comment on attachment 154922
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154922&amp;action=review

An easy way to create patches like this one is to make the code modification, and then use &quot;webkit-patch upload&quot;. That takes care of all the required ChangeLog messages for you.

&gt; Tools/ChangeLog:3
&gt; +        Activate committer bit granted April 6th so I can garden.

Since r? is set, the &quot;Reviewed by (OOPS!)&quot; should be in the ChangeLog.
If you&apos;d like to land this unreviewed, you may want to add a brief note mentioning why it&apos;s ok to land it unreviewed, i.e. &quot;Unreviewed, moving myself in committers.py&quot;.

&gt; Tools/Scripts/webkitpy/common/config/committers.py:373
&gt; +    Committer(&quot;Tom Hudson&quot;, &quot;tomhudson@google.com&quot;),

nit: You seem to be around on IRC as &quot;tomhudson&quot;, it&apos;s convenient for notices (i.e. on reverts) by sheriffbot. Also, do you have an @chromium.org address?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680531</commentid>
    <comment_count>4</comment_count>
      <attachid>154926</attachid>
    <who name="Tom Hudson">tomhudson</who>
    <bug_when>2012-07-27 06:22:25 -0700</bug_when>
    <thetext>Created attachment 154926
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680533</commentid>
    <comment_count>5</comment_count>
    <who name="Tom Hudson">tomhudson</who>
    <bug_when>2012-07-27 06:24:10 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 154922 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=154922&amp;action=review
&gt; 
&gt; An easy way to create patches like this one is to make the code modification, and then use &quot;webkit-patch upload&quot;. That takes care of all the required ChangeLog messages for you.

I actually did use webkit-patch upload; I&apos;m not sure what I did wrong with it.

&gt; &gt; Tools/Scripts/webkitpy/common/config/committers.py:373
&gt; &gt; +    Committer(&quot;Tom Hudson&quot;, &quot;tomhudson@google.com&quot;),
&gt; 
&gt; nit: You seem to be around on IRC as &quot;tomhudson&quot;, it&apos;s convenient for notices (i.e. on reverts) by sheriffbot. Also, do you have an @chromium.org address?

Thanks - I think I was discovering those myself at the same time you were posting here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680534</commentid>
    <comment_count>6</comment_count>
      <attachid>154926</attachid>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-07-27 06:25:03 -0700</bug_when>
    <thetext>Comment on attachment 154926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154926&amp;action=review

Almost there!

&gt; Tools/ChangeLog:5
&gt; +

nit: add the &quot;Reviewed by NOBODY (OOPS!).&quot; line. jochen__ on IRC will be happy to review this :).

&gt; Tools/Scripts/webkitpy/common/config/committers.py:373
&gt; +    Committer(&quot;Tom Hudson&quot;, &quot;tomhudson@google.com&quot;, &quot;tomhudson@chromium.org&quot;, &quot;tomhudson&quot;),

The e-mail addresses should be a list, i.e.

Committer(&quot;Tom Hudson&quot;, [&quot;tomhudson@google.com&quot;, &quot;tomhudson@chromium.org&quot;], &quot;tomhudson&quot;),</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680537</commentid>
    <comment_count>7</comment_count>
      <attachid>154927</attachid>
    <who name="Tom Hudson">tomhudson</who>
    <bug_when>2012-07-27 06:28:22 -0700</bug_when>
    <thetext>Created attachment 154927
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680541</commentid>
    <comment_count>8</comment_count>
      <attachid>154927</attachid>
    <who name="">jochen</who>
    <bug_when>2012-07-27 06:31:35 -0700</bug_when>
    <thetext>Comment on attachment 154927
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154927&amp;action=review

&gt; Tools/ChangeLog:3
&gt; +        Activate committer bit granted April 6th so I can garden.

nit &quot;Update my email address and irc nick&quot; would be a better changelog description, no?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680544</commentid>
    <comment_count>9</comment_count>
    <who name="Tom Hudson">tomhudson</who>
    <bug_when>2012-07-27 06:34:29 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; (From update of attachment 154927 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=154927&amp;action=review
&gt; 
&gt; &gt; Tools/ChangeLog:3
&gt; &gt; +        Activate committer bit granted April 6th so I can garden.
&gt; 
&gt; nit &quot;Update my email address and irc nick&quot; would be a better changelog description, no?

I thought the significant fact that needed to go in the changelog was moving me from Contributors: to Committers:</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680548</commentid>
    <comment_count>10</comment_count>
      <attachid>154927</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-27 06:37:27 -0700</bug_when>
    <thetext>Comment on attachment 154927
Patch

Rejecting attachment 154927 from commit-queue.

tomhudson@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680576</commentid>
    <comment_count>11</comment_count>
      <attachid>154927</attachid>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-07-27 06:52:03 -0700</bug_when>
    <thetext>Comment on attachment 154927
Patch

Setting cq+.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680631</commentid>
    <comment_count>12</comment_count>
      <attachid>154927</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-27 07:39:43 -0700</bug_when>
    <thetext>Comment on attachment 154927
Patch

Rejecting attachment 154927 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 2

Last 500 characters of output:
410-ab3c-d52691b4dbfc ...
Currently at 123873 = ac0cb6ade7cad7a46d3800ba5b8d9fff931c2986
r123874 = c63ad0593b841b826df1d10fe8242e3c73e492c2
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
RA layer request failed: Server sent unexpected return value (503 Service Temporarily Unavailable) in response to OPTIONS request for &apos;http://svn.webkit.org/repository/webkit&apos; at /usr/lib/git-core/git-svn line 2290

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13375402</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680820</commentid>
    <comment_count>13</comment_count>
      <attachid>154927</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-27 11:03:04 -0700</bug_when>
    <thetext>Comment on attachment 154927
Patch

Rejecting attachment 154927 from commit-queue.

tomhudson@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680846</commentid>
    <comment_count>14</comment_count>
      <attachid>154927</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-27 11:17:50 -0700</bug_when>
    <thetext>Comment on attachment 154927
Patch

Clearing flags on attachment: 154927

Committed r123892: &lt;http://trac.webkit.org/changeset/123892&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>680847</commentid>
    <comment_count>15</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-27 11:17:54 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>681053</commentid>
    <comment_count>16</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2012-07-27 13:53:00 -0700</bug_when>
    <thetext>One is supposed to land changes to this file manually, not have someone else cq+ it. That&apos;s how you prove that you actually have committer privileges.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>681059</commentid>
    <comment_count>17</comment_count>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-07-27 13:58:02 -0700</bug_when>
    <thetext>(In reply to comment #16)
&gt; One is supposed to land changes to this file manually, not have someone else cq+ it. That&apos;s how you prove that you actually have committer privileges.

I was never told anything like this when I became a committer, and judging by a quick peek by similar changes made by other recent new committers, neither were they.

If such a policy exist, then it should be communicated much more clearly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>681074</commentid>
    <comment_count>18</comment_count>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-07-27 14:09:32 -0700</bug_when>
    <thetext>To be clear, I of course don&apos;t doubt existence of such a policy if you say it does. We can&apos;t expect new contributors to immediately understand all our (sometimes unwritten) policies, though, and this seems like a good candidate to clarify on, for example in the initial e-mail sent by Brian.

I have modified the to-do item on the wiki page for now.
https://trac.webkit.org/wiki/CommitterTips</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>154922</attachid>
            <date>2012-07-27 06:12:21 -0700</date>
            <delta_ts>2012-07-27 06:22:21 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-92500-20120727091209.patch</filename>
            <type>text/plain</type>
            <size>1823</size>
            <attacher name="Tom Hudson">tomhudson</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDEyMzczNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDkgQEAKKzIwMTItMDctMjcgIFRvbSBIdWRzb24gIDxodWRzb25AZ29vZ2xlLmNvbT4KKwor
ICAgICAgICBBY3RpdmF0ZSBjb21taXR0ZXIgYml0IGdyYW50ZWQgQXByaWwgNnRoIHNvIEkgY2Fu
IGdhcmRlbi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21t
aXR0ZXJzLnB5OgorCiAyMDEyLTA3LTI2ICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0
Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIHNwZWN1bGF0aXZlIGJ1aWxkZml4IGFmdGVyIHIx
MjM3MjkuCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0
dGVycy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25m
aWcvY29tbWl0dGVycy5weQkocmV2aXNpb24gMTIzODY3KQorKysgVG9vbHMvU2NyaXB0cy93ZWJr
aXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRlcnMucHkJKHdvcmtpbmcgY29weSkKQEAgLTE1OCw3
ICsxNTgsNiBAQCBjb250cmlidXRvcnNfd2hvX2FyZV9ub3RfY29tbWl0dGVycyA9IFsKICAgICBD
b250cmlidXRvcigiVGFtYXMgQ3plbmUiLCBbInRjemVuZUBpbmYudS1zemVnZWQuaHUiLCAiQ3pl
bmUuVGFtYXNAc3R1ZC51LXN6ZWdlZC5odSJdLCAidGN6ZW5lIiksCiAgICAgQ29udHJpYnV0b3Io
IlRlcnJ5IEFuZGVyc29uIiwgInRkYW5kZXJzb25AY2hyb21pdW0ub3JnIiwgInRkYW5kZXJzb24i
KSwKICAgICBDb250cmlidXRvcigiVGllbi1SZW4gQ2hlbiIsICJ0cmNoZW5AY2hyb21pdW0ub3Jn
IiwgInRyY2hlbiIpLAotICAgIENvbnRyaWJ1dG9yKCJUb20gSHVkc29uIiwgInRvbWh1ZHNvbkBn
b29nbGUuY29tIiksCiAgICAgQ29udHJpYnV0b3IoIldlYktpdCBSZXZpZXcgQm90IiwgIndlYmtp
dC5yZXZpZXcuYm90QGdtYWlsLmNvbSIsICJzaGVyaWZmLWJvdCIpLAogICAgIENvbnRyaWJ1dG9y
KCJXeWF0dCBDYXJzcyIsIFsid2NhcnNzQGNocm9taXVtLm9yZyIsICJ3Y2Fyc3NAZ29vZ2xlLmNv
bSJdLCAid2NhcnNzIiksCiAgICAgQ29udHJpYnV0b3IoIlplZXYgTGllYmVyIiwgInpsaWViZXJA
Y2hyb21pdW0ub3JnIiksCkBAIC0zNzEsNiArMzcwLDcgQEAgY29tbWl0dGVyc191bmFibGVfdG9f
cmV2aWV3ID0gWwogICAgIENvbW1pdHRlcigiU3RldmUgTGFjZXkiLCAic2psQGNocm9taXVtLm9y
ZyIsICJzdGV2ZWxhIiksCiAgICAgQ29tbWl0dGVyKCJUYWthc2hpIFRveW9zaGltYSIsICJ0b3lv
c2hpbUBjaHJvbWl1bS5vcmciLCAidG95b3NoaW0iKSwKICAgICBDb21taXR0ZXIoIlRob21hcyBT
ZXBleiIsICJ0c2VwZXpAY2hyb21pdW0ub3JnIiwgInRzZXBleiIpLAorICAgIENvbW1pdHRlcigi
VG9tIEh1ZHNvbiIsICJ0b21odWRzb25AZ29vZ2xlLmNvbSIpLAogICAgIENvbW1pdHRlcigiVG9t
IFpha3JhanNlayIsICJ0b216QGNvZGVhdXJvcmEub3JnIiwgInRvbXoiKSwKICAgICBDb21taXR0
ZXIoIlRvbW15IFdpZGVuZmx5Y2h0IiwgInRvbW15d0Bnb29nbGUuY29tIiwgInRvbW15dyIpLAog
ICAgIENvbW1pdHRlcigiVHJleSBNYXR0ZXNvbiIsICJ0cmV5QHVzYS5uZXQiLCAidHJleSIpLAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>154926</attachid>
            <date>2012-07-27 06:22:25 -0700</date>
            <delta_ts>2012-07-27 06:28:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-92500-20120727092213.patch</filename>
            <type>text/plain</type>
            <size>1918</size>
            <attacher name="Tom Hudson">tomhudson</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDEyMzczNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDEwIEBACisyMDEyLTA3LTI3ICBUb20gSHVkc29uICA8aHVkc29uQGdvb2dsZS5jb20+CisK
KyAgICAgICAgQWN0aXZhdGUgY29tbWl0dGVyIGJpdCBncmFudGVkIEFwcmlsIDZ0aCBzbyBJIGNh
biBnYXJkZW4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD05MjUwMAorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1p
dHRlcnMucHk6CisKIDIwMTItMDctMjYgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQu
b3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgc3BlY3VsYXRpdmUgYnVpbGRmaXggYWZ0ZXIgcjEy
MzcyOS4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0
ZXJzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZp
Zy9jb21taXR0ZXJzLnB5CShyZXZpc2lvbiAxMjM4NjcpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp
dHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5weQkod29ya2luZyBjb3B5KQpAQCAtMTU4LDcg
KzE1OCw2IEBAIGNvbnRyaWJ1dG9yc193aG9fYXJlX25vdF9jb21taXR0ZXJzID0gWwogICAgIENv
bnRyaWJ1dG9yKCJUYW1hcyBDemVuZSIsIFsidGN6ZW5lQGluZi51LXN6ZWdlZC5odSIsICJDemVu
ZS5UYW1hc0BzdHVkLnUtc3plZ2VkLmh1Il0sICJ0Y3plbmUiKSwKICAgICBDb250cmlidXRvcigi
VGVycnkgQW5kZXJzb24iLCAidGRhbmRlcnNvbkBjaHJvbWl1bS5vcmciLCAidGRhbmRlcnNvbiIp
LAogICAgIENvbnRyaWJ1dG9yKCJUaWVuLVJlbiBDaGVuIiwgInRyY2hlbkBjaHJvbWl1bS5vcmci
LCAidHJjaGVuIiksCi0gICAgQ29udHJpYnV0b3IoIlRvbSBIdWRzb24iLCAidG9taHVkc29uQGdv
b2dsZS5jb20iKSwKICAgICBDb250cmlidXRvcigiV2ViS2l0IFJldmlldyBCb3QiLCAid2Via2l0
LnJldmlldy5ib3RAZ21haWwuY29tIiwgInNoZXJpZmYtYm90IiksCiAgICAgQ29udHJpYnV0b3Io
Ild5YXR0IENhcnNzIiwgWyJ3Y2Fyc3NAY2hyb21pdW0ub3JnIiwgIndjYXJzc0Bnb29nbGUuY29t
Il0sICJ3Y2Fyc3MiKSwKICAgICBDb250cmlidXRvcigiWmVldiBMaWViZXIiLCAiemxpZWJlckBj
aHJvbWl1bS5vcmciKSwKQEAgLTM3MSw2ICszNzAsNyBAQCBjb21taXR0ZXJzX3VuYWJsZV90b19y
ZXZpZXcgPSBbCiAgICAgQ29tbWl0dGVyKCJTdGV2ZSBMYWNleSIsICJzamxAY2hyb21pdW0ub3Jn
IiwgInN0ZXZlbGEiKSwKICAgICBDb21taXR0ZXIoIlRha2FzaGkgVG95b3NoaW1hIiwgInRveW9z
aGltQGNocm9taXVtLm9yZyIsICJ0b3lvc2hpbSIpLAogICAgIENvbW1pdHRlcigiVGhvbWFzIFNl
cGV6IiwgInRzZXBlekBjaHJvbWl1bS5vcmciLCAidHNlcGV6IiksCisgICAgQ29tbWl0dGVyKCJU
b20gSHVkc29uIiwgInRvbWh1ZHNvbkBnb29nbGUuY29tIiwgInRvbWh1ZHNvbkBjaHJvbWl1bS5v
cmciLCAidG9taHVkc29uIiksCiAgICAgQ29tbWl0dGVyKCJUb20gWmFrcmFqc2VrIiwgInRvbXpA
Y29kZWF1cm9yYS5vcmciLCAidG9teiIpLAogICAgIENvbW1pdHRlcigiVG9tbXkgV2lkZW5mbHlj
aHQiLCAidG9tbXl3QGdvb2dsZS5jb20iLCAidG9tbXl3IiksCiAgICAgQ29tbWl0dGVyKCJUcmV5
IE1hdHRlc29uIiwgInRyZXlAdXNhLm5ldCIsICJ0cmV5IiksCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>154927</attachid>
            <date>2012-07-27 06:28:22 -0700</date>
            <delta_ts>2012-07-27 11:17:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-92500-20120727092810.patch</filename>
            <type>text/plain</type>
            <size>1959</size>
            <attacher name="Tom Hudson">tomhudson</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDEyMzczNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDEyIEBACisyMDEyLTA3LTI3ICBUb20gSHVkc29uICA8aHVkc29uQGdvb2dsZS5jb20+CisK
KyAgICAgICAgQWN0aXZhdGUgY29tbWl0dGVyIGJpdCBncmFudGVkIEFwcmlsIDZ0aCBzbyBJIGNh
biBnYXJkZW4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD05MjUwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
ICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRlcnMucHk6CisKIDIwMTIt
MDctMjYgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFVu
cmV2aWV3ZWQgc3BlY3VsYXRpdmUgYnVpbGRmaXggYWZ0ZXIgcjEyMzcyOS4KSW5kZXg6IFRvb2xz
L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5Cj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5CShy
ZXZpc2lvbiAxMjM4NjcpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcv
Y29tbWl0dGVycy5weQkod29ya2luZyBjb3B5KQpAQCAtMTU4LDcgKzE1OCw2IEBAIGNvbnRyaWJ1
dG9yc193aG9fYXJlX25vdF9jb21taXR0ZXJzID0gWwogICAgIENvbnRyaWJ1dG9yKCJUYW1hcyBD
emVuZSIsIFsidGN6ZW5lQGluZi51LXN6ZWdlZC5odSIsICJDemVuZS5UYW1hc0BzdHVkLnUtc3pl
Z2VkLmh1Il0sICJ0Y3plbmUiKSwKICAgICBDb250cmlidXRvcigiVGVycnkgQW5kZXJzb24iLCAi
dGRhbmRlcnNvbkBjaHJvbWl1bS5vcmciLCAidGRhbmRlcnNvbiIpLAogICAgIENvbnRyaWJ1dG9y
KCJUaWVuLVJlbiBDaGVuIiwgInRyY2hlbkBjaHJvbWl1bS5vcmciLCAidHJjaGVuIiksCi0gICAg
Q29udHJpYnV0b3IoIlRvbSBIdWRzb24iLCAidG9taHVkc29uQGdvb2dsZS5jb20iKSwKICAgICBD
b250cmlidXRvcigiV2ViS2l0IFJldmlldyBCb3QiLCAid2Via2l0LnJldmlldy5ib3RAZ21haWwu
Y29tIiwgInNoZXJpZmYtYm90IiksCiAgICAgQ29udHJpYnV0b3IoIld5YXR0IENhcnNzIiwgWyJ3
Y2Fyc3NAY2hyb21pdW0ub3JnIiwgIndjYXJzc0Bnb29nbGUuY29tIl0sICJ3Y2Fyc3MiKSwKICAg
ICBDb250cmlidXRvcigiWmVldiBMaWViZXIiLCAiemxpZWJlckBjaHJvbWl1bS5vcmciKSwKQEAg
LTM3MSw2ICszNzAsNyBAQCBjb21taXR0ZXJzX3VuYWJsZV90b19yZXZpZXcgPSBbCiAgICAgQ29t
bWl0dGVyKCJTdGV2ZSBMYWNleSIsICJzamxAY2hyb21pdW0ub3JnIiwgInN0ZXZlbGEiKSwKICAg
ICBDb21taXR0ZXIoIlRha2FzaGkgVG95b3NoaW1hIiwgInRveW9zaGltQGNocm9taXVtLm9yZyIs
ICJ0b3lvc2hpbSIpLAogICAgIENvbW1pdHRlcigiVGhvbWFzIFNlcGV6IiwgInRzZXBlekBjaHJv
bWl1bS5vcmciLCAidHNlcGV6IiksCisgICAgQ29tbWl0dGVyKCJUb20gSHVkc29uIiwgWyJ0b21o
dWRzb25AZ29vZ2xlLmNvbSIsICJ0b21odWRzb25AY2hyb21pdW0ub3JnIl0sICJ0b21odWRzb24i
KSwKICAgICBDb21taXR0ZXIoIlRvbSBaYWtyYWpzZWsiLCAidG9tekBjb2RlYXVyb3JhLm9yZyIs
ICJ0b216IiksCiAgICAgQ29tbWl0dGVyKCJUb21teSBXaWRlbmZseWNodCIsICJ0b21teXdAZ29v
Z2xlLmNvbSIsICJ0b21teXciKSwKICAgICBDb21taXR0ZXIoIlRyZXkgTWF0dGVzb24iLCAidHJl
eUB1c2EubmV0IiwgInRyZXkiKSwK
</data>

          </attachment>
      

    </bug>

</bugzilla>