92493 2012-07-27 05:01:46 -0700 REGRESSION(r123856): Breaks the build when disabling inspector 2012-07-27 11:14:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 80444 1 tmpsantos tmpsantos abarth eric haraken japhet jochen webkit.review.bot oldest_to_newest 680464 0 tmpsantos 2012-07-27 05:01:46 -0700 Get some errors when compiling MemoryInfo.h. 680501 1 154916 tmpsantos 2012-07-27 05:49:32 -0700 Created attachment 154916 Patch 680514 2 haraken 2012-07-27 06:08:34 -0700 Fixing the build error is critical, but I am not sure if the fix is correct. Looks like Eric and Adam are not in IRC. If you are confident about the fix, I can rubber-stamp it. 680535 3 tmpsantos 2012-07-27 06:26:05 -0700 (In reply to comment #2) > Fixing the build error is critical, but I am not sure if the fix is correct. Looks like Eric and Adam are not in IRC. If you are confident about the fix, I can rubber-stamp it. This fix just moves "struct HeapInfo" to outside INSPECTOR #ifdefs. I first thought about moving the struct to a new file... Let's wait and see what Eric and Adam thinks about this. 680536 4 haraken 2012-07-27 06:28:15 -0700 (In reply to comment #3) > Let's wait and see what Eric and Adam thinks about this. They are asleep:) So we might want to land your patch or roll out the original patch. If you can watch the tree for a while, it would be OK to try to land it. 680555 5 tmpsantos 2012-07-27 06:40:59 -0700 (In reply to comment #4) > (In reply to comment #3) > > Let's wait and see what Eric and Adam thinks about this. > > They are asleep:) So we might want to land your patch or roll out the original patch. If you can watch the tree for a while, it would be OK to try to land it. IMO is fine. Thanks. 680556 6 tmpsantos 2012-07-27 06:41:32 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Let's wait and see what Eric and Adam thinks about this. > > > > They are asleep:) So we might want to land your patch or roll out the original patch. If you can watch the tree for a while, it would be OK to try to land it. > > IMO is fine. Thanks. cq+? 680581 7 154916 webkit.review.bot 2012-07-27 06:57:21 -0700 Comment on attachment 154916 Patch Clearing flags on attachment: 154916 Committed r123873: <http://trac.webkit.org/changeset/123873> 680582 8 webkit.review.bot 2012-07-27 06:57:25 -0700 All reviewed patches have been landed. Closing bug. 680841 9 154916 abarth 2012-07-27 11:14:24 -0700 Comment on attachment 154916 Patch Thanks for the fix! 154916 2012-07-27 05:49:32 -0700 2012-07-27 11:14:24 -0700 Patch bug-92493-20120727154919.patch text/plain 2527 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzRkMzQ3M2ExZmM2MjQ1 MjMwYjcxYjNmN2I3MWJiODMyMTUxYjA5MS4uN2FkZTU2OTE2NjM5ZWIwYmJlZWI5MGU4ZTBjNDYz ZDRhYWE0ODVlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTI3ICBUaGlh Z28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04ocjEyMzg1Nik6IEJyZWFrcyB0aGUgYnVpbGQgd2hlbiBkaXNhYmxpbmcgaW5z cGVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MjQ5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog YmluZGluZ3MvanMvU2NyaXB0R0NFdmVudC5oOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAg ICogYmluZGluZ3MvdjgvU2NyaXB0R0NFdmVudC5oOgorICAgICAgICAoV2ViQ29yZSk6CisKIDIw MTItMDctMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQg YSBTZXR0aW5nIHRvIGV4cG9zZSBxdWFudGl6ZWQsIHJhdGUtbGltaXRlZCBNZW1vcnlJbmZvIHZh bHVlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0R0NFdmVu dC5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0R0NFdmVudC5oCmluZGV4IDFi ZDkwNzFiZGRmY2FmZWNhNTBkZjZkMDIwNjA1ODhhZTVmMzBlYmQuLjEyNjY1MDE2MDk0MGY2MmU0 MDY0NGU4MTkyMTFhMDk0NTYzMTJmODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL1NjcmlwdEdDRXZlbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9T Y3JpcHRHQ0V2ZW50LmgKQEAgLTMxLDEyICszMSw4IEBACiAjaWZuZGVmIFNjcmlwdEdDRXZlbnRf aAogI2RlZmluZSBTY3JpcHRHQ0V2ZW50X2gKIAotI2lmIEVOQUJMRShJTlNQRUNUT1IpCi0KIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAotY2xhc3MgU2NyaXB0R0NFdmVudExpc3RlbmVyOwotCiBzdHJ1 Y3QgSGVhcEluZm8gewogICAgIEhlYXBJbmZvKCkKICAgICAgICAgOiB1c2VkSlNIZWFwU2l6ZSgw KQpAQCAtNTAsNiArNDYsMTAgQEAgc3RydWN0IEhlYXBJbmZvIHsKICAgICBzaXplX3QganNIZWFw U2l6ZUxpbWl0OwogfTsKIAorI2lmIEVOQUJMRShJTlNQRUNUT1IpCisKK2NsYXNzIFNjcmlwdEdD RXZlbnRMaXN0ZW5lcjsKKwogY2xhc3MgU2NyaXB0R0NFdmVudAogewogcHVibGljOgpAQCAtNTgs NyArNTgsOCBAQCBwdWJsaWM6CiAgICAgc3RhdGljIHZvaWQgZ2V0SGVhcFNpemUoSGVhcEluZm8m KTsKIH07CiAKKyNlbmRpZiAvLyBFTkFCTEUoSU5TUEVDVE9SKQorCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCiAKLSNlbmRpZiAvLyAhRU5BQkxFKElOU1BFQ1RPUikKICNlbmRpZiAvLyAhZGVmaW5l ZChTY3JpcHRHQ0V2ZW50X2gpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9TY3JpcHRHQ0V2ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRHQ0V2 ZW50LmgKaW5kZXggZDZkNWU1N2E1MzIzY2Q2YzhlMjYwNzQzMjIwMWYwYTAwMzI1YzUzZC4uM2I2 MjQ2MzU2OTdlYWMwYTQyYzliMThhMTM1ZjkyMmU1MjVkNzEyNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0R0NFdmVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1NjcmlwdEdDRXZlbnQuaApAQCAtMzEsMTUgKzMxLDExIEBACiAjaWZuZGVm IFNjcmlwdEdDRXZlbnRfaAogI2RlZmluZSBTY3JpcHRHQ0V2ZW50X2gKIAotI2lmIEVOQUJMRShJ TlNQRUNUT1IpCi0KICNpbmNsdWRlICJ2OC5oIgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KIAog bmFtZXNwYWNlIFdlYkNvcmUgewogCi1jbGFzcyBTY3JpcHRHQ0V2ZW50TGlzdGVuZXI7Ci0KIHN0 cnVjdCBIZWFwSW5mbyB7CiAgICAgSGVhcEluZm8oKQogICAgICAgICA6IHVzZWRKU0hlYXBTaXpl KDApCkBAIC01Myw2ICs0OSwxMCBAQCBzdHJ1Y3QgSGVhcEluZm8gewogICAgIHNpemVfdCBqc0hl YXBTaXplTGltaXQ7CiB9OwogCisjaWYgRU5BQkxFKElOU1BFQ1RPUikKKworY2xhc3MgU2NyaXB0 R0NFdmVudExpc3RlbmVyOworCiBjbGFzcyBTY3JpcHRHQ0V2ZW50CiB7CiBwdWJsaWM6CkBAIC02 Niw3ICs2Niw4IEBAIHByaXZhdGU6CiAgICAgc3RhdGljIHNpemVfdCBnZXRVc2VkSGVhcFNpemUo KTsKIH07CiAKKyNlbmRpZiAvLyBFTkFCTEUoSU5TUEVDVE9SKQorCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCiAKLSNlbmRpZiAvLyAhRU5BQkxFKElOU1BFQ1RPUikKICNlbmRpZiAvLyAhZGVmaW5l ZChTY3JpcHRHQ0V2ZW50X2gpCg==