92488 2012-07-27 04:25:05 -0700 Replace ColorChooserClient::elementRectRelativeToWindow with elementRectRelativeToRootView 2012-07-27 05:28:15 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 92075 1 keishi keishi mifenton pierre.rossi tkent webkit.review.bot oldest_to_newest 680432 0 keishi 2012-07-27 04:25:05 -0700 Replace ColorChooserClient::elementRectRelativeToWindow with elementRectRelativeToRootView because we should be using root view coords inside WebCore(Bug 71945) 680439 1 154903 keishi 2012-07-27 04:33:24 -0700 Created attachment 154903 Patch 680445 2 154903 tkent 2012-07-27 04:43:28 -0700 Comment on attachment 154903 Patch ok 680489 3 154903 webkit.review.bot 2012-07-27 05:28:12 -0700 Comment on attachment 154903 Patch Clearing flags on attachment: 154903 Committed r123867: <http://trac.webkit.org/changeset/123867> 680490 4 webkit.review.bot 2012-07-27 05:28:15 -0700 All reviewed patches have been landed. Closing bug. 154903 2012-07-27 04:33:24 -0700 2012-07-27 05:28:11 -0700 Patch bug-92488-20120727203311.patch text/plain 3464 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzRkMzQ3M2ExZmM2MjQ1 MjMwYjcxYjNmN2I3MWJiODMyMTUxYjA5MS4uYzc3M2RhOWIxNTA1NjYwZmU4ZGE3MDQ4N2ZkODcw Mzg2NjY3OTIyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA3LTI3ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlcGxhY2UgQ29sb3JD aG9vc2VyQ2xpZW50OjplbGVtZW50UmVjdFJlbGF0aXZlVG9XaW5kb3cgd2l0aCBlbGVtZW50UmVj dFJlbGF0aXZlVG9Sb290VmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTI0ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDaGFuZ2luZyBDb2xvckNob29zZXJDbGllbnQgaW50ZXJmYWNlIHRvIHJldHVy biBlbGVtZW50IHJlY3RhbmdsZSB0aGF0IGlzIHJlbGF0aXZlIHRvIHJvb3QgdmlldyBpbnN0ZWFk IG9mIHdpbmRvdy4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE1ldGhvZCBpcyBub3QgdXNlZCB5 ZXQuCisKKyAgICAgICAgKiBodG1sL0NvbG9ySW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNvbG9ySW5wdXRUeXBlOjplbGVtZW50UmVjdFJlbGF0aXZlVG9Sb290Vmlldyk6IFJlcGxh Y2VkIGVsZW1lbnRSZWN0UmVsYXRpdmVUb1dpbmRvdy4gUmV0dXJucyBlbGVtZW50IHJlY3Rhbmds ZSByZWxhdGl2ZSB0byByb290IHZpZXcuCisgICAgICAgICogaHRtbC9Db2xvcklucHV0VHlwZS5o OgorICAgICAgICAoQ29sb3JJbnB1dFR5cGUpOgorICAgICAgICAqIHBsYXRmb3JtL0NvbG9yQ2hv b3NlckNsaWVudC5oOgorICAgICAgICAoQ29sb3JDaG9vc2VyQ2xpZW50KToKKwogMjAxMi0wNy0y NyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBhIFNldHRp bmcgdG8gZXhwb3NlIHF1YW50aXplZCwgcmF0ZS1saW1pdGVkIE1lbW9yeUluZm8gdmFsdWVzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9ySW5wdXRUeXBlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuY3BwCmluZGV4IGFiY2E2YWNmZGZkNDQ3ODdh M2MxYjU2OThjMmZjNzUxNTkxYTViODYuLjg4NmEyYWQwZDExZTljZDVjYTBmMjk4YzRjODkxODNk YWVlNzdjMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuY3BwCkBAIC0yMDEs MTEgKzIwMSw5IEBAIEhUTUxFbGVtZW50KiBDb2xvcklucHV0VHlwZTo6c2hhZG93Q29sb3JTd2F0 Y2goKSBjb25zdAogICAgIHJldHVybiBzaGFkb3cgPyB0b0hUTUxFbGVtZW50KHNoYWRvdy0+Zmly c3RDaGlsZCgpLT5maXJzdENoaWxkKCkpIDogMDsKIH0KIAotSW50UmVjdCBDb2xvcklucHV0VHlw ZTo6ZWxlbWVudFJlY3RSZWxhdGl2ZVRvV2luZG93KCkgY29uc3QKK0ludFJlY3QgQ29sb3JJbnB1 dFR5cGU6OmVsZW1lbnRSZWN0UmVsYXRpdmVUb1Jvb3RWaWV3KCkgY29uc3QKIHsKLSAgICBSZW5k ZXJPYmplY3QqIHJlbmRlcmVyID0gZWxlbWVudCgpLT5yZW5kZXJlcigpOwotICAgIEFTU0VSVChy ZW5kZXJlcik7Ci0gICAgcmV0dXJuIHBpeGVsU25hcHBlZEludFJlY3QocmVuZGVyZXItPnZpZXco KS0+ZnJhbWVWaWV3KCktPmNvbnRlbnRzVG9XaW5kb3cocmVuZGVyZXItPmFic29sdXRlQm91bmRp bmdCb3hSZWN0KCkpKTsKKyAgICByZXR1cm4gZWxlbWVudCgpLT5kb2N1bWVudCgpLT52aWV3KCkt PmNvbnRlbnRzVG9Sb290VmlldyhlbGVtZW50KCktPmdldFBpeGVsU25hcHBlZFJlY3QoKSk7CiB9 CiAKIENvbG9yIENvbG9ySW5wdXRUeXBlOjpjdXJyZW50Q29sb3IoKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9Db2xvcklucHV0VHlwZS5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9D b2xvcklucHV0VHlwZS5oCmluZGV4IGMwYWVkYTc4YjcyMWEyN2U0MDk2ZDg3NTA0NDYxMjVhYWMy ZDE2MzkuLjE2NzhiZGNlNmIzNjRiOGRjMWVkZjNiNDE5YzQyZmZiNDc4ODI4ZDggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0NvbG9ySW5wdXRUeXBlLmgKQEAgLTQ2LDcgKzQ2LDcgQEAgcHVibGljOgogICAg IC8vIENvbG9yQ2hvb3NlckNsaWVudCBpbXBsZW1lbnRhdGlvbi4KICAgICB2aXJ0dWFsIHZvaWQg ZGlkQ2hvb3NlQ29sb3IoY29uc3QgQ29sb3ImKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQg ZGlkRW5kQ2hvb3NlcigpIE9WRVJSSURFOwotICAgIHZpcnR1YWwgSW50UmVjdCBlbGVtZW50UmVj dFJlbGF0aXZlVG9XaW5kb3coKSBjb25zdCBPVkVSUklERTsKKyAgICB2aXJ0dWFsIEludFJlY3Qg ZWxlbWVudFJlY3RSZWxhdGl2ZVRvUm9vdFZpZXcoKSBjb25zdCBPVkVSUklERTsKICAgICB2aXJ0 dWFsIENvbG9yIGN1cnJlbnRDb2xvcigpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgYm9vbCBzaG91 bGRTaG93U3VnZ2VzdGlvbnMoKSBjb25zdCBPVkVSUklERTsKICAgICB2aXJ0dWFsIFZlY3RvcjxD b2xvcj4gc3VnZ2VzdGlvbnMoKSBjb25zdCBPVkVSUklERTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL0NvbG9yQ2hvb3NlckNsaWVudC5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vQ29sb3JDaG9vc2VyQ2xpZW50LmgKaW5kZXggOGJhY2VkMzkyYzU1M2JlNTI4N2VkMjEx NWZiMDZkNTlmOTAxZTdhMS4uNTkyNTMzNGEyY2I2NjcxMTdmOTJhNzhmNjVmNTQ5ODNkMDJjYmU4 MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ29sb3JDaG9vc2VyQ2xpZW50 LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ29sb3JDaG9vc2VyQ2xpZW50LmgKQEAg LTE5LDcgKzE5LDcgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCB2b2lkIGRpZENob29zZUNvbG9y KGNvbnN0IENvbG9yJikgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBkaWRFbmRDaG9vc2VyKCkgPSAw OwotICAgIHZpcnR1YWwgSW50UmVjdCBlbGVtZW50UmVjdFJlbGF0aXZlVG9XaW5kb3coKSBjb25z dCA9IDA7CisgICAgdmlydHVhbCBJbnRSZWN0IGVsZW1lbnRSZWN0UmVsYXRpdmVUb1Jvb3RWaWV3 KCkgY29uc3QgPSAwOwogICAgIHZpcnR1YWwgQ29sb3IgY3VycmVudENvbG9yKCkgPSAwOwogICAg IHZpcnR1YWwgYm9vbCBzaG91bGRTaG93U3VnZ2VzdGlvbnMoKSBjb25zdCA9IDA7CiAgICAgdmly dHVhbCBWZWN0b3I8Q29sb3I+IHN1Z2dlc3Rpb25zKCkgY29uc3QgPSAwOwo=