92487 2012-07-27 04:16:29 -0700 CSP directives containing invalid characters should log an error 2012-07-27 11:57:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mkwst mkwst abarth webkit.review.bot oldest_to_newest 680426 0 mkwst 2012-07-27 04:16:29 -0700 `X-WebKit-CSP: script-src: 'unsafe-inline';` should log an error to the console, as the invalid `:` means the directive is ignored. 680436 1 mkwst 2012-07-27 04:33:01 -0700 Clarifying the title of the bug, uploading a patch in a moment. 680444 2 154906 mkwst 2012-07-27 04:38:58 -0700 Created attachment 154906 Patch 680447 3 mkwst 2012-07-27 04:46:16 -0700 Adam, can you take a look at this when you get a chance? Low priority, just an edge case in which a lack of logging confused me briefly. 680871 4 154906 webkit.review.bot 2012-07-27 11:38:41 -0700 Comment on attachment 154906 Patch Clearing flags on attachment: 154906 Committed r123899: <http://trac.webkit.org/changeset/123899> 680872 5 webkit.review.bot 2012-07-27 11:38:44 -0700 All reviewed patches have been landed. Closing bug. 680901 6 mkwst 2012-07-27 11:57:05 -0700 Thanks for throwing this in the CQ, Adam. I appreciate it. :) 154906 2012-07-27 04:38:58 -0700 2012-07-27 11:38:41 -0700 Patch bug-92487-20120727133845.patch text/plain 5581 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTU5NjI5MWUwMDliYjYy OGYxYjNkMjhmNGE0ZjliMDY4MDU4MDgzMi4uYjljYjg1NzhmNTM0ODRjYjY3YTRmMWZiNGVlZWFm OTQzNjRiNjJkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA3LTI3ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ1NQIGRpcmVjdGl2ZXMgY29u dGFpbmluZyBpbnZhbGlkIGNoYXJhY3RlcnMgc2hvdWxkIGxvZyBhbiBlcnJvci4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNDg3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5rbm93biBkaXJlY3RpdmUg bmFtZXMgYXJlIGN1cnJlbnRseSBsb2dnZWQsIGJ1dCB3ZSBleGl0IHRoZSBkaXJlY3RpdmUKKyAg ICAgICAgcGFyc2VyIGVhcmx5IHdpdGhvdXQgbG9nZ2luZyBpZiB3ZSBoaXQgYW4gaW52YWxpZCBj aGFyYWN0ZXIgaW5zaWRlIGEKKyAgICAgICAgZGlyZWN0aXZlLiBgc2NyaXB0LXNyYzogLi4uYCwg Zm9yIGV4YW1wbGUsIHdhcyBpZ25vcmVkIHdpdGhvdXQgbGV0dGluZworICAgICAgICB0aGUgZGV2 ZWxvcGVyIGtub3cgd2hhdCBoYXBwZW5lZC4gVGhpcyBwYXRjaCBjaGFuZ2VzIHRoYXQgYmVoYXZp b3IsCisgICAgICAgIGxvZ2dpbmcgdGhlIHdob2xlIG5hbWUgKGluIHRoaXMgY2FzZSBgc2NyaXB0 LXNyYzpgKSBhcyBhbiB1bmtub3duCisgICAgICAgIGRpcmVjdGl2ZS4KKworICAgICAgICBUZXN0 OiBodHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9kaXJlY3RpdmUtcGFy c2luZy0wNC5odG1sCisKKyAgICAgICAgKiBwYWdlL0NvbnRlbnRTZWN1cml0eVBvbGljeS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpDU1BEaXJlY3RpdmVMaXN0OjpwYXJzZURpcmVjdGl2ZSk6CisK IDIwMTItMDctMjYgIEthdXN0dWJoIEF0cmF3YWxrYXIgIDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+ CiAKICAgICAgICAgW0RSVF0gTFRDOjogcGFnZU51bWJlckZvckVsZW1lbnRCeUlkKCkgY291bGQg YmUgbW92ZWQgdG8gSW50ZXJuYWxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nv bnRlbnRTZWN1cml0eVBvbGljeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnRlbnRTZWN1 cml0eVBvbGljeS5jcHAKaW5kZXggZGFjNjVjMzM2ODZkNTg2YTQ5N2M5OWIzNTZjZWY4ZmQ2MDJi YzRhNy4uODBjN2UwMDIwNzlhNjk2Y2JkYjhhMGE4ZGUyNzBkYzQ3NmVkY2E4ZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9Db250ZW50U2VjdXJpdHlQb2xpY3kuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvQ29udGVudFNlY3VyaXR5UG9saWN5LmNwcApAQCAtODg3LDggKzg4 NywxMSBAQCBib29sIENTUERpcmVjdGl2ZUxpc3Q6OnBhcnNlRGlyZWN0aXZlKGNvbnN0IFVDaGFy KiBiZWdpbiwgY29uc3QgVUNoYXIqIGVuZCwgU3RyaQogICAgIGlmIChwb3NpdGlvbiA9PSBlbmQp CiAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAgaWYgKCFza2lwRXhhY3RseTxpc0FTQ0lJU3Bh Y2U+KHBvc2l0aW9uLCBlbmQpKQorICAgIGlmICghc2tpcEV4YWN0bHk8aXNBU0NJSVNwYWNlPihw b3NpdGlvbiwgZW5kKSkgeworICAgICAgICBza2lwV2hpbGU8aXNOb3RBU0NJSVNwYWNlPihwb3Np dGlvbiwgZW5kKTsKKyAgICAgICAgbG9nVW5yZWNvZ25pemVkRGlyZWN0aXZlKFN0cmluZyhuYW1l QmVnaW4sIHBvc2l0aW9uIC0gbmFtZUJlZ2luKSk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKKyAg ICB9CiAKICAgICBza2lwV2hpbGU8aXNBU0NJSVNwYWNlPihwb3NpdGlvbiwgZW5kKTsKIApkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IGM0YjQyNWI2NWVkOTdmZjJmMTQzYjBlYzE3YzJjZTM3NGMzMzNiNDIuLmY0NGIwMjViOTc1 NWMwMzNiYTYzOGU1NDUxYmMyNTFmMGIxYTIzNDAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAx Mi0wNy0yNyAgTWlrZSBXZXN0ICA8bWt3c3RAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENTUCBk aXJlY3RpdmVzIGNvbnRhaW5pbmcgaW52YWxpZCBjaGFyYWN0ZXJzIHNob3VsZCBsb2cgYW4gZXJy b3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjQ4 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHR0 cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvZGlyZWN0aXZlLXBhcnNpbmct MDMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nv bnRlbnRTZWN1cml0eVBvbGljeS9kaXJlY3RpdmUtcGFyc2luZy0wNC1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5 L2RpcmVjdGl2ZS1wYXJzaW5nLTA0Lmh0bWw6IEFkZGVkLgorICAgICAgICAgICAgQWRkaW5nIGEg dGVzdCBzcGVjaWZpY2FsbHkgZm9yIGBzY3JpcHQtc3JjOiAuLi5gIHdoaWNoIGJpdCBtZSwgYW5k CisgICAgICAgICAgICB1cGRhdGluZyB0ZXN0ICMzLCB3aGljaCBub3cgaGFzIGEgYmV0dGVyIGVy cm9yIG1lc3NhZ2UuCisKIDIwMTItMDctMjYgIEthdXN0dWJoIEF0cmF3YWxrYXIgIDxrYXVzdHVi aEBtb3Rvcm9sYS5jb20+CiAKICAgICAgICAgW0RSVF0gTFRDOjogcGFnZU51bWJlckZvckVsZW1l bnRCeUlkKCkgY291bGQgYmUgbW92ZWQgdG8gSW50ZXJuYWxzCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9kaXJlY3RpdmUt cGFyc2luZy0wMy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5 L2NvbnRlbnRTZWN1cml0eVBvbGljeS9kaXJlY3RpdmUtcGFyc2luZy0wMy1leHBlY3RlZC50eHQK aW5kZXggNjg2ZWI3MDRkY2U4OTZkOGRkYmJmM2M1ZDQyNTI4YjA5MmVmY2VkNS4uNDljZTAwODBj MWVhYzdiYzA2YTk3MmZhOThkNTM4YTBiMWUzNjJkYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvZGlyZWN0aXZlLXBhcnNp bmctMDMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkv Y29udGVudFNlY3VyaXR5UG9saWN5L2RpcmVjdGl2ZS1wYXJzaW5nLTAzLWV4cGVjdGVkLnR4dApA QCAtMSwzICsxLDUgQEAKK0NPTlNPTEUgTUVTU0FHRTogVW5yZWNvZ25pemVkIENvbnRlbnQtU2Vj dXJpdHktUG9saWN5IGRpcmVjdGl2ZSAnYQdhYScuCisKIENPTlNPTEUgTUVTU0FHRTogUmVmdXNl ZCB0byBsb2FkIHRoZSBzY3JpcHQgJ2h0dHA6Ly8xMjcuMC4wLjE6ODAwMC9zZWN1cml0eS9jb250 ZW50U2VjdXJpdHlQb2xpY3kvcmVzb3VyY2VzL3NjcmlwdC5qcycgYmVjYXVzZSBpdCB2aW9sYXRl cyB0aGUgZm9sbG93aW5nIENvbnRlbnQgU2VjdXJpdHkgUG9saWN5IGRpcmVjdGl2ZTogInNjcmlw dC1zcmMgJ25vbmUnIi4KIAogVGhpcyBzY3JpcHQgc2hvdWxkIG5vdCBleGVjdXRlIGV2ZW4gdGhv dWdoIHRoZXJlIGFyZSBwYXJzZSBlcnJvcnMgaW4gdGhlIHBvbGljeS4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5L2RpcmVj dGl2ZS1wYXJzaW5nLTA0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2Vj dXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5L2RpcmVjdGl2ZS1wYXJzaW5nLTA0LWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi43N2JiNzc1ZWExYWExNzc2YTdkMzVhZTQyZTQ5ZmI2MDljMDU3MDBk Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jb250 ZW50U2VjdXJpdHlQb2xpY3kvZGlyZWN0aXZlLXBhcnNpbmctMDQtZXhwZWN0ZWQudHh0CkBAIC0w LDAgKzEsMTAgQEAKK0NPTlNPTEUgTUVTU0FHRTogVW5yZWNvZ25pemVkIENvbnRlbnQtU2VjdXJp dHktUG9saWN5IGRpcmVjdGl2ZSAnc2NyaXB0LXNyYzonLgorCitBIHdhcm5pbmcgc2hvdWxkIGJl IGxvZ2dlZCB0byB0aGUgY29uc29sZSwgYXMgYHNjcmlwdC1zcmM6ICdub25lJ2Agc2hvdWxkbid0 IGNvbnRhaW4gYSBjb2xvbi4gU2luY2UgdGhlIGRpcmVjdGl2ZSBpcyBpbnZhbGlkLCB0aGUgc2Ny aXB0IHNob3VsZCBydW4uCisKKworCistLS0tLS0tLQorRnJhbWU6ICc8IS0tZnJhbWVQYXRoIC8v PCEtLWZyYW1lMC0tPi0tPicKKy0tLS0tLS0tCitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9kaXJlY3RpdmUtcGFy c2luZy0wNC5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2Vj dXJpdHlQb2xpY3kvZGlyZWN0aXZlLXBhcnNpbmctMDQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iMjUzMzYx ZmU0MWRjYzYxMjg0NDBmMjRlZDI2NWJiODQzNmJiZWNmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvZGlyZWN0 aXZlLXBhcnNpbmctMDQuaHRtbApAQCAtMCwwICsxLDE4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxo dG1sPgorPGhlYWQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgIHRlc3RS dW5uZXIuZHVtcEFzVGV4dCgpOworICB0ZXN0UnVubmVyLmR1bXBDaGlsZEZyYW1lc0FzVGV4dCgp OworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgPHA+CisgICAgQSB3YXJuaW5nIHNo b3VsZCBiZSBsb2dnZWQgdG8gdGhlIGNvbnNvbGUsIGFzIGBzY3JpcHQtc3JjOiAnbm9uZSdgIHNo b3VsZG4ndAorICAgIGNvbnRhaW4gYSBjb2xvbi4gU2luY2UgdGhlIGRpcmVjdGl2ZSBpcyBpbnZh bGlkLCB0aGUgc2NyaXB0IHNob3VsZCBydW4uCisgIDwvcD4KKyAgPGlmcmFtZSBzcmM9Imh0dHA6 Ly8xMjcuMC4wLjE6ODAwMC9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvcmVzb3VyY2Vz L2VjaG8tc2NyaXB0LXNyYy5wbD9zaG91bGRfcnVuPXllcyZxPWh0dHA6Ly8xMjcuMC4wLjE6ODAw MC9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvcmVzb3VyY2VzL3NjcmlwdC5qcyZjc3A9 c2NyaXB0LXNyYyUzQSUyMCdub25lJyI+PC9pZnJhbWU+Cis8L2JvZHk+Cis8L2h0bWw+Cg==