92486 2012-07-27 03:41:13 -0700 [JSC] JSC should use AtomicStrings to make Element::getAttributeNS() faster 2012-10-11 18:51:12 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 99118 1 haraken webkit-unassigned abarth barraclough eric ggaren rniwa sam oldest_to_newest 680401 0 haraken 2012-07-27 03:41:13 -0700 Assume Node::foo(AtomicString& str). Assume JavaScript calls node.foo("bar"). [V8] V8 can cache both Strings and AtomicStrings. "bar" is cached as an AtomicString. When node.foo("bar") is called, the cached AtomicString is passed to Node::foo(). Very efficient. [JSC] JSC can cache Strings but cannot cache AtomicStrings. "bar" is cached as a String. When node.foo("bar") is called, the cached String has to be converted to AtomicString and then passed to Node::foo(). For more details, please refer to Comment #0 of bug 90276. 680691 1 ggaren 2012-07-27 08:34:21 -0700 "Cache" is the wrong term for what happens when JSC passes a string to WebCore. JSC already has a StringImpl*, and it passes that to WebCore. The issue here is that "foo" is in the Identifier table but not the AtomicString table. One way to fix this is to merge the tables. 740508 2 eric 2012-10-11 18:50:12 -0700 I believe bug 99118 and this are the same bug?