92479 2012-07-27 02:51:22 -0700 Add runtime flag to enable/disable JS memory information 2012-07-27 10:19:35 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 90858 92498 1 zoltan zoltan hausmann staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 680368 0 zoltan 2012-07-27 02:51:22 -0700 We need console.memory JS object to be accessible for performance tests memory consumption measurements. 680369 1 154889 zoltan 2012-07-27 02:53:34 -0700 Created attachment 154889 proposed patch 680374 2 154889 hausmann 2012-07-27 02:58:39 -0700 Comment on attachment 154889 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=154889&action=review > Source/WebKit/qt/Api/qwebsettings.cpp:274 > + settings->setMemoryInfoEnabled(true); What's the implication of enabling this? Should this be only done when running inside DRT or the performance test harness? 680383 3 zoltan 2012-07-27 03:05:57 -0700 (In reply to comment #2) > (From update of attachment 154889 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154889&action=review > > > Source/WebKit/qt/Api/qwebsettings.cpp:274 > > + settings->setMemoryInfoEnabled(true); > > What's the implication of enabling this? Should this be only done when running inside DRT or the performance test harness? It will enable WebCore/page/MemoryInfo.h. We should expose it only for DRT/WTR, where is the better place to set this enabled? 680390 4 hausmann 2012-07-27 03:13:25 -0700 (In reply to comment #2) > (From update of attachment 154889 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154889&action=review > > > Source/WebKit/qt/Api/qwebsettings.cpp:274 > > + settings->setMemoryInfoEnabled(true); > > What's the implication of enabling this? Should this be only done when running inside DRT or the performance test harness? Perhaps InternalSettings.idl? 680477 5 154889 hausmann 2012-07-27 05:07:41 -0700 Comment on attachment 154889 proposed patch Taking this out of the review queue. I'm not sure we want this to be exposed in regular production use, so this patch is going to need an iteration :) 680479 6 zoltan 2012-07-27 05:09:19 -0700 (In reply to comment #5) > (From update of attachment 154889 [details]) > Taking this out of the review queue. I'm not sure we want this to be exposed in regular production use, so this patch is going to need an iteration :) Sure, thanks! I will upload the patch soon. :) 680498 7 154914 zoltan 2012-07-27 05:48:08 -0700 Created attachment 154914 proposed patch 680772 8 154914 webkit.review.bot 2012-07-27 10:19:31 -0700 Comment on attachment 154914 proposed patch Clearing flags on attachment: 154914 Committed r123881: <http://trac.webkit.org/changeset/123881> 680773 9 webkit.review.bot 2012-07-27 10:19:35 -0700 All reviewed patches have been landed. Closing bug. 154889 2012-07-27 02:53:34 -0700 2012-07-27 05:48:08 -0700 proposed patch enablememoryinfo.patch text/plain 1351 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCm9sZCBtb2RlIDEwMDY0NApuZXcgbW9k ZSAxMDA3NTUKaW5kZXggNTg4ZGNmNy4uMGU4ZTdjMgotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0Fw aS9xd2Vic2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5n cy5jcHAKQEAgLTI3MCw2ICsyNzAsOCBAQCB2b2lkIFFXZWJTZXR0aW5nc1ByaXZhdGU6OmFwcGx5 KCkKICAgICAgICAgc2V0dGluZ3MtPnNldE5lZWRzU2l0ZVNwZWNpZmljUXVpcmtzKHZhbHVlKTsK IAogICAgICAgICBzZXR0aW5ncy0+c2V0VXNlc1BhZ2VDYWNoZShXZWJDb3JlOjpwYWdlQ2FjaGUo KS0+Y2FwYWNpdHkoKSk7CisKKyAgICAgICAgc2V0dGluZ3MtPnNldE1lbW9yeUluZm9FbmFibGVk KHRydWUpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIFFMaXN0PFFXZWJTZXR0aW5nc1ByaXZhdGUq PiBzZXR0aW5ncyA9ICo6OmFsbFNldHRpbmdzKCk7CiAgICAgICAgIGZvciAoaW50IGkgPSAwOyBp IDwgc2V0dGluZ3MuY291bnQoKTsgKytpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCAzMjYyZjc1Li4xNWFi MDg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTI3ICBab2x0YW4g SG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF0gTWFrZSBKUyBtZW1v cnkgc3RhdHMgYXZhaWxhYmxlIHZpYSBjb25zb2xlLm1lbW9yeSBvYmplY3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNDc5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCBjb25zb2xlLm1lbW9y eSBKUyBvYmplY3QgdG8gYmUgYWNjZXNzaWJsZSBmb3IgcGVyZm9ybWFuY2UgdGVzdHMgbWVtb3J5 IGNvbnN1bXB0aW9uIG1lYXN1cmVtZW50cy4KKworICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3Mu Y3BwOgorICAgICAgICAoUVdlYlNldHRpbmdzUHJpdmF0ZTo6YXBwbHkpOgorCiAyMDEyLTA3LTI3 ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XVtX SzJdIFJFR1JFU1NJT04ocjExOTEyNyk6IHJlc2V0dGluZyB3aW5kb3cuaW50ZXJuYWxzIHNldHRp bmdzIGJldHdlZW4gdGVzdHMgZG9lc24ndCB3b3JrIHByb3Blcmx5Cg== 154914 2012-07-27 05:48:08 -0700 2012-07-27 10:19:30 -0700 proposed patch runtimesetting_memory.patch text/plain 3113 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzN2ZlYThjLi44ODk2NjM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDctMjcgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgQWRkIHJ1bnRpbWUgZmxhZyB0byBlbmFibGUvZGlzYWJsZSBKUyBtZW1vcnkgaW5mb3Jt YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTky NDc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ug bmVlZCBjb25zb2xlLm1lbW9yeSBKUyBvYmplY3QgdG8gYmUgYWNjZXNzaWJsZSBiZWNhdXNlIG9m IHRoZSBtZW1vcnkgY29uc3VtcHRpb24KKyAgICAgICAgbWVhc3VyZW1lbnRzIG9mIHRoZSBwZXJm b3JtYW5jZSB0ZXN0cywgc28gSSBhZGRlZCBhIHRvZ2dsZSB0byBJbnRlcm5hbFNldHRpbmdzLgor CisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkludGVybmFsU2V0dGluZ3M6OnNldE1lbW9yeUluZm9FbmFibGVkKToKKyAgICAgICAgKFdl YkNvcmUpOgorICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5oOgorICAgICAgICAo SW50ZXJuYWxTZXR0aW5ncyk6CisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmlk bDoKKwogMjAxMi0wNy0yNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyMzgyMC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS90ZXN0aW5nL0ludGVybmFsU2V0dGluZ3MuY3BwCm9sZCBtb2RlIDEwMDY0NApuZXcg bW9kZSAxMDA3NTUKaW5kZXggNTMxYjA0Zi4uMzU2OGRjOQotLS0gYS9Tb3VyY2UvV2ViQ29yZS90 ZXN0aW5nL0ludGVybmFsU2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3Rpbmcv SW50ZXJuYWxTZXR0aW5ncy5jcHAKQEAgLTU5MSw0ICs1OTEsMTAgQEAgU3RyaW5nIEludGVybmFs U2V0dGluZ3M6OmNvbmZpZ3VyYXRpb25Gb3JWaWV3cG9ydChmbG9hdCBkZXZpY2VQaXhlbFJhdGlv LCBpbnQgZGUKICAgICByZXR1cm4gInZpZXdwb3J0IHNpemUgIiArIFN0cmluZzo6bnVtYmVyKGF0 dHJpYnV0ZXMubGF5b3V0U2l6ZS53aWR0aCgpKSArICJ4IiArIFN0cmluZzo6bnVtYmVyKGF0dHJp YnV0ZXMubGF5b3V0U2l6ZS5oZWlnaHQoKSkgKyAiIHNjYWxlICIgKyBTdHJpbmc6Om51bWJlcihh dHRyaWJ1dGVzLmluaXRpYWxTY2FsZSkgKyAiIHdpdGggbGltaXRzIFsiICsgU3RyaW5nOjpudW1i ZXIoYXR0cmlidXRlcy5taW5pbXVtU2NhbGUpICsgIiwgIiArIFN0cmluZzo6bnVtYmVyKGF0dHJp YnV0ZXMubWF4aW11bVNjYWxlKSArICJdIGFuZCB1c2VyU2NhbGFibGUgIiArIChhdHRyaWJ1dGVz LnVzZXJTY2FsYWJsZSA/ICJ0cnVlIiA6ICJmYWxzZSIpOwogfQogCit2b2lkIEludGVybmFsU2V0 dGluZ3M6OnNldE1lbW9yeUluZm9FbmFibGVkKGJvb2wgZW5hYmxlZCwgRXhjZXB0aW9uQ29kZSYg ZWMpCit7CisgICAgSW50ZXJuYWxTZXR0aW5nc0d1YXJkRm9yU2V0dGluZ3MoKTsKKyAgICBzZXR0 aW5ncygpLT5zZXRNZW1vcnlJbmZvRW5hYmxlZChlbmFibGVkKTsKK30KKwogfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmggYi9Tb3VyY2UvV2Vi Q29yZS90ZXN0aW5nL0ludGVybmFsU2V0dGluZ3MuaApvbGQgbW9kZSAxMDA2NDQKbmV3IG1vZGUg MTAwNzU1CmluZGV4IGYwNGIxZmEuLmMzZDBjYjUKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGlu Zy9JbnRlcm5hbFNldHRpbmdzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5h bFNldHRpbmdzLmgKQEAgLTEzNCw2ICsxMzQsNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBzaG91bGRE aXNwbGF5VHJhY2tLaW5kKGNvbnN0IFN0cmluZyYga2luZCwgRXhjZXB0aW9uQ29kZSYpOwogICAg IHZvaWQgc2V0RW5hYmxlTW9ja1BhZ2VQb3B1cChib29sLCBFeGNlcHRpb25Db2RlJik7CiAgICAg U3RyaW5nIGNvbmZpZ3VyYXRpb25Gb3JWaWV3cG9ydChmbG9hdCBkZXZpY2VQaXhlbFJhdGlvLCBp bnQgZGV2aWNlV2lkdGgsIGludCBkZXZpY2VIZWlnaHQsIGludCBhdmFpbGFibGVXaWR0aCwgaW50 IGF2YWlsYWJsZUhlaWdodCwgRXhjZXB0aW9uQ29kZSYpOworICAgIHZvaWQgc2V0TWVtb3J5SW5m b0VuYWJsZWQoYm9vbCwgRXhjZXB0aW9uQ29kZSYpOwogcHJpdmF0ZToKICAgICBleHBsaWNpdCBJ bnRlcm5hbFNldHRpbmdzKFBhZ2UqKTsKICAgICB2aXJ0dWFsIHZvaWQgaG9zdERlc3Ryb3llZCgp IE9WRVJSSURFIHsgbV9wYWdlID0gMDsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVz dGluZy9JbnRlcm5hbFNldHRpbmdzLmlkbCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJu YWxTZXR0aW5ncy5pZGwKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQppbmRleCAzYjk1 YzY1Li5kZDEzOWMwCi0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5n cy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmlkbApA QCAtNzUsNiArNzUsNyBAQCBtb2R1bGUgd2luZG93IHsKICAgICAgICAgdm9pZCBzZXRTaG91bGRE aXNwbGF5VHJhY2tLaW5kKGluIERPTVN0cmluZyBraW5kLCBpbiBib29sZWFuIGVuYWJsZWQpIHJh aXNlcyAoRE9NRXhjZXB0aW9uKTsKICAgICAgICAgYm9vbGVhbiBzaG91bGREaXNwbGF5VHJhY2tL aW5kKGluIERPTVN0cmluZyB0cmFja0tpbmQpIHJhaXNlcyAoRE9NRXhjZXB0aW9uKTsKICNlbmRp ZgorICAgICAgICB2b2lkIHNldE1lbW9yeUluZm9FbmFibGVkKGluIGJvb2xlYW4gZW5hYmxlZCkg cmFpc2VzKERPTUV4Y2VwdGlvbik7CiAgICAgfTsKIH0KIAo=