92477 2012-07-27 02:39:05 -0700 REGRESSION (r123767): platform/gtk/accessibility/object-with-title.html failing on GTK 2012-07-30 01:28:44 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r123768%20(26872)/results.html LayoutTestFailure, MakingBotsRed, Regression P2 Normal --- 1 zan mario cfleizach mario oldest_to_newest 680353 0 zan 2012-07-27 02:39:05 -0700 platform/gtk/accessibility/object-with-title.html started failing on GTK after r123767. http://trac.webkit.org/changeset/123767/trunk --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/platform/gtk/accessibility/object-with-title-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/platform/gtk/accessibility/object-with-title-actual.txt @@ -8,8 +8,8 @@ PASS child.role is 'AXRole: list' -PASS child.role is 'AXRole: section' -PASS child.role is 'AXRole: list' +FAIL child.role should be AXRole: section. Was AXRole: list. +FAIL child.role should be AXRole: list. Was AXRole: list item. PASS successfullyParsed is true TEST COMPLETE Perhaps this is actually a progression and the test case should be updated? 680762 1 154981 mario 2012-07-27 10:10:02 -0700 Created attachment 154981 Patch proposal (In reply to comment #0) > platform/gtk/accessibility/object-with-title.html started failing on GTK after r123767. > http://trac.webkit.org/changeset/123767/trunk > [...] > Perhaps this is actually a progression and the test case should be updated? Doesn't seem so. It seems the problem is that the <div> holding the second list is not being exposed (when it should be) because helpText() is not returning the title attribute, just because it happens to be the same than the accessibility description (that changed in r123767). This seems to be a problem for the GTK port because we expect to expose any object with an accessibility description available, regardless of the value of helpText(), which GTK doesn't use (it seems only the mac uses it). So, in order to fix this I propose the current patch, which only affects the GTK port and that just works on the following simple assumption: if an object has an accessible description available, it should be exposed. Considering that, according ARIA specs, the 'title' attribute is the last resort when calculating the alternative text for an element, I think it's a pretty reasonable assumption to make. 680763 2 mario 2012-07-27 10:10:18 -0700 Putting Chris on CC, as I'd be asking for review over the attached patch. 680792 3 154981 cfleizach 2012-07-27 10:42:04 -0700 Comment on attachment 154981 Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=154981&action=review > Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:77 > + if (!accessibilityDescription().isEmpty()) i might change this to if (!accessibilityDescription().isEmpty() || !title.isEmpty()) as the "accessible" name of an object is split between these two concepts, which are modeled on the Mac API where title is what you get visually on the screen if available, and axDescription is what you get when the description is not really visible (think alt tag on image) 681425 4 155132 mario 2012-07-28 08:24:26 -0700 Created attachment 155132 Patch proposal (In reply to comment #3) > (From update of attachment 154981 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154981&action=review > > > Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:77 > > + if (!accessibilityDescription().isEmpty()) > > i might change this to > > if (!accessibilityDescription().isEmpty() || !title.isEmpty()) > > as the "accessible" name of an object is split between these two concepts, which are modeled on the Mac API > where title is what you get visually on the screen if available, and axDescription is what you get when the > description is not really visible (think alt tag on image) Good point. Actually, there was another issue with that solution (which was causing some tests to fail) and it's that calling to title() / accessibilityDescription() from this function will cause infinite recursion since accessibilityIsIgnored() will be called again at some point after calling those functions. So, and considering that helpText() is something that seems to be used only on the Mac, I made a change directly in AccessibilityRenderObject::accessibilityIsIgnored(), so we decide not to ignore an object if helpText is not empty when on the Mac, and when (title || accessibilityDescription) is not empty in other platforms. This seems to fix the issue indeed, while not causing any regression, at least in the GTK port. 681438 5 155132 cfleizach 2012-07-28 10:12:38 -0700 Comment on attachment 155132 Patch proposal i feel like these checks make sense for all platforms. what we're talking about here are things like <div> or <span> not showing up in the tree when they have some sort of accessible name. I think it makes sense that if something has helpText(), title or axDescription() then it should NOT be ignored at this point. the only things to verify is that helpText(), title and axDescription do not call accessibilityIsIgnored() at any point 681457 6 mario 2012-07-28 12:06:28 -0700 (In reply to comment #5) > (From update of attachment 155132 [details]) > i feel like these checks make sense for all platforms. > what we're talking about here are things like <div> or <span> not showing up in > the tree when they have some sort of accessible name. > I think it makes sense that if something has helpText(), title or axDescription() > then it should NOT be ignored at this point. So, you are proposing to just add the new checks right after the helpText() check, not using #if guards at all, right? > the only things to verify is that helpText(), title and axDescription do not > call accessibilityIsIgnored() at any point I think that's not an issue here. The problem happened when calling from accessibilityPlatformIncludesObject(). 681470 7 cfleizach 2012-07-28 13:40:01 -0700 (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 155132 [details] [details]) > > i feel like these checks make sense for all platforms. > > what we're talking about here are things like <div> or <span> not showing up in > > the tree when they have some sort of accessible name. > > I think it makes sense that if something has helpText(), title or axDescription() > > then it should NOT be ignored at this point. > > So, you are proposing to just add the new checks right after the helpText() check, not using #if guards at all, right? > correct 681554 8 155170 mario 2012-07-29 06:49:19 -0700 Created attachment 155170 Patch proposal Ok. Attaching a new patch now then 681574 9 155170 cfleizach 2012-07-29 11:48:11 -0700 Comment on attachment 155170 Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=155170&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2001 > + if (!helpText().isEmpty() || !title().isEmpty() || !accessibilityDescription().isEmpty()) we should update the comments as well to reflect why we're doing this 681769 10 mario 2012-07-30 01:27:07 -0700 (In reply to comment #9) > (From update of attachment 155170 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155170&action=review > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2001 > > + if (!helpText().isEmpty() || !title().isEmpty() || !accessibilityDescription().isEmpty()) > > we should update the comments as well to reflect why we're doing this Right. I'll do it when landing. Thanks 681770 11 mario 2012-07-30 01:28:44 -0700 Committed r124003: <http://trac.webkit.org/changeset/124003> 154981 2012-07-27 10:10:02 -0700 2012-07-28 08:24:26 -0700 Patch proposal 0001-Fix-for-92477.patch text/plain 3376 mario RnJvbSA4NGQzYjU0MDViNDk0MDcxZGY1NGIxYTgzZWEzODQwOTdjOWQyZDY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBGcmksIDI3IEp1bCAyMDEyIDE5OjA1OjE3ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gRml4IGZvciA5MjQ3NwoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgICAgICAgICAgICAgICAgICB8ICAgIDEgLQog U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB8ICAgMTIgKysrKysrKysrKysrCiAuLi4vV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nl c3NpYmlsaXR5T2JqZWN0QXRrLmNwcCAgIHwgICAgNCArKysrCiA0IGZpbGVzIGNoYW5nZWQsIDI3 IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWMxOTY4Yi4uOWI5YmU1OCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA3LTI3ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8 bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTIzNzY3KTogcGxh dGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvb2JqZWN0LXdpdGgtdGl0bGUuaHRtbCBmYWlsaW5nIG9u IEdUSworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI0 NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1v dmUgcGFzc2luZyB0ZXN0IGZyb20gVGVzdEV4cGVjdGF0aW9ucy4KKworICAgICAgICAqIHBsYXRm b3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTA3LTI3ICBEb21pbmlrIFLDtnR0c2No ZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gUmViYXNl bGluZSBhZnRlciBoYXJmYnV6ei1uZyBjb21wbGV4IGZvbnQgc3VwcG9ydCBpcyBlbmFibGVkCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDViZjlmNjguLjVj MmUzYTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRp b25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC0x MjYxLDcgKzEyNjEsNiBAQCBCVUdXSzkyMTAwIDogYWNjZXNzaWJpbGl0eS9jYW52YXMtYWNjZXNz aWJpbGl0eW5vZGVvYmplY3QuaHRtbCA9IFRFWFQKIC8vIFRoaXMgdGVzdCBkZXBlbmRzIG9uIHN1 YnBpeGVsIGxheW91dC4KIEJVR1dLOTIzNTIgOiBjc3MzL2ZsZXhib3gvZmxleC1yb3VuZGluZy5o dG1sID0gVEVYVAogCi1CVUdXSzkyNDc3IDogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvb2Jq ZWN0LXdpdGgtdGl0bGUuaHRtbCA9IFRFWFQKIAogLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vCiAvLyBFbmQgb2YgVGVzdHMgZmFpbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDY1Yzg0MzYuLmRh NWNiMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNy0yNyAgTWFyaW8gU2Fu Y2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjEyMzc2Nyk6IHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L29iamVjdC13aXRoLXRpdGxlLmh0 bWwgZmFpbGluZyBvbiBHVEsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkyNDc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTWFrZSBzdXJlIHRoYXQgYWxsIG9iamVjdHMgd2l0aCBhbiBhY2Nlc3NpYmxlIGRl c2NyaXB0aW9uIGFyZSBleHBvc2VkIGluIEdUSy4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkv Z3RrL0FjY2Vzc2liaWxpdHlPYmplY3RBdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNz aWJpbGl0eU9iamVjdDo6YWNjZXNzaWJpbGl0eVBsYXRmb3JtSW5jbHVkZXNPYmplY3QpOgorCiAy MDEyLTA3LTI3ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwu Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEyMzg1Nik6IEJyZWFrcyB0aGUgYnVpbGQgd2hl biBkaXNhYmxpbmcgaW5zcGVjdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0QXRrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RBdGsuY3BwCmluZGV4IDEwMTgzNDku LjE0ZTU3MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0Fj Y2Vzc2liaWxpdHlPYmplY3RBdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RBdGsuY3BwCkBAIC03Myw2ICs3MywxMCBAQCBBY2Nl c3NpYmlsaXR5T2JqZWN0SW5jbHVzaW9uIEFjY2Vzc2liaWxpdHlPYmplY3Q6OmFjY2Vzc2liaWxp dHlQbGF0Zm9ybUluY2x1ZGVzTwogICAgIGlmIChyb2xlID09IExpc3RNYXJrZXJSb2xlKQogICAg ICAgICByZXR1cm4gSWdub3JlT2JqZWN0OwogCisgICAgLy8gSW5jbHVkZSB0aGUgb2JqZWN0IGlm IGFuIGFjY2Vzc2libGUgZGVzY3JpcHRpb24gaXMgcHJvdmlkZWQuCisgICAgaWYgKCFhY2Nlc3Np YmlsaXR5RGVzY3JpcHRpb24oKS5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiBJbmNsdWRlT2Jq ZWN0OworCiAgICAgLy8gTmV2ZXIgZXhwb3NlIGFuIHVua25vd24gb2JqZWN0LCBzaW5jZSBBVCdz IHdvbid0IGtub3cgd2hhdCB0bwogICAgIC8vIGRvIHdpdGggdGhlbS4gVGhpcyBpcyB3aGF0IGlz IGRvbmUgb24gdGhlIE1hYyBhcyB3ZWxsLgogICAgIGlmIChyb2xlID09IFVua25vd25Sb2xlKQot LSAKMS43LjEwLjQKCg== 155132 2012-07-28 08:24:26 -0700 2012-07-29 06:49:05 -0700 Patch proposal 0001-Fix-for-92477.patch text/plain 3827 mario RnJvbSBhOTEwNDk1ODhmYTUxNjA3YmVmMTNhZjNhN2E0ZDM3NjRiOTg5M2ZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBGcmksIDI3IEp1bCAyMDEyIDE5OjA1OjE3ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gRml4IGZvciA5MjQ3NwoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDExICsrKysrKysrKysrCiBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyAgICAgICAgICAgICAgICAgfCAgICAxIC0KIFNv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTMgKysrKysrKysrKysrKwogLi4uL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5UmVuZGVyT2JqZWN0LmNwcCAgIHwgICAxMiArKysrKysrKysrLS0KIDQgZmlsZXMgY2hhbmdl ZCwgMzQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWMxOTY4Yi4uYWQ3 NDdmZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA3LTI4ICBNYXJpbyBTYW5jaGV6IFBy YWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTIzNzY3 KTogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvb2JqZWN0LXdpdGgtdGl0bGUuaHRtbCBmYWls aW5nIG9uIEdUSworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTI0NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmUgcGFzc2luZyB0ZXN0IGZyb20gVGVzdEV4cGVjdGF0aW9ucy4KKworICAgICAgICAq IHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTA3LTI3ICBEb21pbmlrIFLD tnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0g UmViYXNlbGluZSBhZnRlciBoYXJmYnV6ei1uZyBjb21wbGV4IGZvbnQgc3VwcG9ydCBpcyBlbmFi bGVkCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9u cyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDViZjlm NjguLjVjMmUzYTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhw ZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25z CkBAIC0xMjYxLDcgKzEyNjEsNiBAQCBCVUdXSzkyMTAwIDogYWNjZXNzaWJpbGl0eS9jYW52YXMt YWNjZXNzaWJpbGl0eW5vZGVvYmplY3QuaHRtbCA9IFRFWFQKIC8vIFRoaXMgdGVzdCBkZXBlbmRz IG9uIHN1YnBpeGVsIGxheW91dC4KIEJVR1dLOTIzNTIgOiBjc3MzL2ZsZXhib3gvZmxleC1yb3Vu ZGluZy5odG1sID0gVEVYVAogCi1CVUdXSzkyNDc3IDogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxp dHkvb2JqZWN0LXdpdGgtdGl0bGUuaHRtbCA9IFRFWFQKIAogLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vCiAvLyBFbmQgb2YgVGVzdHMgZmFpbGluZwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDY1Yzg0 MzYuLjViNWE3OWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNy0yOCAgTWFy aW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVT U0lPTiAocjEyMzc2Nyk6IHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L29iamVjdC13aXRoLXRp dGxlLmh0bWwgZmFpbGluZyBvbiBHVEsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkyNDc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVXNlIGhlbHBUZXh0KCkgdG8gZGVjaWRlIHdoZXRoZXIgYW4gb2JqZWN0 IHNob3VsZCBiZSBpZ25vcmVkIGluIHRoZSBBWAorICAgICAgICB0cmVlIG9ubHkgZm9yIE1hYy4g Q29uc2lkZXIgdGl0bGUgYW5kIGFjY2Vzc2liaWxpdHlEZXNjcmlwdGlvbiBvdGhlcndpc2UuCisK KyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YWNjZXNzaWJpbGl0 eUlzSWdub3JlZCk6CisKIDIwMTItMDctMjcgIFRoaWFnbyBNYXJjb3MgUC4gU2FudG9zICA8dGhp YWdvLnNhbnRvc0BpbnRlbC5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTIzODU2KTogQnJl YWtzIHRoZSBidWlsZCB3aGVuIGRpc2FibGluZyBpbnNwZWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3Bw CmluZGV4IGJhYmViY2EuLmU2ZjQwZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcApAQCAtMTk5Miwx MiArMTk5MiwyMCBAQCBib29sIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmFjY2Vzc2liaWxp dHlJc0lnbm9yZWQoKSBjb25zdAogICAgIAogICAgIGlmIChpc1dlYkFyZWEoKSB8fCBtX3JlbmRl cmVyLT5pc0xpc3RNYXJrZXIoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIAorCisjaWYg UExBVEZPUk0oTUFDKQogICAgIC8vIFVzaW5nIHRoZSBoZWxwIHRleHQgdG8gZGVjaWRlIGFuIGVs ZW1lbnQncyB2aXNpYmlsaXR5IGlzIG5vdCBhcyBkZWZpbml0aXZlCiAgICAgLy8gYXMgcHJldmlv dXMgY2hlY2tzLCBzbyB0aGlzIHNob3VsZCByZW1haW4gYXMgb25lIG9mIHRoZSBsYXN0LgogICAg IGlmICghaGVscFRleHQoKS5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAK KyNlbHNlCisgICAgLy8gSGVscCB0ZXh0IGlzIHVzZWQgb25seSBvbiB0aGUgbWFjLCBzbyB3ZSBu ZWVkIHRvIHBlcmZvcm0gb3RoZXIKKyAgICAvLyBjaGVja3MgZm9yIHRoZSByZXN0IG9mIHRoZSBw bGF0Zm9ybXMsIHRvIG1ha2Ugc3VyZSB3ZSBkb24ndAorICAgIC8vIGlnbm9yZSBvYmplY3RzIHdp dGggYXZhaWxhYmxlIGFjY2Vzc2liaWxpdHkgaW5mb3JtYXRpb24uCisgICAgaWYgKCF0aXRsZSgp LmlzRW1wdHkoKSB8fCAhYWNjZXNzaWJpbGl0eURlc2NyaXB0aW9uKCkuaXNFbXB0eSgpKQorICAg ICAgICByZXR1cm4gZmFsc2U7CisjZW5kaWYKKwogICAgIC8vIEJ5IGRlZmF1bHQsIG9iamVjdHMg c2hvdWxkIGJlIGlnbm9yZWQgc28gdGhhdCB0aGUgQVggaGllcmFyY2h5IGlzIG5vdCAKICAgICAv LyBmaWxsZWQgd2l0aCB1bm5lY2Vzc2FyeSBpdGVtcy4KICAgICByZXR1cm4gdHJ1ZTsKLS0gCjEu Ny4xMC40Cgo= 155170 2012-07-29 06:49:19 -0700 2012-07-29 11:48:10 -0700 Patch proposal bug-92477-20120729154904.patch text/plain 3164 mario U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzOTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWJhYzZiNjgwMjI4MDBj YjMzYWQ1MTQxNzE1NzlhYzY4OWJhZmFhMy4uZmQ2YWRkOWMzNzY2MjVjNWYwYjU2Mzk3ZDIxYmI4 ZDk2ZTgzNTNlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTI5ICBNYXJp byBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNT SU9OIChyMTIzNzY3KTogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvb2JqZWN0LXdpdGgtdGl0 bGUuaHRtbCBmYWlsaW5nIG9uIEdUSworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTI0NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDb25zaWRlciB0aXRsZSBhbmQgYWNjZXNzaWJpbGl0eURlc2NyaXB0aW9u IHRvZ2V0aGVyIHdpdGggaGVscFRleHQgdG8KKyAgICAgICAgZGVjaWRlIHdoZXRoZXIgYW4gb2Jq ZWN0IHNob3VsZCBiZSBleHBvc2VkIGluIHRoZSBhY2Nlc3NpYmlsaXR5IHRyZWUuCisKKyAgICAg ICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YWNjZXNzaWJpbGl0eUlzSWdu b3JlZCk6CisKIDIwMTItMDctMjggIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAog ICAgICAgICBSZW5kZXJCbG9jazo6b2Zmc2V0Rm9yQ29udGVudHMoKSBpcyB3cm9uZyBpbiBmbGlw cGVkIGJsb2NrcyB3cml0aW5nIG1vZGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAppbmRleCBlMDZmOWU4 YWMzNTA2ZDJhZjg1MzEzMGJjZDk2MGU5YzQyM2U3MzZmLi5iNGExZGIyNDQ3OGVmYzM1MWFiYWU5 ZDIwNjJiOWRlMmIwNDNiMmNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKQEAgLTE5OTgsNyArMTk5 OCw3IEBAIGJvb2wgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YWNjZXNzaWJpbGl0eUlzSWdu b3JlZCgpIGNvbnN0CiAgICAgCiAgICAgLy8gVXNpbmcgdGhlIGhlbHAgdGV4dCB0byBkZWNpZGUg YW4gZWxlbWVudCdzIHZpc2liaWxpdHkgaXMgbm90IGFzIGRlZmluaXRpdmUKICAgICAvLyBhcyBw cmV2aW91cyBjaGVja3MsIHNvIHRoaXMgc2hvdWxkIHJlbWFpbiBhcyBvbmUgb2YgdGhlIGxhc3Qu Ci0gICAgaWYgKCFoZWxwVGV4dCgpLmlzRW1wdHkoKSkKKyAgICBpZiAoIWhlbHBUZXh0KCkuaXNF bXB0eSgpIHx8ICF0aXRsZSgpLmlzRW1wdHkoKSB8fCAhYWNjZXNzaWJpbGl0eURlc2NyaXB0aW9u KCkuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgCiAgICAgLy8gQnkgZGVm YXVsdCwgb2JqZWN0cyBzaG91bGQgYmUgaWdub3JlZCBzbyB0aGF0IHRoZSBBWCBoaWVyYXJjaHkg aXMgbm90IApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IDQxNDYxYjQ4MjBjOTgzNzU5MmJmZTQ5MzFlMDk5OGQ2NDQ2ZjA5NjQu LjdhOTYwY2M0YTMwYjc0MzFiMGYxYWE1ODg0YTYxMzlhYjhlNzNhZmYgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNCBAQAorMjAxMi0wNy0yOSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxp YS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjEyMzc2Nyk6IHBsYXRmb3JtL2d0ay9hY2Nl c3NpYmlsaXR5L29iamVjdC13aXRoLXRpdGxlLmh0bWwgZmFpbGluZyBvbiBHVEsKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNDc3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHBhc3NpbmcgdGVz dCBmcm9tIFRlc3RFeHBlY3RhdGlvbnMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4 cGVjdGF0aW9uczoKKwogMjAxMi0wNy0yOSAgTWlrZSBXZXN0ICA8bWt3c3RAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEV4dGVuZCBgYXBwbGljYXRpb24veC13ZWJraXQtdGVzdC1uZXRzY2FwZWAg cGx1Z2lucyB0byBiZXR0ZXIgc3VwcG9ydCBtdWx0aXBsZSBmcmFtZXMuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDViZjlmNjg4NTZlZTkxMzlhNTA4YmI0 ZDUxYjAzZWE2YTNiMzJlNTYuLjVjMmUzYTYyODM0NTMzODlhOTdjYjA0ZWIzNTY1MTE0YjRkYWI2 ZTUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25z CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMjYx LDcgKzEyNjEsNiBAQCBCVUdXSzkyMTAwIDogYWNjZXNzaWJpbGl0eS9jYW52YXMtYWNjZXNzaWJp bGl0eW5vZGVvYmplY3QuaHRtbCA9IFRFWFQKIC8vIFRoaXMgdGVzdCBkZXBlbmRzIG9uIHN1YnBp eGVsIGxheW91dC4KIEJVR1dLOTIzNTIgOiBjc3MzL2ZsZXhib3gvZmxleC1yb3VuZGluZy5odG1s ID0gVEVYVAogCi1CVUdXSzkyNDc3IDogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvb2JqZWN0 LXdpdGgtdGl0bGUuaHRtbCA9IFRFWFQKIAogLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vCiAvLyBFbmQgb2YgVGVzdHMgZmFpbGluZwo=