92476 2012-07-27 02:38:00 -0700 Web Inspector: InspectorPageAgent should ascertain document to be non-null in updateViewMetrics() 2012-07-30 20:26:41 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 90675 0 vivekgalatage vivekgalatage apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 680349 0 vivekgalatage 2012-07-27 02:38:00 -0700 Now that https://bugs.webkit.org/show_bug.cgi?id=90675, goes on creating a blank page, with "about:blank" url, this new page will not be having a document object. When the call to Internals::closeDummyInspectorFrontend() is made, it tries to delete the newly created page. In turn, this calls InspectorController::disconnectFrontend() to inform all the agents to clearFrontend(). In case of InspectorPageAgent::clearFrontend(), calls disable() which in turn calls updateViewMetrics(). Now here the document object is NULL. Hence this should be checking for document pointer. 680355 1 154884 vivekgalatage 2012-07-27 02:40:58 -0700 Created attachment 154884 Patch 680877 2 154884 pfeldman 2012-07-27 11:40:21 -0700 Comment on attachment 154884 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154884&action=review > Source/WebCore/inspector/InspectorPageAgent.cpp:970 > + if (document) Is there a test case for this? 680896 3 154884 webkit.review.bot 2012-07-27 11:55:11 -0700 Comment on attachment 154884 Patch Clearing flags on attachment: 154884 Committed r123901: <http://trac.webkit.org/changeset/123901> 680897 4 webkit.review.bot 2012-07-27 11:55:16 -0700 All reviewed patches have been landed. Closing bug. 154884 2012-07-27 02:40:58 -0700 2012-07-27 11:55:11 -0700 Patch bug-92476-20120727150913.patch text/plain 1605 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzg1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA3LTI3ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEluc3BlY3RvclBhZ2VBZ2VudCBzaG91bGQgYXNjZXJ0YWluIGRvY3VtZW50IHRvIGJlIG5v bi1udWxsIGluIHVwZGF0ZVZpZXdNZXRyaWNzKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNDc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSW5zcGVjdG9yUGFnZUFnZW50IHNob3VsZCBjaGVjayBmb3Ig ZG9jdW1lbnQgb2JqZWN0IGJlaW5nIG51bGwuIEFzIHBhZ2VzIGNyZWF0ZWQgd2l0aCBibGFuayBV UkwgbWlnaHQKKyAgICAgICAgbm90IGhhdmUgdGhlIGRvY3VtZW50IG9iamVjdCwgdGhpcyBjYXVz ZXMgYSBjcmFzaC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgYWRkZWQgbnVsbCBjaGVjay4K KworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SW5zcGVjdG9yUGFnZUFnZW50Ojp1cGRhdGVWaWV3TWV0cmljcyk6CisKIDIwMTIt MDctMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgYSBT ZXR0aW5nIHRvIGV4cG9zZSBxdWFudGl6ZWQsIHJhdGUtbGltaXRlZCBNZW1vcnlJbmZvIHZhbHVl cwpJbmRleDogU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclBhZ2VBZ2VudC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclBhZ2VBZ2Vu dC5jcHAJKHJldmlzaW9uIDEyMzg1MikKKysrIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JQYWdlQWdlbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NjcsNyArOTY3LDggQEAgdm9p ZCBJbnNwZWN0b3JQYWdlQWdlbnQ6OnVwZGF0ZVZpZXdNZXRyaQogICAgIG1fY2xpZW50LT5vdmVy cmlkZURldmljZU1ldHJpY3Mod2lkdGgsIGhlaWdodCwgc3RhdGljX2Nhc3Q8ZmxvYXQ+KGZvbnRT Y2FsZUZhY3RvciksIGZpdFdpbmRvdyk7CiAKICAgICBEb2N1bWVudCogZG9jdW1lbnQgPSBtYWlu RnJhbWUoKS0+ZG9jdW1lbnQoKTsKLSAgICBkb2N1bWVudC0+c3R5bGVSZXNvbHZlckNoYW5nZWQo UmVjYWxjU3R5bGVJbW1lZGlhdGVseSk7CisgICAgaWYgKGRvY3VtZW50KQorICAgICAgICBkb2N1 bWVudC0+c3R5bGVSZXNvbHZlckNoYW5nZWQoUmVjYWxjU3R5bGVJbW1lZGlhdGVseSk7CiAgICAg SW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjptZWRpYVF1ZXJ5UmVzdWx0Q2hhbmdlZChkb2N1bWVu dCk7CiB9CiAK