92474 2012-07-27 02:10:27 -0700 DragController should ascertain dragClient to be non-null 2012-07-30 20:26:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 90675 1 vivekgalatage vivekgalatage ap dbates enrica sam tony webkit.review.bot oldest_to_newest 680325 0 vivekgalatage 2012-07-27 02:10:27 -0700 Page object should ascertain pageClients.dragClient to be non-null 680328 1 154882 vivekgalatage 2012-07-27 02:13:32 -0700 Created attachment 154882 Patch 680335 2 vivekgalatage 2012-07-27 02:23:08 -0700 When enabled(DRAG_SUPPORT), the page object should ascertain pageClients.dragClient to be non-null. Page object goes on creating dragController with the given dragClient. The dragController assumes the dragClient being always available hence all the calls on dragClient are not checking for null value of m_client. So there are two options: 1. If the dragClient is still optional when ENABLE(DRAG_SUPPORT), then we should migrate the creation of dragController from Page::Page() constructor's initialization list inside the constructor body to create the controller only when a non-null dragClient is sent. a-la if (pageClients.dragClient) m_dragController = DragController::create(this, pageClients.dragClient); 2. If this is mandatory when ENABLE(DRAG_SUPPORT), then we can simply put an ASSERT statement in Page::Page(). Please let me know your thoughts on the same. 680987 3 155026 vivekgalatage 2012-07-27 12:45:42 -0700 Created attachment 155026 Patch 680991 4 155026 tony 2012-07-27 12:48:15 -0700 Comment on attachment 155026 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155026&action=review > Source/WebCore/ChangeLog:3 > + Page object should ascertain pageClients.dragClient to be non-null This description is no longer correct. Otherwise, this change seems fine. 680999 5 155029 vivekgalatage 2012-07-27 12:54:52 -0700 Created attachment 155029 Patch 681164 6 155029 webkit.review.bot 2012-07-27 15:38:00 -0700 Comment on attachment 155029 Patch Clearing flags on attachment: 155029 Committed r123927: <http://trac.webkit.org/changeset/123927> 681165 7 webkit.review.bot 2012-07-27 15:38:04 -0700 All reviewed patches have been landed. Closing bug. 154882 2012-07-27 02:13:32 -0700 2012-07-27 12:45:35 -0700 Patch bug-92474-20120727144147.patch text/plain 1461 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzg1MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA3LTI3ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFBhZ2Ugb2JqZWN0 IHNob3VsZCBhc2NlcnRhaW4gcGFnZUNsaWVudHMuZHJhZ0NsaWVudCB0byBiZSBub24tbnVsbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI0NzQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGVuYWJs ZWQoRFJBR19TVVBQT1JUKSwgdGhlIHBhZ2Ugb2JqZWN0IHNob3VsZCBhc2NlcnRhaW4gcGFnZUNs aWVudHMuZHJhZ0NsaWVudCB0byBiZSBub24tbnVsbC4KKyAgICAgICAgUGFnZSBvYmplY3QgZ29l cyBvbiBjcmVhdGluZyBkcmFnQ29udHJvbGxlciB3aXRoIHRoZSBnaXZlbiBkcmFnQ2xpZW50LiBU aGUgZHJhZ0NvbnRyb2xsZXIgbXVzdCBhbHdheXMKKyAgICAgICAgaGF2ZSB0aGUgZHJhZ0NsaWVu dCBvYmplY3QgZXhpc3RpbmcuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBBZGRlZCBhc3NlcnRp b24gdG8gbWFrZSBzdXJlIHBhZ2VDbGllbnRzLmRyYWdDbGllbnQgYWx3YXlzIGV4aXN0cyBpZiBF TkFCTEUoRFJBR19TVVBQT1JUKQorCisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlBhZ2U6OlBhZ2UpOgorCiAyMDEyLTA3LTI3ICBWc2V2b2xvZCBWbGFzb3YgIDx2 c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IE1vdmUgZm9ybWF0 dGluZyBzdXBwb3J0IGZyb20gSmF2YVNjcmlwdFNvdXJjZSB0byBVSVNvdXJjZUNvZGUuCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BhZ2UvUGFnZS5jcHAJKHJldmlzaW9uIDEyMzg1MCkKKysrIFNvdXJjZS9XZWJDb3JlL3Bh Z2UvUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2OSw2ICsxNjksMTAgQEAgUGFnZTo6UGFn ZShQYWdlQ2xpZW50cyYgcGFnZUNsaWVudHMpCiB7CiAgICAgQVNTRVJUKG1fZWRpdG9yQ2xpZW50 KTsKIAorI2lmIEVOQUJMRShEUkFHX1NVUFBPUlQpCisgICAgQVNTRVJUKHBhZ2VDbGllbnRzLmRy YWdDbGllbnQpOworI2VuZGlmCisKICAgICBpZiAoIWFsbFBhZ2VzKSB7CiAgICAgICAgIGFsbFBh Z2VzID0gbmV3IEhhc2hTZXQ8UGFnZSo+OwogICAgICAgICAK 155026 2012-07-27 12:45:42 -0700 2012-07-27 12:54:46 -0700 Patch bug-92474-20120728011505.patch text/plain 1272 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzkwOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA3LTI3ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFBhZ2Ugb2JqZWN0 IHNob3VsZCBhc2NlcnRhaW4gcGFnZUNsaWVudHMuZHJhZ0NsaWVudCB0byBiZSBub24tbnVsbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI0NzQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgRHJhZ0Nv bnRyb2xsZXIgbXVzdCBhbHdheXMgZW5zdXJlIGEgdmFsaWQgZHJhZ0NsaWVudCBvYmplY3QuIEhl bmNlCisgICAgICAgIGFkZGluZyB0aGlzIEFTU0VSVCB0byBhc3N1cmUgdGhhdC4KKworICAgICAg ICBObyBuZXcgdGVzdHMuIEFkZGVkIGFzc2VydGlvbiBmb3IgcGFnZUNsaWVudHMuZHJhZ0NsaWVu dC4KKworICAgICAgICAqIHBhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RHJhZ0NvbnRyb2xsZXI6OkRyYWdDb250cm9sbGVyKToKKwogMjAxMi0wNy0yNyAgTWluIFFp biAgPHFpbm1pbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIGFuIG92ZXJsYXkgcGxheSBi dXR0b24gdG8gbWVkaWEgY29udHJvbHMgb24gYW5kcm9pZApJbmRleDogU291cmNlL1dlYkNvcmUv cGFnZS9EcmFnQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFn ZS9EcmFnQ29udHJvbGxlci5jcHAJKHJldmlzaW9uIDEyMzg3NikKKysrIFNvdXJjZS9XZWJDb3Jl L3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDEsNiArMTAxLDcg QEAgRHJhZ0NvbnRyb2xsZXI6OkRyYWdDb250cm9sbGVyKFBhZ2UqIHBhZwogICAgICwgbV9pc0hh bmRsaW5nRHJhZyhmYWxzZSkKICAgICAsIG1fc291cmNlRHJhZ09wZXJhdGlvbihEcmFnT3BlcmF0 aW9uTm9uZSkKIHsKKyAgICBBU1NFUlQobV9jbGllbnQpOwogfQogCiBEcmFnQ29udHJvbGxlcjo6 fkRyYWdDb250cm9sbGVyKCkK 155029 2012-07-27 12:54:52 -0700 2012-07-27 15:38:00 -0700 Patch bug-92474-20120728012415.patch text/plain 1268 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzkxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA3LTI3ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIERyYWdDb250cm9s bGVyIHNob3VsZCBhc2NlcnRhaW4gZHJhZ0NsaWVudCB0byBiZSBub24tbnVsbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI0NzQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgRHJhZ0NvbnRyb2xsZXIg bXVzdCBhbHdheXMgZW5zdXJlIGEgdmFsaWQgZHJhZ0NsaWVudCBvYmplY3QuIEhlbmNlCisgICAg ICAgIGFkZGluZyB0aGUgQVNTRVJUIHRvIGFzc3VyZSB0aGF0LgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gQWRkZWQgYXNzZXJ0aW9uIGZvciBQYWdlQ2xpZW50LmRyYWdDbGllbnQuCisKKyAgICAg ICAgKiBwYWdlL0RyYWdDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRyYWdDb250 cm9sbGVyOjpEcmFnQ29udHJvbGxlcik6CisKIDIwMTItMDctMjcgIFRvbnkgQ2hhbmcgIDx0b255 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBmbGV4LXdyYXA6IHdyYXAgbm90IHdyYXBwaW5nIGZv ciAlIHNpemVkIGl0ZW1zIGluIGNvbHVtbiBmbG93CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdl L0RyYWdDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0Ry YWdDb250cm9sbGVyLmNwcAkocmV2aXNpb24gMTIzODc2KQorKysgU291cmNlL1dlYkNvcmUvcGFn ZS9EcmFnQ29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMSw2ICsxMDEsNyBAQCBE cmFnQ29udHJvbGxlcjo6RHJhZ0NvbnRyb2xsZXIoUGFnZSogcGFnCiAgICAgLCBtX2lzSGFuZGxp bmdEcmFnKGZhbHNlKQogICAgICwgbV9zb3VyY2VEcmFnT3BlcmF0aW9uKERyYWdPcGVyYXRpb25O b25lKQogeworICAgIEFTU0VSVChtX2NsaWVudCk7CiB9CiAKIERyYWdDb250cm9sbGVyOjp+RHJh Z0NvbnRyb2xsZXIoKQo=