92469 2012-07-27 00:42:43 -0700 [chromium] CCLayerTreeHost placeholder scissor should be deviceViewportSize instead of viewportSize 2012-07-27 15:04:36 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shawnsingh shawnsingh cc-bugs danakj enne jamesr kbr webkit.review.bot oldest_to_newest 680209 0 shawnsingh 2012-07-27 00:42:43 -0700 http://code.google.com/p/chromium/issues/detail?id=139005 After tracing the problem from missing tiles --> skipped paints --> bad occlusion --> bad scissor rect, it finally showed up that we are accidentally setting the placeholder scissorRect to the viewportSize. As I understand, the space of the scissorRect is expected to be in the pixel accurate content space of the targetSurface; and for this main-thread placeholder default scissor, that means we should have been using deviceViewportSize instead of viewportSize. It does indeed fix the flickering issue that showed up suddenly on canary. Dear Reviewers: if you wish to land it right away, please go ahead, and feel free to create another bug on me to add a unit test. If you prefer to wait and land this after unit test is created, I'll work on it right away to get this landed soon. 680218 1 154868 shawnsingh 2012-07-27 00:53:30 -0700 Created attachment 154868 Patch 680686 2 154868 danakj 2012-07-27 08:32:33 -0700 Comment on attachment 154868 Patch good catch. lgtm 680690 3 enne 2012-07-27 08:33:57 -0700 The code change looks right to me, but if you can get a test in today, let's land them together. 681069 4 154868 enne 2012-07-27 14:05:54 -0700 Comment on attachment 154868 Patch R=me. After some conversation with Shawn, I'm not sure that there's a really good way to test this without some serious refactoring of how CCLayerTreeHost works. This seems clearly like the right fix, so let's just land it. 681129 5 154868 webkit.review.bot 2012-07-27 15:04:32 -0700 Comment on attachment 154868 Patch Clearing flags on attachment: 154868 Committed r123921: <http://trac.webkit.org/changeset/123921> 681130 6 webkit.review.bot 2012-07-27 15:04:36 -0700 All reviewed patches have been landed. Closing bug. 154868 2012-07-27 00:53:30 -0700 2012-07-27 15:04:31 -0700 Patch bug-92469-20120727005319.patch text/plain 1919 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzdmZWE4YzYwMjVhN2Fl OTY0ZmNjODY0OWEwZTE2ODllMDI2ZmZhNC4uMTY3MWQwODNkYTA5MDViNGJiMTM2ZjI4ZGE3Yzkx Y2ZhYmI1YjJkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTI3ICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g Q0NMYXllclRyZWVIb3N0IHBsYWNlaG9sZGVyIHNjaXNzb3Igc2hvdWxkIGJlIGRldmljZVZpZXdw b3J0U2l6ZSBpbnN0ZWFkIG9mIHZpZXdwb3J0U2l6ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI0NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZSB3ZXJlIGFjY2lkZW50YWxseSB1c2luZyB2aWV3cG9y dFNpemUgaW5zdGVhZCBvZgorICAgICAgICBkZXZpY2VWaWV3cG9ydFNpemUgaW4gYSBwYXJ0aWN1 bGFyIHBsYWNlIGluIGNvZGUuIFJlY2VudAorICAgICAgICByZWZhY3RvcmluZyB0byB1c2UgdGln aHRlciBzY2lzc29yIHJlY3RzIGV4cG9zZWQgdGhpcyBwcm9ibGVtLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNDTGF5ZXJUcmVlSG9zdDo6dXBkYXRlTGF5ZXJzKToKKwogMjAxMi0wNy0yNiAg U2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyMzgyMC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3Qu Y3BwCmluZGV4IGU2MzhmZmEzYmFhOWYxZDBhYjQ1MDQ2YjVkZGIzOTMzOTkxODNlOTMuLmFiMDMx YjI5YzBhYzZmYjIyM2RmOTUzYTZjMzZmN2JlZGVmOGRmN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXll clRyZWVIb3N0LmNwcApAQCAtNDczLDcgKzQ3Myw3IEBAIHZvaWQgQ0NMYXllclRyZWVIb3N0Ojp1 cGRhdGVMYXllcnMoTGF5ZXJDaHJvbWl1bSogcm9vdExheWVyLCBDQ1RleHR1cmVVcGRhdGVyJiB1 CiAgICAgICAgIFRSQUNFX0VWRU5UMCgiY2MiLCAiQ0NMYXllclRyZWVIb3N0Ojp1cGRhdGVMYXll cnM6OmNhbGNEcmF3RXRjIik7CiAgICAgICAgIENDTGF5ZXJUcmVlSG9zdENvbW1vbjo6Y2FsY3Vs YXRlRHJhd1RyYW5zZm9ybXMocm9vdExheWVyLCBkZXZpY2VWaWV3cG9ydFNpemUoKSwgbV9kZXZp Y2VTY2FsZUZhY3RvciwgbGF5ZXJSZW5kZXJlckNhcGFiaWxpdGllcygpLm1heFRleHR1cmVTaXpl LCB1cGRhdGVMaXN0KTsKIAotICAgICAgICBGbG9hdFJlY3Qgcm9vdFNjaXNzb3JSZWN0KEZsb2F0 UG9pbnQoMCwgMCksIHZpZXdwb3J0U2l6ZSgpKTsKKyAgICAgICAgRmxvYXRSZWN0IHJvb3RTY2lz c29yUmVjdChGbG9hdFBvaW50KDAsIDApLCBkZXZpY2VWaWV3cG9ydFNpemUoKSk7CiAgICAgICAg IENDTGF5ZXJUcmVlSG9zdENvbW1vbjo6Y2FsY3VsYXRlVmlzaWJsZUFuZFNjaXNzb3JSZWN0cyh1 cGRhdGVMaXN0LCByb290U2Npc3NvclJlY3QpOwogICAgIH0KIAo=