92468 2012-07-27 00:25:49 -0700 [EFL][WK2] Add unit tests for Ewk_View form client 2012-07-27 02:26:53 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 1 cdumez cdumez gustavo gyuyoung.kim kenneth ryuan.choi tmpsantos tonikitoo webkit.review.bot oldest_to_newest 680193 0 cdumez 2012-07-27 00:25:49 -0700 We need unit tests for the form client functionality in Ewk_View. We basically need to make sure a "form,submission,request" signal is emitted on the view when a form is submitted and make sure the text fields values are present in the Ewk_Form_Submission_Request. 680200 1 154863 cdumez 2012-07-27 00:30:04 -0700 Created attachment 154863 Patch 680338 2 154863 webkit.review.bot 2012-07-27 02:26:48 -0700 Comment on attachment 154863 Patch Clearing flags on attachment: 154863 Committed r123853: <http://trac.webkit.org/changeset/123853> 680339 3 webkit.review.bot 2012-07-27 02:26:53 -0700 All reviewed patches have been landed. Closing bug. 154863 2012-07-27 00:30:04 -0700 2012-07-27 02:26:47 -0700 Patch 92468_form_client_utests.patch text/plain 3387 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1NjlkZDc1Li5mNmNiZWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDctMjcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEFkZCB1bml0IHRlc3RzIGZvciBFd2tfVmlldyBm b3JtIGNsaWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTI0NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgdW5pdCB0ZXN0IGZvciBmb3JtIGNsaWVudCBmdW5jdGlvbmFsaXR5IGluCisgICAgICAg IEV3a19WaWV3LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2sy X3ZpZXcuY3BwOgorICAgICAgICAob25Gb3JtQWJvdXRUb0JlU3VibWl0dGVkKToKKyAgICAgICAg KFRFU1RfRik6CisKIDIwMTItMDctMjYgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZCBRdCBidWlsZGZpeCBhZnRlciByMTIzNzg2LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3Zp ZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2sy X3ZpZXcuY3BwCmluZGV4IDU1Mjk2NjUuLjFkNmE3ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAKQEAg LTYwLDMgKzYwLDU0IEBAIFRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfdmlld19zZXR0aW5n X2VuY29kaW5nX2N1c3RvbSkKICAgICBBU1NFUlRfVFJVRShld2tfdmlld19zZXR0aW5nX2VuY29k aW5nX2N1c3RvbV9zZXQod2ViVmlldygpLCAwKSk7CiAgICAgQVNTRVJUX0ZBTFNFKGV3a192aWV3 X3NldHRpbmdfZW5jb2RpbmdfY3VzdG9tX2dldCh3ZWJWaWV3KCkpKTsKIH0KKworc3RhdGljIHZv aWQgb25Gb3JtQWJvdXRUb0JlU3VibWl0dGVkKHZvaWQqIHVzZXJEYXRhLCBFdmFzX09iamVjdCos IHZvaWQqIGV2ZW50SW5mbykKK3sKKyAgICBFd2tfRm9ybV9TdWJtaXNzaW9uX1JlcXVlc3QqIHJl cXVlc3QgPSBzdGF0aWNfY2FzdDxFd2tfRm9ybV9TdWJtaXNzaW9uX1JlcXVlc3QqPihldmVudElu Zm8pOworICAgIGJvb2wqIGhhbmRsZWQgPSBzdGF0aWNfY2FzdDxib29sKj4odXNlckRhdGEpOwor CisgICAgQVNTRVJUX1RSVUUocmVxdWVzdCk7CisKKyAgICBFaW5hX0xpc3QqIGZpZWxkTmFtZXMg PSBld2tfZm9ybV9zdWJtaXNzaW9uX3JlcXVlc3RfZmllbGRfbmFtZXNfZ2V0KHJlcXVlc3QpOwor ICAgIEFTU0VSVF9UUlVFKGZpZWxkTmFtZXMpOworICAgIEFTU0VSVF9FUShlaW5hX2xpc3RfY291 bnQoZmllbGROYW1lcyksIDMpOworICAgIHZvaWQqIGRhdGE7CisgICAgRUlOQV9MSVNUX0ZSRUUo ZmllbGROYW1lcywgZGF0YSkKKyAgICAgICAgZWluYV9zdHJpbmdzaGFyZV9kZWwoc3RhdGljX2Nh c3Q8Y2hhcio+KGRhdGEpKTsKKworICAgIGNvbnN0IGNoYXIqIHZhbHVlMSA9IGV3a19mb3JtX3N1 Ym1pc3Npb25fcmVxdWVzdF9maWVsZF92YWx1ZV9nZXQocmVxdWVzdCwgInRleHQxIik7CisgICAg QVNTRVJUX1NUUkVRKHZhbHVlMSwgInZhbHVlMSIpOworICAgIGVpbmFfc3RyaW5nc2hhcmVfZGVs KHZhbHVlMSk7CisgICAgY29uc3QgY2hhciogdmFsdWUyID0gZXdrX2Zvcm1fc3VibWlzc2lvbl9y ZXF1ZXN0X2ZpZWxkX3ZhbHVlX2dldChyZXF1ZXN0LCAidGV4dDIiKTsKKyAgICBBU1NFUlRfU1RS RVEodmFsdWUyLCAidmFsdWUyIik7CisgICAgZWluYV9zdHJpbmdzaGFyZV9kZWwodmFsdWUyKTsK KyAgICBjb25zdCBjaGFyKiBwYXNzd29yZCA9IGV3a19mb3JtX3N1Ym1pc3Npb25fcmVxdWVzdF9m aWVsZF92YWx1ZV9nZXQocmVxdWVzdCwgInBhc3N3b3JkIik7CisgICAgQVNTRVJUX1NUUkVRKHBh c3N3b3JkLCAic2VjcmV0Iik7CisgICAgZWluYV9zdHJpbmdzaGFyZV9kZWwocGFzc3dvcmQpOwor CisgICAgKmhhbmRsZWQgPSB0cnVlOworfQorCitURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdr X3ZpZXdfZm9ybV9zdWJtaXNzaW9uX3JlcXVlc3QpCit7CisgICAgY29uc3QgY2hhciogZm9ybUhU TUwgPQorICAgICAgICAiPGh0bWw+PGhlYWQ+PHNjcmlwdCB0eXBlPSd0ZXh0L2phdmFzY3JpcHQn PmZ1bmN0aW9uIHN1Ym1pdEZvcm0oKSB7IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdteWZvcm0n KS5zdWJtaXQoKTsgfTwvc2NyaXB0PjwvaGVhZD4iCisgICAgICAgICI8Ym9keSBvbmxvYWQ9J3N1 Ym1pdEZvcm0oKSc+IgorICAgICAgICAiIDxmb3JtIGlkPSdteWZvcm0nIGFjdGlvbj0nIyc+Igor ICAgICAgICAiICA8aW5wdXQgdHlwZT0ndGV4dCcgbmFtZT0ndGV4dDEnIHZhbHVlPSd2YWx1ZTEn PiIKKyAgICAgICAgIiAgPGlucHV0IHR5cGU9J3RleHQnIG5hbWU9J3RleHQyJyB2YWx1ZT0ndmFs dWUyJz4iCisgICAgICAgICIgIDxpbnB1dCB0eXBlPSdwYXNzd29yZCcgbmFtZT0ncGFzc3dvcmQn IHZhbHVlPSdzZWNyZXQnPiIKKyAgICAgICAgIiAgPHRleHRhcmVhIGNvbHM9JzUnIHJvd3M9JzUn IG5hbWU9J3RleHRhcmVhJz5UZXh0PC90ZXh0YXJlYT4iCisgICAgICAgICIgIDxpbnB1dCB0eXBl PSdoaWRkZW4nIG5hbWU9J2hpZGRlbjEnIHZhbHVlPSdoaWRkZW4xJz4iCisgICAgICAgICIgIDxp bnB1dCB0eXBlPSdzdWJtaXQnIHZhbHVlPSdTdWJtaXQnPiIKKyAgICAgICAgIiA8L2Zvcm0+Igor ICAgICAgICAiPC9ib2R5PjwvaHRtbD4iOworCisgICAgZXdrX3ZpZXdfaHRtbF9zdHJpbmdfbG9h ZCh3ZWJWaWV3KCksIGZvcm1IVE1MLCAiZmlsZTovLy8iLCAwKTsKKyAgICBib29sIGhhbmRsZWQg PSBmYWxzZTsKKyAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQod2ViVmlldygpLCAi Zm9ybSxzdWJtaXNzaW9uLHJlcXVlc3QiLCBvbkZvcm1BYm91dFRvQmVTdWJtaXR0ZWQsICZoYW5k bGVkKTsKKyAgICB3aGlsZSAoIWhhbmRsZWQpCisgICAgICAgIGVjb3JlX21haW5fbG9vcF9pdGVy YXRlKCk7CisgICAgQVNTRVJUX1RSVUUoaGFuZGxlZCk7CisgICAgZXZhc19vYmplY3Rfc21hcnRf Y2FsbGJhY2tfZGVsKHdlYlZpZXcoKSwgImZvcm0sc3VibWlzc2lvbixyZXF1ZXN0Iiwgb25Gb3Jt QWJvdXRUb0JlU3VibWl0dGVkKTsKK30K