92461 2012-07-26 22:58:13 -0700 Fix null pointer dereference when CSSParser::sinkFloatingValueList() returns null and is passed to storeVariableDeclaration(). 2012-08-05 18:23:20 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson cmarcelo eric kling macpherson menard webkit.review.bot oldest_to_newest 680140 0 macpherson 2012-07-26 22:58:13 -0700 Fix null pointer dereference when CSSParser::sinkFloatingValueList() returns null and is passed to storeVariableDeclaration(). 680142 1 154849 macpherson 2012-07-26 23:01:32 -0700 Created attachment 154849 Patch 683665 2 macpherson 2012-07-31 17:15:43 -0700 Ping. Could someone please review? 686282 3 154849 eric 2012-08-03 00:06:15 -0700 Comment on attachment 154849 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154849&action=review > Source/WebCore/css/CSSParser.cpp:3019 > + if (!value) > + return; A comment here to explain the "why" might be helpful. 686286 4 154849 eric 2012-08-03 00:08:00 -0700 Comment on attachment 154849 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154849&action=review >> Source/WebCore/css/CSSParser.cpp:3019 >> + return; > > A comment here to explain the "why" might be helpful. Something like: // When CSSGrammar.y encounters an invalid/un-parseable declaration it passes null for the CSSParserValueList, just bail. 686288 5 eric 2012-08-03 00:08:55 -0700 You don't have to make the comment, but if I were writing the code, I'd be tempted to explain the "why" as null checks are often mysterious as to their necessity or not. This one you're claiming to be necessary based on how BISON behaves. 687670 6 156573 macpherson 2012-08-05 16:54:22 -0700 Created attachment 156573 Patch for landing 687694 7 156573 webkit.review.bot 2012-08-05 18:22:57 -0700 Comment on attachment 156573 Patch for landing Clearing flags on attachment: 156573 Committed r124723: <http://trac.webkit.org/changeset/124723> 687695 8 webkit.review.bot 2012-08-05 18:23:20 -0700 All reviewed patches have been landed. Closing bug. 154849 2012-07-26 23:01:32 -0700 2012-08-05 16:54:15 -0700 Patch bug-92461-20120727160119.patch text/plain 3507 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNkOWE1NGM3MDZhNTMy OTk0YzQyZGY0NTk0MGJjNTAyMWFmMDZkNy4uM2JmNjFhOWNkNTRkZGE2MDA2OWE1M2MzY2U0Nzg2 MmYyYzViNTAzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTI2ICBMdWtl IE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRml4IG51 bGwgcG9pbnRlciBkZXJlZmVyZW5jZSB3aGVuIENTU1BhcnNlcjo6c2lua0Zsb2F0aW5nVmFsdWVM aXN0KCkgcmV0dXJucyBudWxsIGFuZCBpcyBwYXNzZWQgdG8gc3RvcmVWYXJpYWJsZURlY2xhcmF0 aW9uKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MjQ2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElu dmFsaWQgdmFyaWFibGUgbGlzdHMgY291bGQgY2F1c2UgQ1NTR3JhbW1hci55IHRvIHBhc3MgbnVs bCBhcyB2YWx1ZSB0byBzdG9yZVZhcmlhYmxlRGVjbGFyYXRpb24sIHNvIHdlIG5vdyBjaGVjayBm b3IgbnVsbC4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy92YXJpYWJsZXMvaW52YWxpZC12YWx1 ZS1saXN0LWNyYXNoLmh0bWwKKworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpzdG9yZVZhcmlhYmxlRGVjbGFyYXRpb24pOgorCiAyMDEy LTA3LTI2ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgQmxvY2tz IHdpdGggcmV2ZXJzZSBjb2x1bW4gcHJvZ3Jlc3Npb24gZG9u4oCZdCBoYXZlIGxheW91dCBvdmVy ZmxvdyBmb3Igb3ZlcmZsb3dpbmcgY29sdW1ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRl eCBjM2ZmMmFiNTdhM2NjZDFjZWUxMGU4YzJlOGZjYWVmYTJmZDhjZTgxLi40NTI4MGE4YjA0YmQ3 NTc1OGVhYjMzNDdkZmQ3NjI1Yzg3NzVjODk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApA QCAtMzAxNSw2ICszMDE1LDkgQEAgYm9vbCBDU1NQYXJzZXI6OmNzc1ZhcmlhYmxlc0VuYWJsZWQo KSBjb25zdAogCiB2b2lkIENTU1BhcnNlcjo6c3RvcmVWYXJpYWJsZURlY2xhcmF0aW9uKGNvbnN0 IENTU1BhcnNlclN0cmluZyYgbmFtZSwgUGFzc093blB0cjxDU1NQYXJzZXJWYWx1ZUxpc3Q+IHZh bHVlLCBib29sIGltcG9ydGFudCkKIHsKKyAgICBpZiAoIXZhbHVlKQorICAgICAgICByZXR1cm47 CisgICAgCiAgICAgQVNTRVJUKG5hbWUubGVuZ3RoID4gMTIpOwogICAgIEF0b21pY1N0cmluZyB2 YXJpYWJsZU5hbWUgPSBTdHJpbmcobmFtZS5jaGFyYWN0ZXJzICsgMTIsIG5hbWUubGVuZ3RoIC0g MTIpOwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggMDM2MzYzNzk5OTg0NGE5ODIwMWRiOWY3MDU2OGUxZjBkYjE0MGJmMy4u NjAxMWQ0MDM4MmUwZmRhNjI1Mjg2MWJjZTcyN2FlYmE0NzUxMDkzOCAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEyLTA3LTI2ICBMdWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgRml4IG51bGwgcG9pbnRlciBkZXJlZmVyZW5jZSB3aGVuIENTU1Bh cnNlcjo6c2lua0Zsb2F0aW5nVmFsdWVMaXN0KCkgcmV0dXJucyBudWxsIGFuZCBpcyBwYXNzZWQg dG8gc3RvcmVWYXJpYWJsZURlY2xhcmF0aW9uKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjQ2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRlc3QgY2FzZSB0aGF0IGNhdXNlcyBDU1NQYXJzZXI6OnN0 b3JlVmFyaWFibGVEZWNsYXJhdGlvbiB0byBiZSBwYXNzZWQgYSBudWxsIHZhbHVlLgorCisgICAg ICAgICogZmFzdC9jc3MvdmFyaWFibGVzL2ludmFsaWQtdmFsdWUtbGlzdC1jcmFzaC1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL3ZhcmlhYmxlcy9pbnZhbGlkLXZhbHVl LWxpc3QtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTItMDctMjYgIERhbiBCZXJuc3RlaW4gIDxt aXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBCbG9ja3Mgd2l0aCByZXZlcnNlIGNvbHVtbiBwcm9n cmVzc2lvbiBkb27igJl0IGhhdmUgbGF5b3V0IG92ZXJmbG93IGZvciBvdmVyZmxvd2luZyBjb2x1 bW5zCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMvaW52YWxpZC12 YWx1ZS1saXN0LWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3Zhcmlh Ymxlcy9pbnZhbGlkLXZhbHVlLWxpc3QtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmVm MGI2ZjFjNzZjZTBmODFmZjJkMTNmYTJlNzc5NGViZDM4YTAwNWUKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMvaW52YWxpZC12YWx1ZS1saXN0LWNyYXNo LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitUaGlzIHRlc3QgaXMgc3VjY2Vzc2Z1bCBpZiBp dCBkb2VzIG5vdCBjcmFzaC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3Zhcmlh Ymxlcy9pbnZhbGlkLXZhbHVlLWxpc3QtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz L3ZhcmlhYmxlcy9pbnZhbGlkLXZhbHVlLWxpc3QtY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mMjU4 ZGEzMDhiYWU1MGViZWU2Yjg0MTdmNjI2YTAwODRiMjg0ODhiCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9jc3MvdmFyaWFibGVzL2ludmFsaWQtdmFsdWUtbGlzdC1jcmFzaC5o dG1sCkBAIC0wLDAgKzEsMTEgQEAKKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisg ICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CitpbnRlcm5hbHMuc2V0dGluZ3Muc2V0Q1NTVmFy aWFibGVzRW5hYmxlZCh0cnVlKTsKKzwvc2NyaXB0PgorPHN0eWxlPgorZGl2IHsKKy13ZWJraXQt dmFyLWE6IC13ZWJraXQtdmFyKGIpICYjMDsKK30KKzwvc3R5bGU+CitUaGlzIHRlc3QgaXMgc3Vj Y2Vzc2Z1bCBpZiBpdCBkb2VzIG5vdCBjcmFzaC4K 156573 2012-08-05 16:54:22 -0700 2012-08-05 18:22:57 -0700 Patch for landing bug-92461-20120806095403.patch text/plain 3562 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzViMWVlMzFkZmVjMmVi OWNmN2U0ODEyZWUyOTdjMDBkNGVjMzhhNy4uN2RhNGUxYTY0Mzk1MDIzNzQ3MzQyMzFhODQ1Y2U2 YzA0MjNlN2U1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTI2ICBMdWtl IE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRml4IG51 bGwgcG9pbnRlciBkZXJlZmVyZW5jZSB3aGVuIENTU1BhcnNlcjo6c2lua0Zsb2F0aW5nVmFsdWVM aXN0KCkgcmV0dXJucyBudWxsIGFuZCBpcyBwYXNzZWQgdG8gc3RvcmVWYXJpYWJsZURlY2xhcmF0 aW9uKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MjQ2MQorCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgorCisgICAgICAgIEludmFs aWQgdmFyaWFibGUgbGlzdHMgY291bGQgY2F1c2UgQ1NTR3JhbW1hci55IHRvIHBhc3MgbnVsbCBh cyB2YWx1ZSB0byBzdG9yZVZhcmlhYmxlRGVjbGFyYXRpb24sIHNvIHdlIG5vdyBjaGVjayBmb3Ig bnVsbC4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy92YXJpYWJsZXMvaW52YWxpZC12YWx1ZS1s aXN0LWNyYXNoLmh0bWwKKworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q1NTUGFyc2VyOjpzdG9yZVZhcmlhYmxlRGVjbGFyYXRpb24pOgorCiAyMDEyLTA4 LTAzICBTZXJnaW8gQ2FybG9zIE1vcmFsZXMgQW5nZWxlcyAgPGNhcmxvc2NoaWxhem9AZ21haWwu Y29tPgogCiAgICAgICAgIERlbGV0ZSB0ZXh0IGZyb20gcGFzc3dvcmQgZG9lcyBub3RoaW5nLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCAxYmI1YTgyMjU4MDRkOGFhYTNjNDhhYTIzMTg2 NDk3YTc5MmI1MGM4Li44ZDI4ODgzY2VmOTkzYTNmNzhhMGQyZjg5MTdkM2FhYTFmZjc0MmE1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApAQCAtMzAyNSw2ICszMDI1LDEwIEBAIGJvb2wgQ1NT UGFyc2VyOjpjc3NWYXJpYWJsZXNFbmFibGVkKCkgY29uc3QKIAogdm9pZCBDU1NQYXJzZXI6OnN0 b3JlVmFyaWFibGVEZWNsYXJhdGlvbihjb25zdCBDU1NQYXJzZXJTdHJpbmcmIG5hbWUsIFBhc3NP d25QdHI8Q1NTUGFyc2VyVmFsdWVMaXN0PiB2YWx1ZSwgYm9vbCBpbXBvcnRhbnQpCiB7CisgICAg Ly8gV2hlbiBDU1NHcmFtbWFyLnkgZW5jb3VudGVycyBhbiBpbnZhbGlkIGRlY2xhcmF0aW9uIGl0 IHBhc3NlcyBudWxsIGZvciB0aGUgQ1NTUGFyc2VyVmFsdWVMaXN0LCBqdXN0IGJhaWwuCisgICAg aWYgKCF2YWx1ZSkKKyAgICAgICAgcmV0dXJuOworICAgIAogICAgIEFTU0VSVChuYW1lLmxlbmd0 aCA+IDEyKTsKICAgICBBdG9taWNTdHJpbmcgdmFyaWFibGVOYW1lID0gU3RyaW5nKG5hbWUuY2hh cmFjdGVycyArIDEyLCBuYW1lLmxlbmd0aCAtIDEyKTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDI5ZmQ0NTEwOTAwMGJj Y2Y2MTUzZDM2YTc1ODA3ZWUwNTYxMzdjMzQuLjVmZjlhNGUxNzdhNTA3M2RkMGViZWYxNGYwNmI3 YmNiNGFkYTUyNzIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNy0yNiAgTHVrZSBNYWNw aGVyc29uICAgPG1hY3BoZXJzb25AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBudWxsIHBv aW50ZXIgZGVyZWZlcmVuY2Ugd2hlbiBDU1NQYXJzZXI6OnNpbmtGbG9hdGluZ1ZhbHVlTGlzdCgp IHJldHVybnMgbnVsbCBhbmQgaXMgcGFzc2VkIHRvIHN0b3JlVmFyaWFibGVEZWNsYXJhdGlvbigp LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI0NjEK KworICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KKworICAgICAgICBUZXN0IGNhc2Ug dGhhdCBjYXVzZXMgQ1NTUGFyc2VyOjpzdG9yZVZhcmlhYmxlRGVjbGFyYXRpb24gdG8gYmUgcGFz c2VkIGEgbnVsbCB2YWx1ZS4KKworICAgICAgICAqIGZhc3QvY3NzL3ZhcmlhYmxlcy9pbnZhbGlk LXZhbHVlLWxpc3QtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nz cy92YXJpYWJsZXMvaW52YWxpZC12YWx1ZS1saXN0LWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDEy LTA4LTAzICBTZXJnaW8gQ2FybG9zIE1vcmFsZXMgQW5nZWxlcyAgPGNhcmxvc2NoaWxhem9AZ21h aWwuY29tPgogCiAgICAgICAgIERlbGV0ZSB0ZXh0IGZyb20gcGFzc3dvcmQgZG9lcyBub3RoaW5n LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdmFyaWFibGVzL2ludmFsaWQtdmFs dWUtbGlzdC1jcmFzaC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJs ZXMvaW52YWxpZC12YWx1ZS1saXN0LWNyYXNoLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lZjBi NmYxYzc2Y2UwZjgxZmYyZDEzZmEyZTc3OTRlYmQzOGEwMDVlCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9jc3MvdmFyaWFibGVzL2ludmFsaWQtdmFsdWUtbGlzdC1jcmFzaC1l eHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorVGhpcyB0ZXN0IGlzIHN1Y2Nlc3NmdWwgaWYgaXQg ZG9lcyBub3QgY3Jhc2guCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJs ZXMvaW52YWxpZC12YWx1ZS1saXN0LWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92 YXJpYWJsZXMvaW52YWxpZC12YWx1ZS1saXN0LWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjI1OGRh MzA4YmFlNTBlYmVlNmI4NDE3ZjYyNmEwMDg0YjI4NDg4YgotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvY3NzL3ZhcmlhYmxlcy9pbnZhbGlkLXZhbHVlLWxpc3QtY3Jhc2guaHRt bApAQCAtMCwwICsxLDExIEBACis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAg IHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworaW50ZXJuYWxzLnNldHRpbmdzLnNldENTU1Zhcmlh Ymxlc0VuYWJsZWQodHJ1ZSk7Cis8L3NjcmlwdD4KKzxzdHlsZT4KK2RpdiB7Cistd2Via2l0LXZh ci1hOiAtd2Via2l0LXZhcihiKSAmIzA7Cit9Cis8L3N0eWxlPgorVGhpcyB0ZXN0IGlzIHN1Y2Nl c3NmdWwgaWYgaXQgZG9lcyBub3QgY3Jhc2guCg==