92458 2012-07-26 22:28:27 -0700 Page object should ascertain EditorClient to be non-null 2012-07-30 20:26:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 90675 1 vivekgalatage vivekgalatage rniwa webkit.review.bot oldest_to_newest 680125 0 vivekgalatage 2012-07-26 22:28:27 -0700 Adding NULL checks for editor client within Page object 680126 1 154842 vivekgalatage 2012-07-26 22:30:11 -0700 Created attachment 154842 Patch 680132 2 154842 rniwa 2012-07-26 22:41:45 -0700 Comment on attachment 154842 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154842&action=review > Source/WebCore/ChangeLog:10 > + No new tests as no change in functionality. Just addition of check to avoid crash. That's not true. If this can never cause a crash, then we don't have to do null check. If WebKit were to crash without these null checks, then there is a behavior change. Please try to come up with a test. It's okay if you could not come up with a test if it's too hard to do so but please don't say that there is no behavior change in WebKit, when there is one. 680145 3 vivekgalatage 2012-07-26 23:06:35 -0700 Changing the title of the bug as per the IRC discussion with rniwa. 680152 4 154851 vivekgalatage 2012-07-26 23:15:48 -0700 Created attachment 154851 Patch 680291 5 154851 webkit.review.bot 2012-07-27 01:34:36 -0700 Comment on attachment 154851 Patch Clearing flags on attachment: 154851 Committed r123850: <http://trac.webkit.org/changeset/123850> 680292 6 webkit.review.bot 2012-07-27 01:34:39 -0700 All reviewed patches have been landed. Closing bug. 154842 2012-07-26 22:30:11 -0700 2012-07-26 23:15:44 -0700 Patch bug-92458-20120727105827.patch text/plain 1611 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzgzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA3LTI2ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIEFkZGluZyBOVUxM IGNoZWNrcyBmb3IgZWRpdG9yIGNsaWVudCB3aXRoaW4gUGFnZSBvYmplY3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNDU4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGhlIG1pc3NpbmcgbnVs bCBjaGVja3MgZm9yIG1fZWRpdG9yQ2xpZW50IHRvIGF2b2lkIGNyYXNoIHdoZW4gdGhpcyBjbGll bnQgaXMgMC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgbm8gY2hhbmdlIGluIGZ1bmN0aW9u YWxpdHkuIEp1c3QgYWRkaXRpb24gb2YgY2hlY2sgdG8gYXZvaWQgY3Jhc2guCisKKyAgICAgICAg KiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6flBhZ2UpOgorICAgICAg ICAoV2ViQ29yZTo6UGFnZTo6Y2xlYXJVbmRvUmVkb09wZXJhdGlvbnMpOgorCiAyMDEyLTA3LTI2 ICBNaWtlIExhd3RoZXIgIDxtaWtlbGF3dGhlckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTWFr ZSB0cmFuc2l0aW9ucyB3b3JrIGJldHdlZW4gZGlmZmVyZW50IExlbmd0aCB0eXBlcwpJbmRleDog U291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wYWdlL1BhZ2UuY3BwCShyZXZpc2lvbiAxMjI4NTUpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdl L1BhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTIsNyArMTkyLDkgQEAgUGFnZTo6flBhZ2Uo KQogICAgICAgICBmcmFtZS0+ZGV0YWNoRnJvbVBhZ2UoKTsKICAgICB9CiAKLSAgICBtX2VkaXRv ckNsaWVudC0+cGFnZURlc3Ryb3llZCgpOworICAgIGlmIChtX2VkaXRvckNsaWVudCkKKyAgICAg ICAgbV9lZGl0b3JDbGllbnQtPnBhZ2VEZXN0cm95ZWQoKTsKKwogICAgIGlmIChtX2FsdGVybmF0 aXZlVGV4dENsaWVudCkKICAgICAgICAgbV9hbHRlcm5hdGl2ZVRleHRDbGllbnQtPnBhZ2VEZXN0 cm95ZWQoKTsKIApAQCAtNjEyLDcgKzYxNCw4IEBAIHZvaWQgUGFnZTo6c2V0RGVmZXJzTG9hZGlu Zyhib29sIGRlZmVycykKIAogdm9pZCBQYWdlOjpjbGVhclVuZG9SZWRvT3BlcmF0aW9ucygpCiB7 Ci0gICAgbV9lZGl0b3JDbGllbnQtPmNsZWFyVW5kb1JlZG9PcGVyYXRpb25zKCk7CisgICAgaWYg KG1fZWRpdG9yQ2xpZW50KQorICAgICAgICBtX2VkaXRvckNsaWVudC0+Y2xlYXJVbmRvUmVkb09w ZXJhdGlvbnMoKTsKIH0KIAogYm9vbCBQYWdlOjppbkxvd1F1YWxpdHlJbWFnZUludGVycG9sYXRp b25Nb2RlKCkgY29uc3QK 154851 2012-07-26 23:15:48 -0700 2012-07-27 01:34:36 -0700 Patch bug-92458-20120727114403.patch text/plain 1250 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzgzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTI2ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFBhZ2Ugb2JqZWN0 IHNob3VsZCBhc2NlcnRhaW4gRWRpdG9yQ2xpZW50IHRvIGJlIG5vbi1udWxsCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjQ1OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBFZGl0b3JDbGllbnQgc2hv dWxkIGFsd2F5cyBiZSBhdmFpbGFibGUgaW4gUGFnZSBvYmplY3QuIEFkZGVkIHRoZSBhc3NlcnRp b24gdG8gYXNjZXJ0YWluIHRoaXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBBZGRlZCBhc3Nl cnRpb24gdG8gbWFrZSBzdXJlIEVkaXRvckNsaWVudCBhbHdheXMgZXhpc3QuCisKKyAgICAgICAg KiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6UGFnZSk6CisKIDIwMTIt MDctMjYgIEhpcm9ub3JpIEJvbm8gIDxoYm9ub0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1F0 XSBCdWlsZCBmaXggZm9yIFF0IGFmdGVyIHIxMjM4MTEKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bh Z2UvUGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAko cmV2aXNpb24gMTIyODU1KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTY3LDYgKzE2Nyw4IEBAIFBhZ2U6OlBhZ2UoUGFnZUNsaWVudHMmIHBhZ2VD bGllbnRzKQogICAgICwgbV9hbHRlcm5hdGl2ZVRleHRDbGllbnQocGFnZUNsaWVudHMuYWx0ZXJu YXRpdmVUZXh0Q2xpZW50KQogICAgICwgbV9zY3JpcHRlZEFuaW1hdGlvbnNTdXNwZW5kZWQoZmFs c2UpCiB7CisgICAgQVNTRVJUKG1fZWRpdG9yQ2xpZW50KTsKKwogICAgIGlmICghYWxsUGFnZXMp IHsKICAgICAgICAgYWxsUGFnZXMgPSBuZXcgSGFzaFNldDxQYWdlKj47CiAgICAgICAgIAo=