92454 2012-07-26 21:21:28 -0700 [EFL] Return 0 when network is offline 2012-07-27 17:30:52 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://dvcs.w3.org/hg/dap/raw-file/tip/network-api/Overview.html P2 Normal --- 1 gyuyoung.kim gyuyoung.kim cdumez kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 680082 0 gyuyoung.kim 2012-07-26 21:21:28 -0700 Network Info latest spec says 0 is returned when network is offline. r123769 modified to return *infinity value* when network is offiline. 680088 1 154832 gyuyoung.kim 2012-07-26 21:25:03 -0700 Created attachment 154832 Patch 680098 2 154832 cdumez 2012-07-26 21:44:06 -0700 Comment on attachment 154832 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154832&action=review > Source/WebCore/platform/efl/NetworkInfoProviderEfl.cpp:61 > + return 0; // If network is offline, return 0. if eeze_net_new() returns NULL, then it indicates that eth0 interface does not exist. The fact that the interface does not exist is difference from being offline. The user may be connected via another network interface. So, in my opinion, this means the bandwidth is unknown. 680105 3 gyuyoung.kim 2012-07-26 21:55:56 -0700 (In reply to comment #2) > (From update of attachment 154832 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154832&action=review > > > Source/WebCore/platform/efl/NetworkInfoProviderEfl.cpp:61 > > + return 0; // If network is offline, return 0. > > if eeze_net_new() returns NULL, then it indicates that eth0 interface does not exist. The fact that the interface does not exist is difference from being offline. The user may be connected via another network interface. So, in my opinion, this means the bandwidth is unknown. Current implementation only supports ethernet. So, if eeze_net_new() returns NULL, it means there is no device and offline now. Of course, updated patch will support network regardless of wireless and ethernet. Then, we can consider if bandwidth is unknown. 680558 4 gyuyoung.kim 2012-07-27 06:41:48 -0700 Kenneth, could you take a look ? 680564 5 154832 kenneth 2012-07-27 06:43:59 -0700 Comment on attachment 154832 Patch Shouldnt you leave an FIXME: for the future? or at least a note 680704 6 154962 gyuyoung.kim 2012-07-27 08:45:24 -0700 Created attachment 154962 Patch 680705 7 gyuyoung.kim 2012-07-27 08:47:12 -0700 (In reply to comment #5) > (From update of attachment 154832 [details]) > Shouldnt you leave an FIXME: for the future? or at least a note I add an FIXME comment for now. Thanks. 681268 8 154962 webkit.review.bot 2012-07-27 17:30:47 -0700 Comment on attachment 154962 Patch Clearing flags on attachment: 154962 Committed r123939: <http://trac.webkit.org/changeset/123939> 681269 9 webkit.review.bot 2012-07-27 17:30:52 -0700 All reviewed patches have been landed. Closing bug. 154832 2012-07-26 21:25:03 -0700 2012-07-27 08:45:17 -0700 Patch bug-92454-20120727132451.patch text/plain 1580 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWJkYzRkMTQ1YjQyMjI1 ZTFkMWI1NTkxNzNmYmQ2OWY4ZGRjN2I1OC4uYjBhNDk3YjgzOTY1MWVkZTcxYzUyM2Y0YTdjZjNm NzNkZTUyOWZmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTI2ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmV0 dXJuIDAgd2hlbiBuZXR3b3JrIGlzIG9mZmxpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNDU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTmV0d29yayBJbmZvIGxhdGVzdCBzcGVjIHNheXMgMCBpcyBy ZXR1cm5lZCB3aGVuIG5ldHdvcmsgaXMgb2ZmbGluZS4KKyAgICAgICAgcjEyMzc2OSBtb2RpZmll ZCB0byByZXR1cm4gaW5maW5pdHkgdmFsdWUgd2hlbiBuZXR3b3JrIGlzIG9mZmlsaW5lLgorCisg ICAgICAgICogcGxhdGZvcm0vZWZsL05ldHdvcmtJbmZvUHJvdmlkZXJFZmwuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TmV0d29ya0luZm9Qcm92aWRlckVmbDo6YmFuZHdpZHRoKToKKwogMjAxMi0w Ny0yNiAgQW5pc2ggQmhheWFuaSAgPGFuaXNoLmJoYXlhbmlAZ21haWwuY29tPgogCiAgICAgICAg IERlLXZpcnR1YWxpemUgV3JhcFNoYXBlIGNsYXNzZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2VmbC9OZXR3b3JrSW5mb1Byb3ZpZGVyRWZsLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2VmbC9OZXR3b3JrSW5mb1Byb3ZpZGVyRWZsLmNwcAppbmRleCAxY2M1M2Vh NDc3NWQzZmM5M2VlOGNiMDlmMjNjM2RlMmYyYmFmOTUwLi5jNGIxM2RkMDhlOGVjYzNlNmJkYjcz ZjE3ZTM5MTRkYjdiMmQwNzkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9l ZmwvTmV0d29ya0luZm9Qcm92aWRlckVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZWZsL05ldHdvcmtJbmZvUHJvdmlkZXJFZmwuY3BwCkBAIC01OCw3ICs1OCw3IEBAIGRvdWJs ZSBOZXR3b3JrSW5mb1Byb3ZpZGVyRWZsOjpiYW5kd2lkdGgoKSBjb25zdAogICAgIC8vIFNlZSBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk4NTEgZm9yIGRldGFpbC4K ICAgICBFZXplX05ldCogZXRoTmV0ID0gZWV6ZV9uZXRfbmV3KGV0aGVybmV0SW50ZXJmYWNlKTsK ICAgICBpZiAoIWV0aE5ldCkKLSAgICAgICAgcmV0dXJuIHN0ZDo6bnVtZXJpY19saW1pdHM8ZG91 YmxlPjo6aW5maW5pdHkoKTsgLy8gU3BlYyBzYXlzIHdlIHNob3VsZCByZXR1cm4gaW5maW5pdHkg aWYgdW5rbm93bgorICAgICAgICByZXR1cm4gMDsgLy8gSWYgbmV0d29yayBpcyBvZmZsaW5lLCBy ZXR1cm4gMC4KIAogICAgIGVlemVfbmV0X3NjYW4oZXRoTmV0KTsKIAo= 154962 2012-07-27 08:45:24 -0700 2012-07-27 17:30:47 -0700 Patch bug-92454-20120728004511.patch text/plain 1807 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjVjODQzNmI1NTkwYWI4 ZjM1NDhmM2I3MmU4NzM2NGE0YTQyYzYwMC4uOGFiMTA5N2VjNGNhOWY4YzhhMjQ0YjJlMTkxNzhm NmQ4MGEwNjNjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTI3ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmV0 dXJuIDAgd2hlbiBuZXR3b3JrIGlzIG9mZmxpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNDU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTmV0d29yayBJbmZvIGxhdGVzdCBzcGVjIHNheXMgMCBpcyBy ZXR1cm5lZCB3aGVuIG5ldHdvcmsgaXMgb2ZmbGluZS4KKyAgICAgICAgcjEyMzc2OSBtb2RpZmll ZCB0byByZXR1cm4gaW5maW5pdHkgdmFsdWUgd2hlbiBuZXR3b3JrIGlzIG9mZmlsaW5lLgorCisg ICAgICAgICogcGxhdGZvcm0vZWZsL05ldHdvcmtJbmZvUHJvdmlkZXJFZmwuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TmV0d29ya0luZm9Qcm92aWRlckVmbDo6YmFuZHdpZHRoKToKKwogMjAxMi0w Ny0yNyAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVsLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OKHIxMjM4NTYpOiBCcmVha3MgdGhlIGJ1aWxkIHdoZW4gZGlz YWJsaW5nIGluc3BlY3RvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZs L05ldHdvcmtJbmZvUHJvdmlkZXJFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZs L05ldHdvcmtJbmZvUHJvdmlkZXJFZmwuY3BwCmluZGV4IDFjYzUzZWE0Nzc1ZDNmYzkzZWU4Y2Iw OWYyM2MzZGUyZjJiYWY5NTAuLmU1MWU5NjdkYTIwZDJhMWE1YmRjNDkwMjIxZjM1ODA2ZWYxMGRi YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9OZXR3b3JrSW5mb1By b3ZpZGVyRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTmV0d29ya0lu Zm9Qcm92aWRlckVmbC5jcHAKQEAgLTU3LDggKzU3LDkgQEAgZG91YmxlIE5ldHdvcmtJbmZvUHJv dmlkZXJFZmw6OmJhbmR3aWR0aCgpIGNvbnN0CiAgICAgLy8gRklYTUUgOiBUaGlzIGZ1bmN0aW9u IHNob3VsZCBjb25zaWRlciBjZWxsdWxhciBuZXR3b3JrIGFzIHdlbGwuIEZvciBleGFtcGxlLCAy RywgM0cgYW5kIDRHLgogICAgIC8vIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODk4NTEgZm9yIGRldGFpbC4KICAgICBFZXplX05ldCogZXRoTmV0ID0gZWV6ZV9u ZXRfbmV3KGV0aGVybmV0SW50ZXJmYWNlKTsKKyAgICAvLyBGSVhNRTogRXRoZXJuZXQgaXMgb25s eSBzdXBwb3J0ZWQgbm93LiBJZiBldGhOZXQgaXMgbnVsbCwgbmV0d29yayBpcyBvZmZsaW5lLgog ICAgIGlmICghZXRoTmV0KQotICAgICAgICByZXR1cm4gc3RkOjpudW1lcmljX2xpbWl0czxkb3Vi bGU+OjppbmZpbml0eSgpOyAvLyBTcGVjIHNheXMgd2Ugc2hvdWxkIHJldHVybiBpbmZpbml0eSBp ZiB1bmtub3duCisgICAgICAgIHJldHVybiAwOyAvLyBJZiBuZXR3b3JrIGlzIG9mZmxpbmUsIHJl dHVybiAwLgogCiAgICAgZWV6ZV9uZXRfc2NhbihldGhOZXQpOwogCg==