9245 2006-06-02 11:58:11 -0700 Quirksmode: Incorrect handling of disabled BUTTON elements 2006-07-10 01:56:45 -0700 1 1 1 Unclassified WebKit Forms 420+ PC OS X 10.4 RESOLVED FIXED P2 Normal --- 9610 1 adele andersca ian oldest_to_newest 44410 0 adele 2006-06-02 11:58:11 -0700 http://www.quirksmode.org/bugreports/archives/safari/index.html "Adding disabled attributes to <BUTTON> elements in Safari does not have the desired effect. Disabled buttons with text content are not greyed out and still respond visually to clicks (albeit without generating any onclick events). In <BUTTON> elements with image content, the addition of a disabled atribute has no effect whatsoever. Test page http://www.philronan.pwp.blueyonder.co.uk/safari-bugs/bad-buttons.html Workaround is included Reported by: Philip Ronan." 46999 1 joost 2006-06-24 13:24:21 -0700 This should be P1 imho, as it allows users to do things the webdesigner didn't want them to be able to. 47048 2 hyatt 2006-06-24 14:37:40 -0700 P1 = crashes and regressions. 47053 3 joost 2006-06-24 14:52:33 -0700 Hyatt: I strongly disagree and would like to discuss this with you. 48983 4 9312 andersca 2006-07-09 15:09:51 -0700 Created attachment 9312 Patch 49053 5 darin 2006-07-09 23:13:08 -0700 Website compatibility problems should almost never be P1 bugs; exceptions would be problems that affect very important and prominent websites or things that cause security problems. And I agree this bug does not deserve a P1. But I guess we won't resolve this by discussing it in a bug report. And this bug has a fix already, so it doesn't matter too much! 49068 6 andersca 2006-07-10 01:56:45 -0700 Fixed in r15296 9312 2006-07-09 15:09:51 -0700 2006-07-09 17:04:46 -0700 Patch dom-activate-disabled.txt text/plain 5514 andersca SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1MjY2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMDctMDkgIEFuZGVycyBDYXJsc3NvbiAg PGFjYXJsc3NvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNn aT9pZD05MjQ1CisgICAgICAgIFF1aXJrc21vZGU6IEluY29ycmVjdCBoYW5kbGluZyBvZiBkaXNh YmxlZCBCVVRUT04gZWxlbWVudHMKKyAgICAgICAgCisgICAgICAgICogZmFzdC9mb3Jtcy9hY3Rp dmF0ZS1hbmQtZGlzYWJsZWQtZWxlbWVudHMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBmYXN0L2Zvcm1zL2FjdGl2YXRlLWFuZC1kaXNhYmxlZC1lbGVtZW50cy5odG1sOiBBZGRlZC4K KwogMjAwNi0wNy0wOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAa2lsemVyLm5ldD4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEYXJpbi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvYWN0 aXZhdGUtYW5kLWRpc2FibGVkLWVsZW1lbnRzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2FjdGl2YXRlLWFuZC1kaXNhYmxlZC1lbGVtZW50cy1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2FjdGl2YXRl LWFuZC1kaXNhYmxlZC1lbGVtZW50cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsNCBAQAorRGlzYWJsZWQgYnV0dG9uIAorVGhpcyB0ZXN0cyB0aGF0IGRpc2FibGVkIGZvcm0g ZWxlbWVudHMgZG9uJ3QgY2FsbCBzdWJtaXQgd2hlbiB0aGV5IHJlY2VpdmUgYSBET01BY3RpdmF0 ZSBldmVudC4gSWYgdGhpcyB0ZXN0IGlzIHN1Y2Nlc3NmdWwsIHRoZSB0ZXh0ICJTVUNDRVNTIiBz aG91bGQgYmUgc2hvd24gYmVsb3cuCitTVUNDRVNTCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvYWN0aXZhdGUtYW5kLWRpc2FibGVkLWVsZW1lbnRzLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hY3RpdmF0ZS1hbmQtZGlzYWJsZWQtZWxlbWVudHMuaHRt bAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvYWN0aXZhdGUtYW5kLWRp c2FibGVkLWVsZW1lbnRzLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzcgQEAKKzxodG1s PgorICAgIDxoZWFkPgorICAgICAgICA8c2NyaXB0PgorICAgICAgICAKKyAgICAgICAgICAgIGZ1 bmN0aW9uIGRpc3BhdGNoQWN0aXZhdGVFdmVudCh0YXJnZXQpIHsKKyAgICAgICAgICAgICAgICAv LyBDcmVhdGUgYSBET01BY3RpdmF0ZSBldmVudCBhbmQgZGlzcGF0Y2ggaXQKKyAgICAgICAgICAg ICAgICB2YXIgZXZlbnQgPSBkb2N1bWVudC5jcmVhdGVFdmVudCgnVUlFdmVudHMnKTsKKyAgICAg ICAgICAgICAgICBldmVudC5pbml0VUlFdmVudCgnRE9NQWN0aXZhdGUnLCB0cnVlLCB0cnVlLCB3 aW5kb3csIDEpCisgICAgICAgICAgICAgICAgdGFyZ2V0LmRpc3BhdGNoRXZlbnQoZXZlbnQpOyAg ICAgICAgICAgICAgICAKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIAorICAgICAgICAgICAg ZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKQorICAgICAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5k dW1wQXNUZXh0KCk7CisgICAgICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgIHZhciBi dXR0b24gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYnV0dG9uJyk7CisgICAgICAgICAgICAg ICAgdmFyIGlucHV0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lucHV0Jyk7ICAgICAgICAg ICAgCisgICAgICAgICAgICAgICAgCisgICAgICAgICAgICAgICAgb25zdWJtaXRDYWxsZWQgPSBm YWxzZTsKKyAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAgICBkaXNwYXRjaEFjdGl2YXRl RXZlbnQoYnV0dG9uKTsKKyAgICAgICAgICAgICAgICBkaXNwYXRjaEFjdGl2YXRlRXZlbnQoaW5w dXQpOworICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgIGlmICghb25zdWJtaXRDYWxs ZWQpCisgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQn KS5pbm5lckhUTUwgPSAnU1VDQ0VTUycKKyAgICAgICAgICAgIH0KKyAgICAgICAgPC9zY3JpcHQ+ CisgICAgPC9oZWFkPgorICAgIDxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKyAgICAgICAgPGZv cm0gb25zdWJtaXQ9Im9uc3VibWl0Q2FsbGVkID0gdHJ1ZTsgcmV0dXJuIGZhbHNlIj4KKyAgICAg ICAgICAgIDxidXR0b24gaWQ9ImJ1dHRvbiIgZGlzYWJsZWQ+RGlzYWJsZWQgYnV0dG9uPC9idXR0 b24+CisgICAgICAgICAgICA8aW5wdXQgaWQ9ImlucHV0IiB0eXBlPSJzdWJtaXQiIGRpc2FibGVk PgorICAgICAgICA8L2Zvcm0+CisgICAgICAgIFRoaXMgdGVzdHMgdGhhdCBkaXNhYmxlZCBmb3Jt IGVsZW1lbnRzIGRvbid0IGNhbGwgc3VibWl0IHdoZW4gdGhleSByZWNlaXZlIGEgRE9NQWN0aXZh dGUgZXZlbnQuIElmIHRoaXMgdGVzdCBpcyBzdWNjZXNzZnVsLCB0aGUgdGV4dCAiU1VDQ0VTUyIg c2hvdWxkIGJlIHNob3duIGJlbG93LgorICAgICAgICA8ZGl2IGlkPSJyZXN1bHQiPkZBSUxVUkU8 L2Rpdj4KKyAgICA8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUyNjYpCisrKyBXZWJDb3Jl L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDIwIEBACiAyMDA2LTA3LTA5ICBB bmRlcnMgQ2FybHNzb24gIDxhY2FybHNzb25AYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2lu Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI0NQorICAgICAgICBRdWlya3Ntb2RlOiBJbmNvcnJlY3Qg aGFuZGxpbmcgb2YgZGlzYWJsZWQgQlVUVE9OIGVsZW1lbnRzCisKKyAgICAgICAgKiBodG1sL0hU TUxCdXR0b25FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxCdXR0b25FbGVtZW50 OjpkZWZhdWx0RXZlbnRIYW5kbGVyKToKKyAgICAgICAgRG9uJ3QgY2FsbCBwcmVwYXJlU3VibWl0 IGlmIHRoZSBlbGVtZW50IGlzIGRpc2FibGVkLgorCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRF bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OmRlZmF1bHRF dmVudEhhbmRsZXIpOgorICAgICAgICBEb24ndCBjYWxsIHByZXBhcmVTdWJtaXQgaWYgdGhlIGVs ZW1lbnQgaXMgZGlzYWJsZWQuCisKKzIwMDYtMDctMDkgIEFuZGVycyBDYXJsc3NvbiAgPGFjYXJs c3NvbkBhcHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltIE8uCiAKICAgICAgICAg KiBXZWJDb3JlLmV4cDoKQEAgLTM1LDcgKzUwLDYgQEAKICAgICAgICAgKiBpY29uL1NRTFN0YXRl bWVudC5jcHA6CiAgICAgICAgIChXZWJDb3JlOjpTUUxTdGF0ZW1lbnQ6OmdldENvbHVtbkJsb2JB c1ZlY3Rvcik6CiAKLT4+Pj4+Pj4gLnIxNTI2MAogMjAwNi0wNy0wOSAgRGFyaW4gQWRsZXIgIDxk YXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgLSBtb3ZlIGFsbCBidXQgdGhlIGxhc3QgMTIgZmls ZXMgb3V0IG9mIGt3cSBkaXJlY3RvcnkKSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MQnV0dG9uRWxl bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxCdXR0b25FbGVtZW50LmNw cAkocmV2aXNpb24gMTUyNjYpCisrKyBXZWJDb3JlL2h0bWwvSFRNTEJ1dHRvbkVsZW1lbnQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC04NSw3ICs4NSw3IEBAIHZvaWQgSFRNTEJ1dHRvbkVsZW1lbnQ6 OnBhcnNlTWFwcGVkQXR0cmkKIAogdm9pZCBIVE1MQnV0dG9uRWxlbWVudDo6ZGVmYXVsdEV2ZW50 SGFuZGxlcihFdmVudCAqZXZ0KQogewotICAgIGlmIChtX3R5cGUgIT0gQlVUVE9OICYmIChldnQt PnR5cGUoKSA9PSBET01BY3RpdmF0ZUV2ZW50KSkgeworICAgIGlmIChtX3R5cGUgIT0gQlVUVE9O ICYmIChldnQtPnR5cGUoKSA9PSBET01BY3RpdmF0ZUV2ZW50KSAmJiAhZGlzYWJsZWQoKSkgewog ICAgICAgICBpZiAoZm9ybSgpICYmIG1fdHlwZSA9PSBTVUJNSVQpIHsKICAgICAgICAgICAgIG1f YWN0aXZlU3VibWl0ID0gdHJ1ZTsKICAgICAgICAgICAgIGZvcm0oKS0+cHJlcGFyZVN1Ym1pdCgp OwpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAkocmV2aXNpb24gMTUyNjYpCisrKyBX ZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMTks NyArMTIxOSw3IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGwKICAg ICAvLyBhY3R1YWxseSBzdWJtaXR0aW5nIHRoZSBmb3JtLiBGb3IgcmVzZXQgaW5wdXRzLCB0aGUg Zm9ybSBpcyByZXNldC4gVGhlc2UgZXZlbnRzIGFyZSBzZW50IHdoZW4gdGhlIHVzZXIgY2xpY2tz CiAgICAgLy8gb24gdGhlIGVsZW1lbnQsIG9yIHByZXNzZXMgZW50ZXIgd2hpbGUgaXQgaXMgdGhl IGFjdGl2ZSBlbGVtZW50LiBKYXZhY3NyaXB0IGNvZGUgd2lzaGluZyB0byBhY3RpdmF0ZSB0aGUg ZWxlbWVudAogICAgIC8vIG11c3QgZGlzcGF0Y2ggYSBET01BY3RpdmF0ZSBldmVudCAtIGEgY2xp Y2sgZXZlbnQgd2lsbCBub3QgZG8gdGhlIGpvYi4KLSAgICBpZiAoZXZ0LT50eXBlKCkgPT0gRE9N QWN0aXZhdGVFdmVudCkgeworICAgIGlmIChldnQtPnR5cGUoKSA9PSBET01BY3RpdmF0ZUV2ZW50 ICYmICFkaXNhYmxlZCgpKSB7CiAgICAgICAgIGlmIChpbnB1dFR5cGUoKSA9PSBJTUFHRSB8fCBp bnB1dFR5cGUoKSA9PSBTVUJNSVQgfHwgaW5wdXRUeXBlKCkgPT0gUkVTRVQpIHsKICAgICAgICAg ICAgIGlmICghZm9ybSgpKQogICAgICAgICAgICAgICAgIHJldHVybjsK