92437 2012-07-26 16:31:22 -0700 Web Inspector: Allow front_end to be loaded into an iframe 2012-07-27 12:03:07 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 johnjbarton webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 679912 0 johnjbarton 2012-07-26 16:31:22 -0700 One of the wonderful aspects of WebInspector is its use of 100% Web technology. I have leverage this aspect to embed WebInspector in a Web app and in a Chrome browser extension. I was able to hook the load sequence of the code to adapt the WebInspector to alternative backend connections (chrome.debugger API and WebSockets without using the built-in instance). The only small problem I hit was in loading extensions: the postMessage system uses 'top' in two places, but when embedded the WebInspector will not be 'top'. By replacing these uses with 'window.parent' the WebInspector is iframeable. 679921 1 154791 johnjbarton 2012-07-26 16:53:08 -0700 Created attachment 154791 Patch 680120 2 154791 pfeldman 2012-07-26 22:16:15 -0700 Comment on attachment 154791 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154791&action=review Please resubmit with proper changle log so that I could CQ+ it > Source/WebCore/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Remove this line 680793 3 154986 johnjbarton 2012-07-27 10:42:53 -0700 Created attachment 154986 Patch 680795 4 johnjbarton 2012-07-27 10:45:45 -0700 Note I changed the patch to catch one more "top." over in Source/WebKit/chromium. I think this change would only help if embedders can figure out how to use unmodified devtools extensions, but I added it to be consistent with the other changes. 680907 5 154986 webkit.review.bot 2012-07-27 12:03:03 -0700 Comment on attachment 154986 Patch Clearing flags on attachment: 154986 Committed r123902: <http://trac.webkit.org/changeset/123902> 680909 6 webkit.review.bot 2012-07-27 12:03:07 -0700 All reviewed patches have been landed. Closing bug. 154791 2012-07-26 16:53:08 -0700 2012-07-27 10:42:49 -0700 Patch bug-92437-20120726165257.patch text/plain 2486 johnjbarton U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGNmZWMzYjVmYzZkMzYw M2NhNDliOTJmMjY3Y2NmYmNlODkwNzllNi4uY2M0ZmI5Zjg1M2QwN2E1ZjMxMzQ4ZmNlZWI5OGEw YzVmZjMxZTYxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA3LTI2ICBKb2hu IEouIEJhcnRvbiAgPGpvaG5qYmFydG9uQGpvaG5qYmFydG9uLmNvbT4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBBbGxvdyBmcm9udF9lbmQgdG8gYmUgbG9hZGVkIGludG8gYW4gaWZyYW1lCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjQzNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGl0aW9uYWwg aW5mb3JtYXRpb24gb2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCByYXRpb25hbGUuIFBs ZWFzZSBhZGQgcGVyLWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxvdyAoT09QUyEpLgorCisgICAg ICAgIFRoaXMgY2hhbmdlIG9ubHkgYWZmZWN0cyAnZW1iZWRkZXJzJyBvZiB0aGUgaW5zcGVjdG9y L2Zyb250X2VuZC4gTm8gY2hhbmdlIG9mIGZ1bmN0aW9uIGZvciBXZWJLaXQgcG9ydHMuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvbkFQSS5qczogCisgICAgICAgIFJl cGxhY2Ugd2luZG93LnRvcCB3aXRoIHdpbmRvdy5wYXJlbnQgdHdvIHBsYWNlcy4gV2hlbiBXZWJJ bnNwZWN0b3IgaXMgbG9hZGVkIGFzIHRoZSBtYWluIHdpbmRvdyBjb250ZW50LCAKKyAgICAgICAg dGhlbiBleHRlbnNpb24gaWZyYW1lcyBoYXZlIHdpbmRvdy50b3AgPT09IHdpbmRvdy5wYXJlbnQ7 IHdoZW4gV2ViSW5zcGVjdG9yIGlzIGxvYWRlZCBhcyBhbiBpZnJhbWUsIHRoZW4KKyAgICAgICAg ZXh0ZW5zaW9ucyBhcmUgaWZyYW1lcyBpbiBpZnJhbWVzIGFuZCB3ZSBuZWVkIHRvIHVzZSBhIHJl bGF0aXZlIGFkZHJlc3Mgd2luZG93LnBhcmVudC4KKyAgICAgICAgKGluamVjdGVkRXh0ZW5zaW9u QVBJLkV4dGVuc2lvblZpZXdJbXBsLmRpc3BhdGNoU2hvd0V2ZW50KToKKyAgICAgICAgKGluamVj dGVkRXh0ZW5zaW9uQVBJLkV4dGVuc2lvblZpZXdJbXBsKToKKyAgICAgICAgKGluamVjdGVkRXh0 ZW5zaW9uQVBJLkV4dGVuc2lvblNlcnZlckNsaWVudCk6CisKIDIwMTItMDctMjQgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBSZW1vdmUgYW4gaW52YWxp ZCBhc3NlcnRpb24gaW50cm9kdWNlZCBpbiByMTIzNTM2LiBVbnJldmlld2VkLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25BUEkuanMgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvbkFQSS5qcwppbmRleCA5 Y2IyYzMxZjg3MWQ3ZDdhMmM4M2NmMmQ4YmIyZDM1Yjk5Yjk4YTA2Li40Yzk3ZjZkMmVkYTg2M2Y5 YzVmNzZjNDEyZDdhMTVhYTk1ZWYxNzFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvbkFQSS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvbkFQSS5qcwpAQCAtMzQ4LDcgKzM0OCw3IEBAIGZ1bmN0 aW9uIEV4dGVuc2lvblZpZXdJbXBsKGlkKQogICAgIGZ1bmN0aW9uIGRpc3BhdGNoU2hvd0V2ZW50 KG1lc3NhZ2UpCiAgICAgewogICAgICAgICB2YXIgZnJhbWVJbmRleCA9IG1lc3NhZ2UuYXJndW1l bnRzWzBdOwotICAgICAgICB0aGlzLl9maXJlKHdpbmRvdy50b3AuZnJhbWVzW2ZyYW1lSW5kZXhd KTsKKyAgICAgICAgdGhpcy5fZmlyZSh3aW5kb3cucGFyZW50LmZyYW1lc1tmcmFtZUluZGV4XSk7 CiAgICAgfQogICAgIHRoaXMub25TaG93biA9IG5ldyBFdmVudFNpbmsoZXZlbnRzLlZpZXdTaG93 biArIGlkLCBkaXNwYXRjaFNob3dFdmVudCk7CiAgICAgdGhpcy5vbkhpZGRlbiA9IG5ldyBFdmVu dFNpbmsoZXZlbnRzLlZpZXdIaWRkZW4gKyBpZCk7CkBAIC03MzgsNyArNzM4LDcgQEAgZnVuY3Rp b24gRXh0ZW5zaW9uU2VydmVyQ2xpZW50KCkKICAgICB0aGlzLl9wb3J0LmFkZEV2ZW50TGlzdGVu ZXIoIm1lc3NhZ2UiLCB0aGlzLl9vbk1lc3NhZ2UuYmluZCh0aGlzKSwgZmFsc2UpOwogICAgIHRo aXMuX3BvcnQuc3RhcnQoKTsKIAotICAgIHRvcC5wb3N0TWVzc2FnZSgicmVnaXN0ZXJFeHRlbnNp b24iLCBbIGNoYW5uZWwucG9ydDIgXSwgIioiKTsKKyAgICB3aW5kb3cucGFyZW50LnBvc3RNZXNz YWdlKCJyZWdpc3RlckV4dGVuc2lvbiIsIFsgY2hhbm5lbC5wb3J0MiBdLCAiKiIpOwogfQogCiBF eHRlbnNpb25TZXJ2ZXJDbGllbnQucHJvdG90eXBlID0gewo= 154986 2012-07-27 10:42:53 -0700 2012-07-27 12:03:03 -0700 Patch bug-92437-20120727104241.patch text/plain 3292 johnjbarton U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGNmZWMzYjVmYzZkMzYw M2NhNDliOTJmMjY3Y2NmYmNlODkwNzllNi4uYmNlYzI3ZTc0YjE2OGVhNjI3MzJkN2MwZjBmNTc2 YjM1NzY0ZDA0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA3LTI2ICBKb2hu IEouIEJhcnRvbiAgPGpvaG5qYmFydG9uQGpvaG5qYmFydG9uLmNvbT4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBBbGxvdyBmcm9udF9lbmQgdG8gYmUgbG9hZGVkIGludG8gYW4gaWZyYW1lCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjQzNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdl IG9ubHkgYWZmZWN0cyAnZW1iZWRkZXJzJyBvZiB0aGUgaW5zcGVjdG9yL2Zyb250X2VuZC4gTm8g Y2hhbmdlIG9mIGZ1bmN0aW9uIGZvciBXZWJLaXQgcG9ydHMuCisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL0V4dGVuc2lvbkFQSS5qczogCisgICAgICAgIFJlcGxhY2Ugd2luZG93LnRv cCB3aXRoIHdpbmRvdy5wYXJlbnQgdHdvIHBsYWNlcy4gV2hlbiBXZWJJbnNwZWN0b3IgaXMgbG9h ZGVkIGFzIHRoZSBtYWluIHdpbmRvdyBjb250ZW50LCAKKyAgICAgICAgdGhlbiBleHRlbnNpb24g aWZyYW1lcyBoYXZlIHdpbmRvdy50b3AgPT09IHdpbmRvdy5wYXJlbnQ7IHdoZW4gV2ViSW5zcGVj dG9yIGlzIGxvYWRlZCBhcyBhbiBpZnJhbWUsIHRoZW4KKyAgICAgICAgZXh0ZW5zaW9ucyBhcmUg aWZyYW1lcyBpbiBpZnJhbWVzIGFuZCB3ZSBuZWVkIHRvIHVzZSBhIHJlbGF0aXZlIGFkZHJlc3Mg d2luZG93LnBhcmVudC4KKyAgICAgICAgKGluamVjdGVkRXh0ZW5zaW9uQVBJLkV4dGVuc2lvblZp ZXdJbXBsLmRpc3BhdGNoU2hvd0V2ZW50KToKKyAgICAgICAgKGluamVjdGVkRXh0ZW5zaW9uQVBJ LkV4dGVuc2lvblZpZXdJbXBsKToKKyAgICAgICAgKGluamVjdGVkRXh0ZW5zaW9uQVBJLkV4dGVu c2lvblNlcnZlckNsaWVudCk6CisgICAgICAgIFdlYktpdC9jaHJvbWl1bS9zY3JpcHRzL2dlbmVy YXRlX2RldnRvb2xzX2V4dGVuc2lvbl9hcGkucHk6CisgICAgICAgIFRoZSBjdXJyZW50IG51bWJl ciBvZiBmcmFtZXMgaXMgdXNlZCBpbiBhIGR5bmFtaWNhbGx5IGNyZWF0ZWQgaWRlbnRpZmllci4g QWdhaW4gd2UgcmVwbGFjZSAndG9wJyBieSAKKyAgICAgICAgd2luZG93LnBhcmVudC4KKwogMjAx Mi0wNy0yNCAgS3dhbmcgWXVsIFNlbyAgPHNreXVsQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAg IFJlbW92ZSBhbiBpbnZhbGlkIGFzc2VydGlvbiBpbnRyb2R1Y2VkIGluIHIxMjM1MzYuIFVucmV2 aWV3ZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4 dGVuc2lvbkFQSS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5z aW9uQVBJLmpzCmluZGV4IDljYjJjMzFmODcxZDdkN2EyYzgzY2YyZDhiYjJkMzViOTliOThhMDYu LjRjOTdmNmQyZWRhODYzZjljNWY3NmM0MTJkN2ExNWFhOTVlZjE3MWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uQVBJLmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uQVBJLmpzCkBAIC0zNDgs NyArMzQ4LDcgQEAgZnVuY3Rpb24gRXh0ZW5zaW9uVmlld0ltcGwoaWQpCiAgICAgZnVuY3Rpb24g ZGlzcGF0Y2hTaG93RXZlbnQobWVzc2FnZSkKICAgICB7CiAgICAgICAgIHZhciBmcmFtZUluZGV4 ID0gbWVzc2FnZS5hcmd1bWVudHNbMF07Ci0gICAgICAgIHRoaXMuX2ZpcmUod2luZG93LnRvcC5m cmFtZXNbZnJhbWVJbmRleF0pOworICAgICAgICB0aGlzLl9maXJlKHdpbmRvdy5wYXJlbnQuZnJh bWVzW2ZyYW1lSW5kZXhdKTsKICAgICB9CiAgICAgdGhpcy5vblNob3duID0gbmV3IEV2ZW50U2lu ayhldmVudHMuVmlld1Nob3duICsgaWQsIGRpc3BhdGNoU2hvd0V2ZW50KTsKICAgICB0aGlzLm9u SGlkZGVuID0gbmV3IEV2ZW50U2luayhldmVudHMuVmlld0hpZGRlbiArIGlkKTsKQEAgLTczOCw3 ICs3MzgsNyBAQCBmdW5jdGlvbiBFeHRlbnNpb25TZXJ2ZXJDbGllbnQoKQogICAgIHRoaXMuX3Bv cnQuYWRkRXZlbnRMaXN0ZW5lcigibWVzc2FnZSIsIHRoaXMuX29uTWVzc2FnZS5iaW5kKHRoaXMp LCBmYWxzZSk7CiAgICAgdGhpcy5fcG9ydC5zdGFydCgpOwogCi0gICAgdG9wLnBvc3RNZXNzYWdl KCJyZWdpc3RlckV4dGVuc2lvbiIsIFsgY2hhbm5lbC5wb3J0MiBdLCAiKiIpOworICAgIHdpbmRv dy5wYXJlbnQucG9zdE1lc3NhZ2UoInJlZ2lzdGVyRXh0ZW5zaW9uIiwgWyBjaGFubmVsLnBvcnQy IF0sICIqIik7CiB9CiAKIEV4dGVuc2lvblNlcnZlckNsaWVudC5wcm90b3R5cGUgPSB7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NjcmlwdHMvZ2VuZXJhdGVfZGV2dG9vbHNf ZXh0ZW5zaW9uX2FwaS5weSBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc2NyaXB0cy9nZW5lcmF0 ZV9kZXZ0b29sc19leHRlbnNpb25fYXBpLnB5CmluZGV4IGZiYjg3OGRmMjUwNjExNDQyZmJjMjZm N2QwYmQzY2FkYjQ1ZjYwNjMuLmQ2ZDk4MjZjYjE0NmNkZTEyOTg5OTc3NmFmMjQwZTI0YzhiMjBi MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc2NyaXB0cy9nZW5lcmF0ZV9k ZXZ0b29sc19leHRlbnNpb25fYXBpLnB5CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc2Ny aXB0cy9nZW5lcmF0ZV9kZXZ0b29sc19leHRlbnNpb25fYXBpLnB5CkBAIC00MSw3ICs0MSw3IEBA IGRlZiB3cml0ZV9kZXZ0b29sc19leHRlbnNpb25fYXBpKG91dHB1dCwgaW5wdXRfbmFtZXMpOgog ICAgIG91dHB1dC53cml0ZSgiIiIKICAgICAgICAgdmFyIHRhYklkOwogICAgICAgICB2YXIgZXh0 ZW5zaW9uSW5mbyA9IHt9OwotICAgICAgICBwbGF0Zm9ybUV4dGVuc2lvbkFQSShpbmplY3RlZEV4 dGVuc2lvbkFQSSgicmVtb3RlLSIgKyB0b3AuZnJhbWVzLmxlbmd0aCkpOworICAgICAgICBwbGF0 Zm9ybUV4dGVuc2lvbkFQSShpbmplY3RlZEV4dGVuc2lvbkFQSSgicmVtb3RlLSIgKyB3aW5kb3cu cGFyZW50LmZyYW1lcy5sZW5ndGgpKTsKICAgICB9KSgpOyIiIikKIAogCg==