92427 2012-07-26 14:53:47 -0700 [chromium] Remove some unreachable code in ClipboardChromium.cpp 2012-07-26 18:42:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony abarth dcheng rniwa webkit.review.bot oldest_to_newest 679788 0 tony 2012-07-26 14:53:47 -0700 [chromium] Remove some unreachable code in ClipboardChromium.cpp 679789 1 154757 tony 2012-07-26 14:55:00 -0700 Created attachment 154757 Patch 679792 2 dcheng 2012-07-26 14:57:43 -0700 Oops. Thanks for removing this code. 679794 3 tony 2012-07-26 14:59:06 -0700 (In reply to comment #2) > Oops. Thanks for removing this code. Np, I should have caught it during review. 679994 4 154757 webkit.review.bot 2012-07-26 18:42:12 -0700 Comment on attachment 154757 Patch Clearing flags on attachment: 154757 Committed r123828: <http://trac.webkit.org/changeset/123828> 679995 5 webkit.review.bot 2012-07-26 18:42:16 -0700 All reviewed patches have been landed. Closing bug. 154757 2012-07-26 14:55:00 -0700 2012-07-26 18:42:11 -0700 Patch bug-92427-20120726145515.patch text/plain 2236 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzFkNTA1YmJmZmZiNjAy ZGQxMDA2ZDJlMTQ5MGU3NmEwOTdhOGNlZC4uMTZjOTg4ZWUzMDg0NTVlNTU4NWZmY2E5ZDc2MGFm YWU5ODk5YWIwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTI2ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBSZW1vdmUg c29tZSB1bnJlYWNoYWJsZSBjb2RlIGluIENsaXBib2FyZENocm9taXVtLmNwcAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI0MjcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjb252ZXJ0VVJJTGlzdFRvVVJM IGRvZXMgdGhlIHNhbWUgdGhpbmcgKGltcGxlbWVudGF0aW9uIGluIENsaXBib2FyZFV0aWxpdGll c0Nocm9taXVtLiopLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywganVzdCBkZWxldGluZyB1bnVz ZWQgY29kZS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL0NsaXBib2FyZENocm9taXVt LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNsaXBib2FyZENocm9taXVtOjpnZXREYXRhKToKKwog MjAxMi0wNy0yNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBI cmVmIGF0dHJpYnV0ZSB3aXRoIGphdmFzY3JpcHQgcHJvdG9jb2wgaXMgc3RyaXBwZWQgd2hlbiBj b250ZW50IGlzIHBhc3RlZCBpbnRvIGEgWE1MIGRvdWNtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DbGlwYm9hcmRDaHJvbWl1bS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DbGlwYm9hcmRDaHJvbWl1bS5jcHAKaW5kZXggNTk4 NDM2ZGY1Zjk4YmQ1NTkxZmYyYWE1OWU1ZGVjNWE5ZjVhYTI2Ny4uYjA2NTIzN2I5YzI1YjFlOTYy YWI5NmRjZmFjYjNlNTQ4MWEzOWQ0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vQ2xpcGJvYXJkQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2Nocm9taXVtL0NsaXBib2FyZENocm9taXVtLmNwcApAQCAtMjYzLDI3ICsyNjMsNiBA QCBTdHJpbmcgQ2xpcGJvYXJkQ2hyb21pdW06OmdldERhdGEoY29uc3QgU3RyaW5nJiB0eXBlKSBj b25zdAogICAgIGlmICghY29udmVydFRvVVJMKQogICAgICAgICByZXR1cm4gZGF0YTsKICAgICBy ZXR1cm4gY29udmVydFVSSUxpc3RUb1VSTChkYXRhKTsKLQotICAgIFZlY3RvcjxTdHJpbmc+IHVy aUxpc3Q7Ci0gICAgLy8gTGluZSBzZXBhcmF0b3IgaXMgXHJcbiBwZXIgUkZDIDI0ODMgLSBob3d2 ZXIsIGZvciBjb21wYXRpYmxpdHkKLSAgICAvLyByZWFzb25zIHdlIGFsc28gYWxsb3cganVzdCBc biBoZXJlLgotICAgIGRhdGEuc3BsaXQoJ1xuJywgdXJpTGlzdCk7Ci0gICAgLy8gUHJvY2VzcyB0 aGUgaW5wdXQgYW5kIHJldHVybiB0aGUgZmlyc3QgdmFsaWQgUlVMLiBJbiBjYXNlIG5vIFVSTHMg Y2FuCi0gICAgLy8gYmUgZm91bmQsIHJldHVybiBhbiBlbXB0eSBzdHJpbmcuIFRoaXMgaXMgaW4g bGluZSB3aXRoIHRoZSBIVE1MNQotICAgIC8vIHNwZWMgKHNlZSAiVGhlIERyYWdFdmVudCBhbmQg RGF0YVRyYW5zZmVyIGludGVyZmFjZXMiKS4KLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHVy aUxpc3Quc2l6ZSgpOyArK2kpIHsKLSAgICAgICAgU3RyaW5nJiBsaW5lID0gdXJpTGlzdFtpXTsK LSAgICAgICAgbGluZSA9IGxpbmUuc3RyaXBXaGl0ZVNwYWNlKCk7Ci0gICAgICAgIGlmIChsaW5l LmlzRW1wdHkoKSkKLSAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICBpZiAobGluZVswXSA9 PSAnIycpCi0gICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgS1VSTCB1cmwgPSBLVVJMKFBh cnNlZFVSTFN0cmluZywgbGluZSk7Ci0gICAgICAgIGlmICh1cmwuaXNWYWxpZCgpKQotICAgICAg ICAgICAgcmV0dXJuIHVybDsKLSAgICB9Ci0KLSAgICByZXR1cm4gU3RyaW5nKCk7CiB9CiAKIGJv b2wgQ2xpcGJvYXJkQ2hyb21pdW06OnNldERhdGEoY29uc3QgU3RyaW5nJiB0eXBlLCBjb25zdCBT dHJpbmcmIGRhdGEpCg==