92415 2012-07-26 12:54:04 -0700 [BlackBerry] Remove synchronous spellchecking code 2012-07-26 17:01:35 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nima.ghanavatian mifenton tonikitoo webkit.review.bot oldest_to_newest 679664 0 nima.ghanavatian 2012-07-26 12:54:04 -0700 Removing the usage of the synchronous spellchecking code. 679682 1 154729 nima.ghanavatian 2012-07-26 13:05:59 -0700 Created attachment 154729 Patch 679698 2 154733 nima.ghanavatian 2012-07-26 13:29:26 -0700 Created attachment 154733 Patch 679724 3 154733 rwlbuis 2012-07-26 13:48:04 -0700 Comment on attachment 154733 Patch LGTM. 679925 4 154733 webkit.review.bot 2012-07-26 17:01:32 -0700 Comment on attachment 154733 Patch Clearing flags on attachment: 154733 Committed r123815: <http://trac.webkit.org/changeset/123815> 679926 5 webkit.review.bot 2012-07-26 17:01:35 -0700 All reviewed patches have been landed. Closing bug. 154729 2012-07-26 13:05:59 -0700 2012-07-26 13:29:23 -0700 Patch bug-92415-20120726160118.patch text/plain 2600 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA2YTExYjdjYTcxNTE5NGQ5MTdhMDZlMzZiMWMzNTBiZDA1ZDYxNTgwLi5lOGFmYTQ1OWQ0 Mjk5NTVkOTI2Yzg2NmY1ZTQ5NjMwZmZkNWExYjJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNy0yNiAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBSZW1vdmUgc3luY2hy b25vdXMgc3BlbGxjaGVja2luZyBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05MjQxNQorCisgICAgICAgIFJlbW92aW5nIHN5bmNocm9ub3VzIHNw ZWxsY2hlY2tpbmcgY29kZSBwYXRoLgorCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkg TWlrZSBGZW50b24uCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZUNsaWVudC5oOgorICAgICAgICAq IFdlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RWRpdG9yQ2xpZW50QmxhY2tCZXJyeTo6Y2hlY2tTcGVsbGluZ09mU3RyaW5nKToKKwog MjAxMi0wNy0yNCAgTmltYSBHaGFuYXZhdGlhbiAgPG5naGFuYXZhdGlhbkByaW0uY29tPgogCiAg ICAgICAgIFtCbGFja0JlcnJ5XSBTdXBwb3J0IGFzeW5jIHNwZWxsY2hlY2sgZm9yIHRoZSBibGFj a2JlcnJ5IHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZUNsaWVudC5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50 LmgKaW5kZXggZTkzMWQ2MDUwYjFlNTlkZTQ2MzEzNzExYzBjODExYTAzN2RmNTc4OS4uYjQxZTNj MThkY2Q3ZjhlNDc1ZTExYWIzN2EwMjgzOTliNDEzYWM2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmgKQEAgLTE0Myw5ICsxNDMsNyBAQCBwdWJsaWM6 CiAKICAgICB2aXJ0dWFsIHZvaWQgc2hvd1ZpcnR1YWxLZXlib2FyZChib29sKSA9IDA7CiAKLSAg ICB2aXJ0dWFsIHZvaWQgY2hlY2tTcGVsbGluZ09mU3RyaW5nKGNvbnN0IHVuc2lnbmVkIHNob3J0 KiB0ZXh0LCBpbnQgbGVuZ3RoLCBpbnQmIG1pc3NwZWxsaW5nTG9jYXRpb24sIGludCYgbWlzc3Bl bGxpbmdMZW5ndGgpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgcmVxdWVzdFNwZWxsaW5nU3VnZ2Vz dGlvbnNGb3JTdHJpbmcodW5zaWduZWQgc3RhcnQsIHVuc2lnbmVkIGVuZCkgPSAwOwotCiAgICAg dmlydHVhbCBpbnQzMl90IGNoZWNrU3BlbGxpbmdPZlN0cmluZ0FzeW5jKHdjaGFyX3QqIHRleHQs IGludCBsZW5ndGgpID0gMDsKIAogICAgIHZpcnR1YWwgdm9pZCBub3RpZnlTZWxlY3Rpb25EZXRh aWxzQ2hhbmdlZChjb25zdCBQbGF0Zm9ybTo6SW50UmVjdCYgc3RhcnQsIGNvbnN0IFBsYXRmb3Jt OjpJbnRSZWN0JiBlbmQsIGNvbnN0IFBsYXRmb3JtOjpJbnRSZWN0UmVnaW9uJiwgYm9vbCBvdmVy cmlkZVRvdWNoSGFuZGxpbmcgPSBmYWxzZSkgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEJsYWNrQmVycnkuY3BwIGIv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEJsYWNr QmVycnkuY3BwCmluZGV4IGFhYzkyMmQ1NWUxNTVkNjY4ZTJlNGIzYzg1YjcwM2M1NDUwOWE0OGQu Ljk1ZDAyZjdkNWJiNGI5ZDNhZWFiYzBhMzNiMjkyNDZlZDkwMzFhZTEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRCbGFja0Jl cnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRWRp dG9yQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTU1Niw3ICs1NTYsNyBAQCB2b2lkIEVkaXRvckNs aWVudEJsYWNrQmVycnk6OmxlYXJuV29yZChjb25zdCBXVEY6OlN0cmluZyYpCiAKIHZvaWQgRWRp dG9yQ2xpZW50QmxhY2tCZXJyeTo6Y2hlY2tTcGVsbGluZ09mU3RyaW5nKGNvbnN0IFVDaGFyKiB0 ZXh0LCBpbnQgdGV4dExlbmd0aCwgaW50KiBtaXNzcGVsbExvY2F0aW9uLCBpbnQqIG1pc3NwZWxs TGVuZ3RoKQogewotICAgIG1fd2ViUGFnZVByaXZhdGUtPm1fY2xpZW50LT5jaGVja1NwZWxsaW5n T2ZTdHJpbmcodGV4dCwgdGV4dExlbmd0aCwgKm1pc3NwZWxsTG9jYXRpb24sICptaXNzcGVsbExl bmd0aCk7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKIH0KIAogV1RGOjpTdHJpbmcgRWRpdG9yQ2xp ZW50QmxhY2tCZXJyeTo6Z2V0QXV0b0NvcnJlY3RTdWdnZXN0aW9uRm9yTWlzc3BlbGxlZFdvcmQo Y29uc3QgV1RGOjpTdHJpbmcmIG1pc3NwZWxsZWRXb3JkKQo= 154733 2012-07-26 13:29:26 -0700 2012-07-26 17:01:31 -0700 Patch bug-92415-20120726162445.patch text/plain 2639 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBiYWMyYmI0ZGRkNzM3ZTIyZjMxODEwNzRhNmIxNzRmZTk0ODdmNWRhLi4yNzdiMDE3ODU4 NDFlZjRiYmNjZDUyNzc0NmFiYzBmMDdjYWFkNjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wNy0yNiAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBSZW1vdmUgc3luY2hy b25vdXMgc3BlbGxjaGVja2luZyBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05MjQxNQorCisgICAgICAgIFJlbW92aW5nIHN5bmNocm9ub3VzIHNw ZWxsY2hlY2tpbmcgY29kZSBwYXRoLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgTWlrZSBGZW50b24uCisKKyAg ICAgICAgKiBBcGkvV2ViUGFnZUNsaWVudC5oOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Vk aXRvckNsaWVudEJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yQ2xpZW50 QmxhY2tCZXJyeTo6Y2hlY2tTcGVsbGluZ09mU3RyaW5nKToKKwogMjAxMi0wNy0yNCAgTmltYSBH aGFuYXZhdGlhbiAgPG5naGFuYXZhdGlhbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5 XSBTdXBwb3J0IGFzeW5jIHNwZWxsY2hlY2sgZm9yIHRoZSBibGFja2JlcnJ5IHBvcnQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmgKaW5kZXggZTkzMWQ2MDUw YjFlNTlkZTQ2MzEzNzExYzBjODExYTAzN2RmNTc4OS4uYjQxZTNjMThkY2Q3ZjhlNDc1ZTExYWIz N2EwMjgzOTliNDEzYWM2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9XZWJQYWdlQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQ YWdlQ2xpZW50LmgKQEAgLTE0Myw5ICsxNDMsNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIHZv aWQgc2hvd1ZpcnR1YWxLZXlib2FyZChib29sKSA9IDA7CiAKLSAgICB2aXJ0dWFsIHZvaWQgY2hl Y2tTcGVsbGluZ09mU3RyaW5nKGNvbnN0IHVuc2lnbmVkIHNob3J0KiB0ZXh0LCBpbnQgbGVuZ3Ro LCBpbnQmIG1pc3NwZWxsaW5nTG9jYXRpb24sIGludCYgbWlzc3BlbGxpbmdMZW5ndGgpID0gMDsK ICAgICB2aXJ0dWFsIHZvaWQgcmVxdWVzdFNwZWxsaW5nU3VnZ2VzdGlvbnNGb3JTdHJpbmcodW5z aWduZWQgc3RhcnQsIHVuc2lnbmVkIGVuZCkgPSAwOwotCiAgICAgdmlydHVhbCBpbnQzMl90IGNo ZWNrU3BlbGxpbmdPZlN0cmluZ0FzeW5jKHdjaGFyX3QqIHRleHQsIGludCBsZW5ndGgpID0gMDsK IAogICAgIHZpcnR1YWwgdm9pZCBub3RpZnlTZWxlY3Rpb25EZXRhaWxzQ2hhbmdlZChjb25zdCBQ bGF0Zm9ybTo6SW50UmVjdCYgc3RhcnQsIGNvbnN0IFBsYXRmb3JtOjpJbnRSZWN0JiBlbmQsIGNv bnN0IFBsYXRmb3JtOjpJbnRSZWN0UmVnaW9uJiwgYm9vbCBvdmVycmlkZVRvdWNoSGFuZGxpbmcg PSBmYWxzZSkgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNv cmVTdXBwb3J0L0VkaXRvckNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEJsYWNrQmVycnkuY3BwCmluZGV4IGFh YzkyMmQ1NWUxNTVkNjY4ZTJlNGIzYzg1YjcwM2M1NDUwOWE0OGQuLjk1ZDAyZjdkNWJiNGI5ZDNh ZWFiYzBhMzNiMjkyNDZlZDkwMzFhZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50QmxhY2tCZXJy eS5jcHAKQEAgLTU1Niw3ICs1NTYsNyBAQCB2b2lkIEVkaXRvckNsaWVudEJsYWNrQmVycnk6Omxl YXJuV29yZChjb25zdCBXVEY6OlN0cmluZyYpCiAKIHZvaWQgRWRpdG9yQ2xpZW50QmxhY2tCZXJy eTo6Y2hlY2tTcGVsbGluZ09mU3RyaW5nKGNvbnN0IFVDaGFyKiB0ZXh0LCBpbnQgdGV4dExlbmd0 aCwgaW50KiBtaXNzcGVsbExvY2F0aW9uLCBpbnQqIG1pc3NwZWxsTGVuZ3RoKQogewotICAgIG1f d2ViUGFnZVByaXZhdGUtPm1fY2xpZW50LT5jaGVja1NwZWxsaW5nT2ZTdHJpbmcodGV4dCwgdGV4 dExlbmd0aCwgKm1pc3NwZWxsTG9jYXRpb24sICptaXNzcGVsbExlbmd0aCk7CisgICAgbm90SW1w bGVtZW50ZWQoKTsKIH0KIAogV1RGOjpTdHJpbmcgRWRpdG9yQ2xpZW50QmxhY2tCZXJyeTo6Z2V0 QXV0b0NvcnJlY3RTdWdnZXN0aW9uRm9yTWlzc3BlbGxlZFdvcmQoY29uc3QgV1RGOjpTdHJpbmcm IG1pc3NwZWxsZWRXb3JkKQo=