<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>92414</bug_id>
          
          <creation_ts>2012-07-26 12:49:26 -0700</creation_ts>
          <short_desc>[Chromium] IndexedDB: API stubs to simplify WebIDBCursor API</short_desc>
          <delta_ts>2012-08-01 16:16:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>92278</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Joshua Bell">jsbell</reporter>
          <assigned_to name="Joshua Bell">jsbell</assigned_to>
          <cc>abarth</cc>
    
    <cc>alecflett</cc>
    
    <cc>dglazkov</cc>
    
    <cc>dgrogan</cc>
    
    <cc>fishd</cc>
    
    <cc>jamesr</cc>
    
    <cc>tkent+wkapi</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>679662</commentid>
    <comment_count>0</comment_count>
    <who name="Joshua Bell">jsbell</who>
    <bug_when>2012-07-26 12:49:26 -0700</bug_when>
    <thetext>[Chromium] IndexedDB: API stubs to simplify WebIDBCursor API</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>679663</commentid>
    <comment_count>1</comment_count>
      <attachid>154724</attachid>
    <who name="Joshua Bell">jsbell</who>
    <bug_when>2012-07-26 12:52:29 -0700</bug_when>
    <thetext>Created attachment 154724
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>679667</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-26 12:55:25 -0700</bug_when>
    <thetext>Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>679675</commentid>
    <comment_count>3</comment_count>
    <who name="Joshua Bell">jsbell</who>
    <bug_when>2012-07-26 12:59:35 -0700</bug_when>
    <thetext>Note that I will NOT be landing this until alecflett@&apos;s in-progress index changes have landed, as they touch similar code.

Full landing sequence is:

(1) WebKit prep: Add new API stubs http://webkit.org/b/92414 (this patch)
(2) Chromium changes: dispatch to old and new API https://chromiumcodereview.appspot.com/10830028
(3) WebKit changes: use the new API http://webkit.org/b/92278
(4) Chromium cleanup: delete old API usage
(5) WebKit changes: delete old API

Wheee.

Questions for reviewers:

* Should I name the two IDBKey arguments? (key and primaryKey)
* Instead of two new WebIDBCallback methods, onSuccess(cursor, key, primaryKey, value) - callback from openCursor(), and onSuccess(key, primaryKey, value) - callback from continue(), I could use the same method for both; passing along the cursor as a callback from continue() would be redundant but not harmful.

dgrogan@, alecflett@ - please take a look</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>679796</commentid>
    <comment_count>4</comment_count>
      <attachid>154759</attachid>
    <who name="Joshua Bell">jsbell</who>
    <bug_when>2012-07-26 15:04:04 -0700</bug_when>
    <thetext>Created attachment 154759
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>679812</commentid>
    <comment_count>5</comment_count>
    <who name="David Grogan">dgrogan</who>
    <bug_when>2012-07-26 15:12:13 -0700</bug_when>
    <thetext>LGTM

(In reply to comment #3)
&gt; * Instead of two new WebIDBCallback methods, onSuccess(cursor, key, primaryKey, value) - callback from openCursor(), and onSuccess(key, primaryKey, value) - callback from continue(), I could use the same method for both; passing along the cursor as a callback from continue() would be redundant but not harmful.

I&apos;d keep them separate but *shrug*.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>679919</commentid>
    <comment_count>6</comment_count>
    <who name="Alec Flett">alecflett</who>
    <bug_when>2012-07-26 16:51:40 -0700</bug_when>
    <thetext>+1 on separate - its hard enough to keep the various onSuccess&apos;s apart as it is :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682506</commentid>
    <comment_count>7</comment_count>
    <who name="Joshua Bell">jsbell</who>
    <bug_when>2012-07-30 16:27:14 -0700</bug_when>
    <thetext>abarth@, fishd@ or others - r?

Note the &quot;full landing sequence&quot; comment for context.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682513</commentid>
    <comment_count>8</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-07-30 16:34:10 -0700</bug_when>
    <thetext>&gt; * Should I name the two IDBKey arguments? (key and primaryKey)

Yeah, generally if you have two arguments of the same type it&apos;s a good idea to give them names so folks can tell them apart.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>683261</commentid>
    <comment_count>9</comment_count>
    <who name="Alec Flett">alecflett</who>
    <bug_when>2012-07-31 10:53:03 -0700</bug_when>
    <thetext>FWIW, the bulk of my changes that should affect this have landed - I&apos;m happy to have this bug sequence start to land and I&apos;ll sort through any leftover conflicts in bug 91125</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>684480</commentid>
    <comment_count>10</comment_count>
      <attachid>154759</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-01 12:43:36 -0700</bug_when>
    <thetext>Comment on attachment 154759
Patch

Rejecting attachment 154759 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string &quot;Unreviewed&quot; or &quot;Rubber stamp&quot; (case insensitive).

Full output: http://queues.webkit.org/results/13410492</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>684511</commentid>
    <comment_count>11</comment_count>
      <attachid>155869</attachid>
    <who name="Joshua Bell">jsbell</who>
    <bug_when>2012-08-01 13:20:22 -0700</bug_when>
    <thetext>Created attachment 155869
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>684733</commentid>
    <comment_count>12</comment_count>
      <attachid>155869</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-01 16:16:06 -0700</bug_when>
    <thetext>Comment on attachment 155869
Patch for landing

Clearing flags on attachment: 155869

Committed r124382: &lt;http://trac.webkit.org/changeset/124382&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>684734</commentid>
    <comment_count>13</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-01 16:16:11 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>154724</attachid>
            <date>2012-07-26 12:52:29 -0700</date>
            <delta_ts>2012-07-26 15:04:00 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-92414-20120726125218.patch</filename>
            <type>text/plain</type>
            <size>3044</size>
            <attacher name="Joshua Bell">jsbell</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IDI3YjU1MmJlNGQ4MWEyYjNhNmNmYmIwZGJjMTY2MDUzYThkZDQ2M2UuLjBjODlhOWM2NjZkOTEy
OTQ0NDRmMDA3ZDU0YjcwZmU0OTJhNzZjMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMjAgQEAKKzIwMTItMDctMjYgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVt
Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEluZGV4ZWREQjogQVBJIHN0dWJzIHRvIHNpbXBs
aWZ5IFdlYklEQkN1cnNvciBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTkyNDE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgUHJlcCB3b3JrIHRvIHVuYmxvY2sgQ2hyb21pdW0gY2hhbmdlcyBzbyB0aGF0
IGh0dHA6Ly93ZWJraXQub3JnL2IvOTIyNzggY2FuIGxhbmQuCisgICAgICAgIEFkZHMgbm8tb3Ag
bWV0aG9kcyB3aGljaCB3aWxsIGxhdGVyIGJlIGltcGxlbWVudGVkOyBkdXJpbmcgdGhlIGxhbmRp
bmcgc2VxdWVuY2UsCisgICAgICAgIENocm9taXVtIHdpbGwgY2FsbCBib3RoIHRoZSBuZXcgbWV0
aG9kcyBhbmQgdGhlIG9sZCBvbmVzLiBUaGUgZW5kIGdvYWwgaXMgdGhhdAorICAgICAgICB0aGUg
c3VjY2VzcyBjYWxsYmFja3MgZm9yIGN1cnNvcnMgd2lsbCBpbmNsdWRlIHRoZSBuZXcga2V5L3By
aW1hcnlLZXkvdmFsdWUgcmF0aGVyCisgICAgICAgIHRoYW4gcmVxdWlyaW5nIHRoZSBjYWxsZWUg
dG8gY2FsbCBiYWNrIGludG8gdGhlIGN1cnNvciBiYWNrZW5kIHRvIGZldGNoIHRoZW0uCisKKyAg
ICAgICAgKiBwdWJsaWMvV2ViSURCQ2FsbGJhY2tzLmg6CisgICAgICAgIChXZWJJREJDYWxsYmFj
a3MpOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJDYWxsYmFja3M6Om9uU3VjY2Vzcyk6CisKIDIw
MTItMDctMjQgIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJvbWl1bS5vcmc+CiAKICAgICAg
ICAgW2Nocm9taXVtXSBSZWZhY3RvciBDQ0xheWVyVHJlZUhvc3RDb21tb246IG1vdmUgcm9vdCBs
YXllciBzcGVjaWFsIGNhc2UgaW5pdGlhbGl6YXRpb24gaW50byBpbnRlcm5hbCBjb2RlLgpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCQ2FsbGJhY2tzLmgg
Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJDYWxsYmFja3MuaAppbmRleCBh
NjNjMGJjOWVlNmM0Y2FmMmQ2N2Q5NWU1ZDAwYTExYzlmY2Q4MjlkLi5jNzI3MjQzN2JjNGQ3MmQw
N2VjZmNmZjgxOTU3OGFkYzFlNTZjNGMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t
aXVtL3B1YmxpYy9XZWJJREJDYWxsYmFja3MuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt
L3B1YmxpYy9XZWJJREJDYWxsYmFja3MuaApAQCAtNTEsMTIgKzUxLDE2IEBAIHB1YmxpYzoKICAg
ICB2aXJ0dWFsIHZvaWQgb25FcnJvcihjb25zdCBXZWJJREJEYXRhYmFzZUVycm9yJikgeyBXRUJL
SVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgb25TdWNjZXNzKGNv
bnN0IFdlYkRPTVN0cmluZ0xpc3QmKSB7IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsgfQog
ICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3MoV2ViSURCQ3Vyc29yKikgeyBXRUJLSVRfQVNTRVJU
X05PVF9SRUFDSEVEKCk7IH0KKyAgICAvLyBGSVhNRTogVGVtcG9yYXJ5IG5vLW9wIG1ldGhvZCB0
byBhbGxvdyBjYWxsZXJzIHRvIHVwZGF0ZSBiZWZvcmUgV0s5MjI3OCBsYW5kcy4KKyAgICB2aXJ0
dWFsIHZvaWQgb25TdWNjZXNzKFdlYklEQkN1cnNvciosIGNvbnN0IFdlYklEQktleSYsIGNvbnN0
IFdlYklEQktleSYsIGNvbnN0IFdlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSYpIHsgfQogICAgIHZp
cnR1YWwgdm9pZCBvblN1Y2Nlc3MoV2ViSURCRGF0YWJhc2UqKSB7IFdFQktJVF9BU1NFUlRfTk9U
X1JFQUNIRUQoKTsgfQogICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3MoY29uc3QgV2ViSURCS2V5
JikgeyBXRUJLSVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgb25T
dWNjZXNzKFdlYklEQlRyYW5zYWN0aW9uKikgeyBXRUJLSVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7
IH0KICAgICB2aXJ0dWFsIHZvaWQgb25TdWNjZXNzKGNvbnN0IFdlYlNlcmlhbGl6ZWRTY3JpcHRW
YWx1ZSYpIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAgICAgdmlydHVhbCB2b2lk
IG9uU3VjY2Vzcyhjb25zdCBXZWJTZXJpYWxpemVkU2NyaXB0VmFsdWUmLCBjb25zdCBXZWJJREJL
ZXkmLCBjb25zdCBXZWJJREJLZXlQYXRoJikgeyBXRUJLSVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7
IH0KICAgICB2aXJ0dWFsIHZvaWQgb25TdWNjZXNzV2l0aENvbnRpbnVhdGlvbigpIHsgV0VCS0lU
X0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CisgICAgLy8gRklYTUU6IFRlbXBvcmFyeSBuby1vcCBt
ZXRob2QgdG8gYWxsb3cgY2FsbGVycyB0byB1cGRhdGUgYmVmb3JlIFdLOTIyNzggbGFuZHMuCisg
ICAgdmlydHVhbCB2b2lkIG9uU3VjY2Vzcyhjb25zdCBXZWJJREJLZXkmLCBjb25zdCBXZWJJREJL
ZXkmLCBjb25zdCBXZWJTZXJpYWxpemVkU2NyaXB0VmFsdWUmKSB7IH0KICAgICB2aXJ0dWFsIHZv
aWQgb25CbG9ja2VkKCkgeyBXRUJLSVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0KICAgICB2aXJ0
dWFsIHZvaWQgb25TdWNjZXNzV2l0aFByZWZldGNoKGNvbnN0IFdlYlZlY3RvcjxXZWJJREJLZXk+
JiBrZXlzLCBjb25zdCBXZWJWZWN0b3I8V2ViSURCS2V5PiYgcHJpbWFyeUtleXMsIGNvbnN0IFdl
YlZlY3RvcjxXZWJTZXJpYWxpemVkU2NyaXB0VmFsdWU+JiB2YWx1ZXMpIHsgV0VCS0lUX0FTU0VS
VF9OT1RfUkVBQ0hFRCgpOyB9CiB9Owo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>154759</attachid>
            <date>2012-07-26 15:04:04 -0700</date>
            <delta_ts>2012-08-01 13:20:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-92414-20120726150352.patch</filename>
            <type>text/plain</type>
            <size>3074</size>
            <attacher name="Joshua Bell">jsbell</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IDI3YjU1MmJlNGQ4MWEyYjNhNmNmYmIwZGJjMTY2MDUzYThkZDQ2M2UuLjBjODlhOWM2NjZkOTEy
OTQ0NDRmMDA3ZDU0YjcwZmU0OTJhNzZjMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMjAgQEAKKzIwMTItMDctMjYgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVt
Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEluZGV4ZWREQjogQVBJIHN0dWJzIHRvIHNpbXBs
aWZ5IFdlYklEQkN1cnNvciBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTkyNDE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgUHJlcCB3b3JrIHRvIHVuYmxvY2sgQ2hyb21pdW0gY2hhbmdlcyBzbyB0aGF0
IGh0dHA6Ly93ZWJraXQub3JnL2IvOTIyNzggY2FuIGxhbmQuCisgICAgICAgIEFkZHMgbm8tb3Ag
bWV0aG9kcyB3aGljaCB3aWxsIGxhdGVyIGJlIGltcGxlbWVudGVkOyBkdXJpbmcgdGhlIGxhbmRp
bmcgc2VxdWVuY2UsCisgICAgICAgIENocm9taXVtIHdpbGwgY2FsbCBib3RoIHRoZSBuZXcgbWV0
aG9kcyBhbmQgdGhlIG9sZCBvbmVzLiBUaGUgZW5kIGdvYWwgaXMgdGhhdAorICAgICAgICB0aGUg
c3VjY2VzcyBjYWxsYmFja3MgZm9yIGN1cnNvcnMgd2lsbCBpbmNsdWRlIHRoZSBuZXcga2V5L3By
aW1hcnlLZXkvdmFsdWUgcmF0aGVyCisgICAgICAgIHRoYW4gcmVxdWlyaW5nIHRoZSBjYWxsZWUg
dG8gY2FsbCBiYWNrIGludG8gdGhlIGN1cnNvciBiYWNrZW5kIHRvIGZldGNoIHRoZW0uCisKKyAg
ICAgICAgKiBwdWJsaWMvV2ViSURCQ2FsbGJhY2tzLmg6CisgICAgICAgIChXZWJJREJDYWxsYmFj
a3MpOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJDYWxsYmFja3M6Om9uU3VjY2Vzcyk6CisKIDIw
MTItMDctMjQgIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJvbWl1bS5vcmc+CiAKICAgICAg
ICAgW2Nocm9taXVtXSBSZWZhY3RvciBDQ0xheWVyVHJlZUhvc3RDb21tb246IG1vdmUgcm9vdCBs
YXllciBzcGVjaWFsIGNhc2UgaW5pdGlhbGl6YXRpb24gaW50byBpbnRlcm5hbCBjb2RlLgpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCQ2FsbGJhY2tzLmgg
Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJDYWxsYmFja3MuaAppbmRleCBh
NjNjMGJjOWVlNmM0Y2FmMmQ2N2Q5NWU1ZDAwYTExYzlmY2Q4MjlkLi42NjM4ZWIxMDIzOGJjNDk1
ZjJkYTFiODJjMTg3NmZiYTU5ZTQyY2M1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t
aXVtL3B1YmxpYy9XZWJJREJDYWxsYmFja3MuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt
L3B1YmxpYy9XZWJJREJDYWxsYmFja3MuaApAQCAtNTEsMTIgKzUxLDE2IEBAIHB1YmxpYzoKICAg
ICB2aXJ0dWFsIHZvaWQgb25FcnJvcihjb25zdCBXZWJJREJEYXRhYmFzZUVycm9yJikgeyBXRUJL
SVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgb25TdWNjZXNzKGNv
bnN0IFdlYkRPTVN0cmluZ0xpc3QmKSB7IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsgfQog
ICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3MoV2ViSURCQ3Vyc29yKikgeyBXRUJLSVRfQVNTRVJU
X05PVF9SRUFDSEVEKCk7IH0KKyAgICAvLyBGSVhNRTogVGVtcG9yYXJ5IG5vLW9wIG1ldGhvZCB0
byBhbGxvdyBjYWxsZXJzIHRvIHVwZGF0ZSBiZWZvcmUgV0s5MjI3OCBsYW5kcy4KKyAgICB2aXJ0
dWFsIHZvaWQgb25TdWNjZXNzKFdlYklEQkN1cnNvciosIGNvbnN0IFdlYklEQktleSYga2V5LCBj
b25zdCBXZWJJREJLZXkmIHByaW1hcnlLZXksIGNvbnN0IFdlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1
ZSYpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3MoV2ViSURCRGF0YWJhc2UqKSB7IFdF
QktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsgfQogICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3Mo
Y29uc3QgV2ViSURCS2V5JikgeyBXRUJLSVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0KICAgICB2
aXJ0dWFsIHZvaWQgb25TdWNjZXNzKFdlYklEQlRyYW5zYWN0aW9uKikgeyBXRUJLSVRfQVNTRVJU
X05PVF9SRUFDSEVEKCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgb25TdWNjZXNzKGNvbnN0IFdlYlNl
cmlhbGl6ZWRTY3JpcHRWYWx1ZSYpIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAg
ICAgdmlydHVhbCB2b2lkIG9uU3VjY2Vzcyhjb25zdCBXZWJTZXJpYWxpemVkU2NyaXB0VmFsdWUm
LCBjb25zdCBXZWJJREJLZXkmLCBjb25zdCBXZWJJREJLZXlQYXRoJikgeyBXRUJLSVRfQVNTRVJU
X05PVF9SRUFDSEVEKCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgb25TdWNjZXNzV2l0aENvbnRpbnVh
dGlvbigpIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CisgICAgLy8gRklYTUU6IFRl
bXBvcmFyeSBuby1vcCBtZXRob2QgdG8gYWxsb3cgY2FsbGVycyB0byB1cGRhdGUgYmVmb3JlIFdL
OTIyNzggbGFuZHMuCisgICAgdmlydHVhbCB2b2lkIG9uU3VjY2Vzcyhjb25zdCBXZWJJREJLZXkm
IGtleSwgY29uc3QgV2ViSURCS2V5JiBwcmltYXJ5S2V5LCBjb25zdCBXZWJTZXJpYWxpemVkU2Ny
aXB0VmFsdWUmKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgb25CbG9ja2VkKCkgeyBXRUJLSVRfQVNT
RVJUX05PVF9SRUFDSEVEKCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgb25TdWNjZXNzV2l0aFByZWZl
dGNoKGNvbnN0IFdlYlZlY3RvcjxXZWJJREJLZXk+JiBrZXlzLCBjb25zdCBXZWJWZWN0b3I8V2Vi
SURCS2V5PiYgcHJpbWFyeUtleXMsIGNvbnN0IFdlYlZlY3RvcjxXZWJTZXJpYWxpemVkU2NyaXB0
VmFsdWU+JiB2YWx1ZXMpIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiB9Owo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>155869</attachid>
            <date>2012-08-01 13:20:22 -0700</date>
            <delta_ts>2012-08-01 16:16:06 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-92414-20120801142004.patch</filename>
            <type>text/plain</type>
            <size>3098</size>
            <attacher name="Joshua Bell">jsbell</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IDk5Yzk1Y2UzMmI0ZDdkNjc4ODI4YzA3ZGFjZDYyNzk5OGQ1MGQ2MGUuLjRjMzJiZTU3YTM1ZjJk
ZjMzMzA3MjdiMDMwYjFhNDM5OGZmNjU1ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMjAgQEAKKzIwMTItMDgtMDEgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVt
Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEluZGV4ZWREQjogQVBJIHN0dWJzIHRvIHNpbXBs
aWZ5IFdlYklEQkN1cnNvciBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTkyNDE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KKwor
ICAgICAgICBQcmVwIHdvcmsgdG8gdW5ibG9jayBDaHJvbWl1bSBjaGFuZ2VzIHNvIHRoYXQgaHR0
cDovL3dlYmtpdC5vcmcvYi85MjI3OCBjYW4gbGFuZC4KKyAgICAgICAgQWRkcyBuby1vcCBtZXRo
b2RzIHdoaWNoIHdpbGwgbGF0ZXIgYmUgaW1wbGVtZW50ZWQ7IGR1cmluZyB0aGUgbGFuZGluZyBz
ZXF1ZW5jZSwKKyAgICAgICAgQ2hyb21pdW0gd2lsbCBjYWxsIGJvdGggdGhlIG5ldyBtZXRob2Rz
IGFuZCB0aGUgb2xkIG9uZXMuIFRoZSBlbmQgZ29hbCBpcyB0aGF0CisgICAgICAgIHRoZSBzdWNj
ZXNzIGNhbGxiYWNrcyBmb3IgY3Vyc29ycyB3aWxsIGluY2x1ZGUgdGhlIG5ldyBrZXkvcHJpbWFy
eUtleS92YWx1ZSByYXRoZXIKKyAgICAgICAgdGhhbiByZXF1aXJpbmcgdGhlIGNhbGxlZSB0byBj
YWxsIGJhY2sgaW50byB0aGUgY3Vyc29yIGJhY2tlbmQgdG8gZmV0Y2ggdGhlbS4KKworICAgICAg
ICAqIHB1YmxpYy9XZWJJREJDYWxsYmFja3MuaDoKKyAgICAgICAgKFdlYklEQkNhbGxiYWNrcyk6
CisgICAgICAgIChXZWJLaXQ6OldlYklEQkNhbGxiYWNrczo6b25TdWNjZXNzKToKKwogMjAxMi0w
Ny0zMSAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtD
aHJvbWl1bV0gRW5hYmxlIEVOQUJMRV9JTlBVVF9UWVBFX1RJTUVfTVVMVElQTEVfRklFTERTCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJDYWxsYmFja3Mu
aCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQkNhbGxiYWNrcy5oCmluZGV4
IGNlMTAwZjI5NTY1ZGQyMzE3YzQ3ZWZkOTViZjUyNzcyYWUzNmUzYTUuLjY1NWIwMDllMDFhYTNi
Y2U5ZDYyMDkwZDAyNDkwOWM0NDU5ZTBmOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vcHVibGljL1dlYklEQkNhbGxiYWNrcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p
dW0vcHVibGljL1dlYklEQkNhbGxiYWNrcy5oCkBAIC01MSwxMiArNTEsMTYgQEAgcHVibGljOgog
ICAgIHZpcnR1YWwgdm9pZCBvbkVycm9yKGNvbnN0IFdlYklEQkRhdGFiYXNlRXJyb3ImKSB7IFdF
QktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsgfQogICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3Mo
Y29uc3QgV2ViRE9NU3RyaW5nTGlzdCYpIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9
CiAgICAgdmlydHVhbCB2b2lkIG9uU3VjY2VzcyhXZWJJREJDdXJzb3IqKSB7IFdFQktJVF9BU1NF
UlRfTk9UX1JFQUNIRUQoKTsgfQorICAgIC8vIEZJWE1FOiBUZW1wb3Jhcnkgbm8tb3AgbWV0aG9k
IHRvIGFsbG93IGNhbGxlcnMgdG8gdXBkYXRlIGJlZm9yZSBXSzkyMjc4IGxhbmRzLgorICAgIHZp
cnR1YWwgdm9pZCBvblN1Y2Nlc3MoV2ViSURCQ3Vyc29yKiwgY29uc3QgV2ViSURCS2V5JiBrZXks
IGNvbnN0IFdlYklEQktleSYgcHJpbWFyeUtleSwgY29uc3QgV2ViU2VyaWFsaXplZFNjcmlwdFZh
bHVlJikgeyB9CiAgICAgdmlydHVhbCB2b2lkIG9uU3VjY2VzcyhXZWJJREJEYXRhYmFzZSopIHsg
V0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAgICAgdmlydHVhbCB2b2lkIG9uU3VjY2Vz
cyhjb25zdCBXZWJJREJLZXkmKSB7IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsgfQogICAg
IHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3MoV2ViSURCVHJhbnNhY3Rpb24qKSB7IFdFQktJVF9BU1NF
UlRfTk9UX1JFQUNIRUQoKTsgfQogICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3MoY29uc3QgV2Vi
U2VyaWFsaXplZFNjcmlwdFZhbHVlJikgeyBXRUJLSVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0K
ICAgICB2aXJ0dWFsIHZvaWQgb25TdWNjZXNzKGNvbnN0IFdlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1
ZSYsIGNvbnN0IFdlYklEQktleSYsIGNvbnN0IFdlYklEQktleVBhdGgmKSB7IFdFQktJVF9BU1NF
UlRfTk9UX1JFQUNIRUQoKTsgfQogICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3NXaXRoQ29udGlu
dWF0aW9uKCkgeyBXRUJLSVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0KKyAgICAvLyBGSVhNRTog
VGVtcG9yYXJ5IG5vLW9wIG1ldGhvZCB0byBhbGxvdyBjYWxsZXJzIHRvIHVwZGF0ZSBiZWZvcmUg
V0s5MjI3OCBsYW5kcy4KKyAgICB2aXJ0dWFsIHZvaWQgb25TdWNjZXNzKGNvbnN0IFdlYklEQktl
eSYga2V5LCBjb25zdCBXZWJJREJLZXkmIHByaW1hcnlLZXksIGNvbnN0IFdlYlNlcmlhbGl6ZWRT
Y3JpcHRWYWx1ZSYpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBvbkJsb2NrZWQoKSB7IFdFQktJVF9B
U1NFUlRfTk9UX1JFQUNIRUQoKTsgfQogICAgIHZpcnR1YWwgdm9pZCBvbkJsb2NrZWQobG9uZyBs
b25nIG9sZFZlcnNpb24pIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAgICAgdmly
dHVhbCB2b2lkIG9uU3VjY2Vzc1dpdGhQcmVmZXRjaChjb25zdCBXZWJWZWN0b3I8V2ViSURCS2V5
PiYga2V5cywgY29uc3QgV2ViVmVjdG9yPFdlYklEQktleT4mIHByaW1hcnlLZXlzLCBjb25zdCBX
ZWJWZWN0b3I8V2ViU2VyaWFsaXplZFNjcmlwdFZhbHVlPiYgdmFsdWVzKSB7IFdFQktJVF9BU1NF
UlRfTk9UX1JFQUNIRUQoKTsgfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>