92403 2012-07-26 11:22:54 -0700 [BlackBerry] InputHandler failure logs should be logAlways and critical. 2012-07-26 13:02:32 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton tonikitoo webkit.review.bot oldest_to_newest 679556 0 mifenton 2012-07-26 11:22:54 -0700 SSIA. 679572 1 154699 mifenton 2012-07-26 11:30:21 -0700 Created attachment 154699 Patch 679590 2 154699 rwlbuis 2012-07-26 11:40:50 -0700 Comment on attachment 154699 Patch LGTM. 679678 3 154699 webkit.review.bot 2012-07-26 13:02:29 -0700 Comment on attachment 154699 Patch Clearing flags on attachment: 154699 Committed r123784: <http://trac.webkit.org/changeset/123784> 679679 4 webkit.review.bot 2012-07-26 13:02:32 -0700 All reviewed patches have been landed. Closing bug. 154699 2012-07-26 11:30:21 -0700 2012-07-26 13:02:29 -0700 Patch 0001-2012-07-26-Mike-Fenton-mifenton-rim.com.patch text/plain 6004 mifenton RnJvbSA5MGEwYzYwZTI5NDUyOWI5ZTUwNDFiZDI2YTQ2MGM3OGIyMWY5YWJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VGh1LCAyNiBKdWwgMjAxMiAxMjoxMDoyMiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDct MjYgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgVXBkYXRlIExvZyBs ZXZlbCBmb3IgZmFpbHVyZXMgYW5kIGZpeCBtYXNrIGluIGxvZy4KCiAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIu Y3BwOgogICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OklucHV0SGFuZGxlcjo6c3Bhbm5hYmxl VGV4dEluUmFuZ2UpOgogICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OklucHV0SGFuZGxlcjo6 c2V0VGV4dEF0dHJpYnV0ZXMpOgotLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM b2cgICAgICAgICAgICAgICAgIHwgICAxOCArKysrKysrKysrKysrKysrKysKIC4uLi9ibGFja2Jl cnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcCAgICAgIHwgICAxNSArKysrKysrKy0t LS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCA4NDNkMWYyLi5jMzkzZTFjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0wNy0yNiAg TWlrZSBGZW50b24gIDxtaWZlbnRvbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBJ bnB1dEhhbmRsZXIgZmFpbHVyZSBsb2dzIHNob3VsZCBiZSBsb2dBbHdheXMgYW5kIGNyaXRpY2Fs LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI0MDMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUg TG9nIGxldmVsIGZvciBmYWlsdXJlcyBhbmQgZml4IG1hc2sgaW4gbG9nLgorCisgICAgICAgIFJl dmlld2VkIEludGVybmFsbHkgYnkgTmltYSBHaGFuYXZhdGlhbi4KKworICAgICAgICAqIFdlYktp dFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6 Y29udmVydFN0cmluZ1RvV2NoYXIpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0Ojpjb252 ZXJ0U3RyaW5nVG9XY2hhclZlY3Rvcik6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OmNv bnZlcnRTcGFubmFibGVTdHJpbmdUb1N0cmluZyk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJL aXQ6OklucHV0SGFuZGxlcjo6c3Bhbm5hYmxlVGV4dEluUmFuZ2UpOgorICAgICAgICAoQmxhY2tC ZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6OnNldFRleHRBdHRyaWJ1dGVzKToKKwogMjAxMi0w Ny0yNiAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29uQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNr QmVycnldIFJlZmFjdG9yIEJhY2tpbmdTdG9yZVByaXZhdGU6OkJhY2tpbmdTdG9yZVByaXZhdGU6 OmNsZWFyQW5kVXBkYXRlVGlsZU9mTm90UmVuZGVyZWRSZWdpb24oKSB0byBhdm9pZCB0b3VjaGlu ZyB0aWxlIGZyb250YnVmZmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv V2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAppbmRleCBlYzFkYjBmLi5iZmI2MjI2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhh bmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lu cHV0SGFuZGxlci5jcHAKQEAgLTQzMyw3ICs0MzMsNyBAQCBzdGF0aWMgYm9vbCBjb252ZXJ0U3Ry aW5nVG9XY2hhcihjb25zdCBTdHJpbmcmIHN0cmluZywgd2NoYXJfdCogZGVzdCwgaW50IGRlc3RD YQogICAgIC8vIHdjaGFyX3Qgc3RyaW5ncyBzZW50IHRvIElNRiBhcmUgMzIgYml0IHNvIGNhc3Rp bmcgdG8gVUNoYXIzMiBpcyBzYWZlLgogICAgIHVfc3RyVG9VVEYzMihyZWludGVycHJldF9jYXN0 PFVDaGFyMzIqPihkZXN0KSwgZGVzdENhcGFjaXR5LCBkZXN0TGVuZ3RoLCBzdHJpbmcuY2hhcmFj dGVycygpLCBzdHJpbmcubGVuZ3RoKCksICZlYyk7CiAgICAgaWYgKGVjKSB7Ci0gICAgICAgIElu cHV0TG9nKExvZ0xldmVsSW5mbywgIklucHV0SGFuZGxlcjo6Y29udmVydFN0cmluZ1RvV2NoYXIg RXJyb3IgY29udmVydGluZyBzdHJpbmcgZWMgKCVkKS4iLCBlYyk7CisgICAgICAgIGxvZ0Fsd2F5 cyhMb2dMZXZlbENyaXRpY2FsLCAiSW5wdXRIYW5kbGVyOjpjb252ZXJ0U3RyaW5nVG9XY2hhciBF cnJvciBjb252ZXJ0aW5nIHN0cmluZyBlYyAoJWQpLiIsIGVjKTsKICAgICAgICAgZGVzdExlbmd0 aCA9IDA7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CkBAIC00NDksNyArNDQ5LDcgQEAg c3RhdGljIGJvb2wgY29udmVydFN0cmluZ1RvV2NoYXJWZWN0b3IoY29uc3QgU3RyaW5nJiBzdHJp bmcsIFdURjo6VmVjdG9yPHdjaGFyX3QKICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICBpZiAo IXdjaGFyU3RyaW5nLnRyeVJlc2VydmVDYXBhY2l0eShsZW5ndGggKyAxKSkgewotICAgICAgICBs b2dBbHdheXMoTG9nTGV2ZWxXYXJuLCAiSW5wdXRIYW5kbGVyOjpjb252ZXJ0U3RyaW5nVG9XY2hh clZlY3RvciBDYW5ub3QgYWxsb2NhdGUgbWVtb3J5IGZvciBzdHJpbmcuXG4iKTsKKyAgICAgICAg bG9nQWx3YXlzKExvZ0xldmVsQ3JpdGljYWwsICJJbnB1dEhhbmRsZXI6OmNvbnZlcnRTdHJpbmdU b1djaGFyVmVjdG9yIENhbm5vdCBhbGxvY2F0ZSBtZW1vcnkgZm9yIHN0cmluZy5cbiIpOwogICAg ICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCkBAIC00NjksNyArNDY5LDcgQEAgc3RhdGljIFN0 cmluZyBjb252ZXJ0U3Bhbm5hYmxlU3RyaW5nVG9TdHJpbmcoc3Bhbm5hYmxlX3N0cmluZ190KiBz cmMpCiAgICAgV1RGOjpWZWN0b3I8VUNoYXI+IGRlc3Q7CiAgICAgaW50IGRlc3RDYXBhY2l0eSA9 IChzcmMtPmxlbmd0aCAqIDIpICsgMTsKICAgICBpZiAoIWRlc3QudHJ5UmVzZXJ2ZUNhcGFjaXR5 KGRlc3RDYXBhY2l0eSkpIHsKLSAgICAgICAgbG9nQWx3YXlzKExvZ0xldmVsV2FybiwgIklucHV0 SGFuZGxlcjo6Y29udmVydFNwYW5uYWJsZVN0cmluZ1RvU3RyaW5nIENhbm5vdCBhbGxvY2F0ZSBt ZW1vcnkgZm9yIHN0cmluZy5cbiIpOworICAgICAgICBsb2dBbHdheXMoTG9nTGV2ZWxDcml0aWNh bCwgIklucHV0SGFuZGxlcjo6Y29udmVydFNwYW5uYWJsZVN0cmluZ1RvU3RyaW5nIENhbm5vdCBh bGxvY2F0ZSBtZW1vcnkgZm9yIHN0cmluZy5cbiIpOwogICAgICAgICByZXR1cm4gU3RyaW5nKCk7 CiAgICAgfQogCkBAIC00NzgsNyArNDc4LDcgQEAgc3RhdGljIFN0cmluZyBjb252ZXJ0U3Bhbm5h YmxlU3RyaW5nVG9TdHJpbmcoc3Bhbm5hYmxlX3N0cmluZ190KiBzcmMpCiAgICAgLy8gd2NoYXJf dCBzdHJpbmdzIHNlbnQgZnJvbSBJTUYgYXJlIDMyIGJpdCBzbyBjYXN0aW5nIHRvIFVDaGFyMzIg aXMgc2FmZS4KICAgICB1X3N0ckZyb21VVEYzMihkZXN0LmRhdGEoKSwgZGVzdENhcGFjaXR5LCAm ZGVzdExlbmd0aCwgcmVpbnRlcnByZXRfY2FzdDxVQ2hhcjMyKj4oc3JjLT5zdHIpLCBzcmMtPmxl bmd0aCwgJmVjKTsKICAgICBpZiAoZWMpIHsKLSAgICAgICAgSW5wdXRMb2coTG9nTGV2ZWxJbmZv LCAiSW5wdXRIYW5kbGVyOjpjb252ZXJ0U3Bhbm5hYmxlU3RyaW5nVG9TdHJpbmcgRXJyb3IgY29u dmVydGluZyBzdHJpbmcgZWMgKCVkKS4iLCBlYyk7CisgICAgICAgIGxvZ0Fsd2F5cyhMb2dMZXZl bENyaXRpY2FsLCAiSW5wdXRIYW5kbGVyOjpjb252ZXJ0U3Bhbm5hYmxlU3RyaW5nVG9TdHJpbmcg RXJyb3IgY29udmVydGluZyBzdHJpbmcgZWMgKCVkKS4iLCBlYyk7CiAgICAgICAgIHJldHVybiBT dHJpbmcoKTsKICAgICB9CiAgICAgZGVzdC5yZXNpemUoZGVzdExlbmd0aCk7CkBAIC0xNDcxLDE5 ICsxNDcxLDIwIEBAIHNwYW5uYWJsZV9zdHJpbmdfdCogSW5wdXRIYW5kbGVyOjpzcGFubmFibGVU ZXh0SW5SYW5nZShpbnQgc3RhcnQsIGludCBlbmQsIGludDMyCiAKICAgICBzcGFubmFibGVfc3Ry aW5nX3QqIHBzdCA9IChzcGFubmFibGVfc3RyaW5nX3QqKW1hbGxvYyhzaXplb2Yoc3Bhbm5hYmxl X3N0cmluZ190KSk7CiAgICAgaWYgKCFwc3QpIHsKLSAgICAgICAgSW5wdXRMb2coTG9nTGV2ZWxJ bmZvLCAiSW5wdXRIYW5kbGVyOjpzcGFubmFibGVUZXh0SW5SYW5nZSBlcnJvciBhbGxvY2F0aW5n IHNwYW5uYWJsZSBzdHJpbmcuIik7CisgICAgICAgIGxvZ0Fsd2F5cyhMb2dMZXZlbENyaXRpY2Fs LCAiSW5wdXRIYW5kbGVyOjpzcGFubmFibGVUZXh0SW5SYW5nZSBlcnJvciBhbGxvY2F0aW5nIHNw YW5uYWJsZSBzdHJpbmcuIik7CiAgICAgICAgIHJldHVybiAwOwogICAgIH0KIAogICAgIHBzdC0+ c3RyID0gKHdjaGFyX3QqKW1hbGxvYyhzaXplb2Yod2NoYXJfdCkgKiAobGVuZ3RoICsgMSkpOwog ICAgIGlmICghcHN0LT5zdHIpIHsKLSAgICAgICAgSW5wdXRMb2coTG9nTGV2ZWxJbmZvLCAiSW5w dXRIYW5kbGVyOjpzcGFubmFibGVUZXh0SW5SYW5nZSBDYW5ub3QgYWxsb2NhdGUgbWVtb3J5IGZv ciBzdHJpbmcuXG4iKTsKKyAgICAgICAgbG9nQWx3YXlzKExvZ0xldmVsQ3JpdGljYWwsICJJbnB1 dEhhbmRsZXI6OnNwYW5uYWJsZVRleHRJblJhbmdlIENhbm5vdCBhbGxvY2F0ZSBtZW1vcnkgZm9y IHN0cmluZy5cbiIpOwogICAgICAgICBmcmVlKHBzdCk7CiAgICAgICAgIHJldHVybiAwOwogICAg IH0KIAogICAgIGludCBzdHJpbmdMZW5ndGggPSAwOwogICAgIGlmICghY29udmVydFN0cmluZ1Rv V2NoYXIodGV4dFN0cmluZywgcHN0LT5zdHIsIGxlbmd0aCArIDEsICZzdHJpbmdMZW5ndGgpKSB7 CisgICAgICAgIGxvZ0Fsd2F5cyhMb2dMZXZlbENyaXRpY2FsLCAiSW5wdXRIYW5kbGVyOjpzcGFu bmFibGVUZXh0SW5SYW5nZSBmYWlsZWQgdG8gY29udmVydCBzdHJpbmcuXG4iKTsKICAgICAgICAg ZnJlZShwc3QtPnN0cik7CiAgICAgICAgIGZyZWUocHN0KTsKICAgICAgICAgcmV0dXJuIDA7CkBA IC0xNzkwLDcgKzE3OTEsNyBAQCBib29sIElucHV0SGFuZGxlcjo6c2V0VGV4dEF0dHJpYnV0ZXMo aW50IGluc2VydGlvblBvaW50LCBzcGFubmFibGVfc3RyaW5nX3QqIHNwYQogICAgICAgICAvLyB1 c2VkIGJ5IElNRi4gV2hlbiB0aGV5IGFkZCBzdXBwb3J0IGZvciBvbiB0aGUgZmx5IHNwZWxsIGNo ZWNraW5nIHdlIGNhbgogICAgICAgICAvLyB1c2UgaXQgdG8gYXBwbHkgc3BlbGxpbmcgbWFya2Vy cyBhbmQgZGlzYWJsZSBjb250aW51b3VzIHNwZWxsIGNoZWNraW5nLgogCi0gICAgICAgIElucHV0 TG9nKExvZ0xldmVsSW5mbywgIklucHV0SGFuZGxlcjo6c2V0VGV4dEF0dHJpYnV0ZXMgYWRkaW5n IG1hcmtlciAlZCB0byAlZCAtICVkIiwgc3RhcnRQb3NpdGlvbiwgZW5kUG9zaXRpb24sIHNwYW4t PmF0dHJpYnV0ZXNfbWFzayk7CisgICAgICAgIElucHV0TG9nKExvZ0xldmVsSW5mbywgIklucHV0 SGFuZGxlcjo6c2V0VGV4dEF0dHJpYnV0ZXMgYWRkaW5nIG1hcmtlciAlZCB0byAlZCAtICVsbHUi LCBzdGFydFBvc2l0aW9uLCBlbmRQb3NpdGlvbiwgc3Bhbi0+YXR0cmlidXRlc19tYXNrKTsKICAg ICAgICAgYWRkQXR0cmlidXRlZFRleHRNYXJrZXIoc3RhcnRQb3NpdGlvbiwgZW5kUG9zaXRpb24s IHRleHRTdHlsZUZyb21NYXNrKHNwYW4tPmF0dHJpYnV0ZXNfbWFzaykpOwogCiAgICAgICAgIHNw YW4rKzsKLS0gCjEuNy45LjUKCg==