92393 2012-07-26 10:11:49 -0700 Build broken when svg is disabled. 2013-01-25 11:13:42 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cshu cshu eric koivisto webkit.review.bot zimmermann oldest_to_newest 679463 0 cshu 2012-07-26 10:11:49 -0700 Source/WebCore/rendering/FilterEffectRenderer.cpp does not compile when the following command is issued: Tools/Scripts/build-webkit --no-svg --no-svg-fonts --no-svg-dom-objc-bindings 679465 1 154680 cshu 2012-07-26 10:14:26 -0700 Created attachment 154680 surpress unused parameters warning. 679491 2 154680 laszlo.gombos 2012-07-26 10:39:42 -0700 Comment on attachment 154680 surpress unused parameters warning. r=me. 679630 3 154680 webkit.review.bot 2012-07-26 12:10:34 -0700 Comment on attachment 154680 surpress unused parameters warning. Clearing flags on attachment: 154680 Committed r123781: <http://trac.webkit.org/changeset/123781> 679631 4 webkit.review.bot 2012-07-26 12:10:38 -0700 All reviewed patches have been landed. Closing bug. 816622 5 cshu 2013-01-25 08:34:41 -0800 build is broken again when svg is disabled. 816624 6 184759 cshu 2013-01-25 08:36:05 -0800 Created attachment 184759 fix patch 816629 7 184759 webkit.review.bot 2013-01-25 08:43:50 -0800 Comment on attachment 184759 fix patch Rejecting attachment 184759 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'validate-changelog', '--non-interactive', 184759, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16121415 816646 8 184763 cshu 2013-01-25 09:21:29 -0800 Created attachment 184763 fix patch 816658 9 184763 eric 2013-01-25 09:35:57 -0800 Comment on attachment 184763 fix patch View in context: https://bugs.webkit.org/attachment.cgi?id=184763&action=review > Source/WebCore/css/StyleResolver.cpp:4110 > -#if ENABLE(SVG) > default: > +#if ENABLE(SVG) This part should not be needed. We're missing some non-svg properties from this list which are being masked by the presence of applySVGProperty. :( 816659 10 eric 2013-01-25 09:36:40 -0800 I'm not saying it's your fault. But the build break for non-svg is just being masked in teh SVG case, and is a real bug. 816692 11 koivisto 2013-01-25 10:00:35 -0800 I would be nice to get rid of the no-SVG build entirely. I guess everyone ships it. 816696 12 eric 2013-01-25 10:02:59 -0800 before SVG came along, all CSS properties were handled in applyProperty(). For various reasons, SVG property handling was made separate in svgApplyProperty, but they share in enum, thus we had to add that default: clause. Now, since SVG has been enabled for so long, someone must have added a new proprty and failed to support it in applyProperty like they should. We didn't catch it, because both applyProperty and applySVGPrperty use default: clauses since neither of them can handle the whole list of properties in their switch. :( 816711 13 184763 webkit.review.bot 2013-01-25 10:12:37 -0800 Comment on attachment 184763 fix patch Clearing flags on attachment: 184763 Committed r140845: <http://trac.webkit.org/changeset/140845> 816712 14 webkit.review.bot 2013-01-25 10:12:41 -0800 All reviewed patches have been landed. Closing bug. 816772 15 cshu 2013-01-25 11:13:42 -0800 (In reply to comment #12) > before SVG came along, all CSS properties were handled in applyProperty(). For various reasons, SVG property handling was made separate in svgApplyProperty, but they share in enum, thus we had to add that default: clause. Now, since SVG has been enabled for so long, someone must have added a new proprty and failed to support it in applyProperty like they should. We didn't catch it, because both applyProperty and applySVGPrperty use default: clauses since neither of them can handle the whole list of properties in their switch. :( I agree with you guys. The correct way for the switch should be: case <a non-svg case>: blah-blah; #if ENABLE(SVG) case <a svg case>: blah-blah; #endif default: assert(0); But my fix at least didn't introduce new bugs. :) I just wanted to commit it so I don't have to patch it every time. Thanks. 154680 2012-07-26 10:14:26 -0700 2012-07-26 12:10:34 -0700 surpress unused parameters warning. 92393_1.patch text/plain 1155 cshu ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZTVmMzdjLi42N2Q3NDZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDctMjYgIENoYW5nIFNodSAgPGNzaHVAd2Via2l0Lm9yZz4KKworICAgICAgICBC dWlsZCBicm9rZW4gd2hlbiBzdmcgaXMgZGlzYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjM5My4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZWVkIHRvIHN1cnByZXNzIHVudXNlZCBwYXJhbWV0 ZXJzIHdhcm5pbmcuCisKKyAgICAgICAgKiByZW5kZXJpbmcvRmlsdGVyRWZmZWN0UmVuZGVyZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RmlsdGVyRWZmZWN0UmVuZGVyZXI6OmJ1aWxkUmVmZXJl bmNlRmlsdGVyKToKKwogMjAxMi0wNy0yNiAgSm9zaHVhIE5ldHRlcmZpZWxkICA8am5ldHRlcmZp ZWxkQHJpbS5jb20+CiAKICAgICAgICAgW1dlYkdMXSBBTkdMRVdlYktpdEJyaWRnZSBzaG91bGQg c3VwcG9ydCBFU1NMIHBsYXRmb3JtcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL0ZpbHRlckVmZmVjdFJlbmRlcmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9G aWx0ZXJFZmZlY3RSZW5kZXJlci5jcHAKaW5kZXggMTFjZjVmNS4uNjc0ODYxZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0ZpbHRlckVmZmVjdFJlbmRlcmVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmlsdGVyRWZmZWN0UmVuZGVyZXIuY3BwCkBAIC0x NjEsNiArMTYxLDkgQEAgUGFzc1JlZlB0cjxGaWx0ZXJFZmZlY3Q+IEZpbHRlckVmZmVjdFJlbmRl cmVyOjpidWlsZFJlZmVyZW5jZUZpbHRlcihEb2N1bWVudCogZG8KICAgICB9CiAgICAgcmV0dXJu IGVmZmVjdDsKICNlbHNlCisgICAgVU5VU0VEX1BBUkFNKGRvY3VtZW50KTsKKyAgICBVTlVTRURf UEFSQU0ocHJldmlvdXNFZmZlY3QpOworICAgIFVOVVNFRF9QQVJBTShvcCk7CiAgICAgcmV0dXJu IDA7CiAjZW5kaWYKIH0K 184759 2013-01-25 08:36:05 -0800 2013-01-25 09:21:29 -0800 fix patch 92393_2.patch text/plain 1725 cshu ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZjM0YTNhLi4xYWMyNmFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDEtMjUgIENoYW5nIFNodSAgPGNzaHVAd2Via2l0Lm9yZz4KKworICAgICAgICBC dWlsZCBicm9rZW4gd2hlbiBzdmcgaXMgZGlzYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjM5My4KKworICAgICAgICBCdWlsZCBmaXguIE5v IHJldmlldyBuZWVkZWQuCisKKyAgICAgICAgKiBjc3MvU3R5bGVSZXNvbHZlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjphcHBseVByb3BlcnR5KToKKyAgICAgICAgKiBy ZW5kZXJpbmcvRmlsdGVyRWZmZWN0UmVuZGVyZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rmls dGVyRWZmZWN0UmVuZGVyZXI6OmJ1aWxkUmVmZXJlbmNlRmlsdGVyKToKKwogMjAxMy0wMS0yNSAg QW5kcmV5IEx1c2huaWtvdiAgPGx1c2huaWtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogaGlnaGxpZ2h0IG9jY3VyZW5jZXMgb2Ygd29yZCBpbiBEZWZhdWx0VGV4dEVk aXRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCmluZGV4IGIyNjNkODAuLjM3MTc1 MTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKQEAgLTQxMDYsMTIgKzQxMDYs MTIgQEAgdm9pZCBTdHlsZVJlc29sdmVyOjphcHBseVByb3BlcnR5KENTU1Byb3BlcnR5SUQgaWQs IENTU1ZhbHVlKiB2YWx1ZSkKICNlbmRpZgogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK ICAgICAgICAgcmV0dXJuOwotI2lmIEVOQUJMRShTVkcpCiAgICAgZGVmYXVsdDoKKyNpZiBFTkFC TEUoU1ZHKQogICAgICAgICAvLyBUcnkgdGhlIFNWRyBwcm9wZXJ0aWVzCiAgICAgICAgIGFwcGx5 U1ZHUHJvcGVydHkoaWQsIHZhbHVlKTsKLSAgICAgICAgcmV0dXJuOwogI2VuZGlmCisgICAgICAg IHJldHVybjsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9GaWx0ZXJFZmZlY3RSZW5kZXJlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmls dGVyRWZmZWN0UmVuZGVyZXIuY3BwCmluZGV4IDk2NDM1ZjkuLmRlYTJlZjAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GaWx0ZXJFZmZlY3RSZW5kZXJlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0ZpbHRlckVmZmVjdFJlbmRlcmVyLmNwcApAQCAtMTgy LDYgKzE4Miw3IEBAIFBhc3NSZWZQdHI8RmlsdGVyRWZmZWN0PiBGaWx0ZXJFZmZlY3RSZW5kZXJl cjo6YnVpbGRSZWZlcmVuY2VGaWx0ZXIoUmVuZGVyT2JqZWN0CiAgICAgfQogICAgIHJldHVybiBl ZmZlY3Q7CiAjZWxzZQorICAgIFVOVVNFRF9QQVJBTShyZW5kZXJlcik7CiAgICAgVU5VU0VEX1BB UkFNKHByZXZpb3VzRWZmZWN0KTsKICAgICBVTlVTRURfUEFSQU0oZmlsdGVyT3BlcmF0aW9uKTsK ICAgICByZXR1cm4gMDsK 184763 2013-01-25 09:21:29 -0800 2013-01-25 10:12:37 -0800 fix patch 92393_3.patch text/plain 1718 cshu ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZjM0YTNhLi4xNmFkY2UxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDEtMjUgIENoYW5nIFNodSAgPGNzaHVAd2Via2l0Lm9yZz4KKworICAgICAgICBC dWlsZCBicm9rZW4gd2hlbiBzdmcgaXMgZGlzYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjM5My4KKworICAgICAgICBVbnJldmlld2VkIGJ1 aWxkIGZpeC4KKworICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlN0eWxlUmVzb2x2ZXI6OmFwcGx5UHJvcGVydHkpOgorICAgICAgICAqIHJlbmRlcmlu Zy9GaWx0ZXJFZmZlY3RSZW5kZXJlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGaWx0ZXJFZmZl Y3RSZW5kZXJlcjo6YnVpbGRSZWZlcmVuY2VGaWx0ZXIpOgorCiAyMDEzLTAxLTI1ICBBbmRyZXkg THVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBoaWdobGlnaHQgb2NjdXJlbmNlcyBvZiB3b3JkIGluIERlZmF1bHRUZXh0RWRpdG9yCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKaW5kZXggYjI2M2Q4MC4uMzcxNzUxNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApAQCAtNDEwNiwxMiArNDEwNiwxMiBAQCB2 b2lkIFN0eWxlUmVzb2x2ZXI6OmFwcGx5UHJvcGVydHkoQ1NTUHJvcGVydHlJRCBpZCwgQ1NTVmFs dWUqIHZhbHVlKQogI2VuZGlmCiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAg ICByZXR1cm47Ci0jaWYgRU5BQkxFKFNWRykKICAgICBkZWZhdWx0OgorI2lmIEVOQUJMRShTVkcp CiAgICAgICAgIC8vIFRyeSB0aGUgU1ZHIHByb3BlcnRpZXMKICAgICAgICAgYXBwbHlTVkdQcm9w ZXJ0eShpZCwgdmFsdWUpOwotICAgICAgICByZXR1cm47CiAjZW5kaWYKKyAgICAgICAgcmV0dXJu OwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0ZpbHRl ckVmZmVjdFJlbmRlcmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GaWx0ZXJFZmZl Y3RSZW5kZXJlci5jcHAKaW5kZXggOTY0MzVmOS4uZGVhMmVmMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL0ZpbHRlckVmZmVjdFJlbmRlcmVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvRmlsdGVyRWZmZWN0UmVuZGVyZXIuY3BwCkBAIC0xODIsNiArMTgy LDcgQEAgUGFzc1JlZlB0cjxGaWx0ZXJFZmZlY3Q+IEZpbHRlckVmZmVjdFJlbmRlcmVyOjpidWls ZFJlZmVyZW5jZUZpbHRlcihSZW5kZXJPYmplY3QKICAgICB9CiAgICAgcmV0dXJuIGVmZmVjdDsK ICNlbHNlCisgICAgVU5VU0VEX1BBUkFNKHJlbmRlcmVyKTsKICAgICBVTlVTRURfUEFSQU0ocHJl dmlvdXNFZmZlY3QpOwogICAgIFVOVVNFRF9QQVJBTShmaWx0ZXJPcGVyYXRpb24pOwogICAgIHJl dHVybiAwOwo=