92385 2012-07-26 08:28:26 -0700 Web Inspector: element tag disappears after editing 2012-07-30 02:25:42 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 caseq pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 679360 0 caseq 2012-07-26 08:28:26 -0700 0. Navigate to http://webkit.org 1. Open Web Inspector 2. Switch to Elements panel 3. Double-click on any element (e.g. <div id="title" ...>") 4. Edit attribute (e.g. add an attribute) 5. Press Enter 6. Observe that the element tag is replaced with whitespace. 7. Hover mouse over where the tag used to be -- observe it's visible again. 679460 1 154678 pfeldman 2012-07-26 10:09:28 -0700 Created attachment 154678 Patch 680205 2 154678 vsevik 2012-07-27 00:35:04 -0700 Comment on attachment 154678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154678&action=review > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:2041 > + var hidePanelWhileUpdating = this._recentlyModifiedNodes.length > 10; Please extract a const here. 681797 3 154678 webkit.review.bot 2012-07-30 02:25:38 -0700 Comment on attachment 154678 Patch Clearing flags on attachment: 154678 Committed r124007: <http://trac.webkit.org/changeset/124007> 681798 4 webkit.review.bot 2012-07-30 02:25:42 -0700 All reviewed patches have been landed. Closing bug. 154678 2012-07-26 10:09:28 -0700 2012-07-30 02:25:37 -0700 Patch bug-92385-20120726210916.patch text/plain 2954 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmI1YTI1NTg2MjAwZDRh YmVkZGJlNzgzYTdmM2Y5ZWFiNGQ1ZTQ0Ny4uYmRhNWI5YTk1NzEwNjI1NTk0NWQ5YWIwNWI0NzJj ZmU3NjMyMGU5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA3LTI2ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGVsZW1lbnQgdGFnIGRpc2FwcGVhcnMgYWZ0ZXIgZWRpdGluZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIzODUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGhhcyByZWdyZXNzZWQgd2hlbiB3 ZSBzdGFydGVkIGhpZGluZyBlbGVtZW50cyBwYW5lbCB1cG9uCisgICAgICAgIGJhdGNoIHVwZGF0 ZXMuIE5hcnJvd2luZyBoaWRpbmcgY2FzZXMsIHVwZGF0aW5nIHNlbGVjdGlvbgorICAgICAgICBp biBvbi1zY3JlZW4gbW9kZSBvbmx5LgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9F bGVtZW50c1RyZWVPdXRsaW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJl ZUVsZW1lbnQucHJvdG90eXBlLnVwZGF0ZVNlbGVjdGlvbik6CisKKzIwMTItMDctMjYgIFBhdmVs IEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgV2ViIEluc3BlY3Rv cjogcmVwbGFjZSAidGV4dElucHV0IiBrZXlib2FyZCBldmVudCBsaXN0ZW5lciBicmVha3BvaW50 IHdpdGggImlucHV0IgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTIzODQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCmluZGV4IDQ2YzBlMzM1NDQ0ZDY0ZmQ2NGVm ZjRiNzg1N2RkNDcxYTgwNmNkYzQuLjM0MTMwMzEwMzVjMTYwMWRmMWUzMmI2NmU3ZDZiYTRiYzE2 M2Q1MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxl bWVudHNUcmVlT3V0bGluZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKQEAgLTIwMzcsOSArMjAzNywxMyBAQCBXZWJJbnNw ZWN0b3IuRWxlbWVudHNUcmVlVXBkYXRlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIH0KIAogICAg ICAgICB2YXIgdXBkYXRlZFBhcmVudFRyZWVFbGVtZW50cyA9IFtdOwotICAgICAgICB2YXIgdHJl ZU91dGxpbmVDb250YWluZXJFbGVtZW50ID0gdGhpcy5fdHJlZU91dGxpbmUuZWxlbWVudC5wYXJl bnROb2RlOwotICAgICAgICB2YXIgb3JpZ2luYWxTY3JvbGxUb3AgPSB0cmVlT3V0bGluZUNvbnRh aW5lckVsZW1lbnQgPyB0cmVlT3V0bGluZUNvbnRhaW5lckVsZW1lbnQuc2Nyb2xsVG9wIDogMDsK LSAgICAgICAgdGhpcy5fdHJlZU91dGxpbmUuZWxlbWVudC5hZGRTdHlsZUNsYXNzKCJoaWRkZW4i KTsKKworICAgICAgICB2YXIgaGlkZVBhbmVsV2hpbGVVcGRhdGluZyA9IHRoaXMuX3JlY2VudGx5 TW9kaWZpZWROb2Rlcy5sZW5ndGggPiAxMDsKKyAgICAgICAgaWYgKGhpZGVQYW5lbFdoaWxlVXBk YXRpbmcpIHsKKyAgICAgICAgICAgIHZhciB0cmVlT3V0bGluZUNvbnRhaW5lckVsZW1lbnQgPSB0 aGlzLl90cmVlT3V0bGluZS5lbGVtZW50LnBhcmVudE5vZGU7CisgICAgICAgICAgICB0aGlzLl90 cmVlT3V0bGluZS5lbGVtZW50LmFkZFN0eWxlQ2xhc3MoImhpZGRlbiIpOworICAgICAgICAgICAg dmFyIG9yaWdpbmFsU2Nyb2xsVG9wID0gdHJlZU91dGxpbmVDb250YWluZXJFbGVtZW50ID8gdHJl ZU91dGxpbmVDb250YWluZXJFbGVtZW50LnNjcm9sbFRvcCA6IDA7CisgICAgICAgIH0KIAogICAg ICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMuX3JlY2VudGx5TW9kaWZpZWROb2Rlcy5sZW5n dGg7ICsraSkgewogICAgICAgICAgICAgdmFyIHBhcmVudCA9IHRoaXMuX3JlY2VudGx5TW9kaWZp ZWROb2Rlc1tpXS5wYXJlbnQ7CkBAIC0yMDc0LDkgKzIwNzgsMTIgQEAgV2ViSW5zcGVjdG9yLkVs ZW1lbnRzVHJlZVVwZGF0ZXIucHJvdG90eXBlID0gewogICAgICAgICBmb3IgKHZhciBpID0gMDsg aSA8IHVwZGF0ZWRQYXJlbnRUcmVlRWxlbWVudHMubGVuZ3RoOyArK2kpCiAgICAgICAgICAgICBk ZWxldGUgdXBkYXRlZFBhcmVudFRyZWVFbGVtZW50c1tpXS5hbHJlYWR5VXBkYXRlZENoaWxkcmVu OwogCi0gICAgICAgIHRoaXMuX3RyZWVPdXRsaW5lLmVsZW1lbnQucmVtb3ZlU3R5bGVDbGFzcygi aGlkZGVuIik7Ci0gICAgICAgIGlmIChvcmlnaW5hbFNjcm9sbFRvcCkKLSAgICAgICAgICAgIHRy ZWVPdXRsaW5lQ29udGFpbmVyRWxlbWVudC5zY3JvbGxUb3AgPSBvcmlnaW5hbFNjcm9sbFRvcDsK KyAgICAgICAgaWYgKGhpZGVQYW5lbFdoaWxlVXBkYXRpbmcpIHsKKyAgICAgICAgICAgIHRoaXMu X3RyZWVPdXRsaW5lLmVsZW1lbnQucmVtb3ZlU3R5bGVDbGFzcygiaGlkZGVuIik7CisgICAgICAg ICAgICBpZiAob3JpZ2luYWxTY3JvbGxUb3ApCisgICAgICAgICAgICAgICAgdHJlZU91dGxpbmVD b250YWluZXJFbGVtZW50LnNjcm9sbFRvcCA9IG9yaWdpbmFsU2Nyb2xsVG9wOworICAgICAgICAg ICAgdGhpcy5fdHJlZU91dGxpbmUudXBkYXRlU2VsZWN0aW9uKCk7CisgICAgICAgIH0KICAgICAg ICAgdGhpcy5fcmVjZW50bHlNb2RpZmllZE5vZGVzID0gW107CiAgICAgfSwKIAo=