92364 2012-07-26 04:08:37 -0700 [WK2] WebPage::handleEditingKeyboardEvent does not check whether the node allows editing. 2012-07-26 05:10:46 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 1 mikhail.pozdnyakov mikhail.pozdnyakov kenneth tonikitoo webkit.review.bot oldest_to_newest 679139 0 mikhail.pozdnyakov 2012-07-26 04:08:37 -0700 WebPage::handleEditingKeyboardEvent does not check whether the node allows editing. Affects the behavior of fast/events/key-events-in-input-button.html test. 679140 1 154607 mikhail.pozdnyakov 2012-07-26 04:14:08 -0700 Created attachment 154607 patch 679153 2 154607 kenneth 2012-07-26 04:40:01 -0700 Comment on attachment 154607 patch View in context: https://bugs.webkit.org/attachment.cgi?id=154607&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2149 > + // Don't allow text insertion for nodes that cannot edit. > + if (!frame->editor()->canEdit()) You might not always have an editor() either. 679159 3 mikhail.pozdnyakov 2012-07-26 04:46:40 -0700 (In reply to comment #2) > (From update of attachment 154607 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154607&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2149 > > + // Don't allow text insertion for nodes that cannot edit. > > + if (!frame->editor()->canEdit()) > > You might not always have an editor() either. this function ends already with following: return frame->editor()->insertText(evt->keyEvent()->text(), evt); and here is from Frame.h inline Editor* Frame::editor() const { return &m_editor; } 679162 4 kenneth 2012-07-26 04:48:38 -0700 Ah maybe that changed then 679176 5 154607 webkit.review.bot 2012-07-26 05:10:42 -0700 Comment on attachment 154607 patch Clearing flags on attachment: 154607 Committed r123732: <http://trac.webkit.org/changeset/123732> 679177 6 webkit.review.bot 2012-07-26 05:10:46 -0700 All reviewed patches have been landed. Closing bug. 154607 2012-07-26 04:14:08 -0700 2012-07-26 05:10:42 -0700 patch bug92364 text/plain 1604 mikhail.pozdnyakov Y29tbWl0IDJlNTYzNGQxZThmZTE1ZjRjNDUwNTVhOWNjNDg3Y2ViZjI2NDhlMzEKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VGh1IEp1bCAyNiAxNDoxMjo0OSAyMDEyICswMzAwCgogICAgYnVnOTIzNjQKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k ZXggYzkzYzVlZS4uZjUzZTEwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3 LTI2ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgor CisgICAgICAgIFtXSzJdIFdlYlBhZ2U6OmhhbmRsZUVkaXRpbmdLZXlib2FyZEV2ZW50IGRvZXMg bm90IGNoZWNrIHdoZXRoZXIgdGhlIG5vZGUgYWxsb3dzIGVkaXRpbmcuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjM2NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGEgY2hlY2sgd2hldGhlciB0 aGUgaW5wdXQgbm9kZSBhbGxvd3MgZWRpdGluZy4gSWYgZWRpdGluZyBpcyBub3QgYWxsb3dlZAor ICAgICAgICB0ZXh0IGlucHV0IGV2ZW50IHdpbGwgbm90IGJlIGVtaXR0ZWQuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBh Z2U6OmhhbmRsZUVkaXRpbmdLZXlib2FyZEV2ZW50KToKKwogMjAxMi0wNy0yNSAgU2Vva2p1IEt3 b24gIDxzZW9ranUua3dvbkBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIEltcGxl bWVudCB0aGUgaW5zcGVjdG9yIGZvciBXZWJLaXRUZXN0UnVubmVyCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggOTU3MWZmYi4uYmI2M2I0NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcApAQCAt MjE0NSw2ICsyMTQ1LDEwIEBAIGJvb2wgV2ViUGFnZTo6aGFuZGxlRWRpdGluZ0tleWJvYXJkRXZl bnQoS2V5Ym9hcmRFdmVudCogZXZ0KQogICAgIGlmIChjb21tYW5kLmV4ZWN1dGUoZXZ0KSkKICAg ICAgICAgcmV0dXJuIHRydWU7CiAKKyAgICAvLyBEb24ndCBhbGxvdyB0ZXh0IGluc2VydGlvbiBm b3Igbm9kZXMgdGhhdCBjYW5ub3QgZWRpdC4KKyAgICBpZiAoIWZyYW1lLT5lZGl0b3IoKS0+Y2Fu RWRpdCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICAvLyBEb24ndCBpbnNlcnQgbnVs bCBvciBjb250cm9sIGNoYXJhY3RlcnMgYXMgdGhleSBjYW4gcmVzdWx0IGluIHVuZXhwZWN0ZWQg YmVoYXZpb3VyCiAgICAgaWYgKGV2dC0+Y2hhckNvZGUoKSA8ICcgJykKICAgICAgICAgcmV0dXJu IGZhbHNlOwo=