9236 2006-06-02 08:47:51 -0700 REGRESSION: focus method does not work on some elements before they are laid out 2006-06-02 17:15:41 -0700 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED EasyFix, Regression P1 Normal --- 1 darin darin justin.garcia oldest_to_newest 44379 0 darin 2006-06-02 08:47:51 -0700 The fast/forms/access-key.html layout test is failing. That's because the focus method isn't working because the page isn't laid out yet; the input element still has a width of 0. Easy to fix. 44380 1 darin 2006-06-02 08:48:16 -0700 This must be a regression since the test used to work. 44381 2 8666 darin 2006-06-02 08:51:01 -0700 Created attachment 8666 patch 44383 3 darin 2006-06-02 09:06:12 -0700 Mitz found where this regressed. Change 14666 for bug <rdar://problem/4567752> rearranged Element::focus, putting the isFocusable call before the layout. 44398 4 8666 ggaren 2006-06-02 10:54:24 -0700 Comment on attachment 8666 patch r=me 44484 5 timothy 2006-06-02 17:15:41 -0700 Maciej landed this in r14699. 8666 2006-06-02 08:51:01 -0700 2006-06-02 10:54:24 -0700 patch FocusPatch.txt text/plain 1121 darin SW5kZXg6IGRvbS9FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBkb20vRWxlbWVudC5jcHAJKHJl dmlzaW9uIDE0Njg0KQorKysgZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MjEs MTIgKzgyMSwxMiBAQAogCiB2b2lkIEVsZW1lbnQ6OmZvY3VzKCkKIHsKLSAgICBpZiAoIWlzRm9j dXNhYmxlKCkpCi0gICAgICAgIHJldHVybjsKLSAgICAKICAgICBEb2N1bWVudCogZG9jID0gZG9j dW1lbnQoKTsKICAgICBkb2MtPnVwZGF0ZUxheW91dCgpOwogICAgICAgICAgICAgICAgIAorICAg IGlmICghaXNGb2N1c2FibGUoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgZG9jLT5zZXRGb2N1 c05vZGUodGhpcyk7CiAgICAgCiAgICAgaWYgKHRoaXMgPT0gcm9vdEVkaXRhYmxlRWxlbWVudCgp KSB7ICAgIApJbmRleDogQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIENoYW5nZUxvZwkocmV2aXNp b24gMTQ2ODQpCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAor MjAwNi0wNi0wMiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxh Lm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05MjM2CisgICAgICAgICAgUkVHUkVTU0lP TjogZm9jdXMgbWV0aG9kIGRvZXMgbm90IHdvcmsgb24gc29tZSBlbGVtZW50cyBiZWZvcmUgdGhl eSBhcmUgbGFpZCBvdXQKKworICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDogKFdlYkNvcmU6OkVs ZW1lbnQ6OmZvY3VzKTogRG8gdGhlIHVwZGF0ZUxheW91dCBjYWxsIGJlZm9yZQorICAgICAgICBj YWxsaW5nIGlzRm9jdXNhYmxlLCBzaW5jZSBpc0ZvY3VzYWJsZSBsb29rcyBhdCB0aGUgc2l6ZSBv ZiB0aGUgcmVuZGVyZXIuCisKIDIwMDYtMDYtMDIgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGtp bHplci5uZXQ+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgbWpzLgo=