92349 2012-07-26 01:28:04 -0700 [EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing 2012-07-26 03:08:09 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 92072 1 cdumez cdumez gustavo gyuyoung.kim haraken kenneth lucas.de.marchi mikhail.pozdnyakov morrita rakuco tonikitoo webkit.review.bot oldest_to_newest 679018 0 cdumez 2012-07-26 01:28:04 -0700 strdup has been replaced by eina stringsharing in: http://trac.webkit.org/changeset/123604 Unfortunately, this change causes webintents/web-intents-obj-constructor.html to crash now. 679022 1 cdumez 2012-07-26 01:32:47 -0700 Looks like DumpRenderTreeChrome::onFrameIntentNew() was not updated accordingly to use einastringshare_del() instead of free(). I'm preparing a fix now. 679027 2 cdumez 2012-07-26 01:34:26 -0700 *** Bug 92350 has been marked as a duplicate of this bug. *** 679035 3 154577 cdumez 2012-07-26 01:43:07 -0700 Created attachment 154577 Patch 679043 4 154577 gyuyoung.kim 2012-07-26 01:48:31 -0700 Comment on attachment 154577 Patch Looks fine. Thanks. 679045 5 154577 haraken 2012-07-26 01:49:31 -0700 Comment on attachment 154577 Patch Looks OK. 679110 6 154577 webkit.review.bot 2012-07-26 03:08:02 -0700 Comment on attachment 154577 Patch Clearing flags on attachment: 154577 Committed r123723: <http://trac.webkit.org/changeset/123723> 679111 7 webkit.review.bot 2012-07-26 03:08:09 -0700 All reviewed patches have been landed. Closing bug. 154577 2012-07-26 01:43:07 -0700 2012-07-26 03:08:02 -0700 Patch 92349_webintents_crash_fix.patch text/plain 2183 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjOTkx MjU0Li5lM2U0YTYyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTItMDctMjYgIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBSZWdyZXNzaW9uKHIx MjM2MDQpOiB3ZWJpbnRlbnRzL3dlYi1pbnRlbnRzLW9iai1jb25zdHJ1Y3Rvci5odG1sIGlzIGNy YXNoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MjM0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCBjcmFzaCBvY2N1cnJpbmcgYWZ0ZXIgcjEyMzYwNCwgd2hpY2ggcmVwbGFjZWQgc3RyZHVwKCkK KyAgICAgICAgdXNhZ2Ugd2l0aCBlaW5hX3N0cmluZ3NoYXJlX2FkZCgpLiBVbmZvcnR1bmF0ZWx5 LCB0aGUgRFJUCisgICAgICAgIHdhcyBub3QgdXBkYXRlZCBhY2NvcmRpbmdseSB0byB1c2UgZWlu YV9zdHJpbmdzaGFyZV9kZWwoKQorICAgICAgICBpbnN0ZWFkIG9mIGZyZWUoKSBvbiB0aGUgdmFs dWVzIHJldHVybmVkIGJ5IEV3a19JbnRlbnQKKyAgICAgICAgZ2V0dGVycyBhbmQgaXQgd2FzIGNh dXNpbmcKKyAgICAgICAgd2ViaW50ZW50cy93ZWItaW50ZW50cy1vYmotY29uc3RydWN0b3IuaHRt bCB0byBjcmFzaC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJl ZUNocm9tZS5jcHA6CisgICAgICAgIChEdW1wUmVuZGVyVHJlZUNocm9tZTo6b25GcmFtZUludGVu dE5ldyk6CisKIDIwMTItMDctMjYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkIGF0dGVtcHQgdG8gZml4IHRoZSBjaHJvbWl1bS13aW4gYnVpbGQu CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJv bWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNw cAppbmRleCA5ODMwNDU3Li4xMzZiYWUxIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJl ZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKQEAgLTg1NiwxOSArODU2LDIwIEBAIHZvaWQg RHVtcFJlbmRlclRyZWVDaHJvbWU6Om9uRnJhbWVJbnRlbnROZXcodm9pZCosIEV2YXNfT2JqZWN0 Kiwgdm9pZCogZXZlbnRJbmZvCiAgICAgdm9pZCogZGF0YSA9IDA7CiAgICAgRWluYV9MaXN0KiBl eHRyYU5hbWVzID0gZXdrX2ludGVudF9leHRyYV9uYW1lc19nZXQoaW50ZW50KTsKICAgICBFSU5B X0xJU1RfRlJFRShleHRyYU5hbWVzLCBkYXRhKSB7Ci0gICAgICAgIGNoYXIqIG5hbWUgPSBzdGF0 aWNfY2FzdDxjaGFyKj4oZGF0YSk7CisgICAgICAgIGNvbnN0IGNoYXIqIG5hbWUgPSBzdGF0aWNf Y2FzdDxjaGFyKj4oZGF0YSk7CiAgICAgICAgIGNvbnN0IGNoYXIqIHZhbHVlID0gZXdrX2ludGVu dF9leHRyYV9nZXQoaW50ZW50LCBuYW1lKTsKICAgICAgICAgaWYgKHZhbHVlKSB7CiAgICAgICAg ICAgICBwcmludGYoIkV4dHJhc1slc10gPSAlc1xuIiwgbmFtZSwgdmFsdWUpOwogICAgICAgICAg ICAgZWluYV9zdHJpbmdzaGFyZV9kZWwodmFsdWUpOwogICAgICAgICB9Ci0gICAgICAgIGZyZWUo bmFtZSk7CisgICAgICAgIGVpbmFfc3RyaW5nc2hhcmVfZGVsKG5hbWUpOwogICAgIH0KIAogICAg IEVpbmFfTGlzdCogc3VnZ2VzdGlvbnMgPSBld2tfaW50ZW50X3N1Z2dlc3Rpb25zX2dldChpbnRl bnQpOwogICAgIEVJTkFfTElTVF9GUkVFKHN1Z2dlc3Rpb25zLCBkYXRhKSB7Ci0gICAgICAgIHBy aW50ZigiSGF2ZSBzdWdnZXN0aW9uICVzXG4iLCBzdGF0aWNfY2FzdDxjaGFyKj4oZGF0YSkpOwot ICAgICAgICBmcmVlKGRhdGEpOworICAgICAgICBjb25zdCBjaGFyKiBzdWdnZXN0aW9uID0gc3Rh dGljX2Nhc3Q8Y2hhcio+KGRhdGEpOworICAgICAgICBwcmludGYoIkhhdmUgc3VnZ2VzdGlvbiAl c1xuIiwgc3VnZ2VzdGlvbik7CisgICAgICAgIGVpbmFfc3RyaW5nc2hhcmVfZGVsKHN1Z2dlc3Rp b24pOwogICAgIH0KIH0KIAo=