92326 2012-07-25 18:13:09 -0700 Web Inspector: ExtensionView constructor shouldn't take parent argument 2012-07-26 09:12:58 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 janx webkit-unassigned apavlov bweinstein caseq joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 678698 0 janx 2012-07-25 18:13:09 -0700 ExtensionView's constructor takes a parent argument and directly calls `this.show(parent)` at the end of the constructor. This is problematic if you're creating and ExtensionView but you don't want to show it right away or you don't know about its parent element yet. The correct behavior should be the same as for View objects: do not take `parent` as a constructor argument, wait for a call to `extensionView.show(parent)` whenever needed. 678730 1 154517 janx 2012-07-25 18:59:59 -0700 Created attachment 154517 Patch 679239 2 154517 caseq 2012-07-26 06:12:02 -0700 Comment on attachment 154517 Patch LGTM 679396 3 154517 webkit.review.bot 2012-07-26 09:12:53 -0700 Comment on attachment 154517 Patch Clearing flags on attachment: 154517 Committed r123753: <http://trac.webkit.org/changeset/123753> 679397 4 webkit.review.bot 2012-07-26 09:12:58 -0700 All reviewed patches have been landed. Closing bug. 154517 2012-07-25 18:59:59 -0700 2012-07-26 09:12:53 -0700 Patch bug-92326-20120725185949.patch text/plain 3524 janx U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDAzYWI4YzQyYWU3ODQx MTkzOTEwMjZiNjYyZDgwYjg1MWZmNWM4YS4uODFmNjc3MzEwMDY0MmViMmI0YjUxOTMxYjI3Y2Rm M2UwYWUyNDkxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA3LTI1ICBKYW4g S2Vyb21uZXMgIDxqYW54QGxpbnV4LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBFeHRl bnNpb25WaWV3IGNvbnN0cnVjdG9yIHNob3VsZG4ndCB0YWtlIHBhcmVudCBhcmd1bWVudAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIzMjYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHRlbnNpb25WaWV3 J3MgY29uc3RydWN0b3IgdG9vayBhIHBhcmVudCBlbGVtZW50IHBhcmFtZXRlciBhbmQgYXV0by0K KyAgICAgICAgc2hvd2VkIGl0c2VsZiBpbiB0aGUgY29uc3RydWN0b3IuIFRoaXMgZGlkbid0IGFs bG93IGxhenkgc2hvd2luZyBhbmQKKyAgICAgICAgd2FzIGNvbmZ1c2luZyBiZWNhdXNlIGl0IGRp ZG4ndCB3b3JrIGxpa2UgYSBjbGFzc2ljIFZpZXcgb2JqZWN0LiBGaXhlZC4KKworICAgICAgICBO byBuZXcgdGVzdHMgbmVlZGVkOiBSZWZhY3RvcmluZyB3aXRoIG5vIGJlaGF2aW9yIGNoYW5nZXMu CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblBhbmVsLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkV4dGVuc2lvblBhbmVsKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5FeHRlbnNpb25TaWRlYmFyUGFuZS5wcm90b3R5cGUuc2V0UGFnZSk6CisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25WaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkV4dGVuc2lvblZpZXcpOgorCiAyMDEyLTA3LTI1ICBBbmRyZXcgV2lsc29uICA8YXR3aWxzb25A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjM1NjAu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lv blBhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25Q YW5lbC5qcwppbmRleCA0Y2RjODFjOTk3NjdlNjlhZWI2OWRjNGU2MjZkNTc5NWFjZGZmNmUxLi4x YzY5NjUzNmRkY2I5YzY1OWIyZDlmNTVhZDQwZWRiOWUzYzM3ZmUyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblBhbmVsLmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uUGFuZWwuanMKQEAgLTQ3 LDcgKzQ3LDggQEAgV2ViSW5zcGVjdG9yLkV4dGVuc2lvblBhbmVsID0gZnVuY3Rpb24oaWQsIGxh YmVsLCBwYWdlVVJMLCBpY29uVVJMKQogICAgICAgICB0aGlzLl9hZGRTdHlsZVJ1bGUoIi50b29s YmFyLWl0ZW0uIiArIGlkICsgIiAudG9vbGJhci1pY29uIiwgImJhY2tncm91bmQtaW1hZ2U6IHVy bCgiICsgaWNvblVSTCArICIpOyIpOwogICAgICAgICB0aGlzLl9hZGRTdHlsZVJ1bGUoIi50b29s YmFyLXNtYWxsIC50b29sYmFyLWl0ZW0uIiArIGlkICsgIiAudG9vbGJhci1pY29uIiwgImJhY2tn cm91bmQtcG9zaXRpb24teDogLTMycHg7Iik7CiAgICAgfQotICAgIG5ldyBXZWJJbnNwZWN0b3Iu RXh0ZW5zaW9uVmlldyhpZCwgdGhpcy5lbGVtZW50LCBwYWdlVVJMLCAiZXh0ZW5zaW9uIHBhbmVs Iik7CisgICAgdmFyIGV4dGVuc2lvblZpZXcgPSBuZXcgV2ViSW5zcGVjdG9yLkV4dGVuc2lvblZp ZXcoaWQsIHBhZ2VVUkwsICJleHRlbnNpb24gcGFuZWwiKTsKKyAgICBleHRlbnNpb25WaWV3LnNo b3codGhpcy5lbGVtZW50KTsKIH0KIAogV2ViSW5zcGVjdG9yLkV4dGVuc2lvblBhbmVsLnByb3Rv dHlwZSA9IHsKQEAgLTE5Niw3ICsxOTcsOSBAQCBXZWJJbnNwZWN0b3IuRXh0ZW5zaW9uU2lkZWJh clBhbmUucHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhpcy5fZXh0ZW5zaW9uVmlldykKICAg ICAgICAgICAgIHRoaXMuX2V4dGVuc2lvblZpZXcuZGV0YWNoKHRydWUpOwogCi0gICAgICAgIHRo aXMuX2V4dGVuc2lvblZpZXcgPSBuZXcgV2ViSW5zcGVjdG9yLkV4dGVuc2lvblZpZXcodGhpcy5f aWQsIHRoaXMuYm9keUVsZW1lbnQsIHVybCwgImV4dGVuc2lvbiBmaWxsIik7CisgICAgICAgIHRo aXMuX2V4dGVuc2lvblZpZXcgPSBuZXcgV2ViSW5zcGVjdG9yLkV4dGVuc2lvblZpZXcodGhpcy5f aWQsIHVybCwgImV4dGVuc2lvbiBmaWxsIik7CisgICAgICAgIHRoaXMuX2V4dGVuc2lvblZpZXcu c2hvdyh0aGlzLmJvZHlFbGVtZW50KTsKKwogICAgICAgICBpZiAoIXRoaXMuYm9keUVsZW1lbnQu c3R5bGUuaGVpZ2h0KQogICAgICAgICAgICAgdGhpcy5zZXRIZWlnaHQoIjE1MHB4Iik7CiAgICAg fSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5z aW9uVmlldy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9u Vmlldy5qcwppbmRleCBkNzkyNTE4ODI5ZGZjM2E4YTk0NjhjNjJjOGM3YTY1YjU4N2RkODQzLi5k NGNkNzJjNGQ1Y2YzNDdkZjJmYjMwNzcyN2M2NDc0OTYxODA0NzAyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblZpZXcuanMKKysrIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25WaWV3LmpzCkBAIC0zMiwx MSArMzIsMTAgQEAKICAqIEBjb25zdHJ1Y3RvcgogICogQGV4dGVuZHMge1dlYkluc3BlY3Rvci5W aWV3fQogICogQHBhcmFtIHtzdHJpbmd9IGlkCi0gKiBAcGFyYW0ge0VsZW1lbnR9IHBhcmVudAog ICogQHBhcmFtIHtzdHJpbmd9IHNyYwogICogQHBhcmFtIHtzdHJpbmd9IGNsYXNzTmFtZQogICov Ci1XZWJJbnNwZWN0b3IuRXh0ZW5zaW9uVmlldyA9IGZ1bmN0aW9uKGlkLCBwYXJlbnQsIHNyYywg Y2xhc3NOYW1lKQorV2ViSW5zcGVjdG9yLkV4dGVuc2lvblZpZXcgPSBmdW5jdGlvbihpZCwgc3Jj LCBjbGFzc05hbWUpCiB7CiAgICAgV2ViSW5zcGVjdG9yLlZpZXcuY2FsbCh0aGlzKTsKICAgICB0 aGlzLmVsZW1lbnQuY2xhc3NOYW1lID0gImZpbGwiOwpAQCAtNDgsNyArNDcsNiBAQCBXZWJJbnNw ZWN0b3IuRXh0ZW5zaW9uVmlldyA9IGZ1bmN0aW9uKGlkLCBwYXJlbnQsIHNyYywgY2xhc3NOYW1l KQogICAgIHRoaXMuX2lmcmFtZS5jbGFzc05hbWUgPSBjbGFzc05hbWU7CiAKICAgICB0aGlzLmVs ZW1lbnQuYXBwZW5kQ2hpbGQodGhpcy5faWZyYW1lKTsKLSAgICB0aGlzLnNob3cocGFyZW50KTsK IH0KIAogV2ViSW5zcGVjdG9yLkV4dGVuc2lvblZpZXcucHJvdG90eXBlID0gewo=