92314 2012-07-25 16:08:52 -0700 [BlackBerry] GraphicsContext3D::paintToCanvas should not swap 0th and 2nd components of color 2012-07-25 19:53:09 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jnetterfield webkit-unassigned mifenton noam tonikitoo webkit.review.bot oldest_to_newest 678572 0 jnetterfield 2012-07-25 16:08:52 -0700 paintToCanvas already receives BGRA data. It shouldn't convert it back to RGBA. 678653 1 154497 jnetterfield 2012-07-25 17:14:51 -0700 Created attachment 154497 Patch 678784 2 154497 rwlbuis 2012-07-25 19:29:43 -0700 Comment on attachment 154497 Patch LGTM. 678805 3 154497 webkit.review.bot 2012-07-25 19:53:05 -0700 Comment on attachment 154497 Patch Clearing flags on attachment: 154497 Committed r123702: <http://trac.webkit.org/changeset/123702> 678806 4 webkit.review.bot 2012-07-25 19:53:09 -0700 All reviewed patches have been landed. Closing bug. 154497 2012-07-25 17:14:51 -0700 2012-07-25 19:53:05 -0700 Patch bug-92314-20120725201349.patch text/plain 5173 jnetterfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTQ3ZDNhY2UzZTJkZTFj NjZiMjE1Y2MzNWRlM2EzNjIyZGM1OTAxNC4uNGMyODdkNWNjMzRhOGM1YTYyODVhNjRmZTI5YzNl MjdmNjVlYTAyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTA3LTI1ICBKb3No dWEgTmV0dGVyZmllbGQgIDxqbmV0dGVyZmllbGRAcmltLmNvbT4KIAorICAgICAgICBbQmxhY2tC ZXJyeV0gR3JhcGhpY3NDb250ZXh0M0Q6OnBhaW50VG9DYW52YXMgc2hvdWxkIG5vdCBzd2FwIDB0 aCBhbmQgMm5kIGNvbXBvbmVudHMgb2YgY29sb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkyMzE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBiZWNhdXNlIGl0IGNvcnJlY3RzIGV4 aXN0aW5nIGZ1bmN0aW9uYWxpdHksIGJ1dCBpdCBtYWtlcyBCbGFja0JlcnJ5CisgICAgICAgIHBh c3MgY2FudmFzLXRleHQuaHRtbCBhbmQgb3RoZXJzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9i bGFja2JlcnJ5L0dyYXBoaWNzQ29udGV4dDNEQmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpHcmFwaGljc0NvbnRleHQzRDo6cGFpbnRUb0NhbnZhcyk6CisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjpwYWludFJlbmRlcmluZ1Jlc3VsdHNU b0NhbnZhcyk6CisKKzIwMTItMDctMjUgIEpvc2h1YSBOZXR0ZXJmaWVsZCAgPGpuZXR0ZXJmaWVs ZEByaW0uY29tPgorCiAgICAgICAgIFtCbGFja0JlcnJ5XSBHcmFwaGljc0NvbnRleHQzRDo6cmVz aGFwZUZCT3MgZG9lcyBub3QgcmVwb3J0IHdoZW4gYm91bmQgRkJPcyBzaG91bGQgYmUgcmVzdG9y ZWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyMzA0 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNz Q29udGV4dDNELmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0Nv bnRleHQzRC5oCmluZGV4IDc0MzNkZjYyNmY0Y2FiMmFjYzZjYTA5OGE2MjgwZDQ4ZDQ5YTJiMTku LmZlMTIyM2Q3ODYwMGQyMTgzMDk0ZWU1NmZhNjNkNDM5MWRlNDk1YTYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaApAQCAt ODA1LDYgKzgwNSw5IEBAIHB1YmxpYzoKICNlbGlmIFBMQVRGT1JNKFFUKQogICAgIHZvaWQgcGFp bnRUb0NhbnZhcyhjb25zdCB1bnNpZ25lZCBjaGFyKiBpbWFnZVBpeGVscywgaW50IGltYWdlV2lk dGgsIGludCBpbWFnZUhlaWdodCwKICAgICAgICAgICAgICAgICAgICAgICAgaW50IGNhbnZhc1dp ZHRoLCBpbnQgY2FudmFzSGVpZ2h0LCBRUGFpbnRlciogY29udGV4dCk7CisjZWxpZiBQTEFURk9S TShCTEFDS0JFUlJZKQorICAgIHZvaWQgcGFpbnRUb0NhbnZhcyhjb25zdCB1bnNpZ25lZCBjaGFy KiBpbWFnZVBpeGVscywgaW50IGltYWdlV2lkdGgsIGludCBpbWFnZUhlaWdodCwKKyAgICAgICAg ICAgICAgICAgICAgICAgaW50IGNhbnZhc1dpZHRoLCBpbnQgY2FudmFzSGVpZ2h0LCBHcmFwaGlj c0NvbnRleHQqKTsKICNlbmRpZgogCiAgICAgdm9pZCBtYXJrQ29udGV4dENoYW5nZWQoKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvR3Jh cGhpY3NDb250ZXh0M0RCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2JsYWNrYmVycnkvR3JhcGhpY3NDb250ZXh0M0RCbGFja0JlcnJ5LmNwcAppbmRleCA0 OWQwZDE1NWUxOWMwZTdkNjEyYmI5MjlmMzg2YjBlNzgwNDQzYWNkLi4zNjk4ZmQyNWYxMjljMmM0 MDc2ZDUzOWE4M2ViOWEyZGE2MWI3ZGUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0dyYXBoaWNzQ29udGV4dDNEQmxhY2tCZXJyeS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9HcmFwaGlj c0NvbnRleHQzREJsYWNrQmVycnkuY3BwCkBAIC0zNjAsMjkgKzM2MCwxNiBAQCBQbGF0Zm9ybUxh eWVyKiBHcmFwaGljc0NvbnRleHQzRDo6cGxhdGZvcm1MYXllcigpIGNvbnN0CiAjZW5kaWYKIAog dm9pZCBHcmFwaGljc0NvbnRleHQzRDo6cGFpbnRUb0NhbnZhcyhjb25zdCB1bnNpZ25lZCBjaGFy KiBpbWFnZVBpeGVscywgaW50IGltYWdlV2lkdGgsIGludCBpbWFnZUhlaWdodCwgaW50IGNhbnZh c1dpZHRoLCBpbnQgY2FudmFzSGVpZ2h0LAotICAgICAgIEdyYXBoaWNzQ29udGV4dCogY29udGV4 dCwgYm9vbCBmbGlwWSkKKyAgICAgICBHcmFwaGljc0NvbnRleHQqIGNvbnRleHQpCiB7Ci0gICAg Ly8gUmVvcmRlciBwaXhlbHMgaW50byBCR1JBIGZvcm1hdC4KICAgICB1bnNpZ25lZCBjaGFyKiB0 ZW1wUGl4ZWxzID0gbmV3IHVuc2lnbmVkIGNoYXJbaW1hZ2VXaWR0aCAqIGltYWdlSGVpZ2h0ICog NF07CiAKLSAgICBpZiAoZmxpcFkpIHsKLSAgICAgICAgZm9yIChpbnQgeSA9IDA7IHkgPCBpbWFn ZUhlaWdodDsgeSsrKSB7Ci0gICAgICAgICAgICBjb25zdCB1bnNpZ25lZCBjaGFyICpzcmNSb3cg PSBpbWFnZVBpeGVscyArIChpbWFnZVdpZHRoICogNCAqIHkpOwotICAgICAgICAgICAgdW5zaWdu ZWQgY2hhciAqZGVzdFJvdyA9IHRlbXBQaXhlbHMgKyAoaW1hZ2VXaWR0aCAqIDQgKiAoaW1hZ2VI ZWlnaHQgLSB5IC0gMSkpOwotICAgICAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBpbWFnZVdp ZHRoICogNDsgaSArPSA0KSB7Ci0gICAgICAgICAgICAgICAgZGVzdFJvd1tpICsgMF0gPSBzcmNS b3dbaSArIDJdOwotICAgICAgICAgICAgICAgIGRlc3RSb3dbaSArIDFdID0gc3JjUm93W2kgKyAx XTsKLSAgICAgICAgICAgICAgICBkZXN0Um93W2kgKyAyXSA9IHNyY1Jvd1tpICsgMF07Ci0gICAg ICAgICAgICAgICAgZGVzdFJvd1tpICsgM10gPSBzcmNSb3dbaSArIDNdOwotICAgICAgICAgICAg fQotICAgICAgICB9Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBp bWFnZVdpZHRoICogaW1hZ2VIZWlnaHQgKiA0OyBpICs9IDQpIHsKLSAgICAgICAgICAgIHRlbXBQ aXhlbHNbaSArIDBdID0gaW1hZ2VQaXhlbHNbaSArIDJdOwotICAgICAgICAgICAgdGVtcFBpeGVs c1tpICsgMV0gPSBpbWFnZVBpeGVsc1tpICsgMV07Ci0gICAgICAgICAgICB0ZW1wUGl4ZWxzW2kg KyAyXSA9IGltYWdlUGl4ZWxzW2kgKyAwXTsKLSAgICAgICAgICAgIHRlbXBQaXhlbHNbaSArIDNd ID0gaW1hZ2VQaXhlbHNbaSArIDNdOwotICAgICAgICB9CisgICAgLy8gM0QgaW1hZ2VzIGhhdmUg YWxyZWFkeSBiZWVuIGNvbnZlcnRlZCB0byBCR1JBLiBEb24ndCBkbyBpdCB0d2ljZSEhCisgICAg Zm9yIChpbnQgeSA9IDA7IHkgPCBpbWFnZUhlaWdodDsgeSsrKSB7CisgICAgICAgIGNvbnN0IHVu c2lnbmVkIGNoYXIgKnNyY1JvdyA9IGltYWdlUGl4ZWxzICsgKGltYWdlV2lkdGggKiA0ICogeSk7 CisgICAgICAgIHVuc2lnbmVkIGNoYXIgKmRlc3RSb3cgPSB0ZW1wUGl4ZWxzICsgKGltYWdlV2lk dGggKiA0ICogKGltYWdlSGVpZ2h0IC0geSAtIDEpKTsKKyAgICAgICAgZm9yIChpbnQgaSA9IDA7 IGkgPCBpbWFnZVdpZHRoICogNDsgaSArPSA0KQorICAgICAgICAgICAgbWVtY3B5KGRlc3RSb3cg KyBpLCBzcmNSb3cgKyBpLCA0KTsKICAgICB9CiAKICAgICBTa0JpdG1hcCBjYW52YXNCaXRtYXA7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3Jh cGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcAppbmRleCBh NGQxZWI0Y2Q5M2M0NzYzMzZjMDJmNjEzYmZjNjU5NDRkMjg2Y2I4Li4yMjU2MjgyNDhjMjk4MzYx ZDZiNzliZTViNGFhNGM3OWMxNDEyMTJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRl eHQzRE9wZW5HTENvbW1vbi5jcHAKQEAgLTEyMiw3ICsxMjIsNyBAQCB2b2lkIEdyYXBoaWNzQ29u dGV4dDNEOjpwYWludFJlbmRlcmluZ1Jlc3VsdHNUb0NhbnZhcyhJbWFnZUJ1ZmZlciogaW1hZ2VC dWZmZXIsCiAKICNpZiBQTEFURk9STShCTEFDS0JFUlJZKQogICAgIHBhaW50VG9DYW52YXMocGl4 ZWxzLmdldCgpLCBtX2N1cnJlbnRXaWR0aCwgbV9jdXJyZW50SGVpZ2h0LAotICAgICAgICAgICAg ICAgICAgaW1hZ2VCdWZmZXItPmludGVybmFsU2l6ZSgpLndpZHRoKCksIGltYWdlQnVmZmVyLT5p bnRlcm5hbFNpemUoKS5oZWlnaHQoKSwgaW1hZ2VCdWZmZXItPmNvbnRleHQoKSwgdHJ1ZSk7Cisg ICAgICAgICAgICAgICAgICBpbWFnZUJ1ZmZlci0+aW50ZXJuYWxTaXplKCkud2lkdGgoKSwgaW1h Z2VCdWZmZXItPmludGVybmFsU2l6ZSgpLmhlaWdodCgpLCBpbWFnZUJ1ZmZlci0+Y29udGV4dCgp KTsKICNlbHNlCiAgICAgcGFpbnRUb0NhbnZhcyhwaXhlbHMuZ2V0KCksIG1fY3VycmVudFdpZHRo LCBtX2N1cnJlbnRIZWlnaHQsCiAgICAgICAgICAgICAgICAgICBpbWFnZUJ1ZmZlci0+aW50ZXJu YWxTaXplKCkud2lkdGgoKSwgaW1hZ2VCdWZmZXItPmludGVybmFsU2l6ZSgpLmhlaWdodCgpLCBp bWFnZUJ1ZmZlci0+Y29udGV4dCgpLT5wbGF0Zm9ybUNvbnRleHQoKSk7Cg==