92306 2012-07-25 14:48:01 -0700 "webkit-patch upload" should strip colors from patch if necessary 2012-07-27 15:10:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 webkit.review.bot rafael.lobo abarth dpranke ojan rafael.lobo rniwa oldest_to_newest 678499 0 webkit.review.bot 2012-07-25 14:48:01 -0700 "webkit-patch upload" should strip colors from patch if necessary Requested by rafaelbrandao on #webkit. 678863 1 154543 rafael.lobo 2012-07-25 22:34:51 -0700 Created attachment 154543 Patch 678867 2 rafael.lobo 2012-07-25 22:42:53 -0700 I will add unit tests for this if necessary. It was spotted on bug 91242 where the first two patches are not readable if you click on "Formatted Diff" on bugzilla. If you remove "&action=prettypatch" and check the raw, you'll see it has the colors on it. I was using "git config color.diff" with "always" instead of "auto". 679323 3 154543 rafael.lobo 2012-07-26 07:43:01 -0700 Comment on attachment 154543 Patch I accept suggestions to where I should put tests for this, if it's needed. The downside is that I would have to change git config local settings before running such tests and restore those values afterwards. 679363 4 154543 abarth 2012-07-26 08:34:21 -0700 Comment on attachment 154543 Patch Crazy. Can you run Tools/Script/tests-webkitpy to make sure this doesn't break any unit tests? 681079 5 154543 rafael.lobo 2012-07-27 14:13:39 -0700 Comment on attachment 154543 Patch Double checked, it looks like no harm was done. Thanks! 681135 6 154543 webkit.review.bot 2012-07-27 15:10:45 -0700 Comment on attachment 154543 Patch Clearing flags on attachment: 154543 Committed r123924: <http://trac.webkit.org/changeset/123924> 681136 7 webkit.review.bot 2012-07-27 15:10:50 -0700 All reviewed patches have been landed. Closing bug. 154543 2012-07-25 22:34:51 -0700 2012-07-27 15:10:45 -0700 Patch bug-92306-20120726023440.patch text/plain 1616 rafael.lobo U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNzA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzM0YWRmYTAyYWZlNTFhN2U4ZmQwNTg2Nzg2YzZjNDc3 ZTNkNjI4YS4uZTk2ZTM4NTY1YWViODhjOTVlMzE0YWZiMTAyNDJlYmM5YTcwMmM5MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEyLTA3LTI1ICBSYWZhZWwgQnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgIndlYmtpdC1wYXRjaCB1cGxvYWQiIHNob3VsZCBzdHJpcCBjb2xvcnMg ZnJvbSBwYXRjaCBpZiBuZWNlc3NhcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkyMzA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vZ2l0 LnB5OiBFeHBsaWNpdHkgcmVtb3ZlIGNvbG9ycyBmcm9tIGRpZmYuCisKIDIwMTItMDctMjUgIEFk YW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBUZXN0UnVubmVyLmEgc2hv dWxkIGNvbnRhaW4gYSBUZXN0UnVubmVyIG9iamVjdApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL2dpdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9naXQucHkKaW5kZXggODAyZDgxZGIwZGMyNzZlNzgy N2IxNDkwOGE4MjdhMjBjZWJlY2RjZS4uNDFlMWUxZTA0NGEyZmFjOTJhMDZiMDliYTVhNTMwYzU2 NzIxYzI5OCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tv dXQvc2NtL2dpdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291 dC9zY20vZ2l0LnB5CkBAIC0yNzQsNyArMjc0LDcgQEAgY2xhc3MgR2l0KFNDTSwgU1ZOUmVwb3Np dG9yeSk6CiAgICAgICAgIGlmIHNlbGYuX2ZpbGVzeXN0ZW0uZXhpc3RzKG9yZGVyX2ZpbGUpOgog ICAgICAgICAgICAgb3JkZXIgPSAiLU8lcyIgJSBvcmRlcl9maWxlCiAKLSAgICAgICAgY29tbWFu ZCA9IFtzZWxmLmV4ZWN1dGFibGVfbmFtZSwgJ2RpZmYnLCAnLS1iaW5hcnknLCAiLS1uby1leHQt ZGlmZiIsICItLWZ1bGwtaW5kZXgiLCAiLS1uby1yZW5hbWVzIiwgb3JkZXIsIHNlbGYubWVyZ2Vf YmFzZShnaXRfY29tbWl0KSwgIi0tIl0KKyAgICAgICAgY29tbWFuZCA9IFtzZWxmLmV4ZWN1dGFi bGVfbmFtZSwgJ2RpZmYnLCAnLS1iaW5hcnknLCAnLS1uby1jb2xvcicsICItLW5vLWV4dC1kaWZm IiwgIi0tZnVsbC1pbmRleCIsICItLW5vLXJlbmFtZXMiLCBvcmRlciwgc2VsZi5tZXJnZV9iYXNl KGdpdF9jb21taXQpLCAiLS0iXQogICAgICAgICBpZiBjaGFuZ2VkX2ZpbGVzOgogICAgICAgICAg ICAgY29tbWFuZCArPSBjaGFuZ2VkX2ZpbGVzCiAgICAgICAgIHJldHVybiBzZWxmLnByZXBlbmRf c3ZuX3JldmlzaW9uKHNlbGYucnVuKGNvbW1hbmQsIGRlY29kZV9vdXRwdXQ9RmFsc2UsIGN3ZD1z ZWxmLmNoZWNrb3V0X3Jvb3QpKQo=