92301 2012-07-25 14:25:38 -0700 [BlackBerry] readPixels on FBOs are limited to canvas size on SGX platforms 2012-07-26 09:34:55 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jnetterfield webkit-unassigned noam tonikitoo webkit.review.bot oldest_to_newest 678468 0 jnetterfield 2012-07-25 14:25:38 -0700 We use a workaround for readPixels because of some problems the SGX driver has with reading pixels. This workaround is currently limited to the size of the canvas. 678607 1 154479 jnetterfield 2012-07-25 16:42:26 -0700 Created attachment 154479 Patch 678791 2 154479 rwlbuis 2012-07-25 19:32:49 -0700 Comment on attachment 154479 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154479&action=review > Source/WebCore/ChangeLog:8 > + This fixes an existing test (uninitialized-test), no new tests. Better state which one. > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:120 > + readPixels(x, y, width, height, GL_RGBA, GL_UNSIGNED_BYTE, pixels); This seems not BB specific? Is it safe to do? 679268 3 jnetterfield 2012-07-26 06:43:46 -0700 Right. Forgot about the anti-aliasing stuff on other platforms. I wonder if it's intentionally not in readPixelsAndConvertToBGRAIfNecessary... 679270 4 154642 jnetterfield 2012-07-26 06:45:25 -0700 Created attachment 154642 Patch 679287 5 154642 rwlbuis 2012-07-26 07:04:57 -0700 Comment on attachment 154642 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154642&action=review Better :) > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:127 > + ::glReadPixels(x, y, width, height, GL_RGBA, GL_UNSIGNED_BYTE, pixels); You do the same thing twice, could add a helper method for that, but as we discussed can be done later. 679429 6 154642 webkit.review.bot 2012-07-26 09:34:51 -0700 Comment on attachment 154642 Patch Clearing flags on attachment: 154642 Committed r123759: <http://trac.webkit.org/changeset/123759> 679430 7 webkit.review.bot 2012-07-26 09:34:55 -0700 All reviewed patches have been landed. Closing bug. 154479 2012-07-25 16:42:26 -0700 2012-07-26 06:45:21 -0700 Patch bug-92301-20120725194124.patch text/plain 2553 jnetterfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThmMGNiYjc0M2JiNjEz OGIwZjA0MTkwZDIxZjhmM2M1OGM5OTNhOC4uODU2NTVmMjMwMDAxNGM2YjBjZGZhNjRiMjkwODZh MzY5OWZiYTk0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTI1ICBKb3No dWEgTmV0dGVyZmllbGQgIDxqbmV0dGVyZmllbGRAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tC ZXJyeV0gcmVhZFBpeGVscyBvbiBGQk9zIGFyZSBsaW1pdGVkIHRvIGNhbnZhcyBzaXplIG9uIFNH WCBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkyMzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyBmaXhlcyBhbiBleGlzdGluZyB0ZXN0ICh1bmluaXRpYWxpemVkLXRlc3QpLCBubyBu ZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3ND b250ZXh0M0RPcGVuR0xFUy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQz RDo6cmVhZFBpeGVscyk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6cmVh ZFBpeGVsc0FuZENvbnZlcnRUb0JHUkFJZk5lY2Vzc2FyeSk6CisKIDIwMTItMDctMjUgIE5pY28g V2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bS9tYWNdIFJl bW92ZSBtYWNfYnVuZGxlX3Jlc291cmNlcyBzZWN0aW9uIGZyb20gV2ViQ29yZS5neXAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0Nv bnRleHQzRE9wZW5HTEVTLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29w ZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTEVTLmNwcAppbmRleCA3OWRkY2JiZmQ5YTRiNTVl YzgyNmU0MWI1OTVlZWY4NGU2NGQ5ZDAzLi5lNjdiMWUyMjZmYjM1NWI1ZmRiMGY0NjU1YTllNGUy YTI1ZDc3ZTljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9v cGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xFUy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMRVMuY3BwCkBA IC0xMDAsMTMgKzEwMCwxMyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpyZWFkUGl4ZWxzKEdD M0RpbnQgeCwgR0MzRGludCB5LCBHQzNEc2l6ZWkgd2lkdGgsIEdDM0RzaQogCiAgICAgZGVsZXRl IFtdIGNhbnZhc0RhdGE7CiAjaWYgUExBVEZPUk0oQkxBQ0tCRVJSWSkKLSAgICAvLyBJbWFnaW5h dGlvbiBzcGVjaWZpYyBmaXgKLSAgICBpZiAobV9pc0ltYWdpbmF0aW9uSGFyZHdhcmUpCisgICAg aWYgKG1faXNJbWFnaW5hdGlvbkhhcmR3YXJlICYmIG1fZmJvID09IG1fYm91bmRGQk8pIHsKKyAg ICAgICAgLy8gRklYTUU6IFRoaXMgd29ya2Fyb3VuZCBzaG91bGQgYWx3YXlzIGJlIHVzZWQgdW50 aWwgdGhlCisgICAgICAgIC8vIGRyaXZlciBhbGlnbm1lbnQgYnVnIGlzIGZpeGVkLCBldmVuIHdo ZW4gd2UgYXJlbid0CisgICAgICAgIC8vIGRyYXdpbmcgdG8gdGhlIGNhbnZhcy4KICAgICAgICAg cmVhZFBpeGVsc0lNRyh4LCB5LCB3aWR0aCwgaGVpZ2h0LCBmb3JtYXQsIHR5cGUsIGRhdGEpOwot ICAgIGVsc2UKKyAgICB9IGVsc2UKICAgICAgICAgOjpnbFJlYWRQaXhlbHMoeCwgeSwgd2lkdGgs IGhlaWdodCwgZm9ybWF0LCB0eXBlLCBkYXRhKTsKLQotICAgIC8vIE5vdGU6IEJsYWNrQmVycmll cyBoYXZlIGEgZGlmZmVyZW50IGFudGktYWxpYXNpbmcgcGlwZWxpbmUuCiAjZWxzZQogICAgIDo6 Z2xSZWFkUGl4ZWxzKHgsIHksIHdpZHRoLCBoZWlnaHQsIGZvcm1hdCwgdHlwZSwgZGF0YSk7CiAK QEAgLTExNyw3ICsxMTcsNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpyZWFkUGl4ZWxzKEdD M0RpbnQgeCwgR0MzRGludCB5LCBHQzNEc2l6ZWkgd2lkdGgsIEdDM0RzaQogCiB2b2lkIEdyYXBo aWNzQ29udGV4dDNEOjpyZWFkUGl4ZWxzQW5kQ29udmVydFRvQkdSQUlmTmVjZXNzYXJ5KGludCB4 LCBpbnQgeSwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0LCB1bnNpZ25lZCBjaGFyKiBwaXhlbHMpCiB7 Ci0gICAgOjpnbFJlYWRQaXhlbHMoeCwgeSwgd2lkdGgsIGhlaWdodCwgR0xfUkdCQSwgR0xfVU5T SUdORURfQllURSwgcGl4ZWxzKTsKKyAgICByZWFkUGl4ZWxzKHgsIHksIHdpZHRoLCBoZWlnaHQs IEdMX1JHQkEsIEdMX1VOU0lHTkVEX0JZVEUsIHBpeGVscyk7CiAgICAgaW50IHRvdGFsQnl0ZXMg PSB3aWR0aCAqIGhlaWdodCAqIDQ7CiAgICAgaWYgKGlzR0xFUzJDb21wbGlhbnQoKSkgewogICAg ICAgICBmb3IgKGludCBpID0gMDsgaSA8IHRvdGFsQnl0ZXM7IGkgKz0gNCkK 154642 2012-07-26 06:45:25 -0700 2012-07-26 09:34:50 -0700 Patch bug-92301-20120726094421.patch text/plain 2936 jnetterfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2MyNGQyZWQ5YTI5YWJj NWNkYmM2NDI1ODkxODJiMzEzYzQxOGU4YS4uN2FjYWVmNGNjNzA3YzM3NGU2NzQ3NmU0MWU4NGY3 NDc2ZTNjMzg4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTI1ICBKb3No dWEgTmV0dGVyZmllbGQgIDxqbmV0dGVyZmllbGRAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tC ZXJyeV0gcmVhZFBpeGVscyBvbiBGQk9zIGFyZSBsaW1pdGVkIHRvIGNhbnZhcyBzaXplIG9uIFNH WCBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkyMzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyBmaXhlcyBmYXN0L2NhbnZhcy93ZWJnbC91bmluaXRpYWxpemVkLXRlc3QuaHRtbCBv biBCbGFja0JlcnJ5LCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xFUy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpHcmFwaGljc0NvbnRleHQzRDo6cmVhZFBpeGVscyk6CisgICAgICAgIChXZWJDb3JlOjpHcmFw aGljc0NvbnRleHQzRDo6cmVhZFBpeGVsc0FuZENvbnZlcnRUb0JHUkFJZk5lY2Vzc2FyeSk6CisK IDIwMTItMDctMjYgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogbW92ZSBTdHJpbmdJbXBsIHNpemUgY2FsY3VsYXRpb24gdG8g U3RyaW5nSW1wbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv b3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMRVMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMRVMuY3BwCmluZGV4 IDc5ZGRjYmJmZDlhNGI1NWVjODI2ZTQxYjU5NWVlZjg0ZTY0ZDlkMDMuLjA3ZTVhNzIyMzhlMTYy ZjU0ZGRmYmRjYTIxOWUyZmYzMmM0Nzg4ZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTEVTLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0 M0RPcGVuR0xFUy5jcHAKQEAgLTEwMCwxMyArMTAwLDEzIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0 M0Q6OnJlYWRQaXhlbHMoR0MzRGludCB4LCBHQzNEaW50IHksIEdDM0RzaXplaSB3aWR0aCwgR0Mz RHNpCiAKICAgICBkZWxldGUgW10gY2FudmFzRGF0YTsKICNpZiBQTEFURk9STShCTEFDS0JFUlJZ KQotICAgIC8vIEltYWdpbmF0aW9uIHNwZWNpZmljIGZpeAotICAgIGlmIChtX2lzSW1hZ2luYXRp b25IYXJkd2FyZSkKKyAgICBpZiAobV9pc0ltYWdpbmF0aW9uSGFyZHdhcmUgJiYgbV9mYm8gPT0g bV9ib3VuZEZCTykgeworICAgICAgICAvLyBGSVhNRTogVGhpcyB3b3JrYXJvdW5kIHNob3VsZCBh bHdheXMgYmUgdXNlZCB1bnRpbCB0aGUKKyAgICAgICAgLy8gZHJpdmVyIGFsaWdubWVudCBidWcg aXMgZml4ZWQsIGV2ZW4gd2hlbiB3ZSBhcmVuJ3QKKyAgICAgICAgLy8gZHJhd2luZyB0byB0aGUg Y2FudmFzLgogICAgICAgICByZWFkUGl4ZWxzSU1HKHgsIHksIHdpZHRoLCBoZWlnaHQsIGZvcm1h dCwgdHlwZSwgZGF0YSk7Ci0gICAgZWxzZQorICAgIH0gZWxzZQogICAgICAgICA6OmdsUmVhZFBp eGVscyh4LCB5LCB3aWR0aCwgaGVpZ2h0LCBmb3JtYXQsIHR5cGUsIGRhdGEpOwotCi0gICAgLy8g Tm90ZTogQmxhY2tCZXJyaWVzIGhhdmUgYSBkaWZmZXJlbnQgYW50aS1hbGlhc2luZyBwaXBlbGlu ZS4KICNlbHNlCiAgICAgOjpnbFJlYWRQaXhlbHMoeCwgeSwgd2lkdGgsIGhlaWdodCwgZm9ybWF0 LCB0eXBlLCBkYXRhKTsKIApAQCAtMTE3LDcgKzExNywxNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4 dDNEOjpyZWFkUGl4ZWxzKEdDM0RpbnQgeCwgR0MzRGludCB5LCBHQzNEc2l6ZWkgd2lkdGgsIEdD M0RzaQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpyZWFkUGl4ZWxzQW5kQ29udmVydFRvQkdS QUlmTmVjZXNzYXJ5KGludCB4LCBpbnQgeSwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0LCB1bnNpZ25l ZCBjaGFyKiBwaXhlbHMpCiB7CisjaWYgUExBVEZPUk0oQkxBQ0tCRVJSWSkKKyAgICBpZiAobV9p c0ltYWdpbmF0aW9uSGFyZHdhcmUgJiYgbV9mYm8gPT0gbV9ib3VuZEZCTykgeworICAgICAgICAv LyBGSVhNRTogVGhpcyB3b3JrYXJvdW5kIHNob3VsZCBhbHdheXMgYmUgdXNlZCB1bnRpbCB0aGUK KyAgICAgICAgLy8gZHJpdmVyIGFsaWdubWVudCBidWcgaXMgZml4ZWQsIGV2ZW4gd2hlbiB3ZSBh cmVuJ3QKKyAgICAgICAgLy8gZHJhd2luZyB0byB0aGUgY2FudmFzLgorICAgICAgICByZWFkUGl4 ZWxzSU1HKHgsIHksIHdpZHRoLCBoZWlnaHQsIEdMX1JHQkEsIEdMX1VOU0lHTkVEX0JZVEUsIHBp eGVscyk7CisgICAgfSBlbHNlCisgICAgICAgIDo6Z2xSZWFkUGl4ZWxzKHgsIHksIHdpZHRoLCBo ZWlnaHQsIEdMX1JHQkEsIEdMX1VOU0lHTkVEX0JZVEUsIHBpeGVscyk7CisjZWxzZQogICAgIDo6 Z2xSZWFkUGl4ZWxzKHgsIHksIHdpZHRoLCBoZWlnaHQsIEdMX1JHQkEsIEdMX1VOU0lHTkVEX0JZ VEUsIHBpeGVscyk7CisjZW5kaWYKICAgICBpbnQgdG90YWxCeXRlcyA9IHdpZHRoICogaGVpZ2h0 ICogNDsKICAgICBpZiAoaXNHTEVTMkNvbXBsaWFudCgpKSB7CiAgICAgICAgIGZvciAoaW50IGkg PSAwOyBpIDwgdG90YWxCeXRlczsgaSArPSA0KQo=