92295 2012-07-25 14:04:11 -0700 [WebGL] ANGLEWebKitBridge should support ESSL platforms 2012-07-26 08:26:12 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jnetterfield webkit-unassigned mifenton noam webkit.review.bot oldest_to_newest 678440 0 jnetterfield 2012-07-25 14:04:11 -0700 There should be a way for ESSL platforms to request ESSL output from ANGLE. 678568 1 jnetterfield 2012-07-25 16:04:07 -0700 Didn't see https://bugs.webkit.org/show_bug.cgi?id=87718 (it hasn't landed in our downstream repo yet). This bug is now for having Blackberry take advantage of that. 678609 2 154480 jnetterfield 2012-07-25 16:44:54 -0700 Created attachment 154480 Patch 678796 3 154480 rwlbuis 2012-07-25 19:38:16 -0700 Comment on attachment 154480 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154480&action=review > Source/WebCore/ChangeLog:9 > + glsl-mat4-to-mat3.html) To me as an GLES and shader n00b, it is not clear how the two code sections relate? What does SH_ESSL_OUTPUT do, and why does it mean the hack can be removed? You may have to improve the commit message so more people understand how this change fixes the problem. 679279 4 154645 jnetterfield 2012-07-26 06:53:14 -0700 Created attachment 154645 Patch 679281 5 154645 rwlbuis 2012-07-26 06:54:57 -0700 Comment on attachment 154645 Patch Okay. 679358 6 154645 webkit.review.bot 2012-07-26 08:26:09 -0700 Comment on attachment 154645 Patch Clearing flags on attachment: 154645 Committed r123749: <http://trac.webkit.org/changeset/123749> 679359 7 webkit.review.bot 2012-07-26 08:26:12 -0700 All reviewed patches have been landed. Closing bug. 154480 2012-07-25 16:44:54 -0700 2012-07-26 06:53:10 -0700 Patch bug-92295-20120725194352.patch text/plain 3014 jnetterfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODU2NTVmMjMwMDAxNGM2 YjBjZGZhNjRiMjkwODZhMzY5OWZiYTk0ZS4uZTZmZDQ4MjM3MjRjMTRkOGI2NDkyZWU1NjcyYTgy MTM3NTY2YWEyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTA3LTI1ICBKb3No dWEgTmV0dGVyZmllbGQgIDxqbmV0dGVyZmllbGRAcmltLmNvbT4KIAorICAgICAgICBbV2ViR0xd IEFOR0xFV2ViS2l0QnJpZGdlIHNob3VsZCBzdXBwb3J0IEVTU0wgcGxhdGZvcm1zCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjI5NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgZWxpbWluYXRlcyB0 aGUgbmVlZCBmb3IgYSBoYWNrIGFuZCBmaXhlcyBtYW55IHRlc3RzIChmb3IgZXhhbXBsZSwKKyAg ICAgICAgZ2xzbC1tYXQ0LXRvLW1hdDMuaHRtbCkKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2JsYWNrYmVycnkvR3JhcGhpY3NDb250ZXh0M0RCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjpHcmFwaGljc0NvbnRleHQzRCk6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTENvbW1vbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpFeHRlbnNpb25zM0RPcGVuR0xDb21tb246OmdldFRyYW5zbGF0 ZWRTaGFkZXJTb3VyY2VBTkdMRSk6CisKKzIwMTItMDctMjUgIEpvc2h1YSBOZXR0ZXJmaWVsZCAg PGpuZXR0ZXJmaWVsZEByaW0uY29tPgorCiAgICAgICAgIFtCbGFja0JlcnJ5XSByZWFkUGl4ZWxz IG9uIEZCT3MgYXJlIGxpbWl0ZWQgdG8gY2FudmFzIHNpemUgb24gU0dYIHBsYXRmb3JtcwogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIzMDEKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9HcmFw aGljc0NvbnRleHQzREJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9HcmFwaGljc0NvbnRleHQzREJsYWNrQmVycnkuY3BwCmluZGV4IGRk NGUzZjRjODVhODYzNDUxOWMzZmUyYzAzZmUzYWNjYzA1M2M4YTcuLmRjNDRjYzdjZjMyNTMxMzYw OWM4MWMzMzc3ZDQ1MGE0OWFhODE3NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvR3JhcGhpY3NDb250ZXh0M0RCbGFja0JlcnJ5LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0dyYXBoaWNz Q29udGV4dDNEQmxhY2tCZXJyeS5jcHAKQEAgLTU0LDYgKzU0LDcgQEAgR3JhcGhpY3NDb250ZXh0 M0Q6OkdyYXBoaWNzQ29udGV4dDNEKEdyYXBoaWNzQ29udGV4dDNEOjpBdHRyaWJ1dGVzIGF0dHJz LCBIb3N0V2kKICAgICA6IG1fY3VycmVudFdpZHRoKDApCiAgICAgLCBtX2N1cnJlbnRIZWlnaHQo MCkKICAgICAsIG1fY29udGV4dChCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhpY3M6OmNyZWF0 ZVdlYkdMQ29udGV4dCgpKQorICAgICwgbV9jb21waWxlcihTSF9FU1NMX09VVFBVVCkKICAgICAs IG1fZXh0ZW5zaW9ucyhhZG9wdFB0cihuZXcgRXh0ZW5zaW9uczNET3BlbkdMRVModGhpcykpKQog ICAgICwgbV9hdHRycyhhdHRycykKICAgICAsIG1fdGV4dHVyZSgwKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTENv bW1vbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5z aW9uczNET3BlbkdMQ29tbW9uLmNwcAppbmRleCA1OGZjN2Y3ZGViMGQ4Njk2ZGE3MWJkZDc5NWVj YTFmZDEwODc5NDQyLi41YTYyODgxMGRmZDEyNzY3MDYwZWEwZjRlNjIxODAyYzY5YTNhOGViIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5z aW9uczNET3BlbkdMQ29tbW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMQ29tbW9uLmNwcApAQCAtMTMwLDE2ICsxMzAs NiBAQCBTdHJpbmcgRXh0ZW5zaW9uczNET3BlbkdMQ29tbW9uOjpnZXRUcmFuc2xhdGVkU2hhZGVy U291cmNlQU5HTEUoUGxhdGZvcm0zRE9iamVjdAogICAgIGlmICghaXNWYWxpZCkKICAgICAgICAg cmV0dXJuICIiOwogCi0jaWYgUExBVEZPUk0oQkxBQ0tCRVJSWSkKLSAgICAvLyBPdXIgaGFyZHdh cmUgcmVhbGx5IGxpa2VzIGJlaW5nIHRvbGQgd2hhdCBwcmVjaXNpb24gdG8gaGF2ZSAoaS5lLiwg d2l0aCAicHJlY2lzaW9uICogZmxvYXQiKQotICAgIC8vIEFOR0xFIHN0cmlwcyB0aGlzIGluZm9y bWF0aW9uLgotICAgIGlmIChlbnRyeS5zb3VyY2UuY29udGFpbnMoInByZWNpc2lvbiBsb3dwIGZs b2F0IikpCi0gICAgICAgIHRyYW5zbGF0ZWRTaGFkZXJTb3VyY2UgPSAicHJlY2lzaW9uIGxvd3Ag ZmxvYXQ7XG4iICsgdHJhbnNsYXRlZFNoYWRlclNvdXJjZTsKLSAgICBlbHNlIGlmIChlbnRyeS5z b3VyY2UuY29udGFpbnMoInByZWNpc2lvbiBtZWRpdW1wIGZsb2F0IikpCi0gICAgICAgIHRyYW5z bGF0ZWRTaGFkZXJTb3VyY2UgPSAicHJlY2lzaW9uIG1lZGl1bXAgZmxvYXQ7XG4iICsgdHJhbnNs YXRlZFNoYWRlclNvdXJjZTsKLSAgICBlbHNlCi0gICAgICAgIHRyYW5zbGF0ZWRTaGFkZXJTb3Vy Y2UgPSAicHJlY2lzaW9uIGhpZ2hwIGZsb2F0O1xuIiArIHRyYW5zbGF0ZWRTaGFkZXJTb3VyY2U7 Ci0jZW5kaWYKICAgICByZXR1cm4gdHJhbnNsYXRlZFNoYWRlclNvdXJjZTsKIH0KIAo= 154645 2012-07-26 06:53:14 -0700 2012-07-26 08:26:09 -0700 Patch bug-92295-20120726095210.patch text/plain 3178 jnetterfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2FjYWVmNGNjNzA3YzM3 NGU2NzQ3NmU0MWU4NGY3NDc2ZTNjMzg4Ni4uNDMzNjBmNWMzNTJkMTBhY2MxYzY2NmJmYjUzMzk2 OWY0M2MyMjVhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTA3LTI1ICBKb3No dWEgTmV0dGVyZmllbGQgIDxqbmV0dGVyZmllbGRAcmltLmNvbT4KIAorICAgICAgICBbV2ViR0xd IEFOR0xFV2ViS2l0QnJpZGdlIHNob3VsZCBzdXBwb3J0IEVTU0wgcGxhdGZvcm1zCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjI5NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgdGVsbHMgQU5HTEVX ZWJLaXRCcmlkZ2UgdG8gb3V0cHV0IEVTU0wgY29kZSBmb3IgdGhlIEJsYWNrQmVycnkKKyAgICAg ICAgcGxhdGZvcm0uIFRoaXMgZWxpbWluYXRlcyB0aGUgbmVlZCBmb3IgYSBwcmV2aW91cyBoYWNr LiBJbiBhZGRpdGlvbiwKKyAgICAgICAgc29tZSAoR0xTTCkgQU5HTEUgb3V0cHV0IHRoYXQgY291 bGQgbm90IGJlIGNvbXBpbGVkIChmb3IgZXhhbXBsZSwKKyAgICAgICAgZ2xzbC1tYXQ0LXRvLW1h dDMuaHRtbCkgbm93IGNvbXBpbGVzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxh Y2tiZXJyeS9HcmFwaGljc0NvbnRleHQzREJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6R3JhcGhpY3NDb250ZXh0M0Q6OkdyYXBoaWNzQ29udGV4dDNEKToKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMQ29tbW9uLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkV4dGVuc2lvbnMzRE9wZW5HTENvbW1vbjo6Z2V0VHJhbnNsYXRlZFNoYWRl clNvdXJjZUFOR0xFKToKKworMjAxMi0wNy0yNSAgSm9zaHVhIE5ldHRlcmZpZWxkICA8am5ldHRl cmZpZWxkQHJpbS5jb20+CisKICAgICAgICAgW0JsYWNrQmVycnldIHJlYWRQaXhlbHMgb24gRkJP cyBhcmUgbGltaXRlZCB0byBjYW52YXMgc2l6ZSBvbiBTR1ggcGxhdGZvcm1zCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjMwMQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0dyYXBoaWNzQ29u dGV4dDNEQmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9i bGFja2JlcnJ5L0dyYXBoaWNzQ29udGV4dDNEQmxhY2tCZXJyeS5jcHAKaW5kZXggMzQ0ZWI5NTNk NmIzMDU5ZjBlOWE1Mzk4OWMwYWMzODgxN2FiMDI1Zi4uMzY5OGZkMjVmMTI5YzJjNDA3NmQ1Mzlh ODNlYjlhMmRhNjFiN2RlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9HcmFwaGljc0NvbnRleHQzREJsYWNrQmVycnkuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvR3JhcGhpY3NDb250ZXh0 M0RCbGFja0JlcnJ5LmNwcApAQCAtNTQsNiArNTQsNyBAQCBHcmFwaGljc0NvbnRleHQzRDo6R3Jh cGhpY3NDb250ZXh0M0QoR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0ZXMgYXR0cnMsIEhvc3RX aQogICAgIDogbV9jdXJyZW50V2lkdGgoMCkKICAgICAsIG1fY3VycmVudEhlaWdodCgwKQogICAg ICwgbV9jb250ZXh0KEJsYWNrQmVycnk6OlBsYXRmb3JtOjpHcmFwaGljczo6Y3JlYXRlV2ViR0xD b250ZXh0KCkpCisgICAgLCBtX2NvbXBpbGVyKFNIX0VTU0xfT1VUUFVUKQogICAgICwgbV9leHRl bnNpb25zKGFkb3B0UHRyKG5ldyBFeHRlbnNpb25zM0RPcGVuR0xFUyh0aGlzKSkpCiAgICAgLCBt X2F0dHJzKGF0dHJzKQogICAgICwgbV90ZXh0dXJlKDApCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMQ29tbW9uLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RP cGVuR0xDb21tb24uY3BwCmluZGV4IDU4ZmM3ZjdkZWIwZDg2OTZkYTcxYmRkNzk1ZWNhMWZkMTA4 Nzk0NDIuLjVhNjI4ODEwZGZkMTI3NjcwNjBlYTBmNGU2MjE4MDJjNjlhM2E4ZWIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RP cGVuR0xDb21tb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29w ZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xDb21tb24uY3BwCkBAIC0xMzAsMTYgKzEzMCw2IEBAIFN0 cmluZyBFeHRlbnNpb25zM0RPcGVuR0xDb21tb246OmdldFRyYW5zbGF0ZWRTaGFkZXJTb3VyY2VB TkdMRShQbGF0Zm9ybTNET2JqZWN0CiAgICAgaWYgKCFpc1ZhbGlkKQogICAgICAgICByZXR1cm4g IiI7CiAKLSNpZiBQTEFURk9STShCTEFDS0JFUlJZKQotICAgIC8vIE91ciBoYXJkd2FyZSByZWFs bHkgbGlrZXMgYmVpbmcgdG9sZCB3aGF0IHByZWNpc2lvbiB0byBoYXZlIChpLmUuLCB3aXRoICJw cmVjaXNpb24gKiBmbG9hdCIpCi0gICAgLy8gQU5HTEUgc3RyaXBzIHRoaXMgaW5mb3JtYXRpb24u Ci0gICAgaWYgKGVudHJ5LnNvdXJjZS5jb250YWlucygicHJlY2lzaW9uIGxvd3AgZmxvYXQiKSkK LSAgICAgICAgdHJhbnNsYXRlZFNoYWRlclNvdXJjZSA9ICJwcmVjaXNpb24gbG93cCBmbG9hdDtc biIgKyB0cmFuc2xhdGVkU2hhZGVyU291cmNlOwotICAgIGVsc2UgaWYgKGVudHJ5LnNvdXJjZS5j b250YWlucygicHJlY2lzaW9uIG1lZGl1bXAgZmxvYXQiKSkKLSAgICAgICAgdHJhbnNsYXRlZFNo YWRlclNvdXJjZSA9ICJwcmVjaXNpb24gbWVkaXVtcCBmbG9hdDtcbiIgKyB0cmFuc2xhdGVkU2hh ZGVyU291cmNlOwotICAgIGVsc2UKLSAgICAgICAgdHJhbnNsYXRlZFNoYWRlclNvdXJjZSA9ICJw cmVjaXNpb24gaGlnaHAgZmxvYXQ7XG4iICsgdHJhbnNsYXRlZFNoYWRlclNvdXJjZTsKLSNlbmRp ZgogICAgIHJldHVybiB0cmFuc2xhdGVkU2hhZGVyU291cmNlOwogfQogCg==