92266 2012-07-25 10:31:59 -0700 [chromium] Build fix for clang builds after r123628 2012-07-25 10:45:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shawnsingh shawnsingh cc-bugs enne jamesr webkit.review.bot oldest_to_newest 678202 0 shawnsingh 2012-07-25 10:31:59 -0700 Just one un-used variable that was leftover after refactoring. on clang in our build setups, that's considered a build error. 678209 1 154387 shawnsingh 2012-07-25 10:36:24 -0700 Created attachment 154387 Patch 678213 2 154387 enne 2012-07-25 10:40:26 -0700 Comment on attachment 154387 Patch R=me. 678222 3 shawnsingh 2012-07-25 10:44:19 -0700 Committed r123633: <http://trac.webkit.org/changeset/123633> 678224 4 154387 shawnsingh 2012-07-25 10:45:25 -0700 Comment on attachment 154387 Patch landed directly instead of cq. 154387 2012-07-25 10:36:24 -0700 2012-07-25 10:45:25 -0700 Patch bug-92266-20120725103615.patch text/plain 1860 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTA1M2I1YWRmOTJmZTFk MzU1Y2Q1ZTk0ODk4NWI1NTM5ZWI1MWI0YS4uZTgxYzhhOGQzZDM4ZjI1NDQ2YTc5ZGYzM2RhYjM0 Mjk1ZGZhMzIwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTI1ICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g QnVpbGQgZml4IGZvciBjbGFuZyBidWlsZHMgYWZ0ZXIgcjEyMzYyOAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIyNjYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbiB1bi11c2VkIHZhcmlhYmxlIHdhcyBj YXVzaW5nIGJ1aWxkIGZhaWx1cmVzIGZvciBjbGFuZyBidWlsZHMKKyAgICAgICAgYWZ0ZXIgdGhl IHJlZmFjdG9yaW5nIGluIHIxMjM2MjguICBJdCBpcyBjb3JyZWN0IHRvIHNpbXBseSByZW1vdmUK KyAgICAgICAgdGhpcyB2YWx1ZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL2NjL0NDTGF5ZXJUcmVlSG9zdENvbW1vbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjYWxj dWxhdGVEcmF3VHJhbnNmb3Jtc0ludGVybmFsKToKKwogMjAxMi0wNy0yNSAgQWRyaWVubmUgV2Fs a2VyICA8ZW5uZUBnb29nbGUuY29tPgogCiAgICAgICAgIFtjaHJvbWl1bV0gVW5pZnkgY29tcG9z aXRvciBxdWFkVHJhbnNmb3JtL2RyYXdUcmFuc2Zvcm0vb3JpZ2luVHJhbnNmb3JtCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVy VHJlZUhvc3RDb21tb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vY2MvQ0NMYXllclRyZWVIb3N0Q29tbW9uLmNwcAppbmRleCA5Y2I5MWYxZDAxNDE3MzE1 ZWI1YWU4M2MyOWFlODQ2OTU0ZDZmYzU1Li41M2QyNjVjMjlkODA3YmY3NWQ2NDJhNjhlZjZlM2Ex Y2YxOTBiMGQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RDb21tb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdENvbW1vbi5jcHAK QEAgLTczMCw3ICs3MzAsNiBAQCBzdGF0aWMgdm9pZCBjYWxjdWxhdGVEcmF3VHJhbnNmb3Jtc0lu dGVybmFsKExheWVyVHlwZSogbGF5ZXIsIExheWVyVHlwZSogcm9vdExheQogICAgIGlmIChsYXll ci0+cmVuZGVyU3VyZmFjZSgpICYmIGxheWVyICE9IHJvb3RMYXllcikgewogICAgICAgICBSZW5k ZXJTdXJmYWNlVHlwZSogcmVuZGVyU3VyZmFjZSA9IGxheWVyLT5yZW5kZXJTdXJmYWNlKCk7CiAg ICAgICAgIEludFJlY3QgY2xpcHBlZENvbnRlbnRSZWN0ID0gbG9jYWxEcmF3YWJsZUNvbnRlbnRS ZWN0T2ZTdWJ0cmVlOwotICAgICAgICBGbG9hdFBvaW50IHN1cmZhY2VDZW50ZXIgPSBGbG9hdFJl Y3QoY2xpcHBlZENvbnRlbnRSZWN0KS5jZW50ZXIoKTsKIAogICAgICAgICAvLyBUaGUgcmVuZGVy IHN1cmZhY2UgY2xpcFJlY3QgaXMgZXhwcmVzc2VkIGluIHRoZSBzcGFjZSB3aGVyZSB0aGlzIHN1 cmZhY2UgZHJhd3MsIGkuZS4gdGhlIHNhbWUgc3BhY2UgYXMgY2xpcFJlY3RGcm9tQW5jZXN0b3Iu CiAgICAgICAgIGlmIChhbmNlc3RvckNsaXBzU3VidHJlZSkK