92260 2012-07-25 09:08:48 -0700 Repalce "int" with "long" from WebCore/*.idls 2012-07-25 20:25:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 code.vineet code.vineet abarth haraken ojan webkit.review.bot oldest_to_newest 678130 0 code.vineet 2012-07-25 09:08:48 -0700 As per the WebIDL spec IDL shouldn't have int attributes but long instead. 678146 1 154372 code.vineet 2012-07-25 09:21:17 -0700 Created attachment 154372 patch ArrayBuffer spec url http://www.khronos.org/registry/typedarray/specs/latest/#5 No new tests added as this shouldn't cause any regression. 678205 2 code.vineet 2012-07-25 10:33:03 -0700 Thanks abarth, as per comment https://bugs.webkit.org/show_bug.cgi?id=92181#c14 I will replace all int to "unsigned long" in one patch here with changes bug title below are the files to be chaged. ./dom/Touch.idl: readonly attribute int webkitRadiusX; ./dom/Touch.idl: readonly attribute int webkitRadiusY; ./dom/WebKitNamedFlow.idl: readonly attribute int firstEmptyRegionIndex; ./html/canvas/WebGLActiveInfo.idl: readonly attribute int size; ./html/canvas/WebGLActiveInfo.idl: readonly attribute unsigned int type; ./html/canvas/WebGLShaderPrecisionFormat.idl: readonly attribute int rangeMin; ./html/canvas/WebGLShaderPrecisionFormat.idl: readonly attribute int rangeMax; ./html/canvas/WebGLShaderPrecisionFormat.idl: readonly attribute int precision; ./page/WebKitAnimation.idl: readonly attribute [Custom] int iterationCount; 678279 3 abarth 2012-07-25 11:23:41 -0700 It's not clear that they should all be "unsigned long". You need to check the specs for each one to see what the correct type is. 678336 4 154415 code.vineet 2012-07-25 12:26:03 -0700 Created attachment 154415 updated_patch (In reply to comment #3) > It's not clear that they should all be "unsigned long". You need to check the specs for each one to see what the correct type is. Yes not all, only those are "unsinged int" should be repalced with "unsigned long" else for "int" with "long". ArrayBuffer.idl: http://www.khronos.org/registry/typedarray/specs/latest/#5 //Spec says should be unsinged long Touch.idl: http://dvcs.w3.org/hg/webevents/raw-file/tip/touchevents.html#idl-def-Touch WebKitNamedFlow.idl: http://www.w3.org/TR/css3-regions/#dom-named-flow-first-empty-region-index WebGLActiveInfo.idl: http://www.khronos.org/registry/webgl/specs/latest/#5.11 WebGLShaderPrecisionFormat.idl: http://www.khronos.org/registry/webgl/specs/latest/#5.12 WebKitAnimation.idl: http://www.w3.org/TR/css3-animations/#animation-iteration-count 678809 5 154415 webkit.review.bot 2012-07-25 20:01:03 -0700 Comment on attachment 154415 updated_patch Rejecting attachment 154415 from commit-queue. rgf748@motorola.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 678823 6 154415 webkit.review.bot 2012-07-25 20:25:07 -0700 Comment on attachment 154415 updated_patch Clearing flags on attachment: 154415 Committed r123705: <http://trac.webkit.org/changeset/123705> 678824 7 webkit.review.bot 2012-07-25 20:25:11 -0700 All reviewed patches have been landed. Closing bug. 154372 2012-07-25 09:21:17 -0700 2012-07-25 12:26:03 -0700 patch restructure.diff text/plain 1368 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzYyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTI1ICBWaW5lZXQg Q2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xhLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIyNjAKKyAgICAgICAgUmVwYWxjZSAiaW50IiB3 aXRoICJ1bnNpZ25lZCBsb25nIiBmb3IgQXJyYXlCdWZmZXIuaWRsCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgcGVyIHRoZSBXZWJJREwgc3BlYyBJ REwgc2hvdWxkbid0IGhhdmUgaW50IGF0dHJpYnV0ZXMgYnV0IGxvbmcgaW5zdGVhZC4KKworICAg ICAgICBObyBuZXcgdGVzdHMuIFRlc3RPYmouaWRsIGFscmVhZHkgY292ZXJzIHRoaXMuCisgICAg ICAgIFRoZXJlIHNob3VsZCBiZSBubyBiZWhhdmlvdXJhbCBjaGFuZ2VzLgorCisgICAgICAgICog aHRtbC9jYW52YXMvQXJyYXlCdWZmZXIuaWRsOiBSZXBhbGNlIGludCB3aXRoIHVuc2lnbmVkIGxv bmcuCisKIDIwMTItMDctMjUgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBu b2tpYS5jb20+CiAKICAgICAgICAgTm9kZXNGcm9tUmVjdCBhbmQgYXJlYS1iYXNlZCBoaXQtdGVz dGluZyBjYW4gbm90IGhhbmRsZSBDU1MgdHJhbnNmb3Jtcy4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL0FycmF5QnVmZmVyLmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9odG1sL2NhbnZhcy9BcnJheUJ1ZmZlci5pZGwJKHJldmlzaW9uIDEyMzYwOCkKKysrIFNvdXJj ZS9XZWJDb3JlL2h0bWwvY2FudmFzL0FycmF5QnVmZmVyLmlkbAkod29ya2luZyBjb3B5KQpAQCAt MzEsNyArMzEsNyBAQCBtb2R1bGUgaHRtbCB7CiAgICAgICAgIENvbnN0cnVjdG9yUGFyYW1ldGVy cz0xLAogICAgICAgICBKU05vU3RhdGljVGFibGVzCiAgICAgXSBBcnJheUJ1ZmZlciB7Ci0gICAg ICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBpbnQgYnl0ZUxlbmd0aDsKKyAgICAgICAgcmVhZG9ubHkg YXR0cmlidXRlIHVuc2lnbmVkIGxvbmcgYnl0ZUxlbmd0aDsKICAgICAgICAgQXJyYXlCdWZmZXIg c2xpY2UoaW4gbG9uZyBiZWdpbiwgaW4gW09wdGlvbmFsXSBsb25nIGVuZCk7CiAgICAgfTsKIAoK 154415 2012-07-25 12:26:03 -0700 2012-07-25 20:25:07 -0700 updated_patch restructure_02.diff text/plain 4810 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzY0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA3LTI1ICBWaW5lZXQg Q2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xhLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIyNjAKKyAgICAgICAgUmVwYWxjZSAiaW50IiB3 aXRoICJsb25nIiBmcm9tIFdlYkNvcmUvKi5pZGxzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgcGVyIHRoZSBXZWJJREwgc3BlYyBJREwgc2hvdWxk bid0IGhhdmUgaW50IGF0dHJpYnV0ZXMgYnV0IGxvbmcgaW5zdGVhZC4KKyAgICAgICAgUmVwYWxj ZWQgYXR0cmlidXRlcyB0eXBlcyBpbnQgd2l0aCBsb25nIGZyb20gV2ViQ29yZS8qLmlkbHMuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLiBUZXN0T2JqLmlkbCBhbHJlYWR5IGNvdmVycyB0aGlzLgor ICAgICAgICBUaGVyZSBzaG91bGQgYmUgbm8gYmVoYXZpb3VyYWwgY2hhbmdlcy4KKworICAgICAg ICAqIGRvbS9Ub3VjaC5pZGw6IFJlcGFsY2UgaW50IHdpdGggbG9uZy4KKyAgICAgICAgKiBkb20v V2ViS2l0TmFtZWRGbG93LmlkbDogRGl0dG8uCisgICAgICAgICogaHRtbC9jYW52YXMvQXJyYXlC dWZmZXIuaWRsOiBEaXR0by4KKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTEFjdGl2ZUluZm8u aWRsOiBEaXR0by4KKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFNoYWRlclByZWNpc2lvbkZv cm1hdC5pZGw6IERpdHRvLgorICAgICAgICAqIHBhZ2UvV2ViS2l0QW5pbWF0aW9uLmlkbDogRGl0 dG8uCisKIDIwMTItMDctMjUgICdQYXZlbCBGZWxkbWFuJyAgPHBmZWxkbWFuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBmb2xsb3cgdXAgdG8gcjEyMzYxMiwgZml4aW5n IENTUyB2YWx1ZSBzdWdnZXN0LgpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL1RvdWNoLmlkbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vVG91Y2guaWRsCShyZXZpc2lvbiAxMjM2 MDgpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vVG91Y2guaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0z Niw4ICszNiw4IEBAIG1vZHVsZSBldmVudHMgewogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUg bG9uZyAgICAgICAgICAgICBwYWdlWTsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEV2ZW50 VGFyZ2V0ICAgICAgdGFyZ2V0OwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgdW5zaWduZWQg bG9uZyAgICBpZGVudGlmaWVyOwotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgaW50ICAgICAg ICAgICAgICB3ZWJraXRSYWRpdXNYOwotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgaW50ICAg ICAgICAgICAgICB3ZWJraXRSYWRpdXNZOworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgbG9u ZyAgICAgICAgICAgICB3ZWJraXRSYWRpdXNYOworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUg bG9uZyAgICAgICAgICAgICB3ZWJraXRSYWRpdXNZOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1 dGUgZmxvYXQgICAgICAgICAgICB3ZWJraXRSb3RhdGlvbkFuZ2xlOwogICAgICAgICByZWFkb25s eSBhdHRyaWJ1dGUgZmxvYXQgICAgICAgICAgICB3ZWJraXRGb3JjZTsKICAgICB9OwpJbmRleDog U291cmNlL1dlYkNvcmUvZG9tL1dlYktpdE5hbWVkRmxvdy5pZGwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvZG9tL1dlYktpdE5hbWVkRmxvdy5pZGwJKHJldmlzaW9uIDEyMzYwOCkKKysr IFNvdXJjZS9XZWJDb3JlL2RvbS9XZWJLaXROYW1lZEZsb3cuaWRsCSh3b3JraW5nIGNvcHkpCkBA IC0zMyw3ICszMyw3IEBAIG1vZHVsZSBjb3JlIHsKICAgICBdIFdlYktpdE5hbWVkRmxvdyB7CiAg ICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgbmFtZTsKICAgICAgICAgcmVhZG9u bHkgYXR0cmlidXRlIGJvb2xlYW4gb3ZlcnNldDsKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRl IGludCBmaXJzdEVtcHR5UmVnaW9uSW5kZXg7CisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBs b25nIGZpcnN0RW1wdHlSZWdpb25JbmRleDsKICAgICAgICAgTm9kZUxpc3QgZ2V0UmVnaW9uc0J5 Q29udGVudChpbiBOb2RlIGNvbnRlbnROb2RlKTsKICAgICAgICAgTm9kZUxpc3QgZ2V0Q29udGVu dCgpOwogICAgIH07CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9BcnJheUJ1ZmZl ci5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQXJyYXlCdWZm ZXIuaWRsCShyZXZpc2lvbiAxMjM2MDgpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9B cnJheUJ1ZmZlci5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTMxLDcgKzMxLDcgQEAgbW9kdWxlIGh0 bWwgewogICAgICAgICBDb25zdHJ1Y3RvclBhcmFtZXRlcnM9MSwKICAgICAgICAgSlNOb1N0YXRp Y1RhYmxlcwogICAgIF0gQXJyYXlCdWZmZXIgewotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUg aW50IGJ5dGVMZW5ndGg7CisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSB1bnNpZ25lZCBsb25n IGJ5dGVMZW5ndGg7CiAgICAgICAgIEFycmF5QnVmZmVyIHNsaWNlKGluIGxvbmcgYmVnaW4sIGlu IFtPcHRpb25hbF0gbG9uZyBlbmQpOwogICAgIH07CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL1dlYkdMQWN0aXZlSW5mby5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvaHRtbC9jYW52YXMvV2ViR0xBY3RpdmVJbmZvLmlkbAkocmV2aXNpb24gMTIzNjA4KQorKysg U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xBY3RpdmVJbmZvLmlkbAkod29ya2luZyBj b3B5KQpAQCAtMjgsOCArMjgsOCBAQCBtb2R1bGUgaHRtbCB7CiAgICAgaW50ZXJmYWNlIFsKICAg ICAgICAgQ29uZGl0aW9uYWw9V0VCR0wsCiAgICAgXSBXZWJHTEFjdGl2ZUluZm8gewotICAgICAg ICByZWFkb25seSBhdHRyaWJ1dGUgaW50IHNpemU7Ci0gICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0 ZSB1bnNpZ25lZCBpbnQgdHlwZTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGxvbmcgc2l6 ZTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIHVuc2lnbmVkIGxvbmcgdHlwZTsKICAgICAg ICAgcmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZyBuYW1lOwogICAgIH07CiAKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMU2hhZGVyUHJlY2lzaW9uRm9ybWF0LmlkbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFNoYWRlclByZWNp c2lvbkZvcm1hdC5pZGwJKHJldmlzaW9uIDEyMzYwOCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwv Y2FudmFzL1dlYkdMU2hhZGVyUHJlY2lzaW9uRm9ybWF0LmlkbAkod29ya2luZyBjb3B5KQpAQCAt MjksOSArMjksOSBAQCBtb2R1bGUgaHRtbCB7CiAgICAgaW50ZXJmYWNlIFsKICAgICAgICAgQ29u ZGl0aW9uYWw9V0VCR0wsCiAgICAgXSBXZWJHTFNoYWRlclByZWNpc2lvbkZvcm1hdCB7Ci0gICAg ICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBpbnQgcmFuZ2VNaW47Ci0gICAgICAgIHJlYWRvbmx5IGF0 dHJpYnV0ZSBpbnQgcmFuZ2VNYXg7Ci0gICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBpbnQgcHJl Y2lzaW9uOworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgbG9uZyByYW5nZU1pbjsKKyAgICAg ICAgcmVhZG9ubHkgYXR0cmlidXRlIGxvbmcgcmFuZ2VNYXg7CisgICAgICAgIHJlYWRvbmx5IGF0 dHJpYnV0ZSBsb25nIHByZWNpc2lvbjsKICAgICB9OwogCiB9CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wYWdlL1dlYktpdEFuaW1hdGlvbi5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGFnZS9XZWJLaXRBbmltYXRpb24uaWRsCShyZXZpc2lvbiAxMjM2MDgpCisrKyBTb3VyY2UvV2Vi Q29yZS9wYWdlL1dlYktpdEFuaW1hdGlvbi5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTM2LDcgKzM2 LDcgQEAgbW9kdWxlIGh0bWwgewogICAgICAgICBhdHRyaWJ1dGUgZG91YmxlIGVsYXBzZWRUaW1l OwogCiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBkb3VibGUgZGVsYXk7Ci0gICAgICAgIHJl YWRvbmx5IGF0dHJpYnV0ZSBbQ3VzdG9tXSBpbnQgaXRlcmF0aW9uQ291bnQ7CisgICAgICAgIHJl YWRvbmx5IGF0dHJpYnV0ZSBbQ3VzdG9tXSBsb25nIGl0ZXJhdGlvbkNvdW50OwogCiAgICAgICAg IHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFuIHBhdXNlZDsKICAgICAgICAgcmVhZG9ubHkgYXR0 cmlidXRlIGJvb2xlYW4gZW5kZWQ7Cg==