92246 2012-07-25 06:53:14 -0700 [BlackBerry] Add "SelectAll" to WebPage 2012-07-25 08:40:30 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 andchen webkit-unassigned mifenton tonikitoo webkit.review.bot oldest_to_newest 677995 0 andchen 2012-07-25 06:53:14 -0700 Need to add "selectAll" so that client app can directly call it. 678010 1 154345 andchen 2012-07-25 07:09:25 -0700 Created attachment 154345 Patch 678017 2 154345 tonikitoo 2012-07-25 07:16:50 -0700 Comment on attachment 154345 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154345&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:4689 > + d->m_inputHandler->selectAll(); I would say this call belongs more to SelectionHandler, but it is ok. 678097 3 154345 webkit.review.bot 2012-07-25 08:40:26 -0700 Comment on attachment 154345 Patch Clearing flags on attachment: 154345 Committed r123622: <http://trac.webkit.org/changeset/123622> 678098 4 webkit.review.bot 2012-07-25 08:40:30 -0700 All reviewed patches have been landed. Closing bug. 154345 2012-07-25 07:09:25 -0700 2012-07-25 08:40:26 -0700 Patch bug-92246-20120725100915.patch text/plain 3248 andchen U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBhNzIwMDMyNmViNGViOTU0N2I3OWJlOTE1OTM2MGYxYTk3YmM3NTFhLi5kNzgzZDI0ZDA0 MWQ3MGRhZTQxYTk1N2NhNTZjYWRlMjZlNmEyODg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0wNy0yNSAgQW5keSBDaGVuICA8YW5kY2hlbkBy aW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBBZGQgIlNlbGVjdEFsbCIgdG8gV2ViUGFn ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIyNDYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgIlNl bGVjdCBBbGwiIGVkaXRvciBjb21tYW5kIHRvIFdlYlBhZ2UuCisgICAgICAgIEludGVybmFsbHkg cmV2aWV3ZWQgYnkgTWlrZSBGZW50b24uCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6Cisg ICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2U6OnNlbGVjdEFsbCk6CisgICAgICAg IChXZWJLaXQpOgorICAgICAgICAqIEFwaS9XZWJQYWdlLmg6CisgICAgICAgICogV2ViS2l0U3Vw cG9ydC9JbnB1dEhhbmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJbnB1 dEhhbmRsZXI6OnNlbGVjdEFsbCk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIFdlYktp dFN1cHBvcnQvSW5wdXRIYW5kbGVyLmg6CisKIDIwMTItMDctMjQgIE1pa2UgRmVudG9uICA8bWlm ZW50b25AcmltLmNvbT4KIAogICAgICAgICBUaHJvdHRsZSBjYWxscyB0byByZXF1ZXN0IHRoZSB2 aXJ0dWFsIGtleWJvYXJkIGJlIHNob3duLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZS5jcHAKaW5kZXggNDg3YTE3ZDcyNjExYWJiZDFjODcwMGE3ODE2NGRkOGEzNGJmN2I3Mi4u NjdhN2RkYzhmODJjYTQ4MGUxZDE3YTk2ZDg0NDY4MDBjZGJiNDBjMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC00NjgyLDYgKzQ2ODIsMTMgQEAgdm9pZCBX ZWJQYWdlOjpwYXN0ZSgpCiAgICAgZC0+bV9pbnB1dEhhbmRsZXItPnBhc3RlKCk7CiB9CiAKK3Zv aWQgV2ViUGFnZTo6c2VsZWN0QWxsKCkKK3sKKyAgICBpZiAoZC0+bV9wYWdlLT5kZWZlcnNMb2Fk aW5nKCkpCisgICAgICAgIHJldHVybjsKKyAgICBkLT5tX2lucHV0SGFuZGxlci0+c2VsZWN0QWxs KCk7Cit9CisKIHZvaWQgV2ViUGFnZTo6c2V0U2VsZWN0aW9uKGNvbnN0IFBsYXRmb3JtOjpJbnRQ b2ludCYgc3RhcnRQb2ludCwgY29uc3QgUGxhdGZvcm06OkludFBvaW50JiBlbmRQb2ludCkKIHsK ICAgICBpZiAoZC0+bV9wYWdlLT5kZWZlcnNMb2FkaW5nKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9BcGkvV2ViUGFnZS5oCmluZGV4IDAyNjM0OTMxN2FiMmNmZmQ4MDMyNWE2MWMzYjhkYmJjZWZk ODNiM2MuLmU1NTYwODRmOTk4ZmQ1ZTBlNmRiOGViMWM3ZjNmODhmNTVjNGJiNjIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oCkBAIC0xNTgsNiArMTU4LDcgQEAgcHVibGlj OgogICAgIHZvaWQgY3V0KCk7CiAgICAgdm9pZCBjb3B5KCk7CiAgICAgdm9pZCBwYXN0ZSgpOwor ICAgIHZvaWQgc2VsZWN0QWxsKCk7CiAKICAgICAvLyBUZXh0IGVuY29kaW5nLgogICAgIFdlYlN0 cmluZyB0ZXh0RW5jb2RpbmcoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCmluZGV4IDUxNWViNTQyNmM0YmRhNGE0 YWQyODc0Zjc5NDUyMDdiNjRmNzg0ZDMuLmVjMWRiMGYxMWJlMTQwNzk5MmRjMzY0NWRiMGRhNjA0 Nzc2MmRkNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBw b3J0L0lucHV0SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktp dFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcApAQCAtMTE2OCw2ICsxMTY4LDExIEBAIHZvaWQgSW5w dXRIYW5kbGVyOjpwYXN0ZSgpCiAgICAgZXhlY3V0ZVRleHRFZGl0Q29tbWFuZCgiUGFzdGUiKTsK IH0KIAordm9pZCBJbnB1dEhhbmRsZXI6OnNlbGVjdEFsbCgpCit7CisgICAgZXhlY3V0ZVRleHRF ZGl0Q29tbWFuZCgiU2VsZWN0QWxsIik7Cit9CisKIHZvaWQgSW5wdXRIYW5kbGVyOjphZGRBdHRy aWJ1dGVkVGV4dE1hcmtlcihpbnQgc3RhcnQsIGludCBlbmQsIGNvbnN0IEF0dHJpYnV0ZVRleHRT dHlsZSYgc3R5bGUpCiB7CiAgICAgaWYgKChlbmQgLSBzdGFydCkgPCAxIHx8IGVuZCA+IHN0YXRp Y19jYXN0PGludD4oZWxlbWVudFRleHQoKS5sZW5ndGgoKSkpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuaCBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5oCmluZGV4IGVjOTE2 ZjgyNDZiNjQzZDEwNzFiZjkzZTMyNDU5NWI0MTEwZWM2NGIuLmE2ZWVkM2I3ZTJmNDY2ZDVlY2Vk MTBkNmQ0OGJjNWFmODA4YTMzMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5oCkBAIC03NCw2ICs3NCw3IEBAIHB1Ymxp YzoKICAgICB2b2lkIGN1dCgpOwogICAgIHZvaWQgY29weSgpOwogICAgIHZvaWQgcGFzdGUoKTsK KyAgICB2b2lkIHNlbGVjdEFsbCgpOwogCiAgICAgdm9pZCBjYW5jZWxTZWxlY3Rpb24oKTsKIAo=