92231 2012-07-25 02:38:00 -0700 [Qt][WK2] REGRESSION(r123583): Removing a test made 88 tests flakey 2012-11-06 22:40:08 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED DUPLICATE 101353 Qt, QtTriaged P1 Critical --- 79666 92111 96861 1 ossy ossy dbates gustavo hausmann kbalazs ossy xan.lopez zan oldest_to_newest 677839 0 ossy 2012-07-25 02:38:00 -0700 I have no idead how is it possible, but it must be a serious bug somewhere in Qt-WK2 port. r123582 - 22 flakes - http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/6482 r123584 - 110 flakes - http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/6483 677875 1 zan 2012-07-25 03:49:05 -0700 From little experience gained from poking around the Gtk's implementation, I think the EventSenderProxy lacks a method that would reset all the members to their default values before each test is run. Currently the EventSenderProxy is created at TestController initialization and just reused for every test without being reset. Looking through the Qt's implementation I can see a problem occurring if two subsequent tests happen to click with the same button in the exact same location with not enough timespan between them - this would generate a double click in the second test instead of a simple click. Other similar problems can occur due to no resetting of the EventSenderProxy state. I'm not saying that's exactly the problem nor do I have any evidence of this actually happening and causing increase in flaky tests. It just seems to me this might be the most possible explanation to the problem due to the flakiness and the fact this started occurring after a test utilizing the EventSender was removed from the test run. 678164 2 154378 ossy 2012-07-25 09:48:51 -0700 Created attachment 154378 Patch Thanks for the idea, I tried to reinstantiate EventSenderProxy between each tests, and it works for me. Maybe there is simpler solution, but I don't know ... 678329 3 154378 gyuyoung.kim 2012-07-25 12:17:57 -0700 Comment on attachment 154378 Patch Attachment 154378 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13339346 678506 4 154378 gustavo 2012-07-25 14:53:33 -0700 Comment on attachment 154378 Patch Attachment 154378 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13339395 679343 5 154378 hausmann 2012-07-26 08:04:04 -0700 Comment on attachment 154378 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154378&action=review > Tools/WebKitTestRunner/TestController.cpp:432 > + if (m_eventSenderProxy) > + delete m_eventSenderProxy; You don't need to check m_eventSenderProxy for being non-null before deleting it. delete 0 is fine :) However I don't think this approach is quite right. It _seems_ the cause is the event queues in the event sender proxy, which is something only non-mac ports "suffer" from. Either our approach of leapForward should be imlemented differently (can we specify time stamps in the events like mac?) or perhaps we are missing some sort of reset() call here in resetStateToConsistentValues() that clears the queue and has a comment explaining why. Deleting and re-creating the event sender proxy is just hiding the real problem IMHO. 721437 6 ossy 2012-09-15 08:01:06 -0700 There are many notifydone-timeout test (and pass after retry) because of this bug. Unfortunately https://trac.webkit.org/changeset/128395 increased the notifydone timeout from 6 seconds to 30 seconds. It slowed down the testing time from 15.5 minutes to 23.5 minutes. I'm back to fix this bug, runtime is good for me, but there are still 4-5 fails (not flakey, fail), so it seems reseting of some members of EventSenderProxy are still missing. 727533 7 ossy 2012-09-25 05:24:06 -0700 http://trac.webkit.org/changeset/129486 unskipped a bunch of tests, and this bug became hidden again. :-/ But I'm going to fix once I have a day when folks don't break everything at least 5-10 times. 760407 8 ossy 2012-11-06 22:40:08 -0800 *** This bug has been marked as a duplicate of bug 101353 *** 154378 2012-07-25 09:48:51 -0700 2012-07-26 08:04:03 -0700 Patch bug-92231-20120725184840.patch text/plain 1412 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNjI1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzgwYTc0NWNiNWU0ZGY4ODFkN2Y2NDk4YjY3NjNhMTE5 YzZkYjJkNC4uY2FjZDZjZDhhN2ZjZThmMzA0NDZlMDU3MTllZDRjYTFjNmJiMjhiYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTA3LTI1ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1F0XVtXSzJdIFJFR1JFU1NJT04ocjEyMzU4Myk6IFJlbW92aW5nIGEgdGVzdCBt YWRlIDg4IHRlc3RzIGZsYWtleQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTIyMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAg ICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6cmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcyk6IFJl aW5zdGFudGlhdGUgRXZlbnRTZW5kZXJQcm94eSBiZXR3ZWVuIGVhY2ggdGVzdHMuCisKIDIwMTIt MDctMjUgIEtyaXN0w7NmIEtvc3p0ecOzICA8a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgogCiAg ICAgICAgIFtOUldUXSBSZW5hbWUgYmFzZWxpbmVfc2VhcmNoX3BhdGgoKSB0byBkZWZhdWx0X2Jh c2VsaW5lX3NlYXJjaF9wYXRoKCkKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv VGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxl ci5jcHAKaW5kZXggOGMyMjUwODMxYWQ5YTIwYzQ0NzZlZDNjOTUxNzdjYTFiNThiMWNjNC4uODUx ODVmODE0OWNhZGJmYzYyMmQ2YzkxN2IwZDFkOGRhYjE3NDg5YyAxMDA2NDQKLS0tIGEvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAgLTQyOCw2ICs0MjgsMTAgQEAgYm9vbCBUZXN0 Q29udHJvbGxlcjo6cmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcygpCiB7CiAgICAgbV9zdGF0 ZSA9IFJlc2V0dGluZzsKIAorICAgIGlmIChtX2V2ZW50U2VuZGVyUHJveHkpCisgICAgICAgIGRl bGV0ZSBtX2V2ZW50U2VuZGVyUHJveHk7CisgICAgbV9ldmVudFNlbmRlclByb3h5ID0gbmV3IEV2 ZW50U2VuZGVyUHJveHkodGhpcyk7CisKICAgICBtX2JlZm9yZVVubG9hZFJldHVyblZhbHVlID0g dHJ1ZTsKIAogICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiBtZXNzYWdlTmFtZSA9IGFkb3B0 V0soV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoIlJlc2V0IikpOwo=