92219 2012-07-24 23:43:49 -0700 [EFL][DRT] fast/loader/stop-provisional-loads.html fails 2012-08-03 05:16:51 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joone joone gyuyoung.kim kenneth lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 677699 0 joone 2012-07-24 23:43:49 -0700 We need to add the ability to tell DRT to call ewk_frame_stop inside of a didStartProvisionalLoadForFrame signal handler. For more details, please take a look at https://trac.webkit.org/changeset/34972. 677718 1 154279 joone 2012-07-25 00:12:32 -0700 Created attachment 154279 Patch 677723 2 154279 cdumez 2012-07-25 00:17:53 -0700 Comment on attachment 154279 Patch As long as it does not cause regressions for other tests, LGTM. Maybe you should use [DRT] keyword in bug title. 677733 3 154279 gyuyoung.kim 2012-07-25 00:25:26 -0700 Comment on attachment 154279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154279&action=review As we talk on irc, please consider WK2 layout test as well. > Tools/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). Generally, patch description is placed below *Reviewed by NOBODY*. But, this is not rule. 677735 4 154279 cdumez 2012-07-25 00:29:02 -0700 Comment on attachment 154279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154279&action=review >> Tools/ChangeLog:10 >> + Reviewed by NOBODY (OOPS!). > > Generally, patch description is placed below *Reviewed by NOBODY*. But, this is not rule. Right, sorry I missed that. 682724 5 155440 joone 2012-07-30 22:30:47 -0700 Created attachment 155440 Patch 682733 6 joone 2012-07-30 22:42:50 -0700 @Christophe, @Gyuyoung: I've moved the description below *Reviewed by NOBODY* and checked that this test case already passes in WK2 test. Thanks for the review. 686570 7 155440 kenneth 2012-08-03 04:42:56 -0700 Comment on attachment 155440 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155440&action=review > Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:690 > + const String frameName(DumpRenderTreeSupportEfl::suitableDRTFrameName(frame)); Btw Qt is getting rid for DumpRenderTreeSupportQt for a separate library. You should have a look 686585 8 155440 webkit.review.bot 2012-08-03 05:16:45 -0700 Comment on attachment 155440 Patch Clearing flags on attachment: 155440 Committed r124599: <http://trac.webkit.org/changeset/124599> 686586 9 webkit.review.bot 2012-08-03 05:16:51 -0700 All reviewed patches have been landed. Closing bug. 154279 2012-07-25 00:12:32 -0700 2012-07-30 22:30:35 -0700 Patch bug-92219-20120725161217.patch text/plain 2810 joone U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNTYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWJmY2UyY2U0YTY4MzllYWJmMDQ0NGFlZmZjOTQ2Y2Vj YWVhNWJiNS4uOTEwZDhlMjJkODE4MjMyNTIyMGRjMGJjMDBhZGViM2ViNWUyYTVkYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA3LTI0ICBKb29uZSBIdXIgIDxqb29uZS5odXJAaW50ZWwuY29tPgorCisgICAg ICAgIFtFRkxdIGZhc3QvbG9hZGVyL3N0b3AtcHJvdmlzaW9uYWwtbG9hZHMuaHRtbCBmYWlscwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIyMTkKKwor ICAgICAgICBUaGlzIHBhdGNoIGFkZHMgdGhlIGFiaWxpdHkgdG8gdGVsbCBEUlQgdG8gY2FsbCBl d2tfZnJhbWVfc3RvcCAKKyAgICAgICAgaW5zaWRlIG9mIGEgZGlkU3RhcnRQcm92aXNpb25hbExv YWRGb3JGcmFtZSBzaWduYWwgaGFuZGxlci4KKyAgICAgICAgSXQgYWxsb3dzIHRvIHBhc3MgZmFz dC9sb2FkZXIvc3RvcC1wcm92aXNpb25hbC1sb2Fkcy5odG1sLgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBS ZW5kZXJUcmVlQ2hyb21lLmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlQ2hyb21lOjpvbkZy YW1lUHJvdmlzaW9uYWxMb2FkKToKKwogMjAxMi0wNy0yNCAgRGlyayBQcmFua2UgIDxkcHJhbmtl QGNocm9taXVtLm9yZz4KIAogICAgICAgICBtYWtlIHRlc3Qtd2Via2l0cHkgYXQgbGVhc3Qga2lu ZGEgd29yayBpbiBwYXJhbGxlbCBvbiB3aW4zMgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKaW5kZXggY2MyZjA1YmMyNzk2NWE2NmE4YWRk ODRkNDAzMjJlMGFiNTk1N2ZmMS4uNzNiZjIxYWVjNzBiZWJkZTNlY2UwN2NmNjZmNTUwNzVjYjdi Njk1NyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVl Q2hyb21lLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVD aHJvbWUuY3BwCkBAIC02OTMsNiArNjkzLDE1IEBAIHZvaWQgRHVtcFJlbmRlclRyZWVDaHJvbWU6 Om9uRnJhbWVQcm92aXNpb25hbExvYWQodm9pZCosIEV2YXNfT2JqZWN0KiBmcmFtZSwgdm9pCiAg ICAgICAgIGNvbnN0IFN0cmluZyBmcmFtZU5hbWUoRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsOjpz dWl0YWJsZURSVEZyYW1lTmFtZShmcmFtZSkpOwogICAgICAgICBwcmludGYoIiVzIC0gZGlkU3Rh cnRQcm92aXNpb25hbExvYWRGb3JGcmFtZVxuIiwgZnJhbWVOYW1lLnV0ZjgoKS5kYXRhKCkpOwog ICAgIH0KKworICAgIGlmICghdG9wTG9hZGluZ0ZyYW1lICYmICFkb25lKQorICAgICAgICB0b3BM b2FkaW5nRnJhbWUgPSBmcmFtZTsKKyAgCisgICAgaWYgKCFkb25lICYmIGdMYXlvdXRUZXN0Q29u dHJvbGxlci0+c3RvcFByb3Zpc2lvbmFsRnJhbWVMb2FkcygpKSB7IAorICAgICAgICBjb25zdCBT dHJpbmcgZnJhbWVOYW1lKER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6c3VpdGFibGVEUlRGcmFt ZU5hbWUoZnJhbWUpKTsKKyAgICAgICAgcHJpbnRmKCIlcyAtIHN0b3BwaW5nIGxvYWQgaW4gZGlk U3RhcnRQcm92aXNpb25hbExvYWRGb3JGcmFtZSBjYWxsYmFja1xuIiwgZnJhbWVOYW1lLnV0Zjgo KS5kYXRhKCkpOworICAgICAgICBld2tfZnJhbWVfc3RvcChmcmFtZSk7CisgICAgfSAgIAogfQog CiB2b2lkIER1bXBSZW5kZXJUcmVlQ2hyb21lOjpvbkZyYW1lUHJvdmlzaW9uYWxMb2FkRmFpbGVk KHZvaWQqLCBFdmFzX09iamVjdCogZnJhbWUsIHZvaWQqKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9l ZmwvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA0ZGNmYzJmZDQ0NWZkYzIzMDllYjJhYjkzNmMxNTIw NTQwMzRkNDZiLi4yZjlmY2RmN2M4ZWI3ZjZiNGNmZDJiMmY2YWRmOTViYzFlZGNhMDhjIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucworKysgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMzc4LDcgKzM3OCw2 IEBAIEJVR1dLRUZMIFNLSVAgOiBodHRwL3Rlc3RzL3NlY3VyaXR5L2lzb2xhdGVkV29ybGQvZGlk Q2xlYXJXaW5kb3dPYmplY3QuaHRtbCA9IFBBCiBCVUdXSzg3OTc0IDogaHR0cC90ZXN0cy9kb3du bG9hZCA9IFRFWFQgSU1BR0UgSU1BR0UrVEVYVAogCiAvLyBOZWVkcyBjdXN0b20gcG9saWN5IGRl bGVnYXRlIGVuaGFuY2VtZW50IHRvIGxvZyBET00gbm9kZSBpbmZvIC0gRUZMIHBvcnQgaXMgbWlz c2luZyBET00gbm9kZSBhYnN0cmFjdGlvbgotQlVHV0s4Nzk3MiA6IGZhc3QvbG9hZGVyL3N0b3At cHJvdmlzaW9uYWwtbG9hZHMuaHRtbCA9IFRFWFQKIEJVR1dLODc5NzIgOiBmYXN0L2xvYWRlci9w b2xpY3ktZGVsZWdhdGUtYWN0aW9uLWhpdC10ZXN0LXpvb21lZC5odG1sID0gVEVYVAogQlVHV0s4 Nzk3MiA6IGZhc3QvZW5jb2RpbmcvbWFpbHRvLWFsd2F5cy11dGYtOC5odG1sID0gVEVYVAogQlVH V0s4Nzk3MiA6IGZhc3QvZm9ybXMvbWFpbHRvL2Zvcm1lbmN0eXBlLWF0dHJpYnV0ZS1idXR0b24t aHRtbC5odG1sID0gVEVYVAo= 155440 2012-07-30 22:30:47 -0700 2012-08-03 05:16:45 -0700 Patch bug-92219-20120731143022.patch text/plain 2827 joone U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MTQxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWJhZmY1MjRhNTExNTBlZDA4NmY0NDUxYjUxM2U5YmE4 NzdiMWI0Yy4uOTk2OWRkNzQ4MzMzNGRiZWI1MjBhMTA2MjYzZjYxOTRmZjU4OTE3YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA3LTMwICBKb29uZSBIdXIgIDxqb29uZS5odXJAaW50ZWwuY29tPgorCisgICAg ICAgIFtFRkxdW0RSVF0gZmFzdC9sb2FkZXIvc3RvcC1wcm92aXNpb25hbC1sb2Fkcy5odG1sIGZh aWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjIx OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg cGF0Y2ggYWRkcyB0aGUgYWJpbGl0eSB0byB0ZWxsIERSVCB0byBjYWxsIGV3a19mcmFtZV9zdG9w IAorICAgICAgICBpbnNpZGUgb2YgYSBkaWRTdGFydFByb3Zpc2lvbmFsTG9hZEZvckZyYW1lIHNp Z25hbCBoYW5kbGVyLgorICAgICAgICBJdCBhbGxvd3MgdG8gcGFzcyBmYXN0L2xvYWRlci9zdG9w LXByb3Zpc2lvbmFsLWxvYWRzLmh0bWwuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwv RHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwOgorICAgICAgICAoRHVtcFJlbmRlclRyZWVDaHJvbWU6 Om9uRnJhbWVQcm92aXNpb25hbExvYWQpOgorCiAyMDEyLTA3LTMwICBBcm5hdWQgUmVuZXZpZXIg IDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CiAKICAgICAgICAgd2Via2l0LXBhdGNoOiBz eXN0ZW0ga2V5cmluZyBpcyBub3QgdXNlZCB0byByZWFkIG15IHBhc3N3b3JkCmRpZmYgLS1naXQg YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcAppbmRleCAwM2U4 MTQ4YmM0YjkzYjIzZGRmMTc3MjY5MzVkMzk0Y2Q1YjczMzA2Li4wZDFmYTRiNjMxMDQ3M2M4MzQ5 N2IwZTJjNjc0MzM1YmMyODNjMjJmIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9l ZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Vm bC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKQEAgLTY4Miw2ICs2ODIsMTUgQEAgdm9pZCBEdW1w UmVuZGVyVHJlZUNocm9tZTo6b25GcmFtZVByb3Zpc2lvbmFsTG9hZCh2b2lkKiwgRXZhc19PYmpl Y3QqIGZyYW1lLCB2b2kKICAgICAgICAgY29uc3QgU3RyaW5nIGZyYW1lTmFtZShEdW1wUmVuZGVy VHJlZVN1cHBvcnRFZmw6OnN1aXRhYmxlRFJURnJhbWVOYW1lKGZyYW1lKSk7CiAgICAgICAgIHBy aW50ZigiJXMgLSBkaWRTdGFydFByb3Zpc2lvbmFsTG9hZEZvckZyYW1lXG4iLCBmcmFtZU5hbWUu dXRmOCgpLmRhdGEoKSk7CiAgICAgfQorCisgICAgaWYgKCF0b3BMb2FkaW5nRnJhbWUgJiYgIWRv bmUpCisgICAgICAgIHRvcExvYWRpbmdGcmFtZSA9IGZyYW1lOworICAKKyAgICBpZiAoIWRvbmUg JiYgZ0xheW91dFRlc3RDb250cm9sbGVyLT5zdG9wUHJvdmlzaW9uYWxGcmFtZUxvYWRzKCkpIHsg CisgICAgICAgIGNvbnN0IFN0cmluZyBmcmFtZU5hbWUoRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZs OjpzdWl0YWJsZURSVEZyYW1lTmFtZShmcmFtZSkpOworICAgICAgICBwcmludGYoIiVzIC0gc3Rv cHBpbmcgbG9hZCBpbiBkaWRTdGFydFByb3Zpc2lvbmFsTG9hZEZvckZyYW1lIGNhbGxiYWNrXG4i LCBmcmFtZU5hbWUudXRmOCgpLmRhdGEoKSk7CisgICAgICAgIGV3a19mcmFtZV9zdG9wKGZyYW1l KTsKKyAgICB9ICAgCiB9CiAKIHZvaWQgRHVtcFJlbmRlclRyZWVDaHJvbWU6Om9uRnJhbWVQcm92 aXNpb25hbExvYWRGYWlsZWQodm9pZCosIEV2YXNfT2JqZWN0KiBmcmFtZSwgdm9pZCopCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGU0MjEyMzk4YWMyNWQ3 ZDZlMDc4YTQ5YWZlOTFlZjVmNTQ2MmVkMWUuLjdkZGNiMTE5MWE4NWI1YWU0NjIwYjQxM2MwMGM3 NDNlNjI4YzJmYjUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhw ZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25z CkBAIC0zNzUsNyArMzc1LDYgQEAgQlVHV0tFRkwgU0tJUCA6IGh0dHAvdGVzdHMvc2VjdXJpdHkv aXNvbGF0ZWRXb3JsZC9kaWRDbGVhcldpbmRvd09iamVjdC5odG1sID0gUEEKIEJVR1dLODc5NzQg OiBodHRwL3Rlc3RzL2Rvd25sb2FkID0gVEVYVCBJTUFHRSBJTUFHRStURVhUCiAKIC8vIE5lZWRz IGN1c3RvbSBwb2xpY3kgZGVsZWdhdGUgZW5oYW5jZW1lbnQgdG8gbG9nIERPTSBub2RlIGluZm8g LSBFRkwgcG9ydCBpcyBtaXNzaW5nIERPTSBub2RlIGFic3RyYWN0aW9uCi1CVUdXSzg3OTcyIDog ZmFzdC9sb2FkZXIvc3RvcC1wcm92aXNpb25hbC1sb2Fkcy5odG1sID0gVEVYVAogQlVHV0s4Nzk3 MiA6IGZhc3QvbG9hZGVyL3BvbGljeS1kZWxlZ2F0ZS1hY3Rpb24taGl0LXRlc3Qtem9vbWVkLmh0 bWwgPSBURVhUCiBCVUdXSzg3OTcyIDogZmFzdC9lbmNvZGluZy9tYWlsdG8tYWx3YXlzLXV0Zi04 Lmh0bWwgPSBURVhUCiBCVUdXSzg3OTcyIDogZmFzdC9mb3Jtcy9tYWlsdG8vZm9ybWVuY3R5cGUt YXR0cmlidXRlLWJ1dHRvbi1odG1sLmh0bWwgPSBURVhUCg==