92209 2012-07-24 22:22:27 -0700 [Tests] Copy fast/forms/number/number-spinbutton-change-and-input-events.html to fast/forms/js/resources 2012-07-24 22:54:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 92206 1 yosin yosin tkent oldest_to_newest 677628 0 yosin 2012-07-24 22:22:27 -0700 I would like to re-factor fast/forms/number/number-spinbutton-change-and-input-events.html to share JavaScript code with other input types. This bug is preparation of this re-factoring and copy two HTML files into JavaScript code directory (fast/forms/resources) as JavaScript code files. 677635 1 154255 yosin 2012-07-24 22:30:16 -0700 Created attachment 154255 Patch 677636 2 154255 yosin 2012-07-24 22:30:51 -0700 Comment on attachment 154255 Patch Could you review this patch? Thanks in advance. Note: The "Diff" is a result of "svn copy" command. 677639 3 154255 tkent 2012-07-24 22:36:26 -0700 Comment on attachment 154255 Patch please check what you upload. 677648 4 154258 yosin 2012-07-24 22:47:39 -0700 Created attachment 154258 Patch 677651 5 154258 yosin 2012-07-24 22:48:34 -0700 Comment on attachment 154258 Patch Oops, sorry for broken ChangeLog. Could you review this patch? Thanks in advance. = Changes since the last review = * Remove garbage from ChangeLog 677654 6 154258 tkent 2012-07-24 22:52:39 -0700 Comment on attachment 154258 Patch ok 677656 7 yosin 2012-07-24 22:54:08 -0700 Landed: r123578 154255 2012-07-24 22:30:16 -0700 2012-07-24 22:47:35 -0700 Patch bug-92209-20120725143007.patch text/plain 3992 yosin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyMzU3NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDEyLTA3LTI0ICBZb3NoaWZ1bWkgSW5vdWUg IDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1Rlc3RzXSBDb3B5IGZhc3QvZm9ybXMv bnVtYmVyL251bWJlci1zcGluYnV0dG9uLWNoYW5nZS1hbmQtaW5wdXQtZXZlbnRzLmh0bWwgdG8g ZmFzdC9mb3Jtcy9qcy9yZXNvdXJjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkyMjA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkaXRpb25hbCBpbmZvcm1hdGlvbiBvZiB0aGUgY2hhbmdlIHN1Y2gg YXMgYXBwcm9hY2gsIHJhdGlvbmFsZS4gUGxlYXNlIGFkZCBwZXItZnVuY3Rpb24gZGVzY3JpcHRp b25zIGJlbG93IChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3Jlc291cmNlcy9jb21t b24tc3BpbmJ1dHRvbi1jaGFuZ2UtYW5kLWlucHV0LWV2ZW50cy5qczogQ29waWVkIGZyb20gTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9udW1iZXIvbnVtYmVyLXNwaW5idXR0b24tY2hhbmdlLWFuZC1p bnB1dC1ldmVudHMuaHRtbC4KKworMjAxMi0wNy0yNCAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFtUZXN0c10gQ29weSBmYXN0L2Zvcm1zL251bWJlci9u dW1iZXItc3BpbmJ1dHRvbi1jaGFuZ2UtYW5kLWlucHV0LWV2ZW50cy5odG1sIHRvIGZhc3QvZm9y bXMvanMvcmVzb3VyY2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05MjIwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgcGF0Y2ggY29waWVzIHRlc3QgZmlsZSBmYXN0L2Zvcm1zL251bWJlci9udW1i ZXItc3BpbmJ1dHRvbi1jaGFuZ2UtYW5kLWlucHV0LWV2ZW50cy5odG1sCisgICAgICAgIHRvIEph dmFTY3JpcHQgY29kZSBkaXJlY3RvcnkgZmFzdC9mb3Jtcy9yZXNvdXJjZXMgYXMgY29tbW9uLXNw aW5idXR0b24tY2hhbmdlLWFuZC1pbnB1dC1ldmVudHMuanMKKyAgICAgICAgZm9yIHNoYXJpbmcg Y29kZSB3aXRoIG90aGVyIGlucHV0IHR5cGVzLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaXMgcHJl cGFyYXRpb24gb2YgcmUtZmFjdG9yaW5nLgorCisgICAgICAgICogZmFzdC9mb3Jtcy9yZXNvdXJj ZXMvY29tbW9uLXNwaW5idXR0b24tY2hhbmdlLWFuZC1pbnB1dC1ldmVudHMuanM6IENvcGllZCBm cm9tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvbnVtYmVyL251bWJlci1zcGluYnV0dG9uLWNoYW5n ZS1hbmQtaW5wdXQtZXZlbnRzLmh0bWwuCisKIDIwMTItMDctMjQgIFlvc2hpZnVtaSBJbm91ZSAg PHlvc2luQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbVGVzdHNdIENvcHkgZmFzdC9mb3Jtcy9u dW1iZXIvbnVtYmVyLXNwaW5idXR0b24tY2hhbmdlLWFuZC1pbnB1dC1ldmVudHMuaHRtbCB0byBm YXN0L2Zvcm1zL2pzL3Jlc291cmNlcwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9yZXNv dXJjZXMvY29tbW9uLXNwaW5idXR0b24tY2hhbmdlLWFuZC1pbnB1dC1ldmVudHMuanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9yZXNvdXJjZXMvY29tbW9uLXNwaW5idXR0 b24tY2hhbmdlLWFuZC1pbnB1dC1ldmVudHMuanMJKHJldmlzaW9uIDEyMzU3NSkJKGZyb20gTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9udW1iZXIvbnVtYmVyLXNwaW5idXR0b24tY2hhbmdlLWFuZC1p bnB1dC1ldmVudHMuaHRtbDoxMjM1NzUpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Jlc291 cmNlcy9jb21tb24tc3BpbmJ1dHRvbi1jaGFuZ2UtYW5kLWlucHV0LWV2ZW50cy5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMCwwICsxLDU1IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+ Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMi Pjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oJ1Rlc3Qg Zm9yIGV2ZW50IGRpc3BhdGNoaW5nIGJ5IHNwaW4gYnV0dG9ucyBpbiBhIHR5cGU9bnVtbmJlciBp bnB1dC4nKTsKKwordmFyIHBhcmVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOwor ZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChwYXJlbnQpOworcGFyZW50LmlubmVySFRNTCA9ICc8 aW5wdXQgdHlwZT1udW1iZXIgaWQ9bnVtYmVyIHZhbHVlPTAgbWF4PTE+PGlucHV0IGlkPWFub3Ro ZXI+JzsKK3ZhciBudW1iZXJJbnB1dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdudW1iZXIn KTsKK3ZhciBhbm90aGVySW5wdXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYW5vdGhlcicp OwordmFyIGlucHV0RXZlbnRDb3VudGVyID0gMDsKK3ZhciBjaGFuZ2VFdmVudENvdW50ZXIgPSAw OworCitudW1iZXJJbnB1dC5vbmNoYW5nZSA9IGZ1bmN0aW9uKCkgeyBjaGFuZ2VFdmVudENvdW50 ZXIrKzsgfTsKK251bWJlcklucHV0Lm9uaW5wdXQgPSBmdW5jdGlvbigpIHsgaW5wdXRFdmVudENv dW50ZXIrKzsgfTsKKworaWYgKHdpbmRvdy5ldmVudFNlbmRlcikgeworICAgIGRlYnVnKCdJbml0 aWFsIHN0YXRlJyk7CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oMCwgMCk7CisgICAgc2hv dWxkQmUoJ2NoYW5nZUV2ZW50Q291bnRlcicsICcwJyk7CisgICAgc2hvdWxkQmUoJ2lucHV0RXZl bnRDb3VudGVyJywgJzAnKTsKKworICAgIGRlYnVnKCdDbGljayB0aGUgdXBwZXIgYnV0dG9uJyk7 CisgICAgLy8gTW92ZSB0aGUgY3Vyc29yIG9uIHRoZSB1cHBlciBidXR0b24uCisgICAgZXZlbnRT ZW5kZXIubW91c2VNb3ZlVG8obnVtYmVySW5wdXQub2Zmc2V0TGVmdCArIG51bWJlcklucHV0Lm9m ZnNldFdpZHRoIC0gMTAsIG51bWJlcklucHV0Lm9mZnNldFRvcCArIG51bWJlcklucHV0Lm9mZnNl dEhlaWdodCAvIDQpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOworICAgIGV2ZW50U2Vu ZGVyLm1vdXNlVXAoKTsKKyAgICBzaG91bGRCZSgnbnVtYmVySW5wdXQudmFsdWUnLCAnIjEiJyk7 CisgICAgc2hvdWxkQmUoJ2NoYW5nZUV2ZW50Q291bnRlcicsICcxJyk7CisgICAgc2hvdWxkQmUo J2lucHV0RXZlbnRDb3VudGVyJywgJzEnKTsKKworICAgIGRlYnVnKCdDbGljayBhZ2FpbiwgYnV0 IHRoZSB2YWx1ZSBpcyBub3QgY2hhbmdlZC4nKTsKKyAgICBldmVudFNlbmRlci5tb3VzZURvd24o KTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CisgICAgc2hvdWxkQmUoJ251bWJlcklucHV0 LnZhbHVlJywgJyIxIicpOworICAgIHNob3VsZEJlKCdjaGFuZ2VFdmVudENvdW50ZXInLCAnMScp OworICAgIHNob3VsZEJlKCdpbnB1dEV2ZW50Q291bnRlcicsICcxJyk7CisKKyAgICBkZWJ1Zygn Rm9jdXMgb24gYW5vdGhlciBmaWVsZCcpOworICAgIGFub3RoZXJJbnB1dC5mb2N1cygpOworICAg IHNob3VsZEJlKCdjaGFuZ2VFdmVudENvdW50ZXInLCAnMScpOworICAgIHNob3VsZEJlKCdpbnB1 dEV2ZW50Q291bnRlcicsICcxJyk7CisKKyAgICBwYXJlbnQuaW5uZXJIVE1MID0gJyc7Cit9IGVs c2UgeworICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29uc29sZScpLmlubmVySFRNTCA9ICdO byBldmVudFNlbmRlcic7Cit9Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0 L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1s Pgo= 154258 2012-07-24 22:47:39 -0700 2012-07-24 22:52:38 -0700 Patch bug-92209-20120725144729.patch text/plain 3421 yosin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyMzU3NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA3LTI0ICBZb3NoaWZ1bWkgSW5vdWUg IDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1Rlc3RzXSBDb3B5IGZhc3QvZm9ybXMv bnVtYmVyL251bWJlci1zcGluYnV0dG9uLWNoYW5nZS1hbmQtaW5wdXQtZXZlbnRzLmh0bWwgdG8g ZmFzdC9mb3Jtcy9qcy9yZXNvdXJjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkyMjA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBjb3BpZXMgdGVzdCBmaWxlIGZhc3QvZm9ybXMvbnVt YmVyL251bWJlci1zcGluYnV0dG9uLWNoYW5nZS1hbmQtaW5wdXQtZXZlbnRzLmh0bWwKKyAgICAg ICAgdG8gSmF2YVNjcmlwdCBjb2RlIGRpcmVjdG9yeSBmYXN0L2Zvcm1zL3Jlc291cmNlcyBhcyBj b21tb24tc3BpbmJ1dHRvbi1jaGFuZ2UtYW5kLWlucHV0LWV2ZW50cy5qcworICAgICAgICBmb3Ig c2hhcmluZyBjb2RlIHdpdGggb3RoZXIgaW5wdXQgdHlwZXMuCisKKyAgICAgICAgVGhpcyBwYXRj aCBpcyBwcmVwYXJhdGlvbiBvZiByZS1mYWN0b3JpbmcuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1z L3Jlc291cmNlcy9jb21tb24tc3BpbmJ1dHRvbi1jaGFuZ2UtYW5kLWlucHV0LWV2ZW50cy5qczog Q29waWVkIGZyb20gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9udW1iZXIvbnVtYmVyLXNwaW5idXR0 b24tY2hhbmdlLWFuZC1pbnB1dC1ldmVudHMuaHRtbC4KKwogMjAxMi0wNy0yNCAgWW9zaGlmdW1p IElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtUZXN0c10gUmVuYW1lIGZh c3QvbnVtYmVyL251bWJlci1ldmVudHMuaHRtbCB0byBudW1iZXItc3BpbmJ1dHRvbi1jaGFuZ2Ut YW5kLWlucHV0LWV2ZW50cy5odG1sCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Jlc291 cmNlcy9jb21tb24tc3BpbmJ1dHRvbi1jaGFuZ2UtYW5kLWlucHV0LWV2ZW50cy5qcwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Jlc291cmNlcy9jb21tb24tc3BpbmJ1dHRv bi1jaGFuZ2UtYW5kLWlucHV0LWV2ZW50cy5qcwkocmV2aXNpb24gMTIzNTc1KQkoZnJvbSBMYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL251bWJlci9udW1iZXItc3BpbmJ1dHRvbi1jaGFuZ2UtYW5kLWlu cHV0LWV2ZW50cy5odG1sOjEyMzU3NSkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmVzb3Vy Y2VzL2NvbW1vbi1zcGluYnV0dG9uLWNoYW5nZS1hbmQtaW5wdXQtZXZlbnRzLmpzCSh3b3JraW5n IGNvcHkpCkBAIC0wLDAgKzEsNTUgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4K KzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+ PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbignVGVzdCBm b3IgZXZlbnQgZGlzcGF0Y2hpbmcgYnkgc3BpbiBidXR0b25zIGluIGEgdHlwZT1udW1uYmVyIGlu cHV0LicpOworCit2YXIgcGFyZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7Citk b2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHBhcmVudCk7CitwYXJlbnQuaW5uZXJIVE1MID0gJzxp bnB1dCB0eXBlPW51bWJlciBpZD1udW1iZXIgdmFsdWU9MCBtYXg9MT48aW5wdXQgaWQ9YW5vdGhl cj4nOwordmFyIG51bWJlcklucHV0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ251bWJlcicp OwordmFyIGFub3RoZXJJbnB1dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdhbm90aGVyJyk7 Cit2YXIgaW5wdXRFdmVudENvdW50ZXIgPSAwOwordmFyIGNoYW5nZUV2ZW50Q291bnRlciA9IDA7 CisKK251bWJlcklucHV0Lm9uY2hhbmdlID0gZnVuY3Rpb24oKSB7IGNoYW5nZUV2ZW50Q291bnRl cisrOyB9OworbnVtYmVySW5wdXQub25pbnB1dCA9IGZ1bmN0aW9uKCkgeyBpbnB1dEV2ZW50Q291 bnRlcisrOyB9OworCitpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7CisgICAgZGVidWcoJ0luaXRp YWwgc3RhdGUnKTsKKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbygwLCAwKTsKKyAgICBzaG91 bGRCZSgnY2hhbmdlRXZlbnRDb3VudGVyJywgJzAnKTsKKyAgICBzaG91bGRCZSgnaW5wdXRFdmVu dENvdW50ZXInLCAnMCcpOworCisgICAgZGVidWcoJ0NsaWNrIHRoZSB1cHBlciBidXR0b24nKTsK KyAgICAvLyBNb3ZlIHRoZSBjdXJzb3Igb24gdGhlIHVwcGVyIGJ1dHRvbi4KKyAgICBldmVudFNl bmRlci5tb3VzZU1vdmVUbyhudW1iZXJJbnB1dC5vZmZzZXRMZWZ0ICsgbnVtYmVySW5wdXQub2Zm c2V0V2lkdGggLSAxMCwgbnVtYmVySW5wdXQub2Zmc2V0VG9wICsgbnVtYmVySW5wdXQub2Zmc2V0 SGVpZ2h0IC8gNCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgZXZlbnRTZW5k ZXIubW91c2VVcCgpOworICAgIHNob3VsZEJlKCdudW1iZXJJbnB1dC52YWx1ZScsICciMSInKTsK KyAgICBzaG91bGRCZSgnY2hhbmdlRXZlbnRDb3VudGVyJywgJzEnKTsKKyAgICBzaG91bGRCZSgn aW5wdXRFdmVudENvdW50ZXInLCAnMScpOworCisgICAgZGVidWcoJ0NsaWNrIGFnYWluLCBidXQg dGhlIHZhbHVlIGlzIG5vdCBjaGFuZ2VkLicpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigp OworICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKKyAgICBzaG91bGRCZSgnbnVtYmVySW5wdXQu dmFsdWUnLCAnIjEiJyk7CisgICAgc2hvdWxkQmUoJ2NoYW5nZUV2ZW50Q291bnRlcicsICcxJyk7 CisgICAgc2hvdWxkQmUoJ2lucHV0RXZlbnRDb3VudGVyJywgJzEnKTsKKworICAgIGRlYnVnKCdG b2N1cyBvbiBhbm90aGVyIGZpZWxkJyk7CisgICAgYW5vdGhlcklucHV0LmZvY3VzKCk7CisgICAg c2hvdWxkQmUoJ2NoYW5nZUV2ZW50Q291bnRlcicsICcxJyk7CisgICAgc2hvdWxkQmUoJ2lucHV0 RXZlbnRDb3VudGVyJywgJzEnKTsKKworICAgIHBhcmVudC5pbm5lckhUTUwgPSAnJzsKK30gZWxz ZSB7CisgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb25zb2xlJykuaW5uZXJIVE1MID0gJ05v IGV2ZW50U2VuZGVyJzsKK30KKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3Qv anMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ Cg==