92202 2012-07-24 20:53:06 -0700 RenderBlock::positionForPoint can fail when the block or its children have a vertical writing mode 2012-07-24 21:43:14 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz bdakin eric webkit.review.bot oldest_to_newest 677576 0 mitz 2012-07-24 20:53:06 -0700 RenderBlock::positionForPoint can fail when the block or its children have a vertical writing mode 677577 1 154238 mitz 2012-07-24 20:59:57 -0700 Created attachment 154238 Use logical coordinates consistently and correctly 677581 2 154238 bdakin 2012-07-24 21:10:12 -0700 Comment on attachment 154238 Use logical coordinates consistently and correctly View in context: https://bugs.webkit.org/attachment.cgi?id=154238&action=review > Source/WebCore/ChangeLog:12 > + one of the sub-tests in the new regression test: (1) changed to compare children’s logical Funny apostrophe character on children's? > Source/WebCore/ChangeLog:13 > + bounds against pointInLogicalContents, i.e. compare childern’s horizontal bounds to the Here too. > Source/WebCore/ChangeLog:14 > + point’s horizontal component; and (2) changed to use logicalTopForChild and Here too. > Source/WebCore/ChangeLog:15 > + logicalHeightForChild, which account for this block’s writing mode, instead of logicalTop And here. > Source/WebCore/ChangeLog:16 > + and logicalBottom, which are based on the child’s writing mode. And here. :-P 677588 3 mitz 2012-07-24 21:15:33 -0700 (In reply to comment #2) > (From update of attachment 154238 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154238&action=review > > > Source/WebCore/ChangeLog:12 > > + one of the sub-tests in the new regression test: (1) changed to compare children’s logical > > Funny apostrophe character on children's? I blame bug 75394 :( 677596 4 mitz 2012-07-24 21:43:14 -0700 Fixed in <http://trac.webkit.org/r123571>. 154238 2012-07-24 20:59:57 -0700 2012-07-24 21:10:12 -0700 Use logical coordinates consistently and correctly bug-92202-20120724205947.patch text/plain 5205 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzU2OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTI0ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVuZGVyQmxvY2s6OnBvc2l0aW9u Rm9yUG9pbnQgY2FuIGZhaWwgd2hlbiB0aGUgYmxvY2sgb3IgaXRzIGNoaWxkcmVuIGhhdmUgYSB2 ZXJ0aWNhbCB3cml0aW5nIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTkyMjAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGVzdDogZmFzdC93cml0aW5nLW1vZGUvcG9zaXRpb25Gb3JQb2ludC5odG1s CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyQmxvY2s6OnBvc2l0aW9uRm9yUG9pbnQpOiBGaXhlZCB0d28gaXNzdWVzLCBlYWNo IG9mIHdoaWNoIGFyZSBjb3ZlcmVkIGJ5CisgICAgICAgIG9uZSBvZiB0aGUgc3ViLXRlc3RzIGlu IHRoZSBuZXcgcmVncmVzc2lvbiB0ZXN0OiAoMSkgY2hhbmdlZCB0byBjb21wYXJlIGNoaWxkcmVu 4oCZcyBsb2dpY2FsCisgICAgICAgIGJvdW5kcyBhZ2FpbnN0IHBvaW50SW5Mb2dpY2FsQ29udGVu dHMsIGkuZS4gY29tcGFyZSBjaGlsZGVybuKAmXMgaG9yaXpvbnRhbCBib3VuZHMgdG8gdGhlCisg ICAgICAgIHBvaW504oCZcyBob3Jpem9udGFsIGNvbXBvbmVudDsgYW5kICgyKSBjaGFuZ2VkIHRv IHVzZSBsb2dpY2FsVG9wRm9yQ2hpbGQgYW5kCisgICAgICAgIGxvZ2ljYWxIZWlnaHRGb3JDaGls ZCwgd2hpY2ggYWNjb3VudCBmb3IgdGhpcyBibG9ja+KAmXMgd3JpdGluZyBtb2RlLCBpbnN0ZWFk IG9mIGxvZ2ljYWxUb3AKKyAgICAgICAgYW5kIGxvZ2ljYWxCb3R0b20sIHdoaWNoIGFyZSBiYXNl ZCBvbiB0aGUgY2hpbGTigJlzIHdyaXRpbmcgbW9kZS4KKwogMjAxMi0wNy0yNCAgQWxlYyBGbGV0 dCAgPGFsZWNmbGV0dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBmaXggI2lu Y2x1ZGUgZGVwZW5kZW5jaWVzIHNvIElEQlJlcXVlc3QgaXNuJ3QgYW4gaW5jbHVkZSByb290Cklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHJldmlzaW9uIDEy MzU2NikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTUwMTgsMTIgKzUwMTgsMTIgQEAgVmlzaWJsZVBvc2l0aW9uIFJlbmRlckJs b2NrOjpwb3NpdGlvbkZvcgogICAgICAgICBsYXN0Q2FuZGlkYXRlQm94ID0gbGFzdENhbmRpZGF0 ZUJveC0+cHJldmlvdXNTaWJsaW5nQm94KCk7CiAKICAgICBpZiAobGFzdENhbmRpZGF0ZUJveCkg ewotICAgICAgICBpZiAocG9pbnRJbkNvbnRlbnRzLnkoKSA+IGxhc3RDYW5kaWRhdGVCb3gtPmxv Z2ljYWxUb3AoKSkKKyAgICAgICAgaWYgKHBvaW50SW5Mb2dpY2FsQ29udGVudHMueSgpID4gbG9n aWNhbFRvcEZvckNoaWxkKGxhc3RDYW5kaWRhdGVCb3gpKQogICAgICAgICAgICAgcmV0dXJuIHBv c2l0aW9uRm9yUG9pbnRSZXNwZWN0aW5nRWRpdGluZ0JvdW5kYXJpZXModGhpcywgbGFzdENhbmRp ZGF0ZUJveCwgcG9pbnRJbkNvbnRlbnRzKTsKIAogICAgICAgICBmb3IgKFJlbmRlckJveCogY2hp bGRCb3ggPSBmaXJzdENoaWxkQm94KCk7IGNoaWxkQm94OyBjaGlsZEJveCA9IGNoaWxkQm94LT5u ZXh0U2libGluZ0JveCgpKSB7CiAgICAgICAgICAgICAvLyBXZSBoaXQgY2hpbGQgaWYgb3VyIGNs aWNrIGlzIGFib3ZlIHRoZSBib3R0b20gb2YgaXRzIHBhZGRpbmcgYm94IChsaWtlIElFNi83IGFu ZCBGRjMpLgotICAgICAgICAgICAgaWYgKGlzQ2hpbGRIaXRUZXN0Q2FuZGlkYXRlKGNoaWxkQm94 KSAmJiBwb2ludEluQ29udGVudHMueSgpIDwgY2hpbGRCb3gtPmxvZ2ljYWxCb3R0b20oKSkKKyAg ICAgICAgICAgIGlmIChpc0NoaWxkSGl0VGVzdENhbmRpZGF0ZShjaGlsZEJveCkgJiYgcG9pbnRJ bkxvZ2ljYWxDb250ZW50cy55KCkgPCBsb2dpY2FsVG9wRm9yQ2hpbGQoY2hpbGRCb3gpICsgbG9n aWNhbEhlaWdodEZvckNoaWxkKGNoaWxkQm94KSkKICAgICAgICAgICAgICAgICByZXR1cm4gcG9z aXRpb25Gb3JQb2ludFJlc3BlY3RpbmdFZGl0aW5nQm91bmRhcmllcyh0aGlzLCBjaGlsZEJveCwg cG9pbnRJbkNvbnRlbnRzKTsKICAgICAgICAgfQogICAgIH0KSW5kZXg6IExheW91dFRlc3RzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEy MzU2OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDEzIEBACisyMDEyLTA3LTI0ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAg ICAgICAgUmVuZGVyQmxvY2s6OnBvc2l0aW9uRm9yUG9pbnQgY2FuIGZhaWwgd2hlbiB0aGUgYmxv Y2sgb3IgaXRzIGNoaWxkcmVuIGhhdmUgYSB2ZXJ0aWNhbCB3cml0aW5nIG1vZGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyMjAyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3dyaXRpbmctbW9k ZS9wb3NpdGlvbkZvclBvaW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC93 cml0aW5nLW1vZGUvcG9zaXRpb25Gb3JQb2ludC5odG1sOiBBZGRlZC4KKwogMjAxMi0wNy0yNCAg SmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBzZXR0aW5nIHBsYXli YWNrUmF0ZSBvbiBhIE1lZGlhQ29udHJvbGxlciBkb2Vzbid0IGNoYW5nZSB0aGUgcGxheWJhY2tS YXRlIGZvciBzbGF2ZWQgbWVkaWEKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvd3JpdGluZy1tb2Rl L3Bvc2l0aW9uRm9yUG9pbnQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3Qvd3JpdGluZy1tb2RlL3Bvc2l0aW9uRm9yUG9pbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC93cml0aW5nLW1vZGUvcG9zaXRpb25Gb3JQb2ludC1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorCitUZXN0IDEgcmVzdWx0 OiBQQVNTCitUZXN0IDIgcmVzdWx0OiBQQVNTCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvd3Jp dGluZy1tb2RlL3Bvc2l0aW9uRm9yUG9pbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L3dyaXRpbmctbW9kZS9wb3NpdGlvbkZvclBvaW50Lmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9mYXN0L3dyaXRpbmctbW9kZS9wb3NpdGlvbkZvclBvaW50Lmh0bWwJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMzQgQEAKKzxkaXYgaWQ9InRlc3QtMSIgc3R5bGU9IndpZHRo OiAyMDBweDsgb3V0bGluZTogZGFzaGVkIGxpZ2h0Ymx1ZTsiPgorICAgIDxkaXYgc3R5bGU9Imhl aWdodDogMTBweDsgYmFja2dyb3VuZC1jb2xvcjogc2lsdmVyOyI+PC9kaXY+CisgICAgPGRpdiBz dHlsZT0id2lkdGg6IDIwMHB4OyBoZWlnaHQ6IDEwcHg7IGJhY2tncm91bmQtY29sb3I6IHNpbHZl cjsgLXdlYmtpdC13cml0aW5nLW1vZGU6IHZlcnRpY2FsLWxyOyI+PC9kaXY+CisgICAgPGRpdiBj bGFzcz0idGFyZ2V0IiBzdHlsZT0ibWFyZ2luLXRvcDogNDBweDsgaGVpZ2h0OiAyMHB4OyBiYWNr Z3JvdW5kLWNvbG9yOiBzaWx2ZXI7Ij48L2Rpdj4KKzwvZGl2PgorPGJyPgorPGRpdiBpZD0idGVz dC0yIiBzdHlsZT0iaGVpZ2h0OiAyMDBweDsgb3V0bGluZTogZGFzaGVkIGxpZ2h0Ymx1ZTsgLXdl YmtpdC13cml0aW5nLW1vZGU6IHZlcnRpY2FsLWxyOyI+CisgICAgPGRpdiBzdHlsZT0id2lkdGg6 IDEwcHg7IGJhY2tncm91bmQtY29sb3I6IHNpbHZlcjsiPjwvZGl2PgorICAgIDxkaXYgY2xhc3M9 InRhcmdldCIgc3R5bGU9Im1hcmdpbi1sZWZ0OiA0MHB4OyB3aWR0aDogMTBweDsgYmFja2dyb3Vu ZC1jb2xvcjogc2lsdmVyOyI+PC9kaXY+CisgICAgPGRpdiBzdHlsZT0id2lkdGg6IDIwcHg7IGJh Y2tncm91bmQtY29sb3I6IHNpbHZlcjsiPjwvZGl2PgorPC9kaXY+CisKKzxwcmUgaWQ9ImNvbnNv bGUiPjwvcHJlPgorCis8c2NyaXB0PgorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICAgIGZ1 bmN0aW9uIGxvZyhtZXNzYWdlKQorICAgIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoImNvbnNvbGUiKS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShtZXNzYWdl ICsgIlxuIikpOworICAgIH0KKworICAgIGZ1bmN0aW9uIHRlc3QoaW5kZXgsIHgsIHkpCisgICAg eworICAgICAgICB2YXIgY29udGFpbmVyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3Qt IiArIGluZGV4KTsKKyAgICAgICAgdmFyIHJhbmdlID0gZG9jdW1lbnQuY2FyZXRSYW5nZUZyb21Q b2ludChjb250YWluZXIub2Zmc2V0TGVmdCArIHgsIGNvbnRhaW5lci5vZmZzZXRUb3AgKyB5KTsK KyAgICAgICAgbG9nKCJUZXN0ICIgKyBpbmRleCArICIgcmVzdWx0OiAiCisgICAgICAgICAgICAr IChyYW5nZS5zdGFydENvbnRhaW5lci5jbGFzc05hbWUgPT09ICJ0YXJnZXQiID8gIlBBU1MiIDog IkZBSUwiKSk7CisgICAgfQorCisgICAgdGVzdCgxLCAyMCwgNTApOworICAgIHRlc3QoMiwgMjAs IDE4MCk7Cis8L3NjcmlwdD4K