92187 2012-07-24 17:53:26 -0700 ASSERTION FAILED: !rect.isEmpty() : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect &) 2012-07-30 13:25:39 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Mac (Intel) Other CLOSED FIXED http://www.yahoo.com InRadar P2 Normal --- 1 dimitris.apostolou jchaffraix eric jchaffraix mitz simon.fraser webkit-bug-importer webkit.review.bot oldest_to_newest 677439 0 dimitris.apostolou 2012-07-24 17:53:26 -0700 r123549 Reproducibility: always Steps: http://www.yahoo.com What happened: ASSERTION FAILED: !rect.isEmpty() /Users/rex/WebKit/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp(381) : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect &) 1 0x1069a9350 WebCore::GraphicsContext::drawRect(WebCore::IntRect const&) 2 0x10750f722 WebCore::RenderObject::drawLineForBoxSide(WebCore::GraphicsContext*, int, int, int, int, WebCore::BoxSide, WebCore::Color, WebCore::EBorderStyle, int, int, bool) 3 0x1074355ca WebCore::RenderBoxModelObject::paintOneBorderSide(WebCore::GraphicsContext*, WebCore::RenderStyle const*, WebCore::RoundedRect const&, WebCore::RoundedRect const&, WebCore::IntRect const&, WebCore::BoxSide, WebCore::BoxSide, WebCore::BoxSide, WebCore::BorderEdge const*, WebCore::Path const*, WebCore::BackgroundBleedAvoidance, bool, bool, bool, WebCore::Color const*) 4 0x1074379a4 WebCore::RenderBoxModelObject::paintBorderSides(WebCore::GraphicsContext*, WebCore::RenderStyle const*, WebCore::RoundedRect const&, WebCore::RoundedRect const&, WebCore::BorderEdge const*, unsigned int, WebCore::BackgroundBleedAvoidance, bool, bool, bool, WebCore::Color const*) 5 0x107438d49 WebCore::RenderBoxModelObject::paintBorder(WebCore::PaintInfo const&, WebCore::FractionalLayoutRect const&, WebCore::RenderStyle const*, WebCore::BackgroundBleedAvoidance, bool, bool) 6 0x107410a4b WebCore::RenderBox::paintBoxDecorations(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 7 0x1073ac699 WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 8 0x1073a9c93 WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 9 0x1073ac118 WebCore::RenderBlock::paintChild(WebCore::RenderBox*, WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&, WebCore::PaintInfo&, bool) 10 0x1073abd97 WebCore::RenderBlock::paintChildren(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&, WebCore::PaintInfo&, bool) 11 0x1073abd1a WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 12 0x1073ac8a4 WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 13 0x1073a9c93 WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) 14 0x1074ac349 WebCore::RenderLayer::paintLayerContents(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 15 0x1074ab957 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 16 0x1074aafe8 WebCore::RenderLayer::paintLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 17 0x1074ad348 WebCore::RenderLayer::paintList(WTF::Vector<WebCore::RenderLayer*, 0ul>*, WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 18 0x1074ac659 WebCore::RenderLayer::paintLayerContents(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 19 0x1074ab957 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 20 0x1074aafe8 WebCore::RenderLayer::paintLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 21 0x1074ad348 WebCore::RenderLayer::paintList(WTF::Vector<WebCore::RenderLayer*, 0ul>*, WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 22 0x1074ac659 WebCore::RenderLayer::paintLayerContents(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::FractionalLayoutRect const&, unsigned int, WebCore::RenderObject*, WebCore::RenderRegion*, WTF::HashMap<WebCore::OverlapTestRequestClient*, WebCore::IntRect, WTF::PtrHash<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::OverlapTestRequestClient*>, WTF::HashTraits<WebCore::IntRect> >*, unsigned int) 23 0x1074c8bca WebCore::RenderLayerBacking::paintIntoLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::IntRect const&, unsigned int, WebCore::GraphicsLayerPaintingPhase, WebCore::RenderObject*) 24 0x1074c8e84 WebCore::RenderLayerBacking::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, WebCore::IntRect const&) 25 0x1069b5420 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::IntRect const&) 26 0x1069bd8a0 WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::GraphicsContext&, WebCore::IntRect const&) 27 0x1069bd8e7 non-virtual thunk to WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::GraphicsContext&, WebCore::IntRect const&) 28 0x107a6acb7 __drawLayerContents_block_invoke_0 29 0x1048cb24b WKCALayerEnumerateRectsBeingDrawnWithBlock 30 0x107a6a54c drawLayerContents(CGContext*, CALayer*, WebCore::PlatformCALayer*) 31 0x1079c9e4b WebCore::TileCache::drawLayer(WebTileLayer*, CGContext*) Expected result: No assert failure. 679601 1 simon.fraser 2012-07-26 11:50:17 -0700 Is this a regression from http://trac.webkit.org/changeset/123061 ? 679624 2 jchaffraix 2012-07-26 12:00:20 -0700 (In reply to comment #1) > Is this a regression from http://trac.webkit.org/changeset/123061 ? Yes, this change added the ASSERT but it means we were already doing something unneeded. 680798 3 simon.fraser 2012-07-27 10:47:17 -0700 <rdar://problem/11909631> 680876 4 154999 jchaffraix 2012-07-27 11:40:13 -0700 Created attachment 154999 Proposed change. Add an |height| check too. 680888 5 154999 simon.fraser 2012-07-27 11:51:10 -0700 Comment on attachment 154999 Proposed change. Add an |height| check too. View in context: https://bugs.webkit.org/attachment.cgi?id=154999&action=review > Source/WebCore/rendering/RenderObject.cpp:838 > + int width = side == BSTop || side == BSBottom ? y2 - y1 : x2 - x1; > + int height = side == BSTop || side == BSBottom ? x2 - x1 : y2 - y1; width and height are confusing here. Maybe rename 'width' to 'thickness', and 'height' to 'length'? Maybe also use if (top or bottom) { thickness = ; height = } to make it more clear. 681178 6 155072 jchaffraix 2012-07-27 15:47:26 -0700 Created attachment 155072 Proposed change v2: Renamed the variable and fixed another potential issue found by code inspection. 682136 7 155072 webkit.review.bot 2012-07-30 10:24:30 -0700 Comment on attachment 155072 Proposed change v2: Renamed the variable and fixed another potential issue found by code inspection. Clearing flags on attachment: 155072 Committed r124044: <http://trac.webkit.org/changeset/124044> 682137 8 webkit.review.bot 2012-07-30 10:24:34 -0700 All reviewed patches have been landed. Closing bug. 682329 9 dimitris.apostolou 2012-07-30 13:25:39 -0700 Verified with r124045 154999 2012-07-27 11:40:13 -0700 2012-07-27 15:47:23 -0700 Proposed change. Add an |height| check too. bug-92187-20120727114001.patch text/plain 6389 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQwODM0ZTZkNmQzMTk1 YTc0N2YyYWQwZDVjNDMxOWQzMDJmZjRkOC4uZjIxY2U1MDFhNjgxZGEwMWVlYjFhYjIyNjY0ZGI3 YWZkMWYzZDFjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA3LTI3ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIEFTU0VSVElP TiBGQUlMRUQ6ICFyZWN0LmlzRW1wdHkoKSAgOiB2b2lkIFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4 dDo6ZHJhd1JlY3QoY29uc3QgV2ViQ29yZTo6SW50UmVjdCAmKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIxODcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYm9yZGVyIHBhaW50aW5nIGxvZ2ljIChS ZW5kZXJCb3hNb2RlbE9iamVjdDo6cGFpbnRPbmVCb3JkZXJTaWRlKSB3b3VsZCBwYXNzIGEgcmVj dCB3aXRoIGEgMHB4IGhlaWdodAorICAgICAgICB0byBSZW5kZXJPYmplY3Q6OmRyYXdMaW5lRm9y Qm94U2lkZS4gV2UgZG8gY2hlY2sgdGhlIHdpZHRoIGJ1dCBub3QgdGhlIGhlaWdodCBzbyB3ZSB3 b3VsZCBwYXNzIHRoZSByZWN0IHRvCisgICAgICAgIEdyYXBoaWNzQ29udGV4dCBhbmQgaGl0IHRo ZSBBU1NFUlQuIFRoaXMgY2hhbmdlIGFkZHMgYSBjaGVjayBmb3IgaGVpZ2h0IHRvbyBhcyBpdCBp cyB0aGUgc2FmZXN0IHdheSwgaXQgbWVhbnMKKyAgICAgICAgdGhhdCB3ZSBtYXkgc3RpbGwgZG8g dW5uZWVkZWQgb3BlcmF0aW9ucyBiZWZvcmUgYmFpbGluZyBvdXQgYnV0IHRoYXQncyBhbiBleGlz dGluZyBwcm9ibGVtIGluIHRoZSBjb2RlLgorCisgICAgICAgIFRlc3Q6IGZhc3QvYm9yZGVycy8w cHgtYm9yZGVycy1uby1saW5lLWhlaWdodC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6ZHJhd0xpbmVG b3JCb3hTaWRlKToKKyAgICAgICAgQWRkZWQgYSAwcHggaGVpZ2h0IGNoZWNrLiBXaGlsZSBhZGRp bmcgYW4gZXhwbGljaXQgfGhlaWdodHwgdmFyaWFibGUsIGNoYW5nZWQgb25lIHBhdGggdG8gdXNl IGl0CisgICAgICAgIChhbmQgcmVtb3ZlZCBzb21lIHJlZHVuZGFudCBjb2RlKS4KKwogMjAxMi0w Ny0yNiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEhU TUxBcHBsZXRFbGVtZW50IHNob3VsZCBpbmhlcml0IGZyb20gSFRNTFBsdWdJbkltYWdlRWxlbWVu dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAppbmRleCA2MzkxMzM0 ZWZjNDJkMDIwZTM3ODBiNjc1NDQyOTQzODU3NTNmZGVhLi42ODI5YjMyMmY3NTNmN2ZlYjU3MTll ZTY1N2E1ZjY3NDI5MzJjOTI0IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0LmNwcApAQCAtODM0LDExICs4MzQsMTIgQEAgdm9pZCBSZW5kZXJPYmplY3Q6OmRyYXdMaW5l Rm9yQm94U2lkZShHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNzQ29udGV4dCwgaW50IHgxLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBCb3hTaWRlIHNpZGUsIENvbG9yIGNv bG9yLCBFQm9yZGVyU3R5bGUgc3R5bGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGludCBhZGphY2VudFdpZHRoMSwgaW50IGFkamFjZW50V2lkdGgyLCBib29sIGFudGlh bGlhcykKIHsKLSAgICBpbnQgd2lkdGggPSAoc2lkZSA9PSBCU1RvcCB8fCBzaWRlID09IEJTQm90 dG9tID8geTIgLSB5MSA6IHgyIC0geDEpOworICAgIGludCB3aWR0aCA9IHNpZGUgPT0gQlNUb3Ag fHwgc2lkZSA9PSBCU0JvdHRvbSA/IHkyIC0geTEgOiB4MiAtIHgxOworICAgIGludCBoZWlnaHQg PSBzaWRlID09IEJTVG9wIHx8IHNpZGUgPT0gQlNCb3R0b20gPyB4MiAtIHgxIDogeTIgLSB5MTsK IAotICAgIC8vIEZJWE1FOiBXZSByZWFsbHkgd291bGQgbGlrZSB0aGlzIGNoZWNrIHRvIGJlIGFu IEFTU0VSVCBhcyB3ZSBkb24ndCB3YW50IHRvIGRyYXcgMHB4IGJvcmRlcnMuIEhvd2V2ZXIKLSAg ICAvLyBub3RoaW5nIGd1YXJhbnRlZXMgdGhhdCB0aGUgZm9sbG93aW5nIHJlY3Vyc2l2ZSBjYWxs cyB0byBkcmF3TGluZUZvckJveFNpZGUgd2lsbCBoYXZlIG5vbi1udWxsIHdpZHRoLgotICAgIGlm ICghd2lkdGgpCisgICAgLy8gRklYTUU6IFdlIHJlYWxseSB3b3VsZCBsaWtlIHRoaXMgY2hlY2sg dG8gYmUgYW4gQVNTRVJUIGFzIHdlIGRvbid0IHdhbnQgdG8gZHJhdyBlbXB0eSBib3JkZXJzLiBI b3dldmVyCisgICAgLy8gbm90aGluZyBndWFyYW50ZWVzIHRoYXQgdGhlIGZvbGxvd2luZyByZWN1 cnNpdmUgY2FsbHMgdG8gZHJhd0xpbmVGb3JCb3hTaWRlIHdpbGwgaGF2ZSBub24tbnVsbCBkaW1l bnNpb25zLgorICAgIGlmICghd2lkdGggfHwgIWhlaWdodCkKICAgICAgICAgcmV0dXJuOwogCiAg ICAgaWYgKHN0eWxlID09IERPVUJMRSAmJiB3aWR0aCA8IDMpCkBAIC04ODgsMTYgKzg4OSwxMyBA QCB2b2lkIFJlbmRlck9iamVjdDo6ZHJhd0xpbmVGb3JCb3hTaWRlKEdyYXBoaWNzQ29udGV4dCog Z3JhcGhpY3NDb250ZXh0LCBpbnQgeDEsCiAgICAgICAgICAgICAgICAgc3dpdGNoIChzaWRlKSB7 CiAgICAgICAgICAgICAgICAgICAgIGNhc2UgQlNUb3A6CiAgICAgICAgICAgICAgICAgICAgIGNh c2UgQlNCb3R0b206Ci0gICAgICAgICAgICAgICAgICAgICAgICBncmFwaGljc0NvbnRleHQtPmRy YXdSZWN0KEludFJlY3QoeDEsIHkxLCB4MiAtIHgxLCB0aGlyZCkpOwotICAgICAgICAgICAgICAg ICAgICAgICAgZ3JhcGhpY3NDb250ZXh0LT5kcmF3UmVjdChJbnRSZWN0KHgxLCB5MiAtIHRoaXJk LCB4MiAtIHgxLCB0aGlyZCkpOworICAgICAgICAgICAgICAgICAgICAgICAgZ3JhcGhpY3NDb250 ZXh0LT5kcmF3UmVjdChJbnRSZWN0KHgxLCB5MSwgaGVpZ2h0LCB0aGlyZCkpOworICAgICAgICAg ICAgICAgICAgICAgICAgZ3JhcGhpY3NDb250ZXh0LT5kcmF3UmVjdChJbnRSZWN0KHgxLCB5MiAt IHRoaXJkLCBoZWlnaHQsIHRoaXJkKSk7CiAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsK ICAgICAgICAgICAgICAgICAgICAgY2FzZSBCU0xlZnQ6Ci0gICAgICAgICAgICAgICAgICAgICAg ICBncmFwaGljc0NvbnRleHQtPmRyYXdSZWN0KEludFJlY3QoeDEsIHkxICsgMSwgdGhpcmQsIHky IC0geTEgLSAxKSk7Ci0gICAgICAgICAgICAgICAgICAgICAgICBncmFwaGljc0NvbnRleHQtPmRy YXdSZWN0KEludFJlY3QoeDIgLSB0aGlyZCwgeTEgKyAxLCB0aGlyZCwgeTIgLSB5MSAtIDEpKTsK LSAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAgICBjYXNl IEJTUmlnaHQ6CiAgICAgICAgICAgICAgICAgICAgICAgICBncmFwaGljc0NvbnRleHQtPmRyYXdS ZWN0KEludFJlY3QoeDEsIHkxICsgMSwgdGhpcmQsIHkyIC0geTEgLSAxKSk7Ci0gICAgICAgICAg ICAgICAgICAgICAgICBncmFwaGljc0NvbnRleHQtPmRyYXdSZWN0KEludFJlY3QoeDIgLSB0aGly ZCwgeTEgKyAxLCB0aGlyZCwgeTIgLSB5MSAtIDEpKTsKKyAgICAgICAgICAgICAgICAgICAgICAg IGdyYXBoaWNzQ29udGV4dC0+ZHJhd1JlY3QoSW50UmVjdCh4MiAtIHRoaXJkLCB5MSArIDEsIHRo aXJkLCBoZWlnaHQgLSAxKSk7CiAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxMTRkOTQyMTQ2YmFhYWNhMmJjNmUxYTdkOTIzMDc3ZDk4 MGY5ZmRkLi5lZDA4MmY1YWU3OTI2OGEzOWJkOGRiMDg0NjcyODk4MmM4MWU5OTY3IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDctMjcgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4 QHdlYmtpdC5vcmc+CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogIXJlY3QuaXNFbXB0eSgp ICA6IHZvaWQgV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpkcmF3UmVjdChjb25zdCBXZWJDb3Jl OjpJbnRSZWN0ICYpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05MjE4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogZmFzdC9ib3JkZXJzLzBweC1ib3JkZXJzLW5vLWxpbmUtaGVpZ2h0LWV4cGVjdGVkLmh0 bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvYm9yZGVycy8wcHgtYm9yZGVycy1uby1saW5lLWhl aWdodC5odG1sOiBBZGRlZC4KKwogMjAxMi0wNy0yNiAgQW5kcmV3IFdpbHNvbiAgPGF0d2lsc29u QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGNocm9taXVtIGV4cGVjdGF0aW9u cyB1cGRhdGUgZm9yIHRhYmxlLXJvdy1vdXRsaW5lLXBhaW50Lmh0bWwgZnJvbSByMTIzNzkzLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ib3JkZXJzLzBweC1ib3JkZXJzLW5vLWxpbmUt aGVpZ2h0LWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2JvcmRlcnMvMHB4LWJvcmRl cnMtbm8tbGluZS1oZWlnaHQtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42Y2JkODY0MjZiZjVk Mzk3YzliZmQzMmM0MzljNjJmOGNkNmJhOTQ1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9ib3JkZXJzLzBweC1ib3JkZXJzLW5vLWxpbmUtaGVpZ2h0LWV4cGVjdGVkLmh0bWwK QEAgLTAsMCArMSwxNyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHN0eWxl PgorLmJvcmRlciB7CisgICAgYm9yZGVyLXJpZ2h0OiAxcHggc29saWQgYmxhY2s7CisgICAgYm9y ZGVyLWxlZnQ6IDFweCBzb2xpZCBibGFjazsKKyAgICBsaW5lLWhlaWdodDogMDsKK30KKzwvc3R5 bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPlRlc3QgZm9yIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjE4NyI+OTIxODc8L2E+OiBBU1NFUlRJT04gRkFJ TEVEOiAhcmVjdC5pc0VtcHR5KCkgIDogdm9pZCBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmRy YXdSZWN0KGNvbnN0IFdlYkNvcmU6OkludFJlY3QgJik8L3A+Cis8cD5UaGlzIHRlc3QgcGFzc2Vz IGlmIGl0IGRvZXNuJ3QgQVNTRVJULjwvcD4KKzxkaXYgY2xhc3M9ImJvcmRlciI+Jm5zYnA7PC9k aXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2JvcmRl cnMvMHB4LWJvcmRlcnMtbm8tbGluZS1oZWlnaHQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvYm9y ZGVycy8wcHgtYm9yZGVycy1uby1saW5lLWhlaWdodC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNzU1 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmY2ZGFkNDE0 M2NjZjQ2NDJmMDkwMzZkMjRiNzBjYTVlOTg0NGZjODUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2JvcmRlcnMvMHB4LWJvcmRlcnMtbm8tbGluZS1oZWlnaHQuaHRtbApAQCAt MCwwICsxLDE3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+Cisu Ym9yZGVyIHsKKyAgICBib3JkZXItc3R5bGU6IHNvbGlkOworICAgIGJvcmRlci13aWR0aDogMCAx cHggMCAxcHg7CisgICAgbGluZS1oZWlnaHQ6IDA7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJv ZHk+Cis8cD5UZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTIxODciPjkyMTg3PC9hPjogQVNTRVJUSU9OIEZBSUxFRDogIXJlY3QuaXNFbXB0 eSgpICA6IHZvaWQgV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpkcmF3UmVjdChjb25zdCBXZWJD b3JlOjpJbnRSZWN0ICYpPC9wPgorPHA+VGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vzbid0IEFT U0VSVC48L3A+Cis8ZGl2IGNsYXNzPSJib3JkZXIiPiZuc2JwOzwvZGl2PgorPC9ib2R5PgorPC9o dG1sPgo= 155072 2012-07-27 15:47:26 -0700 2012-07-30 10:24:30 -0700 Proposed change v2: Renamed the variable and fixed another potential issue found by code inspection. bug-92187-20120727154713.patch text/plain 13592 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzOTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVjZGJiN2NhYWIzMjBi MjlmODQ5YzJkZGU5YTQwMWYyODk3YTEwZS4uMTZlNWU2NGNiOTZlMWUxZTQzMjQ4Njk4MGRkOWFj NzUzZjk3YTRjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA3LTI3ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIEFTU0VSVElP TiBGQUlMRUQ6ICFyZWN0LmlzRW1wdHkoKSAgOiB2b2lkIFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4 dDo6ZHJhd1JlY3QoY29uc3QgV2ViQ29yZTo6SW50UmVjdCAmKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIxODcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYm9yZGVyIHBhaW50aW5nIGxvZ2ljIChS ZW5kZXJCb3hNb2RlbE9iamVjdDo6cGFpbnRPbmVCb3JkZXJTaWRlKSB3b3VsZCBwYXNzIGEgcmVj dCB3aXRoIGEgMHB4IGxlbmd0aAorICAgICAgICB0byBSZW5kZXJPYmplY3Q6OmRyYXdMaW5lRm9y Qm94U2lkZS4gV2UgZG8gY2hlY2sgdGhlIHdpZHRoICh0aGlja25lc3MpIGJ1dCBub3QgdGhlIGxl bmd0aCBzbyB3ZSB3b3VsZCBwYXNzCisgICAgICAgIHRoZSByZWN0IHRvIEdyYXBoaWNzQ29udGV4 dCBhbmQgaGl0IHRoZSBBU1NFUlQuIFRoaXMgY2hhbmdlIGFkZHMgYSBjaGVjayBmb3IgdGhlIGxl bmd0aCB0b28gYXMgaXQgaXMgdGhlIHNhZmVzdAorICAgICAgICB3YXksIGl0IG1lYW5zIHRoYXQg d2UgbWF5IHN0aWxsIGRvIHVubmVlZGVkIG9wZXJhdGlvbnMgYmVmb3JlIGJhaWxpbmcgb3V0IGJ1 dCB0aGF0J3MgYW4gZXhpc3RpbmcgcHJvYmxlbSBpbiB0aGUgY29kZS4KKworICAgICAgICBUZXN0 czogZmFzdC9ib3JkZXJzLzBweC1ib3JkZXJzLW5vLWxpbmUtaGVpZ2h0Lmh0bWwKKyAgICAgICAg ICAgICAgIGZhc3QvYm9yZGVycy9kb3VibGUtMXB4LWJvcmRlci1hc3NlcnQuaHRtbAorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJPYmplY3Q6OmRyYXdMaW5lRm9yQm94U2lkZSk6CisgICAgICAgIEFkZGVkIGEgMHB4IGxlbmd0 aCBjaGVjay4gV2hpbGUgcmVuYW1pbmcgY29uZnVzaW5nIHZhcmlhYmxlcyBhbmQgcmUtdXNpbmcg b3RoZXJzLAorICAgICAgICBJIGFsc28gZm91bmQgYSBwb3RlbnRpYWwgZW1wdHkgYm9yZGVyIHRo YXQgSSBmaXhlZCAodGVzdGVkIGJ5IHRoZSAybmQgY2FzZSBhYm92ZSkuCisKIDIwMTItMDctMjcg IE1pbiBRaW4gIDxxaW5taW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBhbiBvdmVybGF5 IHBsYXkgYnV0dG9uIHRvIG1lZGlhIGNvbnRyb2xzIG9uIGFuZHJvaWQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKaW5kZXggNjM5MTMzNGVmYzQyZDAyMGUzNzgwYjY3 NTQ0Mjk0Mzg1NzUzZmRlYS4uNDJjYWRiMzc4MzYzZjI3ZjA2MjM0OGUyYTI0OGVmZGIyNmU4NzAy MSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKQEAgLTgzNCwx NCArODM0LDIyIEBAIHZvaWQgUmVuZGVyT2JqZWN0OjpkcmF3TGluZUZvckJveFNpZGUoR3JhcGhp Y3NDb250ZXh0KiBncmFwaGljc0NvbnRleHQsIGludCB4MSwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgQm94U2lkZSBzaWRlLCBDb2xvciBjb2xvciwgRUJvcmRlclN0eWxl IHN0eWxlLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgYWRqYWNl bnRXaWR0aDEsIGludCBhZGphY2VudFdpZHRoMiwgYm9vbCBhbnRpYWxpYXMpCiB7Ci0gICAgaW50 IHdpZHRoID0gKHNpZGUgPT0gQlNUb3AgfHwgc2lkZSA9PSBCU0JvdHRvbSA/IHkyIC0geTEgOiB4 MiAtIHgxKTsKKyAgICBpbnQgdGhpY2tuZXNzOworICAgIGludCBsZW5ndGg7CisgICAgaWYgKHNp ZGUgPT0gQlNUb3AgfHwgc2lkZSA9PSBCU0JvdHRvbSkgeworICAgICAgICB0aGlja25lc3MgPSB5 MiAtIHkxOworICAgICAgICBsZW5ndGggPSB4MiAtIHgxOworICAgIH0gZWxzZSB7CisgICAgICAg IHRoaWNrbmVzcyA9IHgyIC0geDE7CisgICAgICAgIGxlbmd0aCA9IHkyIC0geTE7CisgICAgfQog Ci0gICAgLy8gRklYTUU6IFdlIHJlYWxseSB3b3VsZCBsaWtlIHRoaXMgY2hlY2sgdG8gYmUgYW4g QVNTRVJUIGFzIHdlIGRvbid0IHdhbnQgdG8gZHJhdyAwcHggYm9yZGVycy4gSG93ZXZlcgotICAg IC8vIG5vdGhpbmcgZ3VhcmFudGVlcyB0aGF0IHRoZSBmb2xsb3dpbmcgcmVjdXJzaXZlIGNhbGxz IHRvIGRyYXdMaW5lRm9yQm94U2lkZSB3aWxsIGhhdmUgbm9uLW51bGwgd2lkdGguCi0gICAgaWYg KCF3aWR0aCkKKyAgICAvLyBGSVhNRTogV2UgcmVhbGx5IHdvdWxkIGxpa2UgdGhpcyBjaGVjayB0 byBiZSBhbiBBU1NFUlQgYXMgd2UgZG9uJ3Qgd2FudCB0byBkcmF3IGVtcHR5IGJvcmRlcnMuIEhv d2V2ZXIKKyAgICAvLyBub3RoaW5nIGd1YXJhbnRlZXMgdGhhdCB0aGUgZm9sbG93aW5nIHJlY3Vy c2l2ZSBjYWxscyB0byBkcmF3TGluZUZvckJveFNpZGUgd2lsbCBoYXZlIG5vbi1udWxsIGRpbWVu c2lvbnMuCisgICAgaWYgKCF0aGlja25lc3MgfHwgIWxlbmd0aCkKICAgICAgICAgcmV0dXJuOwog Ci0gICAgaWYgKHN0eWxlID09IERPVUJMRSAmJiB3aWR0aCA8IDMpCisgICAgaWYgKHN0eWxlID09 IERPVUJMRSAmJiB0aGlja25lc3MgPCAzKQogICAgICAgICBzdHlsZSA9IFNPTElEOwogCiAgICAg c3dpdGNoIChzdHlsZSkgewpAQCAtODUxLDExICs4NTksMTEgQEAgdm9pZCBSZW5kZXJPYmplY3Q6 OmRyYXdMaW5lRm9yQm94U2lkZShHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNzQ29udGV4dCwgaW50 IHgxLAogICAgICAgICBjYXNlIERPVFRFRDoKICAgICAgICAgY2FzZSBEQVNIRUQ6IHsKICAgICAg ICAgICAgIGdyYXBoaWNzQ29udGV4dC0+c2V0U3Ryb2tlQ29sb3IoY29sb3IsIG1fc3R5bGUtPmNv bG9yU3BhY2UoKSk7Ci0gICAgICAgICAgICBncmFwaGljc0NvbnRleHQtPnNldFN0cm9rZVRoaWNr bmVzcyh3aWR0aCk7CisgICAgICAgICAgICBncmFwaGljc0NvbnRleHQtPnNldFN0cm9rZVRoaWNr bmVzcyh0aGlja25lc3MpOwogICAgICAgICAgICAgU3Ryb2tlU3R5bGUgb2xkU3Ryb2tlU3R5bGUg PSBncmFwaGljc0NvbnRleHQtPnN0cm9rZVN0eWxlKCk7CiAgICAgICAgICAgICBncmFwaGljc0Nv bnRleHQtPnNldFN0cm9rZVN0eWxlKHN0eWxlID09IERBU0hFRCA/IERhc2hlZFN0cm9rZSA6IERv dHRlZFN0cm9rZSk7CiAKLSAgICAgICAgICAgIGlmICh3aWR0aCA+IDApIHsKKyAgICAgICAgICAg IGlmICh0aGlja25lc3MgPiAwKSB7CiAgICAgICAgICAgICAgICAgYm9vbCB3YXNBbnRpYWxpYXNl ZCA9IGdyYXBoaWNzQ29udGV4dC0+c2hvdWxkQW50aWFsaWFzKCk7CiAgICAgICAgICAgICAgICAg Z3JhcGhpY3NDb250ZXh0LT5zZXRTaG91bGRBbnRpYWxpYXMoYW50aWFsaWFzKTsKIApAQCAtODc1 LDcgKzg4Myw4IEBAIHZvaWQgUmVuZGVyT2JqZWN0OjpkcmF3TGluZUZvckJveFNpZGUoR3JhcGhp Y3NDb250ZXh0KiBncmFwaGljc0NvbnRleHQsIGludCB4MSwKICAgICAgICAgICAgIGJyZWFrOwog ICAgICAgICB9CiAgICAgICAgIGNhc2UgRE9VQkxFOiB7Ci0gICAgICAgICAgICBpbnQgdGhpcmQg PSAod2lkdGggKyAxKSAvIDM7CisgICAgICAgICAgICBpbnQgdGhpcmRPZlRoaWNrbmVzcyA9ICh0 aGlja25lc3MgKyAxKSAvIDM7CisgICAgICAgICAgICBBU1NFUlQodGhpcmRPZlRoaWNrbmVzcyk7 CiAKICAgICAgICAgICAgIGlmIChhZGphY2VudFdpZHRoMSA9PSAwICYmIGFkamFjZW50V2lkdGgy ID09IDApIHsKICAgICAgICAgICAgICAgICBTdHJva2VTdHlsZSBvbGRTdHJva2VTdHlsZSA9IGdy YXBoaWNzQ29udGV4dC0+c3Ryb2tlU3R5bGUoKTsKQEAgLTg4OCwxNiArODk3LDE2IEBAIHZvaWQg UmVuZGVyT2JqZWN0OjpkcmF3TGluZUZvckJveFNpZGUoR3JhcGhpY3NDb250ZXh0KiBncmFwaGlj c0NvbnRleHQsIGludCB4MSwKICAgICAgICAgICAgICAgICBzd2l0Y2ggKHNpZGUpIHsKICAgICAg ICAgICAgICAgICAgICAgY2FzZSBCU1RvcDoKICAgICAgICAgICAgICAgICAgICAgY2FzZSBCU0Jv dHRvbToKLSAgICAgICAgICAgICAgICAgICAgICAgIGdyYXBoaWNzQ29udGV4dC0+ZHJhd1JlY3Qo SW50UmVjdCh4MSwgeTEsIHgyIC0geDEsIHRoaXJkKSk7Ci0gICAgICAgICAgICAgICAgICAgICAg ICBncmFwaGljc0NvbnRleHQtPmRyYXdSZWN0KEludFJlY3QoeDEsIHkyIC0gdGhpcmQsIHgyIC0g eDEsIHRoaXJkKSk7CisgICAgICAgICAgICAgICAgICAgICAgICBncmFwaGljc0NvbnRleHQtPmRy YXdSZWN0KEludFJlY3QoeDEsIHkxLCBsZW5ndGgsIHRoaXJkT2ZUaGlja25lc3MpKTsKKyAgICAg ICAgICAgICAgICAgICAgICAgIGdyYXBoaWNzQ29udGV4dC0+ZHJhd1JlY3QoSW50UmVjdCh4MSwg eTIgLSB0aGlyZE9mVGhpY2tuZXNzLCBsZW5ndGgsIHRoaXJkT2ZUaGlja25lc3MpKTsKICAgICAg ICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAgICBjYXNlIEJTTGVm dDoKLSAgICAgICAgICAgICAgICAgICAgICAgIGdyYXBoaWNzQ29udGV4dC0+ZHJhd1JlY3QoSW50 UmVjdCh4MSwgeTEgKyAxLCB0aGlyZCwgeTIgLSB5MSAtIDEpKTsKLSAgICAgICAgICAgICAgICAg ICAgICAgIGdyYXBoaWNzQ29udGV4dC0+ZHJhd1JlY3QoSW50UmVjdCh4MiAtIHRoaXJkLCB5MSAr IDEsIHRoaXJkLCB5MiAtIHkxIC0gMSkpOwotICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgICAgICAgICAgICAgIGNhc2UgQlNSaWdodDoKLSAgICAgICAgICAgICAgICAgICAg ICAgIGdyYXBoaWNzQ29udGV4dC0+ZHJhd1JlY3QoSW50UmVjdCh4MSwgeTEgKyAxLCB0aGlyZCwg eTIgLSB5MSAtIDEpKTsKLSAgICAgICAgICAgICAgICAgICAgICAgIGdyYXBoaWNzQ29udGV4dC0+ ZHJhd1JlY3QoSW50UmVjdCh4MiAtIHRoaXJkLCB5MSArIDEsIHRoaXJkLCB5MiAtIHkxIC0gMSkp OworICAgICAgICAgICAgICAgICAgICAgICAgLy8gRklYTUU6IFdoeSBkbyB3ZSBvZmZzZXQgdGhl IGJvcmRlciBieSAxIGluIHRoaXMgY2FzZSBidXQgbm90IHRoZSBvdGhlciBvbmU/CisgICAgICAg ICAgICAgICAgICAgICAgICBpZiAobGVuZ3RoID4gMSkgeworICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGdyYXBoaWNzQ29udGV4dC0+ZHJhd1JlY3QoSW50UmVjdCh4MSwgeTEgKyAxLCB0aGly ZE9mVGhpY2tuZXNzLCBsZW5ndGggLSAxKSk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAg Z3JhcGhpY3NDb250ZXh0LT5kcmF3UmVjdChJbnRSZWN0KHgyIC0gdGhpcmRPZlRoaWNrbmVzcywg eTEgKyAxLCB0aGlyZE9mVGhpY2tuZXNzLCBsZW5ndGggLSAxKSk7CisgICAgICAgICAgICAgICAg ICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAg ICB9CiAKQEAgLTkxMCwzMyArOTE5LDMzIEBAIHZvaWQgUmVuZGVyT2JqZWN0OjpkcmF3TGluZUZv ckJveFNpZGUoR3JhcGhpY3NDb250ZXh0KiBncmFwaGljc0NvbnRleHQsIGludCB4MSwKICAgICAg ICAgICAgICAgICBzd2l0Y2ggKHNpZGUpIHsKICAgICAgICAgICAgICAgICAgICAgY2FzZSBCU1Rv cDoKICAgICAgICAgICAgICAgICAgICAgICAgIGRyYXdMaW5lRm9yQm94U2lkZShncmFwaGljc0Nv bnRleHQsIHgxICsgbWF4KCgtYWRqYWNlbnRXaWR0aDEgKiAyICsgMSkgLyAzLCAwKSwKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgeTEsIHgyIC0gbWF4KCgtYWRqYWNlbnRXaWR0 aDIgKiAyICsgMSkgLyAzLCAwKSwgeTEgKyB0aGlyZCwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgeTEsIHgyIC0gbWF4KCgtYWRqYWNlbnRXaWR0aDIgKiAyICsgMSkgLyAzLCAw KSwgeTEgKyB0aGlyZE9mVGhpY2tuZXNzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzaWRlLCBjb2xvciwgU09MSUQsIGFkamFjZW50MUJpZ1RoaXJkLCBhZGphY2VudDJCaWdU aGlyZCwgYW50aWFsaWFzKTsKICAgICAgICAgICAgICAgICAgICAgICAgIGRyYXdMaW5lRm9yQm94 U2lkZShncmFwaGljc0NvbnRleHQsIHgxICsgbWF4KChhZGphY2VudFdpZHRoMSAqIDIgKyAxKSAv IDMsIDApLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB5MiAtIHRoaXJkLCB4 MiAtIG1heCgoYWRqYWNlbnRXaWR0aDIgKiAyICsgMSkgLyAzLCAwKSwgeTIsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHkyIC0gdGhpcmRPZlRoaWNrbmVzcywgeDIgLSBtYXgo KGFkamFjZW50V2lkdGgyICogMiArIDEpIC8gMywgMCksIHkyLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzaWRlLCBjb2xvciwgU09MSUQsIGFkamFjZW50MUJpZ1RoaXJkLCBh ZGphY2VudDJCaWdUaGlyZCwgYW50aWFsaWFzKTsKICAgICAgICAgICAgICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICAgICAgICAgICAgICBjYXNlIEJTTGVmdDoKICAgICAgICAgICAgICAgICAg ICAgICAgIGRyYXdMaW5lRm9yQm94U2lkZShncmFwaGljc0NvbnRleHQsIHgxLCB5MSArIG1heCgo LWFkamFjZW50V2lkdGgxICogMiArIDEpIC8gMywgMCksCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHgxICsgdGhpcmQsIHkyIC0gbWF4KCgtYWRqYWNlbnRXaWR0aDIgKiAyICsg MSkgLyAzLCAwKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgeDEgKyB0aGly ZE9mVGhpY2tuZXNzLCB5MiAtIG1heCgoLWFkamFjZW50V2lkdGgyICogMiArIDEpIC8gMywgMCks CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNpZGUsIGNvbG9yLCBTT0xJRCwg YWRqYWNlbnQxQmlnVGhpcmQsIGFkamFjZW50MkJpZ1RoaXJkLCBhbnRpYWxpYXMpOwotICAgICAg ICAgICAgICAgICAgICAgICAgZHJhd0xpbmVGb3JCb3hTaWRlKGdyYXBoaWNzQ29udGV4dCwgeDIg LSB0aGlyZCwgeTEgKyBtYXgoKGFkamFjZW50V2lkdGgxICogMiArIDEpIC8gMywgMCksCisgICAg ICAgICAgICAgICAgICAgICAgICBkcmF3TGluZUZvckJveFNpZGUoZ3JhcGhpY3NDb250ZXh0LCB4 MiAtIHRoaXJkT2ZUaGlja25lc3MsIHkxICsgbWF4KChhZGphY2VudFdpZHRoMSAqIDIgKyAxKSAv IDMsIDApLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB4MiwgeTIgLSBtYXgo KGFkamFjZW50V2lkdGgyICogMiArIDEpIC8gMywgMCksCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHNpZGUsIGNvbG9yLCBTT0xJRCwgYWRqYWNlbnQxQmlnVGhpcmQsIGFkamFj ZW50MkJpZ1RoaXJkLCBhbnRpYWxpYXMpOwogICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgICAgICAgICAgICAgIGNhc2UgQlNCb3R0b206CiAgICAgICAgICAgICAgICAgICAg ICAgICBkcmF3TGluZUZvckJveFNpZGUoZ3JhcGhpY3NDb250ZXh0LCB4MSArIG1heCgoYWRqYWNl bnRXaWR0aDEgKiAyICsgMSkgLyAzLCAwKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgeTEsIHgyIC0gbWF4KChhZGphY2VudFdpZHRoMiAqIDIgKyAxKSAvIDMsIDApLCB5MSAr IHRoaXJkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB5MSwgeDIgLSBtYXgo KGFkamFjZW50V2lkdGgyICogMiArIDEpIC8gMywgMCksIHkxICsgdGhpcmRPZlRoaWNrbmVzcywK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2lkZSwgY29sb3IsIFNPTElELCBh ZGphY2VudDFCaWdUaGlyZCwgYWRqYWNlbnQyQmlnVGhpcmQsIGFudGlhbGlhcyk7CiAgICAgICAg ICAgICAgICAgICAgICAgICBkcmF3TGluZUZvckJveFNpZGUoZ3JhcGhpY3NDb250ZXh0LCB4MSAr IG1heCgoLWFkamFjZW50V2lkdGgxICogMiArIDEpIC8gMywgMCksCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHkyIC0gdGhpcmQsIHgyIC0gbWF4KCgtYWRqYWNlbnRXaWR0aDIg KiAyICsgMSkgLyAzLCAwKSwgeTIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHkyIC0gdGhpcmRPZlRoaWNrbmVzcywgeDIgLSBtYXgoKC1hZGphY2VudFdpZHRoMiAqIDIgKyAx KSAvIDMsIDApLCB5MiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2lkZSwg Y29sb3IsIFNPTElELCBhZGphY2VudDFCaWdUaGlyZCwgYWRqYWNlbnQyQmlnVGhpcmQsIGFudGlh bGlhcyk7CiAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICAg ICAgY2FzZSBCU1JpZ2h0OgogICAgICAgICAgICAgICAgICAgICAgICAgZHJhd0xpbmVGb3JCb3hT aWRlKGdyYXBoaWNzQ29udGV4dCwgeDEsIHkxICsgbWF4KChhZGphY2VudFdpZHRoMSAqIDIgKyAx KSAvIDMsIDApLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB4MSArIHRoaXJk LCB5MiAtIG1heCgoYWRqYWNlbnRXaWR0aDIgKiAyICsgMSkgLyAzLCAwKSwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgeDEgKyB0aGlyZE9mVGhpY2tuZXNzLCB5MiAtIG1heCgo YWRqYWNlbnRXaWR0aDIgKiAyICsgMSkgLyAzLCAwKSwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgc2lkZSwgY29sb3IsIFNPTElELCBhZGphY2VudDFCaWdUaGlyZCwgYWRqYWNl bnQyQmlnVGhpcmQsIGFudGlhbGlhcyk7Ci0gICAgICAgICAgICAgICAgICAgICAgICBkcmF3TGlu ZUZvckJveFNpZGUoZ3JhcGhpY3NDb250ZXh0LCB4MiAtIHRoaXJkLCB5MSArIG1heCgoLWFkamFj ZW50V2lkdGgxICogMiArIDEpIC8gMywgMCksCisgICAgICAgICAgICAgICAgICAgICAgICBkcmF3 TGluZUZvckJveFNpZGUoZ3JhcGhpY3NDb250ZXh0LCB4MiAtIHRoaXJkT2ZUaGlja25lc3MsIHkx ICsgbWF4KCgtYWRqYWNlbnRXaWR0aDEgKiAyICsgMSkgLyAzLCAwKSwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgeDIsIHkyIC0gbWF4KCgtYWRqYWNlbnRXaWR0aDIgKiAyICsg MSkgLyAzLCAwKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2lkZSwgY29s b3IsIFNPTElELCBhZGphY2VudDFCaWdUaGlyZCwgYWRqYWNlbnQyQmlnVGhpcmQsIGFudGlhbGlh cyk7CiAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwNGEyMzkxNDA2YTll YTQwYmU2N2Q5NzdiODM3MmEwMTliNTZmMDM3Li4xZTlhNGM0OWYwNjNlNjY5ZTRhMDdiNTFkMGQ3 NDEzYTUxNjgzODI5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDctMjcgIEp1bGllbiBD aGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgQVNTRVJUSU9OIEZB SUxFRDogIXJlY3QuaXNFbXB0eSgpICA6IHZvaWQgV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0Ojpk cmF3UmVjdChjb25zdCBXZWJDb3JlOjpJbnRSZWN0ICYpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjE4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9ib3JkZXJzLzBweC1ib3JkZXJzLW5vLWxp bmUtaGVpZ2h0LWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvYm9yZGVycy8w cHgtYm9yZGVycy1uby1saW5lLWhlaWdodC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Jv cmRlcnMvZG91YmxlLTFweC1ib3JkZXItYXNzZXJ0LWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvYm9yZGVycy9kb3VibGUtMXB4LWJvcmRlci1hc3NlcnQuaHRtbDogQWRkZWQu CisKIDIwMTItMDctMjcgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAg ICBIaXQgdGVzdGluZyBuZWFyIGEgY29sdW1uIGJyZWFrIGNhbiByZXR1cm4gYSByZXN1bHQgZnJv bSBhbiBhZGphY2VudCBjb2x1bW4gd2hlbiB0aGVyZSBpcyBsZWFkaW5nCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2JvcmRlcnMvMHB4LWJvcmRlcnMtbm8tbGluZS1oZWlnaHQtZXhwZWN0 ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvYm9yZGVycy8wcHgtYm9yZGVycy1uby1saW5lLWhl aWdodC1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNzU1CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjZjYmQ4NjQyNmJmNWQzOTdjOWJmZDMyYzQz OWM2MmY4Y2Q2YmE5NDUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2JvcmRl cnMvMHB4LWJvcmRlcnMtbm8tbGluZS1oZWlnaHQtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDE3 IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+CisuYm9yZGVyIHsK KyAgICBib3JkZXItcmlnaHQ6IDFweCBzb2xpZCBibGFjazsKKyAgICBib3JkZXItbGVmdDogMXB4 IHNvbGlkIGJsYWNrOworICAgIGxpbmUtaGVpZ2h0OiAwOworfQorPC9zdHlsZT4KKzwvaGVhZD4K Kzxib2R5PgorPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTkyMTg3Ij45MjE4NzwvYT46IEFTU0VSVElPTiBGQUlMRUQ6ICFyZWN0Lmlz RW1wdHkoKSAgOiB2b2lkIFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6ZHJhd1JlY3QoY29uc3Qg V2ViQ29yZTo6SW50UmVjdCAmKTwvcD4KKzxwPlRoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lc24n dCBBU1NFUlQuPC9wPgorPGRpdiBjbGFzcz0iYm9yZGVyIj4mbnNicDs8L2Rpdj4KKzwvYm9keT4K KzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvYm9yZGVycy8wcHgtYm9yZGVy cy1uby1saW5lLWhlaWdodC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ib3JkZXJzLzBweC1ib3Jk ZXJzLW5vLWxpbmUtaGVpZ2h0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA3NTUKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjZkYWQ0MTQzY2NmNDY0MmYwOTAz NmQyNGI3MGNhNWU5ODQ0ZmM4NQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv Ym9yZGVycy8wcHgtYm9yZGVycy1uby1saW5lLWhlaWdodC5odG1sCkBAIC0wLDAgKzEsMTcgQEAK KzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzdHlsZT4KKy5ib3JkZXIgeworICAg IGJvcmRlci1zdHlsZTogc29saWQ7CisgICAgYm9yZGVyLXdpZHRoOiAwIDFweCAwIDFweDsKKyAg ICBsaW5lLWhlaWdodDogMDsKK30KKzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPlRlc3Qg Zm9yIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjE4 NyI+OTIxODc8L2E+OiBBU1NFUlRJT04gRkFJTEVEOiAhcmVjdC5pc0VtcHR5KCkgIDogdm9pZCBX ZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmRyYXdSZWN0KGNvbnN0IFdlYkNvcmU6OkludFJlY3Qg Jik8L3A+Cis8cD5UaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXNuJ3QgQVNTRVJULjwvcD4KKzxk aXYgY2xhc3M9ImJvcmRlciI+Jm5zYnA7PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2JvcmRlcnMvZG91YmxlLTFweC1ib3JkZXItYXNzZXJ0LWV4 cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2JvcmRlcnMvZG91YmxlLTFweC1ib3JkZXIt YXNzZXJ0LWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTJmNWE3YWEyMmU0MzllNWVlZDZiYTdm MDQyOGFkNzM2NTJjZTI1NwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvYm9y ZGVycy9kb3VibGUtMXB4LWJvcmRlci1hc3NlcnQtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDE2 IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c3R5bGU+CisudGVzdCB7Cisg ICAgd2lkdGg6IDFweDsKKyAgICBoZWlnaHQ6IDFweDsKKyAgICBib3JkZXItc3R5bGU6IGRvdWJs ZTsKKyAgICBib3JkZXItd2lkdGg6IDBweCAzcHggMHB4IDNweDsKK30KKzwvc3R5bGU+Cis8cD5U ZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTIxODciPjkyMTg3PC9hPjogQVNTRVJUSU9OIEZBSUxFRDogIXJlY3QuaXNFbXB0eSgpICA6IHZv aWQgV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpkcmF3UmVjdChjb25zdCBXZWJDb3JlOjpJbnRS ZWN0ICYpPC9wPgorPHA+VGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vzbid0IEFTU0VSVC48L3A+ Cis8ZGl2IGNsYXNzPSJ0ZXN0Ij4mbmJzcDs8L2Rpdj4KKzwvaHRtbD4KKzwvYm9keT4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvYm9yZGVycy9kb3VibGUtMXB4LWJvcmRlci1hc3NlcnQu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvYm9yZGVycy9kb3VibGUtMXB4LWJvcmRlci1hc3NlcnQu aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi45MmY1YTdhYTIyZTQzOWU1ZWVkNmJhN2YwNDI4YWQ3MzY1MmNlMjU3 Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ib3JkZXJzL2RvdWJsZS0xcHgt Ym9yZGVyLWFzc2VydC5odG1sCkBAIC0wLDAgKzEsMTYgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0 bWw+Cis8Ym9keT4KKzxzdHlsZT4KKy50ZXN0IHsKKyAgICB3aWR0aDogMXB4OworICAgIGhlaWdo dDogMXB4OworICAgIGJvcmRlci1zdHlsZTogZG91YmxlOworICAgIGJvcmRlci13aWR0aDogMHB4 IDNweCAwcHggM3B4OworfQorPC9zdHlsZT4KKzxwPlRlc3QgZm9yIDxhIGhyZWY9Imh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjE4NyI+OTIxODc8L2E+OiBBU1NFUlRJ T04gRkFJTEVEOiAhcmVjdC5pc0VtcHR5KCkgIDogdm9pZCBXZWJDb3JlOjpHcmFwaGljc0NvbnRl eHQ6OmRyYXdSZWN0KGNvbnN0IFdlYkNvcmU6OkludFJlY3QgJik8L3A+Cis8cD5UaGlzIHRlc3Qg cGFzc2VzIGlmIGl0IGRvZXNuJ3QgQVNTRVJULjwvcD4KKzxkaXYgY2xhc3M9InRlc3QiPiZuYnNw OzwvZGl2PgorPC9odG1sPgorPC9ib2R5Pgo=