92159 2012-07-24 13:47:37 -0700 [Qt][WK2] Disable CopyToTexture for GraphicsSurfaceMac. 2012-07-25 01:36:23 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno zeno jturcotte noam oldest_to_newest 677180 0 zeno 2012-07-24 13:47:37 -0700 Disable CopyToTexture feature for GraphicsSurface on Mac. While this is actually working, it is currently used for Tiles that are single buffered, and therefore requires a call to glFlush. This call blocks the GPU for about 40ms which would make smooth animations impossible. 677185 1 154136 zeno 2012-07-24 13:52:51 -0700 Created attachment 154136 patch for review. 677788 2 154136 zeno 2012-07-25 01:36:17 -0700 Comment on attachment 154136 patch for review. Clearing flags on attachment: 154136 Committed r123588: <http://trac.webkit.org/changeset/123588> 677789 3 zeno 2012-07-25 01:36:23 -0700 All reviewed patches have been landed. Closing bug. 154136 2012-07-24 13:52:51 -0700 2012-07-25 01:36:17 -0700 patch for review. 92159_20120724-225144.patch text/plain 2818 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlMTA2MGE3Li4wY2MzMWZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDctMjQgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW1F0XVtXSzJdIERpc2FibGUgQ29weVRvVGV4dHVyZSBmb3IgR3JhcGhpY3NTdXJmYWNlTWFj LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIxNTkK KworICAgICAgICBEaXNhYmxlIENvcHlUb1RleHR1cmUgZmVhdHVyZSBmb3IgR3JhcGhpY3NTdXJm YWNlIG9uIE1hYy4KKyAgICAgICAgV2hpbGUgdGhpcyBpcyBhY3R1YWxseSB3b3JraW5nLCBpdCBp cyBjdXJyZW50bHkgdXNlZCBmb3IgVGlsZXMKKyAgICAgICAgdGhhdCBhcmUgc2luZ2xlIGJ1ZmZl cmVkLCBhbmQgdGhlcmVmb3JlIHJlcXVpcmVzIGEgY2FsbCB0byBnbEZsdXNoLgorICAgICAgICBU aGlzIGNhbGwgYmxvY2tzIHRoZSBHUFUgZm9yIGFib3V0IDQwbXMgd2hpY2ggd291bGQgbWFrZSBz bW9vdGggYW5pbWF0aW9ucyBpbXBvc3NpYmxlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvbWFjL0dy YXBoaWNzU3VyZmFjZU1hYy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc1N1cmZhY2U6 OnBsYXRmb3JtQ3JlYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzU3VyZmFjZTo6cGxh dGZvcm1JbXBvcnQpOgorCiAyMDEyLTA3LTI0ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBbVjhdIFN0cmluZyB3cmFwcGVycyBzaG91bGQgYmUgbWFya2Vk IEluZGVwZW5kZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9zdXJmYWNlcy9tYWMvR3JhcGhpY3NTdXJmYWNlTWFjLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL21hYy9HcmFwaGljc1N1cmZhY2VNYWMuY3BwCmluZGV4 IDcxMzFiODIuLjU0NGU5NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3N1cmZhY2VzL21hYy9HcmFwaGljc1N1cmZhY2VNYWMuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL21hYy9HcmFwaGljc1N1cmZhY2VNYWMu Y3BwCkBAIC0xMjIsNiArMTIyLDEyIEBAIHZvaWQgR3JhcGhpY3NTdXJmYWNlOjpwbGF0Zm9ybUNv cHlGcm9tRnJhbWVidWZmZXIodWludDMyX3Qgb3JpZ2luRmJvLCBjb25zdCBJbnRSCiAKIFBhc3NS ZWZQdHI8R3JhcGhpY3NTdXJmYWNlPiBHcmFwaGljc1N1cmZhY2U6OnBsYXRmb3JtQ3JlYXRlKGNv bnN0IEludFNpemUmIHNpemUsIEZsYWdzIGZsYWdzKQogeworICAgIC8vIFdlIGN1cnJlbnRseSBk aXNhYmxlIHN1cHBvcnQgZm9yIENvcHlUb1RleHR1cmUgb24gTWFjLCBiZWNhdXNlIHRoaXMgaXMg dXNlZCBmb3Igc2luZ2xlIGJ1ZmZlcmVkIFRpbGVzLgorICAgIC8vIFRoZSBzaW5nbGUgYnVmZmVy ZWQgbmF0dXJlIG9mIHRoaXMgcmVxdWlyZXMgYSBjYWxsIHRvIGdsRmx1c2gsIGFzIGRlc2NyaWJl ZCBpbiBwbGF0Zm9ybUNvcHlUb1RleHR1cmUuCisgICAgLy8gVGhpcyBjYWxsIGJsb2NrcyB0aGUg R1BVIGZvciBhYm91dCA0MG1zLCB3aGljaCBtYWtlcyBzbW9vdGggYW5pbWF0aW9ucyBpbXBvc3Np YmxlLgorICAgIGlmIChmbGFncyAmIFN1cHBvcnRzQ29weVRvVGV4dHVyZSkKKyAgICAgICAgcmV0 dXJuIFBhc3NSZWZQdHI8R3JhcGhpY3NTdXJmYWNlPigpOworCiAgICAgdW5zaWduZWQgcGl4ZWxG b3JtYXQgPSAnQkdSQSc7CiAgICAgdW5zaWduZWQgYnl0ZXNQZXJFbGVtZW50ID0gNDsKICAgICBp bnQgd2lkdGggPSBzaXplLndpZHRoKCk7CkBAIC0xNjUsNiArMTcxLDEyIEBAIFBhc3NSZWZQdHI8 R3JhcGhpY3NTdXJmYWNlPiBHcmFwaGljc1N1cmZhY2U6OnBsYXRmb3JtQ3JlYXRlKGNvbnN0IElu dFNpemUmIHNpemUsCiAKIFBhc3NSZWZQdHI8R3JhcGhpY3NTdXJmYWNlPiBHcmFwaGljc1N1cmZh Y2U6OnBsYXRmb3JtSW1wb3J0KGNvbnN0IEludFNpemUmIHNpemUsIEZsYWdzIGZsYWdzLCB1aW50 MzJfdCB0b2tlbikKIHsKKyAgICAvLyBXZSBjdXJyZW50bHkgZGlzYWJsZSBzdXBwb3J0IGZvciBD b3B5VG9UZXh0dXJlIG9uIE1hYywgYmVjYXVzZSB0aGlzIGlzIHVzZWQgZm9yIHNpbmdsZSBidWZm ZXJlZCBUaWxlcy4KKyAgICAvLyBUaGUgc2luZ2xlIGJ1ZmZlcmVkIG5hdHVyZSBvZiB0aGlzIHJl cXVpcmVzIGEgY2FsbCB0byBnbEZsdXNoLCBhcyBkZXNjcmliZWQgaW4gcGxhdGZvcm1Db3B5VG9U ZXh0dXJlLgorICAgIC8vIFRoaXMgY2FsbCBibG9ja3MgdGhlIEdQVSBmb3IgYWJvdXQgNDBtcywg d2hpY2ggbWFrZXMgc21vb3RoIGFuaW1hdGlvbnMgaW1wb3NzaWJsZS4KKyAgICBpZiAoZmxhZ3Mg JiBTdXBwb3J0c0NvcHlUb1RleHR1cmUpCisgICAgICAgIHJldHVybiBQYXNzUmVmUHRyPEdyYXBo aWNzU3VyZmFjZT4oKTsKKwogICAgIFJlZlB0cjxHcmFwaGljc1N1cmZhY2U+IHN1cmZhY2UgPSBh ZG9wdFJlZihuZXcgR3JhcGhpY3NTdXJmYWNlKHNpemUsIGZsYWdzKSk7CiAgICAgc3VyZmFjZS0+ bV9wbGF0Zm9ybVN1cmZhY2UgPSBJT1N1cmZhY2VMb29rdXAodG9rZW4pOwogICAgIGlmICghc3Vy ZmFjZS0+bV9wbGF0Zm9ybVN1cmZhY2UpCg==