92157 2012-07-24 13:42:13 -0700 [BlackBerry] Do not call settings setters twice on page construction 2013-01-04 08:51:26 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rwlbuis rwlbuis mifenton tonikitoo webkit.review.bot oldest_to_newest 677174 0 rwlbuis 2012-07-24 13:42:13 -0700 The WebPagePrivate init method sets some settings value that were already set in didChangeSettings, do that only once per page construction. 677182 1 154135 rwlbuis 2012-07-24 13:50:21 -0700 Created attachment 154135 Patch 800225 2 rwlbuis 2013-01-04 08:51:26 -0800 This landed in r123526, closing. 154135 2012-07-24 13:50:21 -0700 2012-07-24 13:59:34 -0700 Patch bug-92157-20120724165213.patch text/plain 3489 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA2ZDM0MGQ4ZTJmYzE4N2YzNGY5MTc5YzQwYWMxNDIyOGQ4MDBkMGZiLi45MTU0OGU3M2Nj YzNhN2U3MjcxNGRmN2Y1MTJkNTI1NTJlYTk3ZGQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0wNy0yNCAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBEbyBub3QgY2FsbCBzZXR0aW5ncyBzZXR0ZXJz IHR3aWNlIG9uIHBhZ2UgY29uc3RydWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05MjE1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBXZWJQYWdlUHJpdmF0ZSBpbml0IG1ldGhvZCBzZXRzIHNv bWUgc2V0dGluZ3MgdmFsdWUgdGhhdCB3ZXJlCisgICAgICAgIGFscmVhZHkgc2V0IGluIGRpZENo YW5nZVNldHRpbmdzLiBzZXRVc2VIaXhpZTc2V2ViU29ja2V0UHJvdG9jb2wganVzdAorICAgICAg ICBzZXRzIHRoZSBkZWZhdWx0IHZhbHVlLCBubyBuZWVkIHRvIHNldCBpdCBhZ2Fpbi4KKyAgICAg ICAgQWxzbyBjYWxsIGRpZENoYW5nZVNldHRpbmdzIGV4cGxpY2l0bHkgZnJvbSBpbml0LCBiZWZv cmUgdGhhdCB3ZSBhcmUKKyAgICAgICAgbm90IGNhbGxpbmcgaXQgc2luY2UgdGhlIGRlbGVnYXRl IGlzIG5vdCBzZXQgeWV0LgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAo QmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6aW5pdCk6CisKIDIwMTItMDctMjIg IEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbmFtZSBFTkFC TEVfTUVURVJfVEFHIGFuZCBFTkFCTEVfUFJPR1JFU1NfVEFHIHRvIEVOQUJMRV9NRVRFUl9FTEVN RU5UIGFuZCBFTkFCTEVfUFJPR1JFU1NfRUxFTUVOVCByZXNwZWN0aXZlbHkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IGI1Njg2NzA3ZjE3NGYwNDhiZDg1NThi NGYyYmI3YTZhNzNiMGViN2MuLmRiMDUwNmI2NDBjMmQ4NTJjMjBjNDU4NTBkNzBmZmFjYzExODE3 ZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAK KysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNTUxLDgg KzU1MSw5IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6OmluaXQoY29uc3QgV2ViU3RyaW5nJiBwYWdl R3JvdXBOYW1lKQogICAgIC8vIHNvIHRoYXQgd2Ugb25seSBnZXQgb25lIGRpZENoYW5nZVNldHRp bmdzKCkgY2FsbGJhY2sgd2hlbiB3ZSBzZXQgdGhlIHBhZ2UgZ3JvdXAgbmFtZS4gVGhpcyBjYXVz ZXMgdXMKICAgICAvLyB0byBtYWtlIGEgY29weSBvZiB0aGUgV2ViU2V0dGluZ3Mgc2luY2Ugc29t ZSBXZWJTZXR0aW5ncyBtZXRob2QgbWFrZSB1c2Ugb2YgdGhlIHBhZ2UgZ3JvdXAgbmFtZS4KICAg ICAvLyBJbnN0ZWFkLCB3ZSBzaG91bGRuJ3QgYmUgc3RvcmluZyB0aGUgcGFnZSBncm91cCBuYW1l IGluIFdlYlNldHRpbmdzLgotICAgIG1fd2ViU2V0dGluZ3MtPnNldERlbGVnYXRlKHRoaXMpOwog ICAgIG1fd2ViU2V0dGluZ3MtPnNldFBhZ2VHcm91cE5hbWUocGFnZUdyb3VwTmFtZSk7CisgICAg bV93ZWJTZXR0aW5ncy0+c2V0RGVsZWdhdGUodGhpcyk7CisgICAgZGlkQ2hhbmdlU2V0dGluZ3Mo bV93ZWJTZXR0aW5ncyk7CiAKICAgICBSZWZQdHI8RnJhbWU+IG5ld0ZyYW1lID0gRnJhbWU6OmNy ZWF0ZShtX3BhZ2UsIC8qIEhUTUxGcmFtZU93bmVyRWxlbWVudCogKi8gMCwgZnJhbWVMb2FkZXJD bGllbnQpOwogCkBAIC01NjgsMjIgKzU2OSwxNiBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjppbml0 KGNvbnN0IFdlYlN0cmluZyYgcGFnZUdyb3VwTmFtZSkKICAgICBtX3BhZ2UtPnNldHRpbmdzKCkt PnNldENhbnZhc1VzZXNBY2NlbGVyYXRlZERyYXdpbmcodHJ1ZSk7CiAgICAgbV9wYWdlLT5zZXR0 aW5ncygpLT5zZXRBY2NlbGVyYXRlZDJkQ2FudmFzRW5hYmxlZCh0cnVlKTsKICNlbmRpZgotI2lm IEVOQUJMRShWSUVXUE9SVF9SRUZMT1cpCi0gICAgbV9wYWdlLT5zZXR0aW5ncygpLT5zZXRUZXh0 UmVmbG93RW5hYmxlZChtX3dlYlNldHRpbmdzLT50ZXh0UmVmbG93TW9kZSgpID09IFdlYlNldHRp bmdzOjpUZXh0UmVmbG93RW5hYmxlZCk7Ci0jZW5kaWYKIAogICAgIG1fcGFnZS0+c2V0dGluZ3Mo KS0+c2V0SW50ZXJhY3RpdmVGb3JtVmFsaWRhdGlvbkVuYWJsZWQodHJ1ZSk7CiAgICAgbV9wYWdl LT5zZXR0aW5ncygpLT5zZXRBbGxvd1VuaXZlcnNhbEFjY2Vzc0Zyb21GaWxlVVJMcyhmYWxzZSk7 CiAgICAgbV9wYWdlLT5zZXR0aW5ncygpLT5zZXRBbGxvd0ZpbGVBY2Nlc3NGcm9tRmlsZVVSTHMo ZmFsc2UpOwotICAgIG1fcGFnZS0+c2V0dGluZ3MoKS0+c2V0U2hvdWxkVXNlQ3Jvc3NPcmlnaW5Q cm90b2NvbENoZWNrKCFtX3dlYlNldHRpbmdzLT5hbGxvd0Nyb3NzU2l0ZVJlcXVlc3RzKCkpOwot ICAgIG1fcGFnZS0+c2V0dGluZ3MoKS0+c2V0V2ViU2VjdXJpdHlFbmFibGVkKCFtX3dlYlNldHRp bmdzLT5hbGxvd0Nyb3NzU2l0ZVJlcXVlc3RzKCkpOwogCiAgICAgbV9iYWNraW5nU3RvcmVDbGll bnQgPSBCYWNraW5nU3RvcmVDbGllbnQ6OmNyZWF0ZShtX21haW5GcmFtZSwgLyogcGFyZW50IGZy YW1lICovIDAsIG1fd2ViUGFnZSk7CiAgICAgLy8gVGhlIGRpcmVjdCBhY2Nlc3MgdG8gQmFja2lu Z1N0b3JlIGlzIGxlZnQgaGVyZSBmb3IgY29udmVuaWVuY2Ugc2luY2UgaXQKICAgICAvLyBpcyBv d25lZCBieSBCYWNraW5nU3RvcmVDbGllbnQgYW5kIHRoZW4gZGVsZXRlZCBieSBpdHMgZGVzdHJ1 Y3Rvci4KICAgICBtX2JhY2tpbmdTdG9yZSA9IG1fYmFja2luZ1N0b3JlQ2xpZW50LT5iYWNraW5n U3RvcmUoKTsKIAotICAgIG1fcGFnZS0+c2V0dGluZ3MoKS0+c2V0U3BhdGlhbE5hdmlnYXRpb25F bmFibGVkKG1fd2ViU2V0dGluZ3MtPmlzU3BhdGlhbE5hdmlnYXRpb25FbmFibGVkKCkpOwogICAg IGJsb2NrQ2xpY2tSYWRpdXMgPSBpbnQocm91bmRmKDAuMzUgKiBQbGF0Zm9ybTo6R3JhcGhpY3M6 OlNjcmVlbjo6cHJpbWFyeVNjcmVlbigpLT5waXhlbHNQZXJJbmNoKDApLndpZHRoKCkpKTsgLy8g VGhlIGNsaWNrZWQgcmVjdGFuZ2xlIGFyZWEgc2hvdWxkIGJlIGEgZml4ZWQgdW5pdCBvZiBtZWFz dXJlbWVudC4KIAogICAgIG1fcGFnZS0+c2V0dGluZ3MoKS0+c2V0RGVsZWdhdGVTZWxlY3Rpb25Q YWludCh0cnVlKTsK