92153 2012-07-24 13:30:03 -0700 [BlackBerry] notifyContentRendered() call missing in two spots 2012-07-25 06:19:11 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jpetsovits jpetsovits anilsson manyoso mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 677159 0 jpetsovits 2012-07-24 13:30:03 -0700 From (the initial version of) the commit message: """ In dispatchDidFirstVisualLayout() and repaint() in immediate mode, we render but don't notify the WebPageClient that the content was modified. In the long run, we should probably keep track of the modified reason from within render() itself and use this to automatically notify the client from within blitContents() and/or invalidateWindow(), depending on the rendering path. That's somewhat of a medium-size undertaking though; for now, adding the call directly to the renderVisibleContents() call sites will do. """ Adam Treat suggested I move the notification to renderVisibleContents(). I thought about it, and I think it's a good idea but will require a more general solution as mentioned above. As I'll be occupied with other bug reports for a while, I think it's a good idea to get this fix right now, it fixes a real issue and doesn't introduce any hacks or whatnot. We can and should still do some refactoring, but I think it makes sense to go with the straightforward approach for now. Patch below. The related internal bug is RIM PR 173340. 677217 1 154144 jpetsovits 2012-07-24 14:39:30 -0700 Created attachment 154144 Patch, straightforward version Couldn't get webkit-patch to upload it for me this time, so uploading the output of git show instead which is of course also a patch. 677809 2 anilsson 2012-07-25 02:07:04 -0700 I can be internal reviewer for this, it looks good to me. 677969 3 154144 tonikitoo 2012-07-25 06:03:39 -0700 Comment on attachment 154144 Patch, straightforward version I found it fragile to have to add notifyContentRendered calls in so many places. It is easy to miss one in the future. Lets go with adam's suggestion in the future please. 677978 4 154144 webkit.review.bot 2012-07-25 06:19:07 -0700 Comment on attachment 154144 Patch, straightforward version Clearing flags on attachment: 154144 Committed r123610: <http://trac.webkit.org/changeset/123610> 677979 5 webkit.review.bot 2012-07-25 06:19:11 -0700 All reviewed patches have been landed. Closing bug. 154144 2012-07-24 14:39:30 -0700 2012-07-25 06:19:07 -0700 Patch, straightforward version webkit-more-notifycontentrendered.diff text/plain 6946 jpetsovits Y29tbWl0IGY1ODdhODJkMzU0Mjk5MTAzMTg5N2NiMjU1MjYwNmJkNWI3NjIzZWIKQXV0aG9yOiBK YWtvYiBQZXRzb3ZpdHMgPGpwZXRzb3ZpdHNAcmltLmNvbT4KRGF0ZTogICBUdWUgSnVsIDI0IDE2 OjA4OjEyIDIwMTIgLTA0MDAKCiAgICAyMDEyLTA3LTI0ICBKYWtvYiBQZXRzb3ZpdHMgIDxqcGV0 c292aXRzQHJpbS5jb20+CiAgICAKICAgICAgICAgICAgQ2FsbCBub3RpZnlDb250ZW50UmVuZGVy ZWQoKSBmcm9tIHR3byBwbGFjZXMgd2hlcmUgaXQgd2FzIG1pc3NpbmcKICAgICAgICAgICAgUFIg MTczMzQwCiAgICAKICAgICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAgICAK ICAgICAgICAgICAgSW4gZGlzcGF0Y2hEaWRGaXJzdFZpc3VhbExheW91dCgpIGFuZCByZXBhaW50 KCkgaW4KICAgICAgICAgICAgaW1tZWRpYXRlIG1vZGUsIHdlIHJlbmRlciBidXQgZG9uJ3Qgbm90 aWZ5IHRoZQogICAgICAgICAgICBXZWJQYWdlQ2xpZW50IHRoYXQgdGhlIGNvbnRlbnQgd2FzIG1v ZGlmaWVkLgogICAgCiAgICAgICAgICAgIEluIHRoZSBsb25nIHJ1biwgd2Ugc2hvdWxkIHByb2Jh Ymx5IGtlZXAgdHJhY2sgb2YKICAgICAgICAgICAgdGhlIG1vZGlmaWVkIHJlYXNvbiBmcm9tIHdp dGhpbiByZW5kZXIoKSBpdHNlbGYKICAgICAgICAgICAgYW5kIHVzZSB0aGlzIHRvIGF1dG9tYXRp Y2FsbHkgbm90aWZ5IHRoZSBjbGllbnQKICAgICAgICAgICAgZnJvbSB3aXRoaW4gYmxpdENvbnRl bnRzKCkgYW5kL29yIGludmFsaWRhdGVXaW5kb3coKSwKICAgICAgICAgICAgZGVwZW5kaW5nIG9u IHRoZSByZW5kZXJpbmcgcGF0aC4gVGhhdCdzIHNvbWV3aGF0IG9mCiAgICAgICAgICAgIGEgbWVk aXVtLXNpemUgdW5kZXJ0YWtpbmcgdGhvdWdoOyBmb3Igbm93LCBhZGRpbmcKICAgICAgICAgICAg dGhlIGNhbGwgZGlyZWN0bHkgdG8gdGhlIHJlbmRlclZpc2libGVDb250ZW50cygpCiAgICAgICAg ICAgIGNhbGwgc2l0ZXMgd2lsbCBkby4KICAgIAogICAgICAgICAgICBUaGlzIHBhdGNoIGFsc28g YWRkcyBhIGJsaXRWaXNpYmxlQ29udGVudHMoKSB0bwogICAgICAgICAgICBkaXNwYXRjaERpZEZp cnN0VmlzdWFsTGF5b3V0KCkgd2hlcmUgaXQgd2FzCiAgICAgICAgICAgIGluZXhwbGljYWJseSBt aXNzaW5nLCBwcm9iYWJseSBvbiBhY2NvdW50IG9mCiAgICAgICAgICAgIG9sZCBjb2RlIHRoYXQg d2FzIG5ldmVyIHVwZGF0ZWQuCiAgICAKICAgICAgICAgICAgKiBBcGkvQmFja2luZ1N0b3JlLmNw cDoKICAgICAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6QmFja2luZ1N0b3JlUHJpdmF0ZTo6 cmVwYWludCk6CiAgICAgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgogICAgICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6cmVzdW1lQmFja2luZ1N0b3JlKToKICAg ICAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3Bw OgogICAgICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpkaXNw YXRjaERpZEZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dCk6CgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwCmluZGV4IDIzMjU4YTYuLmMxNTM2YTUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAKQEAgLTM5 OSw4ICszOTksMTEgQEAgdm9pZCBCYWNraW5nU3RvcmVQcml2YXRlOjpyZXBhaW50KGNvbnN0IFBs YXRmb3JtOjpJbnRSZWN0JiB3aW5kb3dSZWN0LAogI2VuZGlmCiAKICAgICAgICAgaWYgKGltbWVk aWF0ZSkgewotICAgICAgICAgICAgaWYgKHJlbmRlcihyZWN0KSAmJiAhc2hvdWxkRGlyZWN0UmVu ZGVyaW5nVG9XaW5kb3coKSkKLSAgICAgICAgICAgICAgICBibGl0VmlzaWJsZUNvbnRlbnRzKCk7 CisgICAgICAgICAgICBpZiAocmVuZGVyKHJlY3QpKSB7CisgICAgICAgICAgICAgICAgaWYgKCFz aG91bGREaXJlY3RSZW5kZXJpbmdUb1dpbmRvdygpKQorICAgICAgICAgICAgICAgICAgICBibGl0 VmlzaWJsZUNvbnRlbnRzKCk7CisgICAgICAgICAgICAgICAgbV93ZWJQYWdlLT5kLT5tX2NsaWVu dC0+bm90aWZ5Q29udGVudFJlbmRlcmVkKHJlY3QpOworICAgICAgICAgICAgfQogICAgICAgICB9 IGVsc2UKICAgICAgICAgICAgIG1fcmVuZGVyUXVldWUtPmFkZFRvUXVldWUoUmVuZGVyUXVldWU6 OlJlZ3VsYXJSZW5kZXIsIHJlY3QpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBp L1dlYlBhZ2UuY3BwCmluZGV4IGYyMjVmMWIuLjFiMzQ2ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtMzY2MiwxMiArMzY2MiwxNCBAQCB2b2lkIFdlYlBh Z2VQcml2YXRlOjpyZXN1bWVCYWNraW5nU3RvcmUoKQogICAgICAgICBtX2JhY2tpbmdTdG9yZS0+ ZC0+b3JpZW50YXRpb25DaGFuZ2VkKCk7IC8vIFVwZGF0ZXMgdGlsZSBnZW9tZXRyeSBhbmQgY3Jl YXRlcyB2aXNpYmxlIHRpbGUgYnVmZmVyLgogICAgICAgICBtX2JhY2tpbmdTdG9yZS0+ZC0+cmVz ZXRUaWxlcyh0cnVlIC8qIHJlc2V0QmFja2dyb3VuZCAqLyk7CiAgICAgICAgIG1fYmFja2luZ1N0 b3JlLT5kLT51cGRhdGVUaWxlcyhmYWxzZSAvKiB1cGRhdGVWaXNpYmxlICovLCBmYWxzZSAvKiBp bW1lZGlhdGUgKi8pOworCiAgICAgICAgIC8vIFRoaXMgdmFsdWUgbWF5IGhhdmUgY2hhbmdlZCwg c28gd2UgbmVlZCB0byB1cGRhdGUgaXQuCiAgICAgICAgIGRpcmVjdFJlbmRlcmluZyA9IG1fYmFj a2luZ1N0b3JlLT5kLT5zaG91bGREaXJlY3RSZW5kZXJpbmdUb1dpbmRvdygpOwotICAgICAgICBp ZiAobV9iYWNraW5nU3RvcmUtPmQtPnJlbmRlclZpc2libGVDb250ZW50cygpICYmICFtX2JhY2tp bmdTdG9yZS0+ZC0+aXNTdXNwZW5kZWQoKSAmJiAhZGlyZWN0UmVuZGVyaW5nKQotICAgICAgICAg ICAgbV9iYWNraW5nU3RvcmUtPmQtPmJsaXRWaXNpYmxlQ29udGVudHMoKTsKLQotICAgICAgICBt X2NsaWVudC0+bm90aWZ5Q29udGVudFJlbmRlcmVkKG1fYmFja2luZ1N0b3JlLT5kLT52aXNpYmxl Q29udGVudHNSZWN0KCkpOworICAgICAgICBpZiAobV9iYWNraW5nU3RvcmUtPmQtPnJlbmRlclZp c2libGVDb250ZW50cygpKSB7CisgICAgICAgICAgICBpZiAoIW1fYmFja2luZ1N0b3JlLT5kLT5p c1N1c3BlbmRlZCgpICYmICFkaXJlY3RSZW5kZXJpbmcpCisgICAgICAgICAgICAgICAgbV9iYWNr aW5nU3RvcmUtPmQtPmJsaXRWaXNpYmxlQ29udGVudHMoKTsKKyAgICAgICAgICAgIG1fY2xpZW50 LT5ub3RpZnlDb250ZW50UmVuZGVyZWQobV9iYWNraW5nU3RvcmUtPmQtPnZpc2libGVDb250ZW50 c1JlY3QoKSk7CisgICAgICAgIH0KICAgICB9IGVsc2UgewogICAgICAgICBpZiAobV9iYWNraW5n U3RvcmUtPmQtPmlzT3BlbkdMQ29tcG9zaXRpbmcoKSkKICAgICAgICAgICAgc2V0Q29tcG9zaXRv ckRyYXdzUm9vdExheWVyKGZhbHNlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4 IDliZDY3NjUuLmFhZWYzMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwz ICsxLDM2IEBACisyMDEyLTA3LTI0ICBKYWtvYiBQZXRzb3ZpdHMgIDxqcGV0c292aXRzQHJpbS5j b20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIG5vdGlmeUNvbnRlbnRSZW5kZXJlZCgpIGNhbGwg bWlzc2luZyBpbiB0d28gc3BvdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTkyMTUzCisgICAgICAgIFJJTSBQUiAxNzMzNDAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBkaXNwYXRjaERpZEZpcnN0Vmlz dWFsTGF5b3V0KCkgYW5kIHJlcGFpbnQoKSBpbgorICAgICAgICBpbW1lZGlhdGUgbW9kZSwgd2Ug cmVuZGVyIGJ1dCBkb24ndCBub3RpZnkgdGhlCisgICAgICAgIFdlYlBhZ2VDbGllbnQgdGhhdCB0 aGUgY29udGVudCB3YXMgbW9kaWZpZWQuCisKKyAgICAgICAgSW4gdGhlIGxvbmcgcnVuLCB3ZSBz aG91bGQgcHJvYmFibHkga2VlcCB0cmFjayBvZgorICAgICAgICB0aGUgbW9kaWZpZWQgcmVhc29u IGZyb20gd2l0aGluIHJlbmRlcigpIGl0c2VsZgorICAgICAgICBhbmQgdXNlIHRoaXMgdG8gYXV0 b21hdGljYWxseSBub3RpZnkgdGhlIGNsaWVudAorICAgICAgICBmcm9tIHdpdGhpbiBibGl0Q29u dGVudHMoKSBhbmQvb3IgaW52YWxpZGF0ZVdpbmRvdygpLAorICAgICAgICBkZXBlbmRpbmcgb24g dGhlIHJlbmRlcmluZyBwYXRoLiBUaGF0J3Mgc29tZXdoYXQgb2YKKyAgICAgICAgYSBtZWRpdW0t c2l6ZSB1bmRlcnRha2luZyB0aG91Z2g7IGZvciBub3csIGFkZGluZworICAgICAgICB0aGUgY2Fs bCBkaXJlY3RseSB0byB0aGUgcmVuZGVyVmlzaWJsZUNvbnRlbnRzKCkKKyAgICAgICAgY2FsbCBz aXRlcyB3aWxsIGRvLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWxzbyBhZGRzIGEgYmxpdFZpc2li bGVDb250ZW50cygpIHRvCisgICAgICAgIGRpc3BhdGNoRGlkRmlyc3RWaXN1YWxMYXlvdXQoKSB3 aGVyZSBpdCB3YXMKKyAgICAgICAgaW5leHBsaWNhYmx5IG1pc3NpbmcsIHByb2JhYmx5IG9uIGFj Y291bnQgb2YKKyAgICAgICAgb2xkIGNvZGUgdGhhdCB3YXMgbmV2ZXIgdXBkYXRlZC4KKworICAg ICAgICAqIEFwaS9CYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0 OjpCYWNraW5nU3RvcmVQcml2YXRlOjpyZXBhaW50KToKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5j cHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpyZXN1bWVC YWNraW5nU3RvcmUpOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50 QmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEJsYWNr QmVycnk6OmRpc3BhdGNoRGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0KToKKwogMjAxMi0w Ny0yMyAgWW9uZyBMaSAgPHlvbGlAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gTW92 ZSBhYm91dDogVVJMIGhhbmRsaW5nIG91dCBvZiBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0Jl cnJ5LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxv YWRlckNsaWVudEJsYWNrQmVycnkuY3BwCmluZGV4IGE3ODYxODkuLjk0YjlhZGMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNs aWVudEJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3Jl U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCkBAIC04NDQsOSArODQ0LDE0 IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpkaXNwYXRjaERpZEZpcnN0Vmlz dWFsbHlOb25FbXB0eUxheW91dCgpCiAgICAgICAgIG1fd2ViUGFnZVByaXZhdGUtPnNldFNob3Vs ZFpvb21Ub0luaXRpYWxTY2FsZUFmdGVyTG9hZEZpbmlzaGVkKHRydWUpOwogCiAgICAgaWYgKG1f d2ViUGFnZVByaXZhdGUtPnNob3VsZFpvb21Ub0luaXRpYWxTY2FsZU9uTG9hZCgpKSB7CisgICAg ICAgIEJhY2tpbmdTdG9yZVByaXZhdGUqIGJhY2tpbmdTdG9yZVByaXZhdGUgPSBtX3dlYlBhZ2VQ cml2YXRlLT5tX2JhY2tpbmdTdG9yZS0+ZDsKICAgICAgICAgbV93ZWJQYWdlUHJpdmF0ZS0+em9v bVRvSW5pdGlhbFNjYWxlT25Mb2FkKCk7IC8vIFNldCB0aGUgcHJvcGVyIHpvb20gbGV2ZWwgZmly c3QuCi0gICAgICAgIG1fd2ViUGFnZVByaXZhdGUtPm1fYmFja2luZ1N0b3JlLT5kLT5jbGVhclZp c2libGVab29tKCk7IC8vIENsZWFyIHRoZSB2aXNpYmxlIHpvb20gc2luY2Ugd2UncmUgZXhwbGlj aXRseSByZW5kZXJpbmcrYmxpdHRpbmcgYmVsb3cuCi0gICAgICAgIG1fd2ViUGFnZVByaXZhdGUt Pm1fYmFja2luZ1N0b3JlLT5kLT5yZW5kZXJWaXNpYmxlQ29udGVudHMoKTsKKyAgICAgICAgYmFj a2luZ1N0b3JlUHJpdmF0ZS0+Y2xlYXJWaXNpYmxlWm9vbSgpOyAvLyBDbGVhciB0aGUgdmlzaWJs ZSB6b29tIHNpbmNlIHdlJ3JlIGV4cGxpY2l0bHkgcmVuZGVyaW5nK2JsaXR0aW5nIGJlbG93Lgor ICAgICAgICBpZiAoYmFja2luZ1N0b3JlUHJpdmF0ZS0+cmVuZGVyVmlzaWJsZUNvbnRlbnRzKCkp IHsKKyAgICAgICAgICAgIGlmICghYmFja2luZ1N0b3JlUHJpdmF0ZS0+c2hvdWxkRGlyZWN0UmVu ZGVyaW5nVG9XaW5kb3coKSkKKyAgICAgICAgICAgICAgICBiYWNraW5nU3RvcmVQcml2YXRlLT5i bGl0VmlzaWJsZUNvbnRlbnRzKCk7CisgICAgICAgICAgICBtX3dlYlBhZ2VQcml2YXRlLT5tX2Ns aWVudC0+bm90aWZ5Q29udGVudFJlbmRlcmVkKGJhY2tpbmdTdG9yZVByaXZhdGUtPnZpc2libGVD b250ZW50c1JlY3QoKSk7CisgICAgICAgIH0KICAgICB9CiAKICAgICBtX3dlYlBhZ2VQcml2YXRl LT5tX2NsaWVudC0+bm90aWZ5Rmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0KCk7Cg==