92151 2012-07-24 12:51:54 -0700 [chromium] Use the event bounding box when constructing a PlatformEvent::GestureTap 2012-07-31 19:04:49 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 92144 1 tdanderson tdanderson abarth dglazkov fishd jamesr sadrul tkent+wkapi webkit.review.bot oldest_to_newest 677126 0 tdanderson 2012-07-24 12:51:54 -0700 When constructing a PlatformEvent::GestureTap in WebInputEventConversion.cpp, use |boundingBox| instead of |deltaX| and |deltaY| when specifying |m_area|. 682522 1 155397 tdanderson 2012-07-30 16:40:45 -0700 Created attachment 155397 Patch 682529 2 155399 tdanderson 2012-07-30 16:50:06 -0700 Created attachment 155399 Patch 682532 3 webkit.review.bot 2012-07-30 16:52:11 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 683750 4 155399 webkit.review.bot 2012-07-31 19:04:44 -0700 Comment on attachment 155399 Patch Clearing flags on attachment: 155399 Committed r124283: <http://trac.webkit.org/changeset/124283> 683751 5 webkit.review.bot 2012-07-31 19:04:49 -0700 All reviewed patches have been landed. Closing bug. 155397 2012-07-30 16:40:45 -0700 2012-07-30 16:50:04 -0700 Patch bug-92151-20120730194028.patch text/plain 1692 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDJlYWIzMTcyYjBhNmI4ZmFhOGQ1ZDViYjNiOWRkMDQ0NWE4OTBlMjkuLjQ5YjU4MDgxN2VkNzYz OWFjNDA2MzJjYTBlMjNlOWIzNGIwYjZiMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDctMzAgIFRlcnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBVc2UgdGhlIGV2ZW50IGJvdW5kaW5n IGJveCB3aGVuIGNvbnN0cnVjdGluZyBhIFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVUYXAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyMTUxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm93IHRoYXQgZ2VzdHVy ZSBldmVudHMgc3RvcmUgYSBib3VuZGluZyBib3gsIHVzZSB8Ym91bmRpbmdCb3h8IGluc3RlYWQg b2YKKyAgICAgICAgfGRlbHRhWHwgYW5kIHxkZWx0YVl8IHdoZW4gc3BlY2lmeWluZyB8bV9hcmVh fC4KKworICAgICAgICAqIHNyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHA6CisgICAgICAg IChXZWJLaXQ6OlBsYXRmb3JtR2VzdHVyZUV2ZW50QnVpbGRlcjo6UGxhdGZvcm1HZXN0dXJlRXZl bnRCdWlsZGVyKToKKwogMjAxMi0wNy0zMCAgU2FkcnVsIEhhYmliIENob3dkaHVyeSAgPHNhZHJ1 bEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUHJvcGFnYXRlIGdlc3R1cmUgZXZlbnRzIHRvIHBs dWdpbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2 ZW50Q29udmVyc2lvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2 ZW50Q29udmVyc2lvbi5jcHAKaW5kZXggYzA4ZWRlYWFhNmM1NjY2MjkxYjRkY2IzYmIxNzZiYmVl YTA3Yjk1My4uMzM0MjhjMzI5NGY2OWU2MzUwNGU2NGFlOWVkNDI4ZDdlZDgxOTMyOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24u Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJz aW9uLmNwcApAQCAtMTUyLDcgKzE1Miw3IEBAIFBsYXRmb3JtR2VzdHVyZUV2ZW50QnVpbGRlcjo6 UGxhdGZvcm1HZXN0dXJlRXZlbnRCdWlsZGVyKFdpZGdldCogd2lkZ2V0LCBjb25zdCBXCiAgICAg ICAgIGJyZWFrOwogICAgIGNhc2UgV2ViSW5wdXRFdmVudDo6R2VzdHVyZVRhcDoKICAgICAgICAg bV90eXBlID0gUGxhdGZvcm1FdmVudDo6R2VzdHVyZVRhcDsKLSAgICAgICAgbV9hcmVhID0gSW50 U2l6ZShlLmRlbHRhWCAqIDIsIGUuZGVsdGFZICogMik7CisgICAgICAgIG1fYXJlYSA9IEludFNp emUoZS5ib3VuZGluZ0JveC53aWR0aCwgZS5ib3VuZGluZ0JveC5oZWlnaHQpOwogICAgICAgICBi cmVhazsKICAgICBjYXNlIFdlYklucHV0RXZlbnQ6Okdlc3R1cmVUYXBEb3duOgogICAgICAgICBt X3R5cGUgPSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlVGFwRG93bjsK 155399 2012-07-30 16:50:06 -0700 2012-07-31 19:04:44 -0700 Patch bug-92151-20120730194950.patch text/plain 2653 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDJlYWIzMTcyYjBhNmI4ZmFhOGQ1ZDViYjNiOWRkMDQ0NWE4OTBlMjkuLmM2YjY3ZDVlNjMyMmJk ZDc0YTFmZjI3ZTBhY2M4Mzc1YzJmNDU4YTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDctMzAgIFRlcnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBVc2UgdGhlIGV2ZW50IGJvdW5kaW5n IGJveCB3aGVuIGNvbnN0cnVjdGluZyBhIFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVUYXAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyMTUxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm93IHRoYXQgZ2VzdHVy ZSBldmVudHMgc3RvcmUgYSBib3VuZGluZyBib3gsIHVzZSB8Ym91bmRpbmdCb3h8IGluc3RlYWQg b2YKKyAgICAgICAgfGRlbHRhWHwgYW5kIHxkZWx0YVl8IHdoZW4gc3BlY2lmeWluZyB8bV9hcmVh fC4KKworICAgICAgICAqIHB1YmxpYy9XZWJJbnB1dEV2ZW50Lmg6CisgICAgICAgIChXZWJHZXN0 dXJlRXZlbnQpOgorICAgICAgICAqIHNyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OlBsYXRmb3JtR2VzdHVyZUV2ZW50QnVpbGRlcjo6UGxhdGZvcm1HZXN0 dXJlRXZlbnRCdWlsZGVyKToKKwogMjAxMi0wNy0zMCAgU2FkcnVsIEhhYmliIENob3dkaHVyeSAg PHNhZHJ1bEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUHJvcGFnYXRlIGdlc3R1cmUgZXZlbnRz IHRvIHBsdWdpbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJJbnB1dEV2ZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEV2 ZW50LmgKaW5kZXggNDBhNmZkYjNlMjZjZWNhYzg4NzhmNjk1ZTE2MDRhYjkxY2FlZTFmZi4uNWVh NTVkNTVjMjgzMGI4ODRlZWMzOWY2YmVhOTQ2OWQ3ZGQ4YzRhNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVudC5oCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaApAQCAtMzcwLDcgKzM3MCw3IEBAIHB1 YmxpYzoKICAgICBpbnQgZ2xvYmFsWDsKICAgICBpbnQgZ2xvYmFsWTsKIAotICAgIC8vIE5PVEU6 IHxkZWx0YVh8IGFuZCB8ZGVsdGFZfCByZXByZXNlbnRzIHRoZSBhbW91bnQgdG8gc2Nyb2xsIGZv ciBTY3JvbGwgZ2VzdHVyZSBldmVudHMuIEZvciBQaW5jaCBnZXN0dXJlIGV2ZW50cywgfGRlbHRh WHwgcmVwcmVzZW50cyB0aGUgc2NhbGluZy9tYWduaWZpY2F0aW9uIGZhY3Rvci4gRm9yIGEgR2Vz dHVyZVRhcCBldmVudCwgfGRlbHRhWHwgYW5kIHxkZWx0YVl8IHJlcHJlc2VudCB0aGUgaG9yaXpv bnRhbCBhbmQgdmVydGljYWwgcmFkaWkgb2YgdGhlIHRvdWNoIHJlZ2lvbi4KKyAgICAvLyBOT1RF OiB8ZGVsdGFYfCBhbmQgfGRlbHRhWXwgcmVwcmVzZW50cyB0aGUgYW1vdW50IHRvIHNjcm9sbCBm b3IgU2Nyb2xsIGdlc3R1cmUgZXZlbnRzLiBGb3IgUGluY2ggZ2VzdHVyZSBldmVudHMsIHxkZWx0 YVh8IHJlcHJlc2VudHMgdGhlIHNjYWxpbmcvbWFnbmlmaWNhdGlvbiBmYWN0b3IuCiAgICAgZmxv YXQgZGVsdGFYOwogICAgIGZsb2F0IGRlbHRhWTsKICAgICBXZWJSZWN0IGJvdW5kaW5nQm94Owpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZl cnNpb24uY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZl cnNpb24uY3BwCmluZGV4IGMwOGVkZWFhYTZjNTY2NjI5MWI0ZGNiM2JiMTc2YmJlZWEwN2I5NTMu LjMzNDI4YzMyOTRmNjllNjM1MDRlNjRhZTllZDQyOGQ3ZWQ4MTkzMjggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9uLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHAK QEAgLTE1Miw3ICsxNTIsNyBAQCBQbGF0Zm9ybUdlc3R1cmVFdmVudEJ1aWxkZXI6OlBsYXRmb3Jt R2VzdHVyZUV2ZW50QnVpbGRlcihXaWRnZXQqIHdpZGdldCwgY29uc3QgVwogICAgICAgICBicmVh azsKICAgICBjYXNlIFdlYklucHV0RXZlbnQ6Okdlc3R1cmVUYXA6CiAgICAgICAgIG1fdHlwZSA9 IFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVUYXA7Ci0gICAgICAgIG1fYXJlYSA9IEludFNpemUoZS5k ZWx0YVggKiAyLCBlLmRlbHRhWSAqIDIpOworICAgICAgICBtX2FyZWEgPSBJbnRTaXplKGUuYm91 bmRpbmdCb3gud2lkdGgsIGUuYm91bmRpbmdCb3guaGVpZ2h0KTsKICAgICAgICAgYnJlYWs7CiAg ICAgY2FzZSBXZWJJbnB1dEV2ZW50OjpHZXN0dXJlVGFwRG93bjoKICAgICAgICAgbV90eXBlID0g UGxhdGZvcm1FdmVudDo6R2VzdHVyZVRhcERvd247Cg==