92147 2012-07-24 12:12:02 -0700 [Mac WK2] Improve text input logging 2012-07-24 13:16:13 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Enhancement --- 1 ap ap kling webkit.review.bot oldest_to_newest 677088 0 ap 2012-07-24 12:12:02 -0700 Log more important stuff. 677090 1 154118 ap 2012-07-24 12:13:16 -0700 Created attachment 154118 proposed patch 677148 2 154118 webkit.review.bot 2012-07-24 13:16:09 -0700 Comment on attachment 154118 proposed patch Clearing flags on attachment: 154118 Committed r123515: <http://trac.webkit.org/changeset/123515> 677149 3 webkit.review.bot 2012-07-24 13:16:13 -0700 All reviewed patches have been landed. Closing bug. 154118 2012-07-24 12:13:16 -0700 2012-07-24 13:16:09 -0700 proposed patch MoreTextInputLogging.txt text/plain 6121 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzUwMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTI0ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWMgV0syXSBJbXByb3Zl IHRleHQgaW5wdXQgbG9nZ2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTIxNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAgICAgKC1bV0tW aWV3IGluc2VydFRleHQ6cmVwbGFjZW1lbnRSYW5nZTpdKToKKyAgICAgICAgKC1bV0tWaWV3IGtl eVVwOl0pOgorICAgICAgICAoLVtXS1ZpZXcga2V5RG93bjpdKToKKyAgICAgICAgKC1bV0tWaWV3 IGZsYWdzQ2hhbmdlZDpdKToKKyAgICAgICAgKC1bV0tWaWV3IF9leGVjdXRlU2F2ZWRLZXlwcmVz c0NvbW1hbmRzXSk6CisgICAgICAgICgtW1dLVmlldyBfbm90aWZ5SW5wdXRDb250ZXh0QWJvdXRE aXNjYXJkZWRDb21wb3NpdGlvbl0pOgorICAgICAgICAoLVtXS1ZpZXcgX2ludGVycHJldEtleUV2 ZW50OnNhdmluZ0NvbW1hbmRzVG86V2ViQ29yZTo6XSk6CisgICAgICAgICgtW1dLVmlldyBfdXBk YXRlU2VjdXJlSW5wdXRTdGF0ZV0pOgorCiAyMDEyLTA3LTI0ICBTdWRhcnNhbmEgTmFnaW5lbmkg IDxzdWRhcnNhbmEubmFnaW5lbmlAbGludXguaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdW1dL Ml0gQWRkIHZpYnJhdGlvbiBjbGllbnQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvbWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDEyMzM0NykKKysrIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTIwMSw2ICsxMjAx LDcgQEAgLSAodm9pZClpbnNlcnRUZXh0OihpZClzdHJpbmcgcmVwbGFjZW1lbgogICAgIC8vIC0g SWYgaXQncyBzZW50IG91dHNpZGUgb2Yga2V5Ym9hcmQgZXZlbnQgcHJvY2Vzc2luZyAoZS5nLiBm cm9tIENoYXJhY3RlciBWaWV3ZXIsIG9yIHdoZW4gY29uZmlybWluZyBhbiBpbmxpbmUgaW5wdXQg YXJlYSB3aXRoIGEgbW91c2UpLAogICAgIC8vIHRoZW4gd2UgYWxzbyBleGVjdXRlIGl0IGltbWVk aWF0ZWx5LCBhcyB0aGVyZSB3aWxsIGJlIG5vIG90aGVyIGNoYW5jZS4KICAgICBpZiAocGFyYW1l dGVycyAmJiAhaXNGcm9tSW5wdXRNZXRob2QpIHsKKyAgICAgICAgLy8gRklYTUU6IEhhbmRsZSBy ZXBsYWNlbWVudFJhbmdlIGluIHRoaXMgY2FzZSwgdG9vLiBJdCdzIGtub3duIHRvIG9jY3VyIGlu IHByYWN0aWNlIHdoZW4gY2FuY2VsaW5nIFByZXNzIGFuZCBIb2xkIChzZWUgPHJkYXI6Ly8xMTk0 MDY3MD4pLgogICAgICAgICBBU1NFUlQocmVwbGFjZW1lbnRSYW5nZS5sb2NhdGlvbiA9PSBOU05v dEZvdW5kKTsKICAgICAgICAgS2V5cHJlc3NDb21tYW5kIGNvbW1hbmQoImluc2VydFRleHQ6Iiwg dGV4dCk7CiAgICAgICAgIHBhcmFtZXRlcnMtPmNvbW1hbmRzLT5hcHBlbmQoY29tbWFuZCk7CkBA IC0xMjcyLDYgKzEyNzMsNyBAQCAtIChCT09MKXBlcmZvcm1LZXlFcXVpdmFsZW50OihOU0V2ZW50 ICopCiAKIC0gKHZvaWQpa2V5VXA6KE5TRXZlbnQgKil0aGVFdmVudAogeworICAgIExPRyhUZXh0 SW5wdXQsICJrZXlVcDolcCAlQCIsIHRoZUV2ZW50LCB0aGVFdmVudCk7CiAgICAgX2RhdGEtPl9w YWdlLT5oYW5kbGVLZXlib2FyZEV2ZW50KE5hdGl2ZVdlYktleWJvYXJkRXZlbnQodGhlRXZlbnQs IHNlbGYpKTsKIH0KIApAQCAtMTMyNiwxMyArMTMyOCwxNyBAQCAtIChCT09MKV90cnlIYW5kbGVQ bHVnaW5Db21wbGV4VGV4dElucHV0CiAKIC0gKHZvaWQpa2V5RG93bjooTlNFdmVudCAqKXRoZUV2 ZW50CiB7CisgICAgTE9HKFRleHRJbnB1dCwgImtleURvd246JXAgJUAlcyIsIHRoZUV2ZW50LCB0 aGVFdmVudCwgKHRoZUV2ZW50ID09IF9kYXRhLT5fa2V5RG93bkV2ZW50QmVpbmdSZXNlbnQpID8g IiAocmUtc2VudCkiIDogIiIpOworCiAgICAgLy8gVGhlcmUncyBhIGNoYW5jZSB0aGF0IHJlc3Bv bmRpbmcgdG8gdGhpcyBldmVudCB3aWxsIHJ1biBhIG5lc3RlZCBldmVudCBsb29wLCBhbmQKICAg ICAvLyBmZXRjaGluZyBhIG5ldyBldmVudCBtaWdodCByZWxlYXNlIHRoZSBvbGQgb25lLiBSZXRh aW5pbmcgYW5kIHRoZW4gYXV0b3JlbGVhc2luZwogICAgIC8vIHRoZSBjdXJyZW50IGV2ZW50IHBy ZXZlbnRzIHRoYXQgZnJvbSBjYXVzaW5nIGEgcHJvYmxlbSBpbnNpZGUgV2ViS2l0IG9yIEFwcEtp dCBjb2RlLgogICAgIFtbdGhlRXZlbnQgcmV0YWluXSBhdXRvcmVsZWFzZV07CiAKLSAgICBpZiAo W3NlbGYgX3RyeUhhbmRsZVBsdWdpbkNvbXBsZXhUZXh0SW5wdXRLZXlEb3duOnRoZUV2ZW50XSkK KyAgICBpZiAoW3NlbGYgX3RyeUhhbmRsZVBsdWdpbkNvbXBsZXhUZXh0SW5wdXRLZXlEb3duOnRo ZUV2ZW50XSkgeworICAgICAgICBMT0coVGV4dElucHV0LCAiLi4uaGFuZGxlZCBieSBwbHVnLWlu Iik7CiAgICAgICAgIHJldHVybjsKKyAgICB9CiAKICAgICAvLyBXZSBjb3VsZCBiZSByZWNlaXZp bmcgYSBrZXkgZG93biBmcm9tIEFwcEtpdCBpZiB3ZSBoYXZlIHJlLXNlbnQgYW4gZXZlbnQKICAg ICAvLyB0aGF0IG1hcHMgdG8gYW4gYWN0aW9uIHRoYXQgaXMgY3VycmVudGx5IHVuYXZhaWxhYmxl IChmb3IgZXhhbXBsZSBhIGNvcHkgd2hlbgpAQCAtMTM0Nyw2ICsxMzUzLDggQEAgLSAodm9pZClr ZXlEb3duOihOU0V2ZW50ICopdGhlRXZlbnQKIAogLSAodm9pZClmbGFnc0NoYW5nZWQ6KE5TRXZl bnQgKil0aGVFdmVudAogeworICAgIExPRyhUZXh0SW5wdXQsICJmbGFnc0NoYW5nZWQ6JXAgJUAi LCB0aGVFdmVudCwgdGhlRXZlbnQpOworCiAgICAgLy8gVGhlcmUncyBhIGNoYW5jZSB0aGF0IHJl c3BvbmRpbmcgdG8gdGhpcyBldmVudCB3aWxsIHJ1biBhIG5lc3RlZCBldmVudCBsb29wLCBhbmQK ICAgICAvLyBmZXRjaGluZyBhIG5ldyBldmVudCBtaWdodCByZWxlYXNlIHRoZSBvbGQgb25lLiBS ZXRhaW5pbmcgYW5kIHRoZW4gYXV0b3JlbGVhc2luZwogICAgIC8vIHRoZSBjdXJyZW50IGV2ZW50 IHByZXZlbnRzIHRoYXQgZnJvbSBjYXVzaW5nIGEgcHJvYmxlbSBpbnNpZGUgV2ViS2l0IG9yIEFw cEtpdCBjb2RlLgpAQCAtMTM3MiwxMCArMTM4MCwxNCBAQCAtICh2b2lkKV9leGVjdXRlU2F2ZWRL ZXlwcmVzc0NvbW1hbmRzCiAgICAgaWYgKHBhcmFtZXRlcnMtPmV4ZWN1dGluZ1NhdmVkS2V5cHJl c3NDb21tYW5kcykKICAgICAgICAgcmV0dXJuOwogCisgICAgTE9HKFRleHRJbnB1dCwgIkV4ZWN1 dGluZyAldSBzYXZlZCBrZXlwcmVzcyBjb21tYW5kcy4uLiIsIHBhcmFtZXRlcnMtPmNvbW1hbmRz LT5zaXplKCkpOworCiAgICAgcGFyYW1ldGVycy0+ZXhlY3V0aW5nU2F2ZWRLZXlwcmVzc0NvbW1h bmRzID0gdHJ1ZTsKICAgICBwYXJhbWV0ZXJzLT5ldmVudEludGVycHJldGF0aW9uSGFkU2lkZUVm ZmVjdHMgfD0gX2RhdGEtPl9wYWdlLT5leGVjdXRlS2V5cHJlc3NDb21tYW5kcygqcGFyYW1ldGVy cy0+Y29tbWFuZHMpOwogICAgIHBhcmFtZXRlcnMtPmNvbW1hbmRzLT5jbGVhcigpOwogICAgIHBh cmFtZXRlcnMtPmV4ZWN1dGluZ1NhdmVkS2V5cHJlc3NDb21tYW5kcyA9IGZhbHNlOworCisgICAg TE9HKFRleHRJbnB1dCwgIi4uLmRvbmUgZXhlY3V0aW5nIHNhdmVkIGtleXByZXNzIGNvbW1hbmRz LiIpOwogfQogCiAtICh2b2lkKV9ub3RpZnlJbnB1dENvbnRleHRBYm91dERpc2NhcmRlZENvbXBv c2l0aW9uCkBAIC0xMzg2LDYgKzEzOTgsNyBAQCAtICh2b2lkKV9ub3RpZnlJbnB1dENvbnRleHRB Ym91dERpc2NhcmRlCiAgICAgaWYgKCFbW3NlbGYgd2luZG93XSBpc0tleVdpbmRvd10gfHwgc2Vs ZiAhPSBbW3NlbGYgd2luZG93XSBmaXJzdFJlc3BvbmRlcl0pCiAgICAgICAgIHJldHVybjsKIAor ICAgIExPRyhUZXh0SW5wdXQsICItPiBkaXNjYXJkTWFya2VkVGV4dCIpOwogICAgIFtbc3VwZXIg aW5wdXRDb250ZXh0XSBkaXNjYXJkTWFya2VkVGV4dF07IC8vIEluZm9ybSB0aGUgaW5wdXQgbWV0 aG9kIHRoYXQgd2Ugd29uJ3QgaGF2ZSBhbiBpbmxpbmUgaW5wdXQgYXJlYSBkZXNwaXRlIGhhdmlu ZyBiZWVuIGFza2VkIHRvLgogfQogCkBAIC0yMzcxLDE0ICsyMzg0LDE5IEBAIC0gKEJPT0wpX2lu dGVycHJldEtleUV2ZW50OihOU0V2ZW50ICopZXYKICAgICBwYXJhbWV0ZXJzLmNvbW1hbmRzID0g JmNvbW1hbmRzOwogICAgIF9kYXRhLT5faW50ZXJwcmV0S2V5RXZlbnRzUGFyYW1ldGVycyA9ICZw YXJhbWV0ZXJzOwogCisgICAgTE9HKFRleHRJbnB1dCwgIi0+IGludGVycHJldEtleUV2ZW50czol cCAlQCIsIGV2ZW50LCBldmVudCk7CiAgICAgW3NlbGYgaW50ZXJwcmV0S2V5RXZlbnRzOltOU0Fy cmF5IGFycmF5V2l0aE9iamVjdDpldmVudF1dOwogCiAgICAgX2RhdGEtPl9pbnRlcnByZXRLZXlF dmVudHNQYXJhbWV0ZXJzID0gMDsKIAogICAgIC8vIEFuIGlucHV0IG1ldGhvZCBtYXkgY29uc3Vt ZSBhbiBldmVudCBhbmQgbm90IHRlbGwgdXMgKGUuZy4gd2hlbiBkaXNwbGF5aW5nIGEgY2FuZGlk YXRlIHdpbmRvdyksCiAgICAgLy8gaW4gd2hpY2ggY2FzZSB3ZSBzaG91bGQgbm90IGJ1YmJsZSB0 aGUgZXZlbnQgdXAgdGhlIERPTS4KLSAgICBpZiAocGFyYW1ldGVycy5jb25zdW1lZEJ5SU0pCisg ICAgaWYgKHBhcmFtZXRlcnMuY29uc3VtZWRCeUlNKSB7CisgICAgICAgIExPRyhUZXh0SW5wdXQs ICIuLi5ldmVudCAlcCB3YXMgY29uc3VtZWQgYnkgYW4gaW5wdXQgbWV0aG9kIiwgZXZlbnQpOwog ICAgICAgICByZXR1cm4gWUVTOworICAgIH0KKworICAgIExPRyhUZXh0SW5wdXQsICIuLi5pbnRl cnByZXRLZXlFdmVudHMgZm9yIGV2ZW50ICVwIGRvbmUsIHJldHVybnMgJWQiLCBldmVudCwgcGFy YW1ldGVycy5ldmVudEludGVycHJldGF0aW9uSGFkU2lkZUVmZmVjdHMpOwogCiAgICAgLy8gSWYg d2UgaGF2ZSBhbHJlYWR5IGV4ZWN1dGVkIGFsbCBvciBzb21lIG9mIHRoZSBjb21tYW5kcywgdGhl IGV2ZW50IGlzICJoYW5kbGVkIi4gTm90ZSB0aGF0IHRoZXJlIGFyZSBhZGRpdGlvbmFsIGNoZWNr cyBvbiB3ZWIgcHJvY2VzcyBzaWRlLgogICAgIHJldHVybiBwYXJhbWV0ZXJzLmV2ZW50SW50ZXJw cmV0YXRpb25IYWRTaWRlRWZmZWN0czsKQEAgLTI4MjcsMTAgKzI4NDUsMTIgQEAgLSAodm9pZClf dXBkYXRlU2VjdXJlSW5wdXRTdGF0ZQogICAgICAgICBpZiAoIV9kYXRhLT5faW5TZWN1cmVJbnB1 dFN0YXRlKQogICAgICAgICAgICAgRW5hYmxlU2VjdXJlRXZlbnRJbnB1dCgpOwogICAgICAgICBz dGF0aWMgTlNBcnJheSAqcm9tYW5JbnB1dFNvdXJjZXMgPSBbW05TQXJyYXkgYWxsb2NdIGluaXRX aXRoT2JqZWN0czomTlNBbGxSb21hbklucHV0U291cmNlc0xvY2FsZUlkZW50aWZpZXIgY291bnQ6 MV07CisgICAgICAgIExPRyhUZXh0SW5wdXQsICItPiBzZXRBbGxvd2VkSW5wdXRTb3VyY2VMb2Nh bGVzOnJvbWFuSW5wdXRTb3VyY2VzIik7CiAgICAgICAgIFtjb250ZXh0IHNldEFsbG93ZWRJbnB1 dFNvdXJjZUxvY2FsZXM6cm9tYW5JbnB1dFNvdXJjZXNdOwogICAgIH0gZWxzZSB7CiAgICAgICAg IGlmIChfZGF0YS0+X2luU2VjdXJlSW5wdXRTdGF0ZSkKICAgICAgICAgICAgIERpc2FibGVTZWN1 cmVFdmVudElucHV0KCk7CisgICAgICAgIExPRyhUZXh0SW5wdXQsICItPiBzZXRBbGxvd2VkSW5w dXRTb3VyY2VMb2NhbGVzOm5pbCIpOwogICAgICAgICBbY29udGV4dCBzZXRBbGxvd2VkSW5wdXRT b3VyY2VMb2NhbGVzOm5pbF07CiAgICAgfQogICAgIF9kYXRhLT5faW5TZWN1cmVJbnB1dFN0YXRl ID0gaXNJblBhc3N3b3JkRmllbGQ7Cg==