92144 2012-07-24 11:07:14 -0700 [chromium] Add a bounding box member in WebGestureEvent 2012-07-24 13:33:04 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 92151 1 tdanderson tdanderson abarth dglazkov fishd jamesr sadrul tkent+wkapi webkit.review.bot oldest_to_newest 677042 0 tdanderson 2012-07-24 11:07:14 -0700 The new |boundingBox| member will be used to store the touch region for a WebGestureEvent. This will be useful for gesture target fuzzing across multiple different gesture types (tap, long press, scroll, etc.) 677046 1 154111 tdanderson 2012-07-24 11:11:29 -0700 Created attachment 154111 Patch 677047 2 webkit.review.bot 2012-07-24 11:12:49 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 677053 3 154111 sadrul 2012-07-24 11:22:28 -0700 Comment on attachment 154111 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154111&action=review Can you also update the computation of PlatformGestureEvent::m_area at the same time? (looks like should be trivial?) > Source/WebKit/chromium/public/WebInputEvent.h:42 > +struct WebRect; This probably isn't necessary since you include the header? > Source/WebKit/chromium/public/WebInputEvent.h:388 > + , boundingBox(0, 0, 0, 0) WebRect initializes itself correctly. This should not be necessary. 677078 4 154111 abarth 2012-07-24 11:58:39 -0700 Comment on attachment 154111 Patch Please address sadrul's concerns before landing. 677087 5 154117 tdanderson 2012-07-24 12:11:49 -0700 Created attachment 154117 Patch for landing 677101 6 154117 abarth 2012-07-24 12:20:24 -0700 Comment on attachment 154117 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=154117&action=review > Source/WebKit/chromium/src/WebInputEventConversion.cpp:155 > m_type = PlatformEvent::GestureTap; > - m_area = IntSize(e.deltaX * 2, e.deltaY * 2); > + IntRect bounds(e.boundingBox); > + m_area = IntSize(bounds.width(), bounds.height()); Don't you need to do this in a subsequent patch once your change to WebInputEvent has landed and you've updated Chromium to use this API? 677102 7 154117 abarth 2012-07-24 12:20:48 -0700 Comment on attachment 154117 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=154117&action=review > Source/WebKit/chromium/public/WebInputEvent.h:373 > // NOTE: |deltaX| and |deltaY| represents the amount to scroll for Scroll gesture events. For Pinch gesture events, |deltaX| represents the scaling/magnification factor. For a GestureTap event, |deltaX| and |deltaY| represent the horizontal and vertical radii of the touch region. Do we need to update this comment? 677111 8 tdanderson 2012-07-24 12:37:10 -0700 (In reply to comment #6) > (From update of attachment 154117 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154117&action=review > > > Source/WebKit/chromium/src/WebInputEventConversion.cpp:155 > > m_type = PlatformEvent::GestureTap; > > - m_area = IntSize(e.deltaX * 2, e.deltaY * 2); > > + IntRect bounds(e.boundingBox); > > + m_area = IntSize(bounds.width(), bounds.height()); > > Don't you need to do this in a subsequent patch once your change to WebInputEvent has landed and you've updated Chromium to use this API? Yes, you're right... I will make this change in another patch once the Chromium side has landed. 677112 9 tdanderson 2012-07-24 12:38:24 -0700 (In reply to comment #7) > (From update of attachment 154117 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154117&action=review > > > Source/WebKit/chromium/public/WebInputEvent.h:373 > > // NOTE: |deltaX| and |deltaY| represents the amount to scroll for Scroll gesture events. For Pinch gesture events, |deltaX| represents the scaling/magnification factor. For a GestureTap event, |deltaX| and |deltaY| represent the horizontal and vertical radii of the touch region. > > Do we need to update this comment? Yes, we do. I'll update it in the next patch after this and the Chromium patch both land. 677113 10 154121 tdanderson 2012-07-24 12:40:00 -0700 Created attachment 154121 Patch 677165 11 154121 webkit.review.bot 2012-07-24 13:32:58 -0700 Comment on attachment 154121 Patch Clearing flags on attachment: 154121 Committed r123520: <http://trac.webkit.org/changeset/123520> 677166 12 webkit.review.bot 2012-07-24 13:33:04 -0700 All reviewed patches have been landed. Closing bug. 154111 2012-07-24 11:11:29 -0700 2012-07-24 12:11:45 -0700 Patch bug-92144-20120724141120.patch text/plain 2977 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNhNDQ2ZmU5MDU4ZmZmNTYyZjFkYjIxYWU1M2UxMTRlYjMyOTU1MTguLjY1OWNkYzkzNzI3OGFl MzY2OWY5ZWY2MDk0OTdhZDljOTI2NDg1YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDctMjQgIFRlcnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBBZGQgYSBib3VuZGluZyBib3ggbWVt YmVyIGluIFdlYkdlc3R1cmVFdmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTIxNDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgbmV3IHxib3VuZGluZ0JveHwgbWVtYmVyIHdpbGwgYmUgdXNlZCB0 byBzdG9yZSB0aGUgdG91Y2ggcmVnaW9uIGZvciBhIFdlYkdlc3R1cmVFdmVudC4KKyAgICAgICAg VGhpcyB3aWxsIGJlIHVzZWZ1bCBmb3IgZ2VzdHVyZSB0YXJnZXQgZnV6emluZyBhY3Jvc3MgbXVs dGlwbGUgZGlmZmVyZW50IGdlc3R1cmUgdHlwZXMKKyAgICAgICAgKHRhcCwgbG9uZyBwcmVzcywg c2Nyb2xsLCBldGMuKQorCisgICAgICAgICogcHVibGljL1dlYklucHV0RXZlbnQuaDoKKyAgICAg ICAgKFdlYktpdCk6CisgICAgICAgIChXZWJHZXN0dXJlRXZlbnQpOgorICAgICAgICAoV2ViS2l0 OjpXZWJHZXN0dXJlRXZlbnQ6OldlYkdlc3R1cmVFdmVudCk6CisgICAgICAgICogc3JjL1dlYklu cHV0RXZlbnQuY3BwOgorICAgICAgICAoU2FtZVNpemVBc1dlYkdlc3R1cmVFdmVudCk6CisKIDIw MTItMDctMjQgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZC4gIFJvbGxlZCBERVBTLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVudC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViSW5wdXRFdmVudC5oCmluZGV4IGI3YTVlY2JkMjJiMDQzNTUxNDlmMjA2NTRhY2Rj YjBiYWNiOTU2M2QuLjQzOTcxN2U1MDU0ODNkYWExY2Q1MzEwYzM4ZTJkOTlmYWYwYWRjN2IgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaAor KysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEV2ZW50LmgKQEAgLTMz LDExICszMywxNCBAQAogCiAjaW5jbHVkZSAiV2ViVG91Y2hQb2ludC5oIgogI2luY2x1ZGUgInBs YXRmb3JtL1dlYkNvbW1vbi5oIgorI2luY2x1ZGUgInBsYXRmb3JtL1dlYlJlY3QuaCIKIAogI2lu Y2x1ZGUgPHN0cmluZy5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAorc3RydWN0IFdlYlJlY3Q7 CisKIC8vIFRoZSBjbGFzc2VzIGRlZmluZWQgaW4gdGhpcyBmaWxlIGFyZSBpbnRlbmRlZCB0byBi ZSB1c2VkIHdpdGgKIC8vIFdlYldpZGdldCdzIGhhbmRsZUlucHV0RXZlbnQgbWV0aG9kLiAgVGhl c2UgZXZlbnQgdHlwZXMgYXJlIGNyb3NzLQogLy8gcGxhdGZvcm0gYW5kIGNvcnJlc3BvbmQgY2xv c2VseSB0byBXZWJDb3JlJ3MgUGxhdGZvcm0qRXZlbnQgY2xhc3Nlcy4KQEAgLTM3Miw2ICszNzUs NyBAQCBwdWJsaWM6CiAgICAgLy8gTk9URTogfGRlbHRhWHwgYW5kIHxkZWx0YVl8IHJlcHJlc2Vu dHMgdGhlIGFtb3VudCB0byBzY3JvbGwgZm9yIFNjcm9sbCBnZXN0dXJlIGV2ZW50cy4gRm9yIFBp bmNoIGdlc3R1cmUgZXZlbnRzLCB8ZGVsdGFYfCByZXByZXNlbnRzIHRoZSBzY2FsaW5nL21hZ25p ZmljYXRpb24gZmFjdG9yLiBGb3IgYSBHZXN0dXJlVGFwIGV2ZW50LCB8ZGVsdGFYfCBhbmQgfGRl bHRhWXwgcmVwcmVzZW50IHRoZSBob3Jpem9udGFsIGFuZCB2ZXJ0aWNhbCByYWRpaSBvZiB0aGUg dG91Y2ggcmVnaW9uLgogICAgIGZsb2F0IGRlbHRhWDsKICAgICBmbG9hdCBkZWx0YVk7CisgICAg V2ViUmVjdCBib3VuZGluZ0JveDsKIAogICAgIFdlYkdlc3R1cmVFdmVudCh1bnNpZ25lZCBzaXpl UGFyYW0gPSBzaXplb2YoV2ViR2VzdHVyZUV2ZW50KSkKICAgICAgICAgOiBXZWJJbnB1dEV2ZW50 KHNpemVQYXJhbSkKQEAgLTM4MSw2ICszODUsNyBAQCBwdWJsaWM6CiAgICAgICAgICwgZ2xvYmFs WSgwKQogICAgICAgICAsIGRlbHRhWCgwLjBmKQogICAgICAgICAsIGRlbHRhWSgwLjBmKQorICAg ICAgICAsIGJvdW5kaW5nQm94KDAsIDAsIDAsIDApCiAgICAgewogICAgIH0KIH07CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50LmNwcCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnQuY3BwCmluZGV4IGMwNjkwZjhkN2Mz ODE2OWY1ZTAwNDM2MWQ4NmUzMDY0MTJkYzM3N2EuLjY2YTA0ODBiNGQ0YWRhYzMxN2JhMzEyOWE3 ZjAyY2QzYTVmY2I0NjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YklucHV0RXZlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0 RXZlbnQuY3BwCkBAIC02MCw3ICs2MCw3IEBAIHN0cnVjdCBTYW1lU2l6ZUFzV2ViTW91c2VXaGVl bEV2ZW50IDogcHVibGljIFNhbWVTaXplQXNXZWJNb3VzZUV2ZW50IHsKIH07CiAKIHN0cnVjdCBT YW1lU2l6ZUFzV2ViR2VzdHVyZUV2ZW50IDogcHVibGljIFNhbWVTaXplQXNXZWJJbnB1dEV2ZW50 IHsKLSAgICBpbnQgZ2VzdHVyZURhdGFbNl07CisgICAgaW50IGdlc3R1cmVEYXRhWzEwXTsKIH07 CiAKIHN0cnVjdCBTYW1lU2l6ZUFzV2ViVG91Y2hFdmVudCA6IHB1YmxpYyBTYW1lU2l6ZUFzV2Vi SW5wdXRFdmVudCB7Cg== 154117 2012-07-24 12:11:49 -0700 2012-07-24 12:39:56 -0700 Patch for landing bug-92144-20120724151140.patch text/plain 3589 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNhNDQ2ZmU5MDU4ZmZmNTYyZjFkYjIxYWU1M2UxMTRlYjMyOTU1MTguLmM0MDgwYmE2ZTgzNjc3 MjZhMmY0YmNmNjVlMzJkYWY0NTE4ZGZhY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDctMjQgIFRlcnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBBZGQgYSBib3VuZGluZyBib3ggbWVt YmVyIGluIFdlYkdlc3R1cmVFdmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTIxNDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgbmV3IHxib3VuZGluZ0JveHwgbWVtYmVyIHdpbGwgYmUgdXNlZCB0 byBzdG9yZSB0aGUgdG91Y2ggcmVnaW9uIGZvciBhIFdlYkdlc3R1cmVFdmVudC4KKyAgICAgICAg VGhpcyB3aWxsIGJlIHVzZWZ1bCBmb3IgZ2VzdHVyZSB0YXJnZXQgZnV6emluZyBhY3Jvc3MgbXVs dGlwbGUgZGlmZmVyZW50IGdlc3R1cmUgdHlwZXMKKyAgICAgICAgKHRhcCwgbG9uZyBwcmVzcywg c2Nyb2xsLCBldGMuKQorCisgICAgICAgICogcHVibGljL1dlYklucHV0RXZlbnQuaDoKKyAgICAg ICAgKFdlYkdlc3R1cmVFdmVudCk6CisgICAgICAgICogc3JjL1dlYklucHV0RXZlbnQuY3BwOgor ICAgICAgICAoU2FtZVNpemVBc1dlYkdlc3R1cmVFdmVudCk6CisgICAgICAgICogc3JjL1dlYklu cHV0RXZlbnRDb252ZXJzaW9uLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGxhdGZvcm1HZXN0dXJl RXZlbnRCdWlsZGVyOjpQbGF0Zm9ybUdlc3R1cmVFdmVudEJ1aWxkZXIpOgorCiAyMDEyLTA3LTI0 ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQuICBSb2xsZWQgREVQUy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYklucHV0RXZlbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YklucHV0RXZlbnQuaAppbmRleCBiN2E1ZWNiZDIyYjA0MzU1MTQ5ZjIwNjU0YWNkY2IwYmFjYjk1 NjNkLi40MGE2ZmRiM2UyNmNlY2FjODg3OGY2OTVlMTYwNGFiOTFjYWVlMWZmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEV2ZW50LmgKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVudC5oCkBAIC0zMyw2ICszMyw3 IEBACiAKICNpbmNsdWRlICJXZWJUb3VjaFBvaW50LmgiCiAjaW5jbHVkZSAicGxhdGZvcm0vV2Vi Q29tbW9uLmgiCisjaW5jbHVkZSAicGxhdGZvcm0vV2ViUmVjdC5oIgogCiAjaW5jbHVkZSA8c3Ry aW5nLmg+CiAKQEAgLTM3Miw2ICszNzMsNyBAQCBwdWJsaWM6CiAgICAgLy8gTk9URTogfGRlbHRh WHwgYW5kIHxkZWx0YVl8IHJlcHJlc2VudHMgdGhlIGFtb3VudCB0byBzY3JvbGwgZm9yIFNjcm9s bCBnZXN0dXJlIGV2ZW50cy4gRm9yIFBpbmNoIGdlc3R1cmUgZXZlbnRzLCB8ZGVsdGFYfCByZXBy ZXNlbnRzIHRoZSBzY2FsaW5nL21hZ25pZmljYXRpb24gZmFjdG9yLiBGb3IgYSBHZXN0dXJlVGFw IGV2ZW50LCB8ZGVsdGFYfCBhbmQgfGRlbHRhWXwgcmVwcmVzZW50IHRoZSBob3Jpem9udGFsIGFu ZCB2ZXJ0aWNhbCByYWRpaSBvZiB0aGUgdG91Y2ggcmVnaW9uLgogICAgIGZsb2F0IGRlbHRhWDsK ICAgICBmbG9hdCBkZWx0YVk7CisgICAgV2ViUmVjdCBib3VuZGluZ0JveDsKIAogICAgIFdlYkdl c3R1cmVFdmVudCh1bnNpZ25lZCBzaXplUGFyYW0gPSBzaXplb2YoV2ViR2VzdHVyZUV2ZW50KSkK ICAgICAgICAgOiBXZWJJbnB1dEV2ZW50KHNpemVQYXJhbSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnQuY3BwIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViSW5wdXRFdmVudC5jcHAKaW5kZXggYzA2OTBmOGQ3YzM4MTY5ZjVlMDA0MzYx ZDg2ZTMwNjQxMmRjMzc3YS4uNjZhMDQ4MGI0ZDRhZGFjMzE3YmEzMTI5YTdmMDJjZDNhNWZjYjQ2 OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudC5jcHAKQEAg LTYwLDcgKzYwLDcgQEAgc3RydWN0IFNhbWVTaXplQXNXZWJNb3VzZVdoZWVsRXZlbnQgOiBwdWJs aWMgU2FtZVNpemVBc1dlYk1vdXNlRXZlbnQgewogfTsKIAogc3RydWN0IFNhbWVTaXplQXNXZWJH ZXN0dXJlRXZlbnQgOiBwdWJsaWMgU2FtZVNpemVBc1dlYklucHV0RXZlbnQgewotICAgIGludCBn ZXN0dXJlRGF0YVs2XTsKKyAgICBpbnQgZ2VzdHVyZURhdGFbMTBdOwogfTsKIAogc3RydWN0IFNh bWVTaXplQXNXZWJUb3VjaEV2ZW50IDogcHVibGljIFNhbWVTaXplQXNXZWJJbnB1dEV2ZW50IHsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252 ZXJzaW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252 ZXJzaW9uLmNwcAppbmRleCAyMDdkODFjYTM4NGQzNmM4M2E0ZDEwMWU0NzBkYTllMDkyMjIzNGQ4 Li43N2FlOGVhYmJlNDY0MDViN2Y2NjA0MDFkNjJiNGM3NGZiOWUxNzU4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHAKKysr IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24uY3Bw CkBAIC0xNDksMTAgKzE0OSwxMiBAQCBQbGF0Zm9ybUdlc3R1cmVFdmVudEJ1aWxkZXI6OlBsYXRm b3JtR2VzdHVyZUV2ZW50QnVpbGRlcihXaWRnZXQqIHdpZGdldCwgY29uc3QgVwogICAgIGNhc2Ug V2ViSW5wdXRFdmVudDo6R2VzdHVyZVNjcm9sbFVwZGF0ZToKICAgICAgICAgbV90eXBlID0gUGxh dGZvcm1FdmVudDo6R2VzdHVyZVNjcm9sbFVwZGF0ZTsKICAgICAgICAgYnJlYWs7Ci0gICAgY2Fz ZSBXZWJJbnB1dEV2ZW50OjpHZXN0dXJlVGFwOgorICAgIGNhc2UgV2ViSW5wdXRFdmVudDo6R2Vz dHVyZVRhcDogewogICAgICAgICBtX3R5cGUgPSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlVGFwOwot ICAgICAgICBtX2FyZWEgPSBJbnRTaXplKGUuZGVsdGFYICogMiwgZS5kZWx0YVkgKiAyKTsKKyAg ICAgICAgSW50UmVjdCBib3VuZHMoZS5ib3VuZGluZ0JveCk7CisgICAgICAgIG1fYXJlYSA9IElu dFNpemUoYm91bmRzLndpZHRoKCksIGJvdW5kcy5oZWlnaHQoKSk7CiAgICAgICAgIGJyZWFrOwor ICAgIH0KICAgICBjYXNlIFdlYklucHV0RXZlbnQ6Okdlc3R1cmVUYXBEb3duOgogICAgICAgICBt X3R5cGUgPSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlVGFwRG93bjsKICAgICAgICAgYnJlYWs7Cg== 154121 2012-07-24 12:40:00 -0700 2012-07-24 13:32:58 -0700 Patch bug-92144-20120724153951.patch text/plain 2501 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNhNDQ2ZmU5MDU4ZmZmNTYyZjFkYjIxYWU1M2UxMTRlYjMyOTU1MTguLmQxMzUzMDczYzY5NjZj M2FjYmQ4Yzg5MTk2OWFjZTc0Yjc4YmZkZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMDctMjQgIFRlcnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBBZGQgYSBib3VuZGluZyBib3ggbWVt YmVyIGluIFdlYkdlc3R1cmVFdmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTIxNDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgbmV3IHxib3VuZGluZ0JveHwgbWVtYmVyIHdpbGwgYmUgdXNlZCB0 byBzdG9yZSB0aGUgdG91Y2ggcmVnaW9uIGZvciBhIFdlYkdlc3R1cmVFdmVudC4KKyAgICAgICAg VGhpcyB3aWxsIGJlIHVzZWZ1bCBmb3IgZ2VzdHVyZSB0YXJnZXQgZnV6emluZyBhY3Jvc3MgbXVs dGlwbGUgZGlmZmVyZW50IGdlc3R1cmUgdHlwZXMKKyAgICAgICAgKHRhcCwgbG9uZyBwcmVzcywg c2Nyb2xsLCBldGMuKQorCisgICAgICAgICogcHVibGljL1dlYklucHV0RXZlbnQuaDoKKyAgICAg ICAgKFdlYkdlc3R1cmVFdmVudCk6CisgICAgICAgICogc3JjL1dlYklucHV0RXZlbnQuY3BwOgor ICAgICAgICAoU2FtZVNpemVBc1dlYkdlc3R1cmVFdmVudCk6CisKIDIwMTItMDctMjQgIEpvY2hl biBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4g IFJvbGxlZCBERVBTLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViSW5wdXRFdmVudC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRF dmVudC5oCmluZGV4IGI3YTVlY2JkMjJiMDQzNTUxNDlmMjA2NTRhY2RjYjBiYWNiOTU2M2QuLjQw YTZmZGIzZTI2Y2VjYWM4ODc4ZjY5NWUxNjA0YWI5MWNhZWUxZmYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEV2ZW50LmgKQEAgLTMzLDYgKzMzLDcgQEAKIAog I2luY2x1ZGUgIldlYlRvdWNoUG9pbnQuaCIKICNpbmNsdWRlICJwbGF0Zm9ybS9XZWJDb21tb24u aCIKKyNpbmNsdWRlICJwbGF0Zm9ybS9XZWJSZWN0LmgiCiAKICNpbmNsdWRlIDxzdHJpbmcuaD4K IApAQCAtMzcyLDYgKzM3Myw3IEBAIHB1YmxpYzoKICAgICAvLyBOT1RFOiB8ZGVsdGFYfCBhbmQg fGRlbHRhWXwgcmVwcmVzZW50cyB0aGUgYW1vdW50IHRvIHNjcm9sbCBmb3IgU2Nyb2xsIGdlc3R1 cmUgZXZlbnRzLiBGb3IgUGluY2ggZ2VzdHVyZSBldmVudHMsIHxkZWx0YVh8IHJlcHJlc2VudHMg dGhlIHNjYWxpbmcvbWFnbmlmaWNhdGlvbiBmYWN0b3IuIEZvciBhIEdlc3R1cmVUYXAgZXZlbnQs IHxkZWx0YVh8IGFuZCB8ZGVsdGFZfCByZXByZXNlbnQgdGhlIGhvcml6b250YWwgYW5kIHZlcnRp Y2FsIHJhZGlpIG9mIHRoZSB0b3VjaCByZWdpb24uCiAgICAgZmxvYXQgZGVsdGFYOwogICAgIGZs b2F0IGRlbHRhWTsKKyAgICBXZWJSZWN0IGJvdW5kaW5nQm94OwogCiAgICAgV2ViR2VzdHVyZUV2 ZW50KHVuc2lnbmVkIHNpemVQYXJhbSA9IHNpemVvZihXZWJHZXN0dXJlRXZlbnQpKQogICAgICAg ICA6IFdlYklucHV0RXZlbnQoc2l6ZVBhcmFtKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJJbnB1dEV2ZW50LmNwcAppbmRleCBjMDY5MGY4ZDdjMzgxNjlmNWUwMDQzNjFkODZlMzA2 NDEyZGMzNzdhLi42NmEwNDgwYjRkNGFkYWMzMTdiYTMxMjlhN2YwMmNkM2E1ZmNiNDY4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50LmNwcApAQCAtNjAsNyAr NjAsNyBAQCBzdHJ1Y3QgU2FtZVNpemVBc1dlYk1vdXNlV2hlZWxFdmVudCA6IHB1YmxpYyBTYW1l U2l6ZUFzV2ViTW91c2VFdmVudCB7CiB9OwogCiBzdHJ1Y3QgU2FtZVNpemVBc1dlYkdlc3R1cmVF dmVudCA6IHB1YmxpYyBTYW1lU2l6ZUFzV2ViSW5wdXRFdmVudCB7Ci0gICAgaW50IGdlc3R1cmVE YXRhWzZdOworICAgIGludCBnZXN0dXJlRGF0YVsxMF07CiB9OwogCiBzdHJ1Y3QgU2FtZVNpemVB c1dlYlRvdWNoRXZlbnQgOiBwdWJsaWMgU2FtZVNpemVBc1dlYklucHV0RXZlbnQgewo=