92122 2012-07-24 08:26:40 -0700 [NRWT] Rename baseline_search_path() to default_baseline_search_path() 2012-07-25 07:00:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED NRWT P2 Normal --- 64491 90555 1 kkristof webkit-unassigned abarth dpranke ojan webkit.review.bot oldest_to_newest 676844 0 kkristof 2012-07-24 08:26:40 -0700 The Port's baseline_search_path() method doesn't return the finally search path because of the --additional-platform-directory change the final path. It will be better if we rename it and add a new method which return the final path. 676849 1 154072 kkristof 2012-07-24 08:29:18 -0700 Created attachment 154072 proposed refactoring 677045 2 154072 dpranke 2012-07-24 11:08:28 -0700 Comment on attachment 154072 proposed refactoring Agreed. Looks good to me. Thanks! 678001 3 kkristof 2012-07-25 07:00:51 -0700 Committed r123614: <http://trac.webkit.org/changeset/123614> 154072 2012-07-24 08:29:18 -0700 2012-07-24 11:08:28 -0700 proposed refactoring rename.patch text/plain 5315 kkristof ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMTI0 YTNlLi45ZDkzOTM2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTItMDctMjQgIEtyaXN0w7NmIEtvc3p0ecOzICA8 a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtOUldUXSBSZW5hbWUgYmFzZWxp bmVfc2VhcmNoX3BhdGgoKSB0byBkZWZhdWx0X2Jhc2VsaW5lX3NlYXJjaF9wYXRoKCkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyMTIyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHk6CisgICAgICAgIChQb3J0LmJhc2VsaW5lX3Zl cnNpb25fZGlyKToKKyAgICAgICAgKFBvcnQuYmFzZWxpbmVfc2VhcmNoX3BhdGgpOgorICAgICAg ICAoUG9ydCk6CisgICAgICAgIChQb3J0LmRlZmF1bHRfYmFzZWxpbmVfc2VhcmNoX3BhdGgpOgor ICAgICAgICAoUG9ydC5leHBlY3RlZF9iYXNlbGluZXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZV91bml0dGVzdC5weToKKyAgICAgICAgKFBvcnRU ZXN0LnRlc3RfYWRkaXRpb25hbF9wbGF0Zm9ybV9kaXJlY3RvcnkpOgorICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5OgorICAgICAgICAoTWFjUG9ydC5k ZWZhdWx0X2Jhc2VsaW5lX3NlYXJjaF9wYXRoKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L3F0LnB5OgorICAgICAgICAoUXRQb3J0LmRlZmF1bHRfYmFzZWxp bmVfc2VhcmNoX3BhdGgpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvd2luLnB5OgorICAgICAgICAoV2luUG9ydC5kZWZhdWx0X2Jhc2VsaW5lX3NlYXJjaF9w YXRoKToKKwogMjAxMi0wNy0yNCAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tp YS5jb20+CiAKICAgICAgICAgW1F0XSBNU1ZDOiB1bnJlc29sdmVkIGV4dGVybmFsIHN5bWJvbCBf X0RsbE1haW5DUlRTdGFydHVwQDEyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Jhc2UucHkKaW5kZXggZDc5MTQzMS4uZjY3ZjVjZCAxMDA3NTUKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQpAQCAtMTc5LDEw ICsxNzksMTQgQEAgY2xhc3MgUG9ydChvYmplY3QpOgogCiAgICAgZGVmIGJhc2VsaW5lX3ZlcnNp b25fZGlyKHNlbGYpOgogICAgICAgICAiIiJSZXR1cm4gdGhlIGFic29sdXRlIHBhdGggdG8gdGhl IHBsYXRmb3JtLWFuZC12ZXJzaW9uLXNwZWNpZmljIHJlc3VsdHMuIiIiCi0gICAgICAgIGJhc2Vs aW5lX3NlYXJjaF9wYXRocyA9IHNlbGYuZ2V0X29wdGlvbignYWRkaXRpb25hbF9wbGF0Zm9ybV9k aXJlY3RvcnknLCBbXSkgKyBzZWxmLmJhc2VsaW5lX3NlYXJjaF9wYXRoKCkKKyAgICAgICAgYmFz ZWxpbmVfc2VhcmNoX3BhdGhzID0gc2VsZi5iYXNlbGluZV9zZWFyY2hfcGF0aCgpCiAgICAgICAg IHJldHVybiBiYXNlbGluZV9zZWFyY2hfcGF0aHNbMF0KIAorCiAgICAgZGVmIGJhc2VsaW5lX3Nl YXJjaF9wYXRoKHNlbGYpOgorICAgICAgICByZXR1cm4gc2VsZi5nZXRfb3B0aW9uKCdhZGRpdGlv bmFsX3BsYXRmb3JtX2RpcmVjdG9yeScsIFtdKSArIHNlbGYuZGVmYXVsdF9iYXNlbGluZV9zZWFy Y2hfcGF0aCgpCisKKyAgICBkZWYgZGVmYXVsdF9iYXNlbGluZV9zZWFyY2hfcGF0aChzZWxmKToK ICAgICAgICAgIiIiUmV0dXJuIGEgbGlzdCBvZiBhYnNvbHV0ZSBwYXRocyB0byBkaXJlY3Rvcmll cyB0byBzZWFyY2ggdW5kZXIgZm9yCiAgICAgICAgIGJhc2VsaW5lcy4gVGhlIGRpcmVjdG9yaWVz IGFyZSBzZWFyY2hlZCBpbiBvcmRlci4iIiIKICAgICAgICAgc2VhcmNoX3BhdGhzID0gW10KQEAg LTM5NSw3ICszOTksNyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAgIHBsYXRmb3JtIHNw ZWNpZmljLgogICAgICAgICAiIiIKICAgICAgICAgYmFzZWxpbmVfZmlsZW5hbWUgPSBzZWxmLl9m aWxlc3lzdGVtLnNwbGl0ZXh0KHRlc3RfbmFtZSlbMF0gKyAnLWV4cGVjdGVkJyArIHN1ZmZpeAot ICAgICAgICBiYXNlbGluZV9zZWFyY2hfcGF0aCA9IHNlbGYuZ2V0X29wdGlvbignYWRkaXRpb25h bF9wbGF0Zm9ybV9kaXJlY3RvcnknLCBbXSkgKyBzZWxmLmJhc2VsaW5lX3NlYXJjaF9wYXRoKCkK KyAgICAgICAgYmFzZWxpbmVfc2VhcmNoX3BhdGggPSBzZWxmLmJhc2VsaW5lX3NlYXJjaF9wYXRo KCkKIAogICAgICAgICBiYXNlbGluZXMgPSBbXQogICAgICAgICBmb3IgcGxhdGZvcm1fZGlyIGlu IGJhc2VsaW5lX3NlYXJjaF9wYXRoOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5CmluZGV4IDdlOTI1OWIuLjAx OTg3MzUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvYmFzZV91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2Jhc2VfdW5pdHRlc3QucHkKQEAgLTIzOSw3ICsyMzksNyBAQCBjbGFzcyBQb3J0 VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKICAgICBkZWYgdGVzdF9hZGRpdGlvbmFsX3BsYXRm b3JtX2RpcmVjdG9yeShzZWxmKToKICAgICAgICAgcG9ydCA9IHNlbGYubWFrZV9wb3J0KHBvcnRf bmFtZT0nZm9vJykKLSAgICAgICAgcG9ydC5iYXNlbGluZV9zZWFyY2hfcGF0aCA9IGxhbWJkYTog WydMYXlvdXRUZXN0cy9wbGF0Zm9ybS9mb28nXQorICAgICAgICBwb3J0LmRlZmF1bHRfYmFzZWxp bmVfc2VhcmNoX3BhdGggPSBsYW1iZGE6IFsnTGF5b3V0VGVzdHMvcGxhdGZvcm0vZm9vJ10KICAg ICAgICAgbGF5b3V0X3Rlc3RfZGlyID0gcG9ydC5sYXlvdXRfdGVzdHNfZGlyKCkKICAgICAgICAg dGVzdF9maWxlID0gJ2Zhc3QvdGVzdC5odG1sJwogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5CmluZGV4IDM3MmZmYjguLjZiNTUwMzYgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5CkBAIC04 OSw3ICs4OSw3IEBAIGNsYXNzIE1hY1BvcnQoQXBwbGVQb3J0KToKICAgICAgICAgICAgIHJldHVy biBzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCgnbWFjJykKICAgICAgICAgcmV0dXJuIEFwcGxl UG9ydC5iYXNlbGluZV9wYXRoKHNlbGYpCiAKLSAgICBkZWYgYmFzZWxpbmVfc2VhcmNoX3BhdGgo c2VsZik6CisgICAgZGVmIGRlZmF1bHRfYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2VsZik6CiAgICAg ICAgIGZhbGxiYWNrX2luZGV4ID0gc2VsZi5WRVJTSU9OX0ZBTExCQUNLX09SREVSLmluZGV4KHNl bGYuX3BvcnRfbmFtZV93aXRoX3ZlcnNpb24oKSkKICAgICAgICAgZmFsbGJhY2tfbmFtZXMgPSBs aXN0KHNlbGYuVkVSU0lPTl9GQUxMQkFDS19PUkRFUltmYWxsYmFja19pbmRleDpdKQogICAgICAg ICBpZiBzZWxmLmdldF9vcHRpb24oJ3dlYmtpdF90ZXN0X3J1bm5lcicpOgpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXQucHkKaW5kZXggYWFhYWZhYy4uYTlh MWZmOSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9xdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0 LnB5CkBAIC0xNDEsNyArMTQxLDcgQEAgY2xhc3MgUXRQb3J0KFdlYktpdFBvcnQpOgogICAgICAg ICBzZWFyY2hfcGF0aHMuYXBwZW5kKHNlbGYucG9ydF9uYW1lKQogICAgICAgICByZXR1cm4gc2Vh cmNoX3BhdGhzCiAKLSAgICBkZWYgYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2VsZik6CisgICAgZGVm IGRlZmF1bHRfYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2VsZik6CiAgICAgICAgIHJldHVybiBtYXAo c2VsZi5fd2Via2l0X2Jhc2VsaW5lX3BhdGgsIHNlbGYuX3NlYXJjaF9wYXRocygpKQogCiAgICAg ZGVmIF9za2lwcGVkX2ZpbGVfc2VhcmNoX3BhdGhzKHNlbGYpOgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93aW4ucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dpbi5weQppbmRleCA0MjBmNGRiLi4yODQ2NWJm IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dp bi5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dpbi5w eQpAQCAtNjIsNyArNjIsNyBAQCBjbGFzcyBXaW5Qb3J0KEFwcGxlUG9ydCk6CiAgICAgICAgIGFj dHVhbF90ZXh0ID0gZGVsZWdhdGVfcmVnZXhwLnN1YigiIiwgYWN0dWFsX3RleHQpCiAgICAgICAg IHJldHVybiBleHBlY3RlZF90ZXh0ICE9IGFjdHVhbF90ZXh0CiAKLSAgICBkZWYgYmFzZWxpbmVf c2VhcmNoX3BhdGgoc2VsZik6CisgICAgZGVmIGRlZmF1bHRfYmFzZWxpbmVfc2VhcmNoX3BhdGgo c2VsZik6CiAgICAgICAgIGZhbGxiYWNrX2luZGV4ID0gc2VsZi5WRVJTSU9OX0ZBTExCQUNLX09S REVSLmluZGV4KHNlbGYuX3BvcnRfbmFtZV93aXRoX3ZlcnNpb24oKSkKICAgICAgICAgZmFsbGJh Y2tfbmFtZXMgPSBsaXN0KHNlbGYuVkVSU0lPTl9GQUxMQkFDS19PUkRFUltmYWxsYmFja19pbmRl eDpdKQogICAgICAgICAjIEZJWE1FOiBUaGUgQXBwbGVXaW4gcG9ydCBmYWxscyBiYWNrIHRvIEFw cGxlTWFjIGZvciBzb21lIHJlc3VsdHMuICBFdmVudHVhbGx5IHdlJ2xsIGhhdmUgYSBzaGFyZWQg J2FwcGxlJyBwb3J0Lgo=