92117 2012-07-24 07:45:12 -0700 [Chromium] Enable conversion between WebFloatRect and gfx::RectF 2012-07-24 12:48:34 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 91648 1 leandrogracia leandrogracia abarth dglazkov fishd jamesr peter tkent+wkapi webkit.review.bot oldest_to_newest 676805 0 leandrogracia 2012-07-24 07:45:12 -0700 WebFloatRects and gfx::RectFs are used by the custom find-in-page implementation of the Android port. We should allow conversion between WebFloatRect and gfx::RectF in the same way we already do with WebRect and gfx::Rect and other classes. 676809 1 154059 leandrogracia 2012-07-24 07:48:35 -0700 Created attachment 154059 Patch 676970 2 webkit.review.bot 2012-07-24 10:20:45 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 677123 3 154059 webkit.review.bot 2012-07-24 12:48:30 -0700 Comment on attachment 154059 Patch Clearing flags on attachment: 154059 Committed r123511: <http://trac.webkit.org/changeset/123511> 677125 4 webkit.review.bot 2012-07-24 12:48:34 -0700 All reviewed patches have been landed. Closing bug. 154059 2012-07-24 07:48:35 -0700 2012-07-24 12:48:29 -0700 Patch bug-92117-20120724154825.patch text/plain 2251 leandrogracia U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA5ZWVmZDJiYjNkY2Iy NjE1Yjc2NzIxMmEwYThmMzc4ZDhhYThkOTZiLi41NmZjYTgyNjNmM2E5NDRjNWE3MzA2YzdiNzA5 YjkyMmM1NmY1ODNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wNy0yNCAg TGVhbmRybyBHcmFjaWEgR2lsICA8bGVhbmRyb2dyYWNpYUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgW0Nocm9taXVtXSBFbmFibGUgY29udmVyc2lvbiBiZXR3ZWVuIFdlYkZsb2F0UmVjdCBhbmQg Z2Z4OjpSZWN0Ri4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkyMTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSW50cm9kdWNlIFdlYkZsb2F0UmVjdCA8LS0+IGdmeDo6UmVjdEYgY29udmVyc2lvbiBhcyB3 ZSBhbHJlYWR5IGRvIHdpdGggV2ViUmVjdCA8LS0+IGdmeDo6UmVjdC4KKworICAgICAgICAqIGNo cm9taXVtL3B1YmxpYy9XZWJGbG9hdFJlY3QuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViRmxvYXRS ZWN0OjpXZWJGbG9hdFJlY3QpOgorICAgICAgICAoV2ViRmxvYXRSZWN0KToKKyAgICAgICAgKFdl YktpdDo6V2ViRmxvYXRSZWN0OjpvcGVyYXRvcj0pOgorICAgICAgICAoV2ViS2l0OjpXZWJGbG9h dFJlY3Q6Om9wZXJhdG9yIGdmeDo6UmVjdEYpOgorCiAyMDEyLTA3LTIzICBEYXZlIFR1ICA8ZHR1 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEFkZCBkcm9wcGVkRnJhbWVDb3Vu dCB0byByZW5kZXJpbmdTdGF0cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1 bS9wdWJsaWMvV2ViRmxvYXRSZWN0LmggYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGlj L1dlYkZsb2F0UmVjdC5oCmluZGV4IGE4ODM1MTNmY2RhYzU0M2U5MDAzNzcyZTU0MjIwNWIyMWM3 M2JhMDMuLjlmZWNlNGQ1NmYxNmUzNjkzNWNjNjU0ZmYzM2ZiOTc2ZTgyOTcxOGIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViRmxvYXRSZWN0LmgKKysrIGIv U291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJGbG9hdFJlY3QuaApAQCAtMzUsNiAr MzUsOCBAQAogCiAjaWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OCiAjaW5jbHVkZSAiRmxvYXRSZWN0 LmgiCisjZWxzZQorI2luY2x1ZGUgPHVpL2dmeC9yZWN0X2YuaD4KICNlbmRpZgogCiBuYW1lc3Bh Y2UgV2ViS2l0IHsKQEAgLTQ4LDEwICs1MCwxMCBAQCBzdHJ1Y3QgV2ViRmxvYXRSZWN0IHsKICAg ICBib29sIGlzRW1wdHkoKSBjb25zdCB7IHJldHVybiB3aWR0aCA8PSAwIHx8IGhlaWdodCA8PSAw OyB9CiAKICAgICBXZWJGbG9hdFJlY3QoKQotICAgICAgICA6IHgoMC4wZikKLSAgICAgICAgLCB5 KDAuMGYpCi0gICAgICAgICwgd2lkdGgoMC4wZikKLSAgICAgICAgLCBoZWlnaHQoMC4wZikKKyAg ICAgICAgOiB4KDApCisgICAgICAgICwgeSgwKQorICAgICAgICAsIHdpZHRoKDApCisgICAgICAg ICwgaGVpZ2h0KDApCiAgICAgewogICAgIH0KIApAQCAtODUsNiArODcsMjggQEAgc3RydWN0IFdl YkZsb2F0UmVjdCB7CiAgICAgewogICAgICAgICByZXR1cm4gV2ViQ29yZTo6RmxvYXRSZWN0KHgs IHksIHdpZHRoLCBoZWlnaHQpOwogICAgIH0KKyNlbHNlCisgICAgV2ViRmxvYXRSZWN0KGNvbnN0 IGdmeDo6UmVjdEYmIHIpCisgICAgICAgIDogeChyLngoKSkKKyAgICAgICAgLCB5KHIueSgpKQor ICAgICAgICAsIHdpZHRoKHIud2lkdGgoKSkKKyAgICAgICAgLCBoZWlnaHQoci5oZWlnaHQoKSkK KyAgICB7CisgICAgfQorCisgICAgV2ViRmxvYXRSZWN0JiBvcGVyYXRvcj0oY29uc3QgZ2Z4OjpS ZWN0RiYgcikKKyAgICB7CisgICAgICAgIHggPSByLngoKTsKKyAgICAgICAgeSA9IHIueSgpOwor ICAgICAgICB3aWR0aCA9IHIud2lkdGgoKTsKKyAgICAgICAgaGVpZ2h0ID0gci5oZWlnaHQoKTsK KyAgICAgICAgcmV0dXJuICp0aGlzOworICAgIH0KKworICAgIG9wZXJhdG9yIGdmeDo6UmVjdEYo KSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIGdmeDo6UmVjdEYoeCwgeSwgd2lkdGgsIGhl aWdodCk7CisgICAgfQogI2VuZGlmCiB9OwogCg==