92099 2012-07-24 04:40:33 -0700 [EFL] [WK2] Memory leak in ewk_view_resource_load_client.cpp 2012-07-26 04:32:53 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cdumez gyuyoung.kim kenneth lucas.de.marchi mrobinson webkit.review.bot oldest_to_newest 676656 0 naginenis 2012-07-24 04:40:33 -0700 Valgrind reports the following memory leak in ewk_view_resource_load_client.cpp. ==27984== 648 bytes in 27 blocks are definitely lost in loss record 687 of 782 ==27984== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27984== by 0xA86A1CA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27984== by 0x549CA88: ewk_web_resource_new(char const*, bool) (FastMalloc.h:265) ==27984== by 0x549BD22: didInitiateLoadForResource(OpaqueWKPage const*, OpaqueWKFrame const*, unsigned long, OpaqueWKURLRequest const*, bool, void const*) (ewk_view_resource_load_client.cpp:59) ==27984== by 0x53CAE04: WebKit::WebResourceLoadClient::didInitiateLoadForResource(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, unsigned long, WebCore::ResourceRequest const&, bool) (WebResourceLoadClient.cpp:43) ==27984== by 0x538D1E6: WebKit::WebPageProxy::didInitiateLoadForResource(unsigned long, unsigned long, WebCore::ResourceRequest const&, bool) (WebPageProxy.cpp:2340) ==27984== by 0x54B9393: void CoreIPC::callMemberFunction<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(unsigned long, unsigned long, WebCore::ResourceRequest const&, bool), unsigned long, unsigned long, WebCore::ResourceRequest, bool>(CoreIPC::Arguments4<unsigned long, unsigned long, WebCore::ResourceRequest, bool> const&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(unsigned long, unsigned long, WebCore::ResourceRequest const&, bool)) (HandleMessage.h:37) ==27984== by 0x54B5ADE: void CoreIPC::handleMessage<Messages::WebPageProxy::DidInitiateLoadForResource, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(unsigned long, unsigned long, WebCore::ResourceRequest const&, bool)>(CoreIPC::ArgumentDecoder*, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(unsigned long, unsigned long, WebCore::ResourceRequest const&, bool)) (HandleMessage.h:302) ==27984== by 0x54B2A95: WebKit::WebPageProxy::didReceiveWebPageProxyMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) (WebPageProxyMessageReceiver.cpp:322) ==27984== by 0x5389A56: WebKit::WebPageProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) (WebPageProxy.cpp:1771) ==27984== by 0x53C0A39: WebKit::WebProcessProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) (WebProcessProxy.cpp:347) ==27984== by 0x534F08E: WebKit::WebConnectionToWebProcess::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) (WebConnectionToWebProcess.cpp:92) ==27984== by 0x52F939A: CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::ArgumentDecoder>&) (Connection.cpp:691) ==27984== by 0x52F9538: CoreIPC::Connection::dispatchOneMessage() (Connection.cpp:717) ==27984== by 0x530342B: WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator()(CoreIPC::Connection*) (Functional.h:173) ==27984== by 0x5303231: WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>, void ()(CoreIPC::Connection*)>::operator()() (Functional.h:405) ==27984== by 0x5454DBD: WTF::Function<void ()()>::operator()() const (Functional.h:613) ==27984== by 0x9E69861: WebCore::RunLoop::performWork() (RunLoop.cpp:102) ==27984== by 0xA79D5EE: WebCore::RunLoop::wakeUpEvent(void*, void*, unsigned int) (RunLoopEfl.cpp:100) ==27984== by 0x415B060: _ecore_pipe_read (ecore_pipe.c:625) ==27984== by 0x415A130: _ecore_main_loop_iterate_internal (ecore_private.h:343) ==27984== by 0x415A676: ecore_main_loop_begin (ecore_main.c:931) ==27984== by 0x40200B: main (main.c:218) ==27984== 676696 1 154028 naginenis 2012-07-24 05:35:43 -0700 Created attachment 154028 Patch 676725 2 154028 cdumez 2012-07-24 06:01:51 -0700 Comment on attachment 154028 Patch LGTM. Thanks for fixing this. 677671 3 154028 gyuyoung.kim 2012-07-24 23:23:11 -0700 Comment on attachment 154028 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154028&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:297 > + for ( ; it != end; ++it) If possible, why don't you modify this one as below ? for (LoadingResourcesMap::iterator it = loadingResourcesMap.begin(); it != end; ++it) In addition, we can save a line. 677697 4 154028 cdumez 2012-07-24 23:43:06 -0700 Comment on attachment 154028 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154028&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:297 >> + for ( ; it != end; ++it) > > If possible, why don't you modify this one as below ? > > for (LoadingResourcesMap::iterator it = loadingResourcesMap.begin(); it != end; ++it) > > In addition, we can save a line. This is really a matter of preference. There is no coding style rule that says we should do it either way and AFAIK there is no performance impact. 677767 5 gyuyoung.kim 2012-07-25 01:12:43 -0700 (In reply to comment #4) > This is really a matter of preference. There is no coding style rule that says we should do it either way and AFAIK there is no performance impact. This is just my suggestion because it seems to me above code is more used in WebKit inside. Of course, there is no performance gain. 677784 6 naginenis 2012-07-25 01:33:22 -0700 (In reply to comment #5) > This is just my suggestion because it seems to me above code is more used in WebKit inside. Of course, there is no performance gain. Can I leave this as it is since there is no any gain in changing it? 677791 7 gyuyoung.kim 2012-07-25 01:38:35 -0700 (In reply to comment #6) > (In reply to comment #5) > > This is just my suggestion because it seems to me above code is more used in WebKit inside. Of course, there is no performance gain. > > Can I leave this as it is since there is no any gain in changing it? Ok, I don't wanna disturb this patch is landed. LGTM as well. 679059 8 154581 naginenis 2012-07-26 02:00:34 -0700 Created attachment 154581 Patch Rebased 679067 9 154581 haraken 2012-07-26 02:13:20 -0700 Comment on attachment 154581 Patch Looks OK 679149 10 154581 webkit.review.bot 2012-07-26 04:32:48 -0700 Comment on attachment 154581 Patch Clearing flags on attachment: 154581 Committed r123727: <http://trac.webkit.org/changeset/123727> 679150 11 webkit.review.bot 2012-07-26 04:32:53 -0700 All reviewed patches have been landed. Closing bug. 154028 2012-07-24 05:35:43 -0700 2012-07-26 02:00:34 -0700 Patch 92099.patch text/plain 2870 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwZTI0Y2Q1Li4wNzlhYzFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDctMjQgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW1dLMl0gTWVtb3J5IGxlYWsgaW4gZXdr X3ZpZXdfcmVzb3VyY2VfbG9hZF9jbGllbnQuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjA5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIG1lbW9yeSBsZWFrIGJ5IGNsZWFyaW5nIHRoZSBs b2FkaW5nUmVzb3VyY2VzIEhhc2hNYXAgb24gZXhpdC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKF9Fd2tfVmlld19Qcml2YXRlX0RhdGE6On5f RXdrX1ZpZXdfUHJpdmF0ZV9EYXRhKToKKyAgICAgICAgKF9ld2tfdmlld19wcml2X2xvYWRpbmdf cmVzb3VyY2VzX2NsZWFyKToKKyAgICAgICAgKGV3a192aWV3X2xvYWRfcHJvdmlzaW9uYWxfc3Rh cnRlZCk6CisKIDIwMTItMDctMjMgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21h aWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjMxODQsIHIxMjMx OTUsIGFuZCByMTIzMTk3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdr X3ZpZXcuY3BwCmluZGV4IDNmODBhYTEuLjY0Y2ZlZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKQEAgLTQ1LDYgKzQ1LDcgQEAgdXNpbmcgbmFt ZXNwYWNlIFdlYkNvcmU7CiBzdGF0aWMgY29uc3QgY2hhciBFV0tfVklFV19UWVBFX1NUUltdID0g IkVXSzJfVmlldyI7CiAKIHR5cGVkZWYgSGFzaE1hcDx1aW50NjRfdCwgRXdrX1dlYl9SZXNvdXJj ZSo+IExvYWRpbmdSZXNvdXJjZXNNYXA7CitzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfcHJpdl9sb2Fk aW5nX3Jlc291cmNlc19jbGVhcihMb2FkaW5nUmVzb3VyY2VzTWFwJiBsb2FkaW5nUmVzb3VyY2Vz TWFwKTsKIAogc3RydWN0IF9Fd2tfVmlld19Qcml2YXRlX0RhdGEgewogICAgIE93blB0cjxQYWdl Q2xpZW50SW1wbD4gcGFnZUNsaWVudDsKQEAgLTY3LDYgKzY4LDcgQEAgc3RydWN0IF9Fd2tfVmll d19Qcml2YXRlX0RhdGEgewogICAgICAgICBlaW5hX3N0cmluZ3NoYXJlX2RlbCh0aXRsZSk7CiAg ICAgICAgIGVpbmFfc3RyaW5nc2hhcmVfZGVsKHRoZW1lKTsKICAgICAgICAgZWluYV9zdHJpbmdz aGFyZV9kZWwoY3VzdG9tRW5jb2RpbmcpOworICAgICAgICBfZXdrX3ZpZXdfcHJpdl9sb2FkaW5n X3Jlc291cmNlc19jbGVhcihsb2FkaW5nUmVzb3VyY2VzTWFwKTsKICAgICB9CiB9OwogCkBAIC0y ODcsNiArMjg5LDE3IEBAIHN0YXRpYyBFd2tfVmlld19Qcml2YXRlX0RhdGEqIF9ld2tfdmlld19w cml2X25ldyhFd2tfVmlld19TbWFydF9EYXRhKiBzbWFydERhdGEpCiAgICAgcmV0dXJuIHByaXY7 CiB9CiAKK3N0YXRpYyB2b2lkIF9ld2tfdmlld19wcml2X2xvYWRpbmdfcmVzb3VyY2VzX2NsZWFy KExvYWRpbmdSZXNvdXJjZXNNYXAmIGxvYWRpbmdSZXNvdXJjZXNNYXApCit7CisgICAgLy8gQ2xl YXIgdGhlIGxvYWRpbmdSZXNvdXJjZXMgSGFzaE1hcC4KKyAgICBMb2FkaW5nUmVzb3VyY2VzTWFw OjppdGVyYXRvciBpdCA9IGxvYWRpbmdSZXNvdXJjZXNNYXAuYmVnaW4oKTsKKyAgICBMb2FkaW5n UmVzb3VyY2VzTWFwOjppdGVyYXRvciBlbmQgPSBsb2FkaW5nUmVzb3VyY2VzTWFwLmVuZCgpOwor ICAgIGZvciAoIDsgaXQgIT0gZW5kOyArK2l0KQorICAgICAgICBld2tfd2ViX3Jlc291cmNlX3Vu cmVmKGl0LT5zZWNvbmQpOworCisgICAgbG9hZGluZ1Jlc291cmNlc01hcC5jbGVhcigpOworfQor CiBzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfcHJpdl9kZWwoRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhKiBw cml2KQogewogICAgIGRlbGV0ZSBwcml2OwpAQCAtODk5LDExICs5MTIsNyBAQCB2b2lkIGV3a192 aWV3X2xvYWRfcHJvdmlzaW9uYWxfc3RhcnRlZChFdmFzX09iamVjdCogZXdrVmlldykKIAogICAg IC8vIFRoZSBtYWluIGZyYW1lIHN0YXJ0ZWQgcHJvdmlzaW9uYWwgbG9hZCwgd2Ugc2hvdWxkIGNs ZWFyCiAgICAgLy8gdGhlIGxvYWRpbmdSZXNvdXJjZXMgSGFzaE1hcCB0byBzdGFydCBjbGVhbi4K LSAgICBMb2FkaW5nUmVzb3VyY2VzTWFwOjppdGVyYXRvciBpdCA9IHByaXYtPmxvYWRpbmdSZXNv dXJjZXNNYXAuYmVnaW4oKTsKLSAgICBMb2FkaW5nUmVzb3VyY2VzTWFwOjppdGVyYXRvciBlbmQg PSBwcml2LT5sb2FkaW5nUmVzb3VyY2VzTWFwLmVuZCgpOwotICAgIGZvciAoIDsgaXQgIT0gZW5k OyArK2l0KQotICAgICAgICBld2tfd2ViX3Jlc291cmNlX3VucmVmKGl0LT5zZWNvbmQpOwotICAg IHByaXYtPmxvYWRpbmdSZXNvdXJjZXNNYXAuY2xlYXIoKTsKKyAgICBfZXdrX3ZpZXdfcHJpdl9s b2FkaW5nX3Jlc291cmNlc19jbGVhcihwcml2LT5sb2FkaW5nUmVzb3VyY2VzTWFwKTsKIAogICAg IGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2NhbGwoZXdrVmlldywgImxvYWQscHJvdmlzaW9u YWwsc3RhcnRlZCIsIDApOwogfQo= 154581 2012-07-26 02:00:34 -0700 2012-07-26 04:32:48 -0700 Patch 92099.patch text/plain 2971 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkY2Q4N2Y1Li5lZDA2ZjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDctMjYgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW1dLMl0gTWVtb3J5IGxlYWsgaW4gZXdr X3ZpZXdfcmVzb3VyY2VfbG9hZF9jbGllbnQuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjA5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIG1lbW9yeSBsZWFrIGJ5IGNsZWFyaW5nIHRoZSBs b2FkaW5nUmVzb3VyY2VzIEhhc2hNYXAgb24gZXhpdC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKF9Fd2tfVmlld19Qcml2YXRlX0RhdGE6On5f RXdrX1ZpZXdfUHJpdmF0ZV9EYXRhKToKKyAgICAgICAgKF9ld2tfdmlld19wcml2X2xvYWRpbmdf cmVzb3VyY2VzX2NsZWFyKToKKyAgICAgICAgKGV3a192aWV3X2xvYWRfcHJvdmlzaW9uYWxfc3Rh cnRlZCk6CisKIDIwMTItMDctMjUgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29t PgogCiAgICAgICAgIFtFRkxdW1dLMl0gQWRkIGV3a192aWV3X2N1cnNvcl9zZXQgdG8gY2hhbmdl IGN1cnNvci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3 a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNw cAppbmRleCA4NDQ4ZmQ2Li5lZDJmYTE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvZXdrX3ZpZXcuY3BwCkBAIC01MSw2ICs1MSw3IEBAIHN0YXRpYyBjb25zdCBjaGFy IEVXS19WSUVXX1RZUEVfU1RSW10gPSAiRVdLMl9WaWV3IjsKIHN0YXRpYyBjb25zdCBpbnQgZGVm YXVsdEN1cnNvclNpemUgPSAxNjsKIAogdHlwZWRlZiBIYXNoTWFwPHVpbnQ2NF90LCBFd2tfV2Vi X1Jlc291cmNlKj4gTG9hZGluZ1Jlc291cmNlc01hcDsKK3N0YXRpYyB2b2lkIF9ld2tfdmlld19w cml2X2xvYWRpbmdfcmVzb3VyY2VzX2NsZWFyKExvYWRpbmdSZXNvdXJjZXNNYXAmIGxvYWRpbmdS ZXNvdXJjZXNNYXApOwogCiBzdHJ1Y3QgX0V3a19WaWV3X1ByaXZhdGVfRGF0YSB7CiAgICAgT3du UHRyPFBhZ2VDbGllbnRJbXBsPiBwYWdlQ2xpZW50OwpAQCAtODQsNiArODUsNyBAQCBzdHJ1Y3Qg X0V3a19WaWV3X1ByaXZhdGVfRGF0YSB7CiAgICAgICAgIGVpbmFfc3RyaW5nc2hhcmVfZGVsKHRp dGxlKTsKICAgICAgICAgZWluYV9zdHJpbmdzaGFyZV9kZWwodGhlbWUpOwogICAgICAgICBlaW5h X3N0cmluZ3NoYXJlX2RlbChjdXN0b21FbmNvZGluZyk7CisgICAgICAgIF9ld2tfdmlld19wcml2 X2xvYWRpbmdfcmVzb3VyY2VzX2NsZWFyKGxvYWRpbmdSZXNvdXJjZXNNYXApOwogCiAgICAgICAg IGlmIChjdXJzb3JPYmplY3QpCiAgICAgICAgICAgICBldmFzX29iamVjdF9kZWwoY3Vyc29yT2Jq ZWN0KTsKQEAgLTMxMSw2ICszMTMsMTcgQEAgc3RhdGljIEV3a19WaWV3X1ByaXZhdGVfRGF0YSog X2V3a192aWV3X3ByaXZfbmV3KEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNtYXJ0RGF0YSkKICAgICBy ZXR1cm4gcHJpdjsKIH0KIAorc3RhdGljIHZvaWQgX2V3a192aWV3X3ByaXZfbG9hZGluZ19yZXNv dXJjZXNfY2xlYXIoTG9hZGluZ1Jlc291cmNlc01hcCYgbG9hZGluZ1Jlc291cmNlc01hcCkKK3sK KyAgICAvLyBDbGVhciB0aGUgbG9hZGluZ1Jlc291cmNlcyBIYXNoTWFwLgorICAgIExvYWRpbmdS ZXNvdXJjZXNNYXA6Oml0ZXJhdG9yIGl0ID0gbG9hZGluZ1Jlc291cmNlc01hcC5iZWdpbigpOwor ICAgIExvYWRpbmdSZXNvdXJjZXNNYXA6Oml0ZXJhdG9yIGVuZCA9IGxvYWRpbmdSZXNvdXJjZXNN YXAuZW5kKCk7CisgICAgZm9yICggOyBpdCAhPSBlbmQ7ICsraXQpCisgICAgICAgIGV3a193ZWJf cmVzb3VyY2VfdW5yZWYoaXQtPnNlY29uZCk7CisKKyAgICBsb2FkaW5nUmVzb3VyY2VzTWFwLmNs ZWFyKCk7Cit9CisKIHN0YXRpYyB2b2lkIF9ld2tfdmlld19wcml2X2RlbChFd2tfVmlld19Qcml2 YXRlX0RhdGEqIHByaXYpCiB7CiAgICAgZGVsZXRlIHByaXY7CkBAIC05OTgsMTEgKzEwMTEsNyBA QCB2b2lkIGV3a192aWV3X2xvYWRfcHJvdmlzaW9uYWxfc3RhcnRlZChFdmFzX09iamVjdCogZXdr VmlldykKIAogICAgIC8vIFRoZSBtYWluIGZyYW1lIHN0YXJ0ZWQgcHJvdmlzaW9uYWwgbG9hZCwg d2Ugc2hvdWxkIGNsZWFyCiAgICAgLy8gdGhlIGxvYWRpbmdSZXNvdXJjZXMgSGFzaE1hcCB0byBz dGFydCBjbGVhbi4KLSAgICBMb2FkaW5nUmVzb3VyY2VzTWFwOjppdGVyYXRvciBpdCA9IHByaXYt PmxvYWRpbmdSZXNvdXJjZXNNYXAuYmVnaW4oKTsKLSAgICBMb2FkaW5nUmVzb3VyY2VzTWFwOjpp dGVyYXRvciBlbmQgPSBwcml2LT5sb2FkaW5nUmVzb3VyY2VzTWFwLmVuZCgpOwotICAgIGZvciAo IDsgaXQgIT0gZW5kOyArK2l0KQotICAgICAgICBld2tfd2ViX3Jlc291cmNlX3VucmVmKGl0LT5z ZWNvbmQpOwotICAgIHByaXYtPmxvYWRpbmdSZXNvdXJjZXNNYXAuY2xlYXIoKTsKKyAgICBfZXdr X3ZpZXdfcHJpdl9sb2FkaW5nX3Jlc291cmNlc19jbGVhcihwcml2LT5sb2FkaW5nUmVzb3VyY2Vz TWFwKTsKIAogICAgIGV3a192aWV3X3VyaV91cGRhdGUoZXdrVmlldyk7CiAgICAgZXZhc19vYmpl Y3Rfc21hcnRfY2FsbGJhY2tfY2FsbChld2tWaWV3LCAibG9hZCxwcm92aXNpb25hbCxzdGFydGVk IiwgMCk7Cg==